Commit Graph

4364 Commits

Author SHA1 Message Date
svetoslav-sportinno 30e4e6339d Add max selections support for polls (#5726) 2026-06-22 13:39:12 +02:00
Mauro Romito 173a927bf8 Revert "Associate the room address field helper text and error with the field"
This reverts commit d4e7cbfdbe.
2026-06-22 13:17:23 +02:00
Mauro Romito d4e7cbfdbe Associate the room address field helper text and error with the field
The address field already had an accessibility label, but the section's
helper text and validation error were only shown in a separate footer and
weren't conveyed to VoiceOver when focusing the field. Compose them into the
field's accessibility hint.

Addresses #5258.
2026-06-22 12:57:49 +02:00
amshak 9f92e181b0 Added a chevron to collapsed call buttons in the DM (#5755)
* Added a chevron to collapsed call buttons in the DM

This makes the context menu more intuitive and easy to find. Inspired by the collapsed state of call buttons in Whatsapp that I saw recently

* Shortening video/voice call button strings

Currently the text is unnecessarily long, I have reduced to button text

# Conflicts:
#	ElementX/Sources/Generated/Strings+Untranslated.swift

* Move translations to localazy

---------

Co-authored-by: Stefan Ceriu <stefan.ceriu@gmail.com>
2026-06-22 13:23:37 +03:00
Hugh Nimmo-Smith 9672c73564 Remove stale reference to fastlane and Gemfile in AGENTS.md (#5761) 2026-06-19 16:26:47 +01:00
Mauro Romito 3aedd0ccff swiftformat now enforces newlines for ifs 2026-06-19 15:28:27 +02:00
Mauro Romito f32b9eeb26 Mark RoomSummary extensions as nonisolated
The RoomSummary struct is nonisolated, so its CustomStringConvertible and
helper extensions should be too.
2026-06-19 13:45:38 +02:00
Mauro Romito 8a4e4d1903 Give the media upload preview a descriptive VoiceOver title
The QLPreviewItem used the media's file name as its title, which VoiceOver
read as cryptic alt text. Provide a descriptive "Photo preview" / "Video
preview" title based on the media type instead.

Addresses #5240, #5241.
2026-06-19 13:45:38 +02:00
Mauro Romito 17da5ff3b7 Keep hidden QuickLook chrome out of VoiceOver focus order
The media upload preview hides the QLPreviewController's navigation bar and
toolbar share button visually, but their buttons stayed in VoiceOver's focus
order. Mark the chrome as accessibility-hidden so it is no longer focusable.

Addresses #5266, #5267.
2026-06-19 13:45:38 +02:00
Stefan Ceriu fbbdb6f5f7 Fix iOS specific notification sound localizable keys. 2026-06-19 14:11:28 +03:00
Stefan Ceriu 7f1b6086ae Search tab (#5754)
* Add a developer flag for the search tab
Introduces a globalSearchEnabled user preference (off by default) with a toggle in Developer Options, used to gate the new search experience.

* Support search role tabs in the tab coordinator
Migrates the NavigationTabCoordinator to SwiftUI's value-based Tab API and adds an isSearch option so a tab can adopt the iOS 26 .search role, which detaches it into the trailing search button in the tab bar.

* Moves room search to a new screen
Adds a new screen that filters the alternate room summary provider as you type, shows an empty state, and lists matching rooms with their matrix identifier. Supports hardware keyboard selection (arrow keys to move through results, return to open) by reaching into the system search field.

* Present search in a dedicated tab
Adds the search tab to the chats flow on iOS 26 when the flag is enabled, rendered as the detached .search role button. The Cmd+K shortcut now selects this tab, and the home screen's inline search is hidden while the tab is available.

* Remove the old global search screen
The dedicated search tab replaces the Cmd+K floating window, so the GlobalSearchScreen, its window plumbing in the WindowManager, and its presentation in the chats flow are all removed.
2026-06-19 13:50:17 +03:00
Stefan Ceriu 9a6f7595e5 Fix crashes during logout. 2026-06-19 12:58:28 +03:00
Mauro 6a381dcef0 Fix some issues with missing a11y labels (#5747)
* add a11y label to the bug report field

* include a11y label to the list row directly

* remove is header trait from poll form question header section

* a11y label added to the create room screen name textfield
2026-06-19 11:48:13 +02:00
Mauro Romito 4ab0f659b2 hide avatar in send invite confirmation view 2026-06-19 11:03:10 +02:00
Doug b38c216185 Add support for defining the text entry type on CompoundTextFieldStyle. (#5757)
* Add support for defining the text entry type on CompoundTextFieldStyle.

* Use Xcode 26.5 when running Compound tests too.
2026-06-18 19:18:44 +01:00
Mauro a520d94760 Swift 6 Migration (#5733)
* Enable Swift 6.2 with default main actor isolation for the app target

Turn on SWIFT_VERSION 6.2, SWIFT_APPROACHABLE_CONCURRENCY and SWIFT_DEFAULT_ACTOR_ISOLATION = MainActor for the ElementX target, matching the NSE and Share Extension (which already use 6.2 without the main actor default).

# Conflicts:
#	ElementX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

* Update the code generation templates for Swift 6

Emit nonisolated/@unchecked Sendable mocks and nonisolated string enums, and mark async mock methods @concurrent so they keep suspending like the real implementations (otherwise intermediate states are unobservable in tests). Includes the regenerated mocks and strings.

# Conflicts:
#	ElementX/Sources/Mocks/Generated/GeneratedMocks.swift

* Make the data layer and services nonisolated and Sendable

Annotate the value-type models, Rust SDK proxy wrappers, timeline item graph, settings, logging and NSE-shared types as nonisolated, and conform the service protocols to Sendable so their existentials can cross isolation boundaries. These types run off the main actor and no longer inherit the target's default main actor isolation.

* Adopt the new isolation across call sites, mocks and signatures

Update call sites, closure signatures and mock configuration helpers to match the nonisolated/Sendable data layer, including the main actor isolated mock inits and the @Sendable filter on recentlyVisitedRooms.

^ Conflicts:
^	ElementX/Sources/Services/SecureBackup/SecureBackupController.swift

* Remove redundant @MainActor annotations

With the app target defaulting to main actor isolation, the explicit @MainActor on view models, coordinators, views and their protocols is no longer required.

* Fix concurrency hotspots surfaced by the migration

Resolve the room summary main-thread deadlock by moving diff processing onto AsyncStreams, add the SDKListener.onMainActor FIFO bridge for SDK callbacks, hop KVO/timer/UIKit callbacks to the main actor via assumeIsolated, add isolated deinits, and apply the few justified nonisolated(unsafe) escapes for queue-confined Apple APIs.

* Fix the unit tests for Swift 6 concurrency

Hop the waitForConfirmation body onto the caller's actor (Swift Testing runs confirmation closures off-actor), and adjust the affected suites and async signatures.

* offload diffs on concurrent threads instead of main actor

* make room info protocols sendable

* use a task group for fetching data so that everything runs concurrently in the TextRoomTimelineView when getting the preview.

* use the generic onMainActor implementation, which already makes a stream and send the continuation on the main actor.

* small pr comments issues being addressed

* update enterprise

* Update StaticCode to 1.1.0 and specify the required Swift isolation.

* fix ElementCallServiceTests

* update enterprise

* re-generate mocks

* update enterprise

* enterprise new code conformed to swift 6

---------

Co-authored-by: Doug <douglase@element.io>
2026-06-18 17:55:31 +02:00
Michael 7edca8b5a1 Add a recovery key screen hook. (#5684)
update generateRecoveryKey to take a passphrase option

Wire up AppHooks with recovery key hook

Update xcodeproj

Review fixups

Review fixups

Make the `SecureBackupRecoveryState.viewMode` extension private

Bump the enterprise submodule
2026-06-18 13:28:57 +01:00
Doug 73ea338d67 Regenerate failing UI snapshots. 2026-06-18 12:45:40 +03:00
renovate[bot] 18fac944f5 Update Project Dependencies (#5750)
* Update Project Dependencies

* Run XcodeGen, update Package.resolved and Settings.bundle

* Run XcodeGen, update Package.resolved and Settings.bundle

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Element CI <ci@element.io>
2026-06-18 06:34:20 +00:00
Stefan Ceriu 2411af9556 Re-enable client pausing and resuming for non-release builds
Disabled in 5ba94609b because pause and resume could interleave and strand
the client suspended after a foreground resume. That race is now fixed, so
turn the feature back on for non-release builds.
2026-06-17 15:17:06 +03:00
Stefan Ceriu 514f2b26fc Don't restart the send queue while the client is suspended
The send queue auto-enable listener fires whenever the queue is believed
off and the homeserver is reachable. While the client is suspended this
could re-enable the queue and potentially fall straight back into a re-enable
loop.

Gate the listener on the desired service state so queues are only restarted
when we intend to be running, and nudge the listener on resume so the queue
recovers reliably. The SDK only re-enables queues when client.resume() runs,
which is gated behind clientPausingAndResumingEnabled, so the nudge keeps
recovery uniform across builds rather than depending on the flag.
2026-06-17 15:17:06 +03:00
Stefan Ceriu 02b114d40b Make ClientProxy.pauseServices async and drop its completion block
`pauseServices` took a completion block only because it was historically
called from `deinit`, which can't await (the SE-0371 note). `deinit` now
stops the sync itself, so the sole remaining caller is the AppCoordinator,
which can await instead.

Make `pauseServices` async and update the AppCoordinator background-task
and lifecycle call sites to await it, calling the OS-facing completions
(endBackgroundTask / setTaskCompleted) afterwards. This also removes the
`MainActor.assumeIsolated` workaround — awaiting a @MainActor method hops
onto the main actor cleanly — and fixes a latent bug where a nil `self` in
the background app refresh expiration handler would skip setTaskCompleted.
2026-06-17 15:17:06 +03:00
Stefan Ceriu 04fd1bfd0e Serialise client pausing and resuming to fix the foreground resume race
Pause and resume previously ran as independent, unsynchronised tasks:
`pauseServices` stopped the sync and paused the client from a detached
`Task`, while `resumeServices` resumed and started the sync directly.
With no ordering between them, a late background pause could land after a
foreground resume — leaving the client suspended and the sync stopped
while the app was active, which broke everything until the next relaunch.

Route both through a single serialised reconciler: each request records
the desired state and chains onto the previous transition, and the
reconcile always drives the SDK to the *latest* desired state. Transitions
can no longer interleave and the most recent intent always wins.

On deinit we no longer pause the client — it's being deallocated, so the
SDK tears it down anyway; we just stop the sync and cancel the delegate.
2026-06-17 15:17:06 +03:00
Stefan Ceriu d5ae5ba3e0 Update renovate group names for better PR titles 2026-06-17 14:50:57 +03:00
Element CI 56536c0831 Prepare next release 2026-06-17 01:39:09 -07:00
Element CI c76052e8a2 Run XcodeGen, update Package.resolved and Settings.bundle 2026-06-17 08:52:00 +03:00
Element CI cb491ab4ac Run XcodeGen, update Package.resolved and Settings.bundle 2026-06-17 08:52:00 +03:00
renovate[bot] 5b6ee52009 Update XcodeGen 2026-06-17 08:52:00 +03:00
Mauro Romito dc29be5898 voiceover reads add avatar when there is no avatar yet 2026-06-16 18:25:37 +02:00
Mauro Romito a87005fe5b add ishHeader trait were required 2026-06-16 17:34:13 +02:00
Doug 404efa0d66 Update the SDK. (#5743) 2026-06-16 16:27:42 +01:00
Mauro Romito 39be0dcfde Set pin a11y improvements 2026-06-16 16:58:44 +02:00
Mauro Romito 8bcc7efc49 Create new room - remove wrong header trait 2026-06-16 15:37:55 +02:00
Mauro Romito b3f0402a4d add a11y labels to media upload preview screen 2026-06-16 13:14:12 +02:00
Doug 409e65ecb8 Update CHANGES.md. 2026-06-16 11:19:58 +01:00
Stefan Ceriu 3d90a43175 Wrap selected text in a markdown link when pasting a URL over it
Pasting a single link on top of a selection in the message composer now
produces a markdown link, e.g. selecting "Google" and pasting
"google.com" yields "[Google](google.com)". Non-link clipboard
contents and pastes without a selection keep their existing behaviour.
2026-06-16 13:15:04 +03:00
Doug 47fa40dc9a Update README.md. 2026-06-16 10:29:19 +01:00
Doug e9442a3c60 Clarify Xcode version usage in CONTRIBUTING.md 2026-06-16 10:28:11 +01:00
Stefan Ceriu 0ce7a5ea13 Log Sentry crash events through MXLog
Mirror crashes into our own logs via Sentry's beforeSend hook so the full crash
log ships with rageshakes. Adds a SentryEvent extension to extract the formatted
crash log from the event.
2026-06-16 12:13:10 +03:00
Daniel Anderson 434b3aab83 Report a phantom call to CallKit on PushKit early-return paths
iOS kills the app if a VoIP push isn't followed by reportNewIncomingCall, so
report an immediately ended call on every early-return path, named after the
room. A duplicate of an ongoing call is reported as answered elsewhere and an
expired push as a missed call that can be tapped to call back.

Signed-off-by: Daniel Anderson <daniel.anderson@toptal.com>
2026-06-16 12:11:37 +03:00
Element CI 70152f9ba1 Translations update 2026-06-15 20:10:16 +02:00
Stefan Ceriu de0b6507ef Attempt to fix XcodeCloud errors
An out-of-date resolved file was detected at /Volumes/workspace/repository/ElementX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved, which is not allowed when automatic dependency resolution is disabled; please make sure to update the file to reflect the changes in dependencies. Running resolver because requirements have changed.
2026-06-14 10:58:04 +03:00
renovate[bot] 3ed4b132b6 Update GitHub Actions to v7 2026-06-14 10:40:43 +03:00
renovate[bot] b6943a6142 Update Compound to v10.2.2 2026-06-12 16:34:34 +03:00
Stefan Ceriu ede0438a45 Fix swiftformat Unknown rule 'redundantStateInit'. Did you mean 'redundantNilInit'? error 2026-06-12 11:49:18 +03:00
Stefan Ceriu 67fdbac526 Setup proper logging for MapLibre and location views. 2026-06-12 09:47:25 +03:00
Mauro Romito 9dd78c0188 updated user sessions flow ui tests 2026-06-11 14:53:50 +02:00
Mauro Romito c2909aa9b8 bump rte to 2.42.0 2026-06-11 11:42:40 +02:00
Mauro Romito de6dab3d22 update codecov action 2026-06-11 11:42:10 +02:00
renovate[bot] 8262533b6d Update GitHub Actions to v6.0.3 2026-06-10 16:58:31 +02:00