ehealthsolutions/element-x-android
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-android.git synced 2026-10-31 16:22:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9 from Novaloop-AG/feature/healthchat-remove-analytics-onboarding

Browse Source 
Remove the analytics opt-in screen from onboarding
This commit is contained in:
Joël Poyet
2026-08-04 18:42:11 +02:00
committed by GitHub
parent 67fb6744fe fa08091528
commit c0c0b48470
5 changed files with 6 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/res/values-de/strings.xml
-9
View File
@@ -1,9 +0,0 @@
<?xml version="1.0" encoding="utf-8"?><!--
~ Copyright (c) 2026 Novaloop AG
~
~ SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
~ Please see LICENSE files in the repository root for full details.
-->
<resources>
<string name="screen_onboarding_welcome_title">"Willkommen bei HealthChat"</string>
</resources>
app/src/main/res/values-fr/strings.xml
-9
View File
@@ -1,9 +0,0 @@
<?xml version="1.0" encoding="utf-8"?><!--
~ Copyright (c) 2026 Novaloop AG
~
~ SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
~ Please see LICENSE files in the repository root for full details.
-->
<resources>
<string name="screen_onboarding_welcome_title">"Bienvenue chez HealthChat"</string>
</resources>
app/src/main/res/values-it/strings.xml
-9
View File
@@ -1,9 +0,0 @@
<?xml version="1.0" encoding="utf-8"?><!--
~ Copyright (c) 2026 Novaloop AG
~
~ SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
~ Please see LICENSE files in the repository root for full details.
-->
<resources>
<string name="screen_onboarding_welcome_title">"Benvenuto su HealthChat"</string>
</resources>
app/src/main/res/values/strings.xml
-13
View File
@@ -1,13 +0,0 @@
<?xml version="1.0" encoding="utf-8"?><!--
~ Copyright (c) 2026 Novaloop AG
~
~ SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
~ Please see LICENSE files in the repository root for full details.
-->
<resources xmlns:tools="http://schemas.android.com/tools">
<!-- HealthChat override of the Element onboarding title ("Be in your element").
Overridden here app-side instead of editing the Localazy-managed login
strings, so upstream merges stay clean. Only the main HealthChat locales
are overridden; other locales fall back to their Element translation. -->
<string name="screen_onboarding_welcome_title" tools:ignore="MissingTranslation">"Welcome to HealthChat"</string>
</resources>
plugins/src/main/kotlin/ModulesConfig.kt
+6 -7
View File
@@ -16,7 +16,12 @@ object ModulesConfig {
includeUnifiedPush = BuildTimeConfig.PUSH_CONFIG_INCLUDE_UNIFIED_PUSH,
)
val analyticsConfig: AnalyticsConfig = if (isEnterpriseBuild) {
// Analytics is enabled only when credentials are actually configured in BuildTimeConfig.
// Upstream applies this rule to enterprise builds only and hardcodes both providers on for
// FOSS builds; HealthChat ships no Posthog or Sentry credentials, so that hardcoding meant
// shipping both SDKs, prompting every new user with the analytics opt-in screen during the
// FTUE, and showing an Analytics settings entry — all while collecting nothing.
val analyticsConfig: AnalyticsConfig = run {
// Is Posthog configuration available?
val withPosthog = BuildTimeConfig.SERVICES_POSTHOG_APIKEY.isNullOrEmpty().not() &&
BuildTimeConfig.SERVICES_POSTHOG_HOST.isNullOrEmpty().not()
@@ -32,11 +37,5 @@ object ModulesConfig {
println("Analytics disabled")
AnalyticsConfig.Disabled
}
} else {
println("Analytics enabled with Posthog and Sentry")
AnalyticsConfig.Enabled(
withPosthog = true,
withSentry = true,
)
}
}