Files
element-x-ios/UnitTests/Sources/NotificationToneManagerTests.swift
T
Michael 22d14ff8e4 AppSettings are Mockable (#5589)
* create DependenciesProtocol and replace ServiceLocator registration with it

replace mocking calls for ServiceLocator to Dependencies

replace ServiceLocator with instance level calls

replace ServiceLocator configs with TestDependencies config in Tests

replace servicelocator usage in analytics service

replace remaining ServiceLocator calls in unit tests

that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances

fix swiftlint warning

remove remaining references to ServiceLocator

make dependencies properties consistent in tests

delete Dependencies and DependenciesProtocol

fix whitespace modifications

updates from PR feedback

a pass over converting AppSettings and AnalyticsService test instance properties to per test instantiation

fix a missed PR feedback

Sync up after rebase

create DependenciesProtocol and replace ServiceLocator registration with it

replace mocking calls for ServiceLocator to Dependencies

replace ServiceLocator with instance level calls

replace ServiceLocator configs with TestDependencies config in Tests

replace servicelocator usage in analytics service

replace remaining ServiceLocator calls in unit tests

that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances

fix swiftlint warning

remove remaining references to ServiceLocator

make dependencies properties consistent in tests

delete Dependencies and DependenciesProtocol

* AppSettings is instance level mockable now

* replace mocked and preview usages of reset + AppSettings global init with

AppSettings(store: UserDefaultsMock())

* AppSettings.UserDefaultsKeys is now a RawRep struct, making it extensible

* update tests with new AppSettings so it builds

* update remaining AppSettings test/mock inits

* AppSettings.UserDefaultsKey conformed to ExpressibleByStringLiteral

* addressed issues found in first pass ai review

* update AppSettings instantiations after rebase

* fix accessibility tests coordinator after rebase

* Rename to VolatileUserDefaults

* AppSettings init uses mandatory parameter

* Revert UserDefaultsKey to enum

* Add TrackedUserDefaults to be able to reset the defaults object

* Added volatile static func to AppSettings

* Use .volatile() static func instead of full init

* review fixups

* Resolve build issues after rebase

* updated enterprise module

* remove the static reset settings call from the preview tests

---------

Co-authored-by: Mauro Romito <mauro.romito@element.io>
2026-05-22 15:14:08 +02:00

99 lines
3.8 KiB
Swift

//
// Copyright 2025 Element Creations Ltd.
//
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
// Please see LICENSE files in the repository root for full details.
//
@testable import ElementX
import Foundation
import Testing
/// These tests exercise `NotificationToneManager` against the real app sandbox filesystem.
/// Because all tests share a single `libraryLocation` directory on disk, they are inherently
/// incapable of running in parallel — files written by one test would corrupt the state of
/// another. This project runs test in serial regardless, but this is just to document this is a specific case
/// relying on that behavior.
struct NotificationToneManagerTests {
private let manager: NotificationToneManager
init() {
manager = NotificationToneManager(appSettings: .volatile())
}
// MARK: - Deletion
@Test
func deletingSystemToneThrowsNotACustomTone() {
// Given a system tone (lives outside the library directory)
let tone = NotificationTone.createSystemSound(label: nil, filename: "alarm.caf")
// When deletion is attempted
// Then it throws because only library tones may be deleted
let error = #expect(throws: NotificationToneManager.ManagerError.self) {
try manager.deleteCustomTone(tone)
}
#expect(error == .notACustomTone)
}
@Test
func deletingBundledToneThrowsNotACustomTone() {
// Given a bundled app tone (lives outside the library directory)
let tone = NotificationTone.createBundledSound(label: nil, filename: "message.caf")
// When deletion is attempted
// Then it throws because only library tones may be deleted
let error = #expect(throws: NotificationToneManager.ManagerError.self) {
try manager.deleteCustomTone(tone)
}
#expect(error == .notACustomTone)
}
// MARK: - Custom Tone Listing
@Test
func customTonesFiltersToCAFOnly() throws {
// Given both CAF and non-CAF files written to the library directory
let cafURL = NotificationToneManager.libraryLocation.appending(component: "\(UUID().uuidString).caf")
let mp3URL = NotificationToneManager.libraryLocation.appending(component: "\(UUID().uuidString).mp3")
defer {
try? FileManager.default.removeItem(at: cafURL)
try? FileManager.default.removeItem(at: mp3URL)
}
try Data().write(to: cafURL)
try Data().write(to: mp3URL)
// When fetching the list of custom tones
let tones = manager.customTones()
// Then only the CAF file is included
#expect(tones.contains { $0.filename == cafURL.lastPathComponent })
#expect(!tones.contains { $0.filename == mp3URL.lastPathComponent })
}
// MARK: - Import
@Test
func addingDuplicateToneThrowsFileAlreadyExists() async throws {
// Given a CAF file that has already been imported into the library
let sourceURL = URL.temporaryDirectory.appending(component: "\(UUID().uuidString).caf")
let importedURL = NotificationToneManager.libraryLocation
.appending(component: sourceURL.deletingPathExtension().lastPathComponent)
.appendingPathExtension("caf")
defer {
try? FileManager.default.removeItem(at: sourceURL)
try? FileManager.default.removeItem(at: importedURL)
}
try Data().write(to: sourceURL)
try await manager.addNewToneToLibrary(from: sourceURL)
// When importing the same file a second time
// Then it throws ConversionError (specifically fileAlreadyExists)
await #expect(throws: NotificationToneManager.ManagerError.self) {
try await manager.addNewToneToLibrary(from: sourceURL)
}
}
}