mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-02 12:07:55 +00:00
a520d94760
* Enable Swift 6.2 with default main actor isolation for the app target Turn on SWIFT_VERSION 6.2, SWIFT_APPROACHABLE_CONCURRENCY and SWIFT_DEFAULT_ACTOR_ISOLATION = MainActor for the ElementX target, matching the NSE and Share Extension (which already use 6.2 without the main actor default). # Conflicts: # ElementX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved * Update the code generation templates for Swift 6 Emit nonisolated/@unchecked Sendable mocks and nonisolated string enums, and mark async mock methods @concurrent so they keep suspending like the real implementations (otherwise intermediate states are unobservable in tests). Includes the regenerated mocks and strings. # Conflicts: # ElementX/Sources/Mocks/Generated/GeneratedMocks.swift * Make the data layer and services nonisolated and Sendable Annotate the value-type models, Rust SDK proxy wrappers, timeline item graph, settings, logging and NSE-shared types as nonisolated, and conform the service protocols to Sendable so their existentials can cross isolation boundaries. These types run off the main actor and no longer inherit the target's default main actor isolation. * Adopt the new isolation across call sites, mocks and signatures Update call sites, closure signatures and mock configuration helpers to match the nonisolated/Sendable data layer, including the main actor isolated mock inits and the @Sendable filter on recentlyVisitedRooms. ^ Conflicts: ^ ElementX/Sources/Services/SecureBackup/SecureBackupController.swift * Remove redundant @MainActor annotations With the app target defaulting to main actor isolation, the explicit @MainActor on view models, coordinators, views and their protocols is no longer required. * Fix concurrency hotspots surfaced by the migration Resolve the room summary main-thread deadlock by moving diff processing onto AsyncStreams, add the SDKListener.onMainActor FIFO bridge for SDK callbacks, hop KVO/timer/UIKit callbacks to the main actor via assumeIsolated, add isolated deinits, and apply the few justified nonisolated(unsafe) escapes for queue-confined Apple APIs. * Fix the unit tests for Swift 6 concurrency Hop the waitForConfirmation body onto the caller's actor (Swift Testing runs confirmation closures off-actor), and adjust the affected suites and async signatures. * offload diffs on concurrent threads instead of main actor * make room info protocols sendable * use a task group for fetching data so that everything runs concurrently in the TextRoomTimelineView when getting the preview. * use the generic onMainActor implementation, which already makes a stream and send the continuation on the main actor. * small pr comments issues being addressed * update enterprise * Update StaticCode to 1.1.0 and specify the required Swift isolation. * fix ElementCallServiceTests * update enterprise * re-generate mocks * update enterprise * enterprise new code conformed to swift 6 --------- Co-authored-by: Doug <douglase@element.io>
123 lines
4.2 KiB
Swift
123 lines
4.2 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import Foundation
|
|
import UIKit
|
|
|
|
nonisolated protocol EventBasedTimelineItemProtocol: RoomTimelineItemProtocol, CustomStringConvertible {
|
|
var timestamp: Date { get }
|
|
var isOutgoing: Bool { get }
|
|
var isEditable: Bool { get }
|
|
var canBeRepliedTo: Bool { get }
|
|
|
|
var sender: TimelineItemSender { get }
|
|
|
|
var body: String { get }
|
|
|
|
var properties: RoomTimelineItemProperties { get }
|
|
}
|
|
|
|
nonisolated extension EventBasedTimelineItemProtocol {
|
|
var description: String {
|
|
"\(String(describing: Self.self)): id: \(id), timestamp: \(timestamp), isOutgoing: \(isOutgoing), properties: \(properties)"
|
|
}
|
|
|
|
var isForwardable: Bool {
|
|
isRemoteMessage && !(self is PollRoomTimelineItem)
|
|
}
|
|
|
|
var isRemoteMessage: Bool {
|
|
id.eventID != nil
|
|
}
|
|
|
|
var isRedacted: Bool {
|
|
self is RedactedRoomTimelineItem
|
|
}
|
|
|
|
var pollIfAvailable: Poll? {
|
|
(self as? PollRoomTimelineItem)?.poll
|
|
}
|
|
|
|
var hasStatusIcon: Bool {
|
|
hasFailedToSend || properties.encryptionAuthenticity != nil || properties.encryptionForwarder != nil
|
|
}
|
|
|
|
var hasFailedToSend: Bool {
|
|
properties.deliveryStatus?.isSendingFailed == true
|
|
}
|
|
|
|
var hasFailedDecryption: Bool {
|
|
self is EncryptedRoomTimelineItem
|
|
}
|
|
|
|
var timelineMenuDescription: String {
|
|
switch self {
|
|
case is VoiceMessageRoomTimelineItem:
|
|
return L10n.commonVoiceMessage
|
|
default:
|
|
return body.trimmingCharacters(in: .whitespacesAndNewlines)
|
|
}
|
|
}
|
|
|
|
/// The inline area to reserve at the trailing edge of the message text so the
|
|
/// bubble's natural size accommodates the timestamp (which is overlaid on the
|
|
/// bubble's bottom-trailing corner). Text wraps around this area: if it fits on
|
|
/// the last line, the timestamp tucks inline; otherwise it sits on a new line.
|
|
/// Sized using the same dynamic-type-aware font as the rendered timestamp.
|
|
var trailingReservedSize: CGSize {
|
|
let textStyle: UIFont.TextStyle = .caption1 // matches compound.bodyXS
|
|
let font = UIFont.preferredFont(forTextStyle: textStyle)
|
|
let textSize = (localizedSendInfo as NSString).size(withAttributes: [.font: font])
|
|
var width = textSize.width
|
|
var height = textSize.height
|
|
if hasStatusIcon {
|
|
// CompoundIcon at .xSmall is 16pt at the base size; scale with the same UIFontMetrics
|
|
// as the icon's `relativeTo: .compound.bodyXS` modifier, plus the 4pt HStack spacing.
|
|
let iconSize = UIFontMetrics(forTextStyle: textStyle).scaledValue(for: 16)
|
|
width += iconSize + 4
|
|
height = max(height, iconSize)
|
|
}
|
|
// Small visual gap between the text content and the overlaid timestamp.
|
|
width += 4
|
|
return CGSize(width: ceil(width), height: ceil(height))
|
|
}
|
|
|
|
/// contains the timestamp and an optional edited localised prefix
|
|
/// example: (edited) 12:17 PM
|
|
var localizedSendInfo: String {
|
|
var start = ""
|
|
if properties.isEdited {
|
|
start = "\(L10n.commonEditedSuffix) "
|
|
}
|
|
return start + timestamp.formattedTime()
|
|
}
|
|
|
|
var isCopyable: Bool {
|
|
guard let messageBasedItem = self as? EventBasedMessageTimelineItemProtocol else {
|
|
return false
|
|
}
|
|
|
|
switch messageBasedItem.contentType {
|
|
case .audio, .file, .image, .video, .location, .voice:
|
|
return false
|
|
case .text, .emote, .notice:
|
|
return true
|
|
}
|
|
}
|
|
|
|
var supportsMediaCaption: Bool {
|
|
guard let messageBasedItem = self as? EventBasedMessageTimelineItemProtocol else { return false }
|
|
return messageBasedItem.supportsMediaCaption
|
|
}
|
|
|
|
var hasMediaCaption: Bool {
|
|
guard let messageBasedItem = self as? EventBasedMessageTimelineItemProtocol else { return false }
|
|
return messageBasedItem.hasMediaCaption
|
|
}
|
|
}
|