Indent the new method's blank lines to satisfy SwiftFormat's
indent-blank-lines rule, which failed the Tests CI jobs.
Also address review findings on the crop itself:
- Request a 256pt thumbnail box at both donation sites so cropping a
scaled (aspect-fit) thumbnail to its minor axis keeps enough
resolution for the share sheet's circle.
- Round the draw offsets to whole pixels so odd-sized crops blit
instead of resampling.
- Log when fetched avatar data can't be decoded rather than silently
swapping in the placeholder, and document the non-obvious
format.scale pinning.
The media repo serves thumbnails with the scale method, so avatars keep
their source aspect ratio. The system stretches whatever INImage we
donate to fill a circle, distorting any non-square avatar in the share
sheet's conversation suggestions (and notifications, which are donated
the same image).
Centre-crop donated avatars to a square before handing them to the
system, in both the timeline's send message intent donation and the
NSE's communication context.
* Support for waitingForAuth continuation sender during Link new device
* Stop automatically regenerating new QR codes when they expire.
This reverts part of commit e235e3ba81.
* Add a timeout after the Face/TouchID verification when linking a desktop computer.
---------
Co-authored-by: Hugh Nimmo-Smith <hughns@element.io>
The accessibility audit flagged the avatar node in AvatarSettingsButtonLabel
as having no description, since it carried an accessibility identifier but
never a label.
The avatar is purely decorative, both screens that use it wrap it in a button
that is already labelled with the Settings title, so it is now hidden from
accessibility and the identifier has moved up onto the buttons themselves,
where the UI and integration tests query it.
* feat: add call icon next to members in call
* feat: use matrix rtc room status for in-call
* chore: revert xcodeproj change
* chore: update preview tests
* chore: Update ElementX.xcscheme
* chore: undo room member status proxy
---------
Co-authored-by: Kai <nankeen@users.noreply.github.com>
The Swift 6 migration consumed the KVO progress publisher through its AsyncSequence, which wants one value at a time. Progress updates that arrive while the loop is busy are dropped, the buffer holds onto the latest one until the loop is ready for it.
Signed-off-by: Daniel Anderson <daniel.anderson@toptal.com>
* remove the usage of the timeline kind override in favour of getting it properly from the timeline view model
* allow the previews to include gallery items filtered by the allowed types when started outside the gallery
sss
asa
* fix for actions not being forwarded to the timeline right
* pr suggestions
Tapping a gallery tile/row opens the existing media preview scoped to that gallery's attachments, paging between them. Introduces a typed MediaPreviewItemID (replacing the stringly-typed preview identifier) and a gallery-scoped TimelineMediaPreviewDataSource; the tap routes through TimelineInteractionHandler/TimelineViewModel. Non-previewable (.other) items are skipped without shifting the tapped index.
Co-authored-by: svetoslav.mitov <svetoslav.mitov@sportinno.com>
just use id instead of previewID
removed horrible multiline ternary
pr suggestions
remove redundant code
remove empty caption display + gallery uses the appropriate media timeline actions
* Render galleries with non-visual attachments as a list
Adds GalleryListView (with GalleryDivider) for galleries containing a file or audio item, extracting the shared FileTypeIconView from FileRoomTimelineView. GalleryRoomTimelineView picks the list vs the grid via usesListLayout. Tapping to open the preview lands in a follow-up.
Co-authored-by: svetoslav.mitov <svetoslav.mitov@sportinno.com>
* pr suggestions
---------
Co-authored-by: svetoslav.mitov <svetoslav.mitov@sportinno.com>
* Render live location share start push notifications in the NSE
Live location sharing starts with a cleartext org.matrix.msc3672.beacon_info
STATE event, which the NSE previously rendered as the generic fallback
notification because NotificationContentBuilder only handled message-like
event content.
- Handle .state(.beaconInfo) in NotificationContentBuilder: sender display
name as the title (same as other messages) with a new localized body,
"Started sharing their live location".
- Let beaconInfo state events through NotificationHandler's preprocessing
(all other state events are still discarded).
- Add notification_live_location_started_body, imported from Localazy.
- Unit tests for the new state-event notification paths.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* rename processMessageLike in processAsMessage
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Mauro Romito <mauro.romito@element.io>
Introduces the GalleryRoomTimelineItem and its typed GalleryItem model (reusing the existing per-message content types), builds it in the RoomTimelineItemFactory and routes it through RoomTimelineItemView. For now it renders as a placeholder; the grid/list media views and the full-screen preview land in follow-up PRs.
Co-authored-by: svetoslav.mitov <svetoslav.mitov@sportinno.com>
mredig
Mauro Romito
Matthew Hodgson
Doug
Stefan Ceriu
Doug
Kai
ElementRobot
renovate[bot]
Daniel Anderson
Mauro