ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-10-31 16:24:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

hit region issues were caused by dynamic type checks not working properly, so they have been removed

Browse Source
This commit is contained in:
Mauro Romito
2025-07-21 19:40:26 +02:00
committed by Mauro
parent 8a66cbad68
commit 97f517129f
6 changed files with 3 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
AccessibilityTests/Sources/AccessibilityTests.swift
+3 -3
View File
@@ -91,9 +91,9 @@ final class AccessibilityTests: XCTestCase {
private static let notHumanReadableMessage = "Label not human-readable"
/// Use this array to filter add specific filters to ignore specific issues for certain elements
private static let ignoredA11yIdentifiers: [String: [FilterType]] = [A11yIdentifiers.authenticationStartScreen.appVersion: [.auditType(.hitRegion)],
A11yIdentifiers.pollView.summary: [.auditType(.hitRegion)],
A11yIdentifiers.serverConfirmationScreen.serverPicker: [.compactDescription(notHumanReadableMessage)]]
private static let ignoredA11yIdentifiers: [String: [FilterType]] = [
A11yIdentifiers.serverConfirmationScreen.serverPicker: [.compactDescription(notHumanReadableMessage)]
]
}
private enum FilterType {
ElementX/Sources/Other/AccessibilityIdentifiers.swift
-5
View File
@@ -42,7 +42,6 @@ enum A11yIdentifiers {
static let pollFormScreen = PollFormScreen()
static let roomPollsHistoryScreen = RoomPollsHistoryScreen()
static let manageRoomMemberSheet = ManageRoomMemberSheet()
static let pollView = PollView()
struct AlertInfo {
let primaryButton = "alert_info-primary_button"
@@ -298,8 +297,4 @@ enum A11yIdentifiers {
struct ManageRoomMemberSheet {
let viewProfile = "manage_room_member_sheet-view_profile"
}
struct PollView {
let summary = "poll_view-summary"
}
}
ElementX/Sources/Screens/HomeScreen/View/HomeScreenRecoveryKeyConfirmationBanner.swift
-3
View File
@@ -68,9 +68,6 @@ struct HomeScreenRecoveryKeyConfirmationBanner: View {
Image(systemName: "xmark")
.foregroundColor(.compound.iconSecondary)
.frame(width: 12, height: 12)
// Increase hit area
.padding(.leading, 5)
.padding(.bottom, 2)
}
}
}
ElementX/Sources/Screens/MediaUploadPreviewScreen/View/MediaUploadPreviewScreen.swift
-3
View File
@@ -82,9 +82,6 @@ struct MediaUploadPreviewScreen: View {
context.isPresentingMediaCaptionWarning = true
} label: {
CompoundIcon(\.infoSolid, size: .xSmall, relativeTo: .compound.bodyLG)
// Increase hit area
.padding(.leading, 5)
.padding(.vertical, 2)
}
.tint(.compound.iconCriticalPrimary)
.popover(isPresented: $context.isPresentingMediaCaptionWarning, arrowEdge: .bottom) {
ElementX/Sources/Screens/RoomChangeRolesScreen/View/RoomChangeRolesScreenSelectedItem.swift
-3
View File
@@ -44,9 +44,6 @@ struct RoomChangeRolesScreenSelectedItem: View {
.scaledFrame(size: 20)
.symbolRenderingMode(.palette)
.foregroundStyle(Color.compound.iconOnSolidPrimary, Color.compound.iconPrimary)
// Increase hit area
.padding(.leading, 5)
.padding(.bottom, 5)
}
// We will use the accessibility action
.accessibilityHidden(true)
ElementX/Sources/Screens/Timeline/View/Polls/PollView.swift
-1
View File
@@ -128,7 +128,6 @@ struct PollView: View {
.scaledPadding(.leading, showVotes ? 0 : 32)
.foregroundColor(.compound.textSecondary)
.frame(maxWidth: .infinity, alignment: showVotes ? .trailing : .leading)
.accessibilityIdentifier(A11yIdentifiers.pollView.summary)
}
}