ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-04 01:20:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Periphery cleanup (#5893)

Browse Source
This commit is contained in:
Mauro
2026-07-20 11:16:11 +02:00
committed by GitHub
parent 175aca596e
commit 9093631f8b
275 changed files with 381 additions and 2268 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Screens/Timeline/View/ItemMenu/TimelineItemMenu.swift
-1
View File
@@ -337,7 +337,6 @@ struct TimelineItemMenu_Previews: PreviewProvider, TestablePreview {
canCurrentUserRedactOthers: false,
canCurrentUserPin: true,
pinnedEventIDs: [],
isDM: true,
isViewSourceEnabled: true,
areThreadsEnabled: true,
timelineKind: .live,
ElementX/Sources/Screens/Timeline/View/ItemMenu/TimelineItemMenuActionProvider.swift
+3 -4
View File
@@ -15,7 +15,6 @@ struct TimelineItemMenuActionProvider {
let canCurrentUserRedactOthers: Bool
let canCurrentUserPin: Bool
let pinnedEventIDs: Set<String>
let isDM: Bool
let isViewSourceEnabled: Bool
let areThreadsEnabled: Bool
let timelineKind: TimelineKind
@@ -33,8 +32,8 @@ struct TimelineItemMenuActionProvider {
return nil
}
if let encryptedItem = timelineItem as? EncryptedRoomTimelineItem {
return makeEncryptedItemActions(encryptedItem)
if timelineItem is EncryptedRoomTimelineItem {
return makeEncryptedItemActions()
}
var actions: [TimelineItemMenuAction] = []
@@ -148,7 +147,7 @@ struct TimelineItemMenuActionProvider {
return .init(isReactable: isReactable, actions: actions, secondaryActions: secondaryActions, emojiProvider: emojiProvider)
}
private func makeEncryptedItemActions(_ encryptedItem: EncryptedRoomTimelineItem) -> TimelineItemMenuActions? {
private func makeEncryptedItemActions() -> TimelineItemMenuActions? {
var actions: [TimelineItemMenuAction] = [.copyPermalink]
if isViewSourceEnabled {
ElementX/Sources/Screens/Timeline/View/Replies/TimelineReplyView.swift
+1
View File
@@ -17,6 +17,7 @@ enum TimelineReplyViewPlacement {
struct TimelineReplyView: View {
@Environment(\.timelineContext) private var timelineContext
// periphery:ignore - might be useful to have
let placement: TimelineReplyViewPlacement
let timelineItemReplyDetails: TimelineItemReplyDetails?
var maxWidth: CGFloat?
ElementX/Sources/Screens/Timeline/View/Style/SwipeToReplyView.swift
-34
View File
@@ -1,34 +0,0 @@
//
// Copyright 2025 Element Creations Ltd.
// Copyright 2023-2025 New Vector Ltd.
//
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
// Please see LICENSE files in the repository root for full details.
//
import Compound
import SwiftUI
struct SwipeToReplyView: View {
let timelineItem: RoomTimelineItemProtocol
var body: some View {
CompoundIcon(\.reply)
.foregroundColor(.compound.iconPrimary)
.accessibilityHidden(true)
}
}
struct SwipeToReplyView_Previews: PreviewProvider, TestablePreview {
static let timelineItem = TextRoomTimelineItem(id: .randomEvent,
timestamp: .mock,
isOutgoing: true,
isEditable: true,
canBeRepliedTo: true,
sender: .init(id: ""),
content: .init(body: ""))
static var previews: some View {
SwipeToReplyView(timelineItem: timelineItem)
}
}
ElementX/Sources/Screens/Timeline/View/Style/TimelineItemBubbledStylerView.swift
+3 -2
View File
@@ -166,7 +166,9 @@ struct TimelineItemBubbledStylerView<Content: View>: View {
context.send(viewAction: .displayTimelineItemMenu(itemID: timelineItem.id))
}
.swipeRightAction {
SwipeToReplyView(timelineItem: timelineItem)
CompoundIcon(\.reply)
.foregroundColor(.compound.iconPrimary)
.accessibilityHidden(true)
} shouldStartAction: {
timelineItem.canBeRepliedTo
} action: {
@@ -180,7 +182,6 @@ struct TimelineItemBubbledStylerView<Content: View>: View {
canCurrentUserRedactOthers: context.viewState.canCurrentUserRedactOthers,
canCurrentUserPin: context.viewState.canCurrentUserPin,
pinnedEventIDs: context.viewState.pinnedEventIDs,
isDM: context.viewState.isDM,
isViewSourceEnabled: context.viewState.isViewSourceEnabled,
areThreadsEnabled: context.viewState.areThreadsEnabled,
timelineKind: context.viewState.timelineKind,
ElementX/Sources/Screens/Timeline/View/Supplementary/TimelineReactionsView.swift
-2
View File
@@ -138,8 +138,6 @@ struct TimelineCollapseButtonLabel: View {
}
struct TimelineReactionButton: View {
@Environment(\.accessibilityVoiceOverEnabled) private var voiceOverEnabled
let reaction: AggregatedReaction
let toggleReaction: (String) -> Void
let showReactionSummary: (String) -> Void
ElementX/Sources/Screens/Timeline/View/TimelineItemViews/CallInviteRoomTimelineView.swift
+1 -7
View File
@@ -11,8 +11,6 @@ import Foundation
import SwiftUI
struct CallInviteRoomTimelineView: View {
let timelineItem: CallInviteRoomTimelineItem
var body: some View {
Label {
Text(L10n.screenRoomTimelineLegacyCall)
@@ -34,10 +32,6 @@ struct CallInviteRoomTimelineView_Previews: PreviewProvider, TestablePreview {
}
static var body: some View {
CallInviteRoomTimelineView(timelineItem: .init(id: .randomEvent,
timestamp: .mock,
isEditable: false,
canBeRepliedTo: false,
sender: .init(id: "Bob")))
CallInviteRoomTimelineView()
}
}
ElementX/Sources/Screens/Timeline/View/TimelineItemViews/CallNotificationRoomTimelineView.swift
-16
View File
@@ -11,8 +11,6 @@ import Foundation
import SwiftUI
struct CallNotificationRoomTimelineView: View {
@Environment(\.timelineContext) private var context
let timelineItem: CallNotificationRoomTimelineItem
var body: some View {
@@ -76,8 +74,6 @@ struct CallNotificationRoomTimelineView_Previews: PreviewProvider, TestablePrevi
VStack(spacing: 0) {
CallNotificationRoomTimelineView(timelineItem: .init(id: .randomEvent,
timestamp: .mock,
isEditable: false,
canBeRepliedTo: false,
isDM: false,
isDeclinedByMe: false,
isDeclined: false,
@@ -87,8 +83,6 @@ struct CallNotificationRoomTimelineView_Previews: PreviewProvider, TestablePrevi
CallNotificationRoomTimelineView(timelineItem: .init(id: .randomEvent,
timestamp: .mock,
isEditable: false,
canBeRepliedTo: false,
isDM: true,
isDeclinedByMe: false,
isDeclined: false,
@@ -98,8 +92,6 @@ struct CallNotificationRoomTimelineView_Previews: PreviewProvider, TestablePrevi
CallNotificationRoomTimelineView(timelineItem: .init(id: .randomEvent,
timestamp: .mock,
isEditable: false,
canBeRepliedTo: false,
isDM: false,
isDeclinedByMe: true,
isDeclined: true,
@@ -109,8 +101,6 @@ struct CallNotificationRoomTimelineView_Previews: PreviewProvider, TestablePrevi
CallNotificationRoomTimelineView(timelineItem: .init(id: .randomEvent,
timestamp: .mock,
isEditable: false,
canBeRepliedTo: false,
isDM: true,
isDeclinedByMe: false,
isDeclined: true,
@@ -120,8 +110,6 @@ struct CallNotificationRoomTimelineView_Previews: PreviewProvider, TestablePrevi
CallNotificationRoomTimelineView(timelineItem: .init(id: .randomEvent,
timestamp: .mock,
isEditable: false,
canBeRepliedTo: false,
isDM: true,
isDeclinedByMe: true,
isDeclined: true,
@@ -131,8 +119,6 @@ struct CallNotificationRoomTimelineView_Previews: PreviewProvider, TestablePrevi
CallNotificationRoomTimelineView(timelineItem: .init(id: .randomEvent,
timestamp: .mock,
isEditable: false,
canBeRepliedTo: false,
isDM: true,
isDeclinedByMe: false,
isDeclined: true,
@@ -142,8 +128,6 @@ struct CallNotificationRoomTimelineView_Previews: PreviewProvider, TestablePrevi
CallNotificationRoomTimelineView(timelineItem: .init(id: .randomEvent,
timestamp: .mock,
isEditable: false,
canBeRepliedTo: false,
isDM: true,
isDeclinedByMe: true,
isDeclined: true,
ElementX/Sources/Screens/Timeline/View/TimelineItemViews/LiveLocationRoomTimelineView.swift
-2
View File
@@ -13,10 +13,8 @@ struct LiveLocationRoomTimelineView: View {
@Environment(\.timelineContext) private var context: TimelineViewModel.Context!
@State private var hasExpired: Bool
let timelineItem: LiveLocationRoomTimelineItem
private let currentDate: Date
init(currentDate: Date = .now, timelineItem: LiveLocationRoomTimelineItem, isStopped: Bool = false) {
self.currentDate = currentDate
self.timelineItem = timelineItem
_hasExpired = State(initialValue: isStopped || currentDate >= timelineItem.content.timeoutDate)
}
ElementX/Sources/Screens/Timeline/View/TimelineItemViews/PaginationIndicatorRoomTimelineView.swift
+1 -4
View File
@@ -9,8 +9,6 @@
import SwiftUI
struct PaginationIndicatorRoomTimelineView: View {
let timelineItem: PaginationIndicatorRoomTimelineItem
var body: some View {
ProgressView()
.frame(maxWidth: .infinity)
@@ -20,7 +18,6 @@ struct PaginationIndicatorRoomTimelineView: View {
struct PaginationIndicatorRoomTimelineView_Previews: PreviewProvider, TestablePreview {
static var previews: some View {
let item = PaginationIndicatorRoomTimelineItem(position: .start)
PaginationIndicatorRoomTimelineView(timelineItem: item)
PaginationIndicatorRoomTimelineView()
}
}
ElementX/Sources/Screens/Timeline/View/TimelineItemViews/ReadMarkerRoomTimelineView.swift
+1 -5
View File
@@ -10,8 +10,6 @@ import Foundation
import SwiftUI
struct ReadMarkerRoomTimelineView: View {
let timelineItem: ReadMarkerRoomTimelineItem
var body: some View {
VStack(alignment: .trailing, spacing: 2) {
Text(L10n.screenRoomTimelineReadMarkerTitle)
@@ -30,8 +28,6 @@ struct ReadMarkerRoomTimelineView: View {
struct ReadMarkerRoomTimelineView_Previews: PreviewProvider, TestablePreview {
static let viewModel = TimelineViewModel.mock
static let item = ReadMarkerRoomTimelineItem(id: .randomVirtual)
static var previews: some View {
VStack(alignment: .leading, spacing: 0) {
RoomTimelineItemView(viewState: .init(type: .separator(.init(id: .virtual(uniqueID: .init("Separator")), timestamp: .mock)), groupStyle: .single))
@@ -43,7 +39,7 @@ struct ReadMarkerRoomTimelineView_Previews: PreviewProvider, TestablePreview {
sender: .init(id: "1", displayName: "Bob"),
content: .init(body: "This is another message"))), groupStyle: .single))
ReadMarkerRoomTimelineView(timelineItem: item)
ReadMarkerRoomTimelineView()
RoomTimelineItemView(viewState: .init(type: .separator(.init(id: .virtual(uniqueID: .init("Separator")), timestamp: .mock)), groupStyle: .single))
RoomTimelineItemView(viewState: .init(type: .text(.init(id: .randomEvent,
ElementX/Sources/Screens/Timeline/View/TimelineItemViews/TextBasedRoomTimelineViewProtocol.swift
-1
View File
@@ -6,7 +6,6 @@
// Please see LICENSE files in the repository root for full details.
//
// periphery: ignore - markdown protocol
protocol TextBasedRoomTimelineViewProtocol {
associatedtype TimelineItemType: TextBasedRoomTimelineItem
ElementX/Sources/Screens/Timeline/View/TimelineView.swift
-1
View File
@@ -34,7 +34,6 @@ struct TimelineView: View {
canCurrentUserRedactOthers: timelineContext.viewState.canCurrentUserRedactOthers,
canCurrentUserPin: timelineContext.viewState.canCurrentUserPin,
pinnedEventIDs: timelineContext.viewState.pinnedEventIDs,
isDM: timelineContext.viewState.isDM,
isViewSourceEnabled: timelineContext.viewState.isViewSourceEnabled,
areThreadsEnabled: timelineContext.viewState.areThreadsEnabled,
timelineKind: timelineContext.viewState.timelineKind,