mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-04 01:20:12 +00:00
Refactor Rageshake URL and Target configuration. (#4337)
* Move the rageshakeURL configuration from the BugReportService to AppSettings. * Refactor Target to return a handle when configuring. This helps with reconfiguration and removes the @MainActor constraint.
This commit is contained in:
@@ -46,13 +46,11 @@ enum BugReportServiceError: LocalizedError {
|
||||
}
|
||||
}
|
||||
|
||||
enum RageshakeConfiguration {
|
||||
enum RageshakeConfiguration: Equatable {
|
||||
/// Rageshakes should be sent to the provided URL
|
||||
case url(URL)
|
||||
/// Rageshakes are disabled.
|
||||
case disabled
|
||||
/// No customisations are made, use the default configuration.
|
||||
case `default`
|
||||
}
|
||||
|
||||
// sourcery: AutoMockable
|
||||
@@ -62,8 +60,6 @@ protocol BugReportServiceProtocol: AnyObject {
|
||||
|
||||
var lastCrashEventID: String? { get set }
|
||||
|
||||
func applyConfiguration(_ configuration: RageshakeConfiguration)
|
||||
|
||||
func submitBugReport(_ bugReport: BugReport,
|
||||
progressListener: CurrentValueSubject<Double, Never>) async -> Result<SubmitBugReportResponse, BugReportServiceError>
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user