ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-02 21:33:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

increas hit area for the media preview upload warning, and hide accessibility for the avatar in the mention suggestions view

Browse Source
This commit is contained in:
Mauro Romito
2025-07-21 12:51:19 +02:00
committed by Mauro
parent a547782e94
commit 5905bc1e76
2 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Screens/MediaUploadPreviewScreen/View/MediaUploadPreviewScreen.swift
+3
View File
@@ -82,6 +82,9 @@ struct MediaUploadPreviewScreen: View {
context.isPresentingMediaCaptionWarning = true
} label: {
CompoundIcon(\.infoSolid, size: .xSmall, relativeTo: .compound.bodyLG)
// Increase hit area
.padding(.leading, 5)
.padding(.vertical, 2)
}
.tint(.compound.iconCriticalPrimary)
.popover(isPresented: $context.isPresentingMediaCaptionWarning, arrowEdge: .bottom) {
ElementX/Sources/Screens/RoomScreen/ComposerToolbar/View/MentionSuggestionItemView.swift
+15 -8
View File
@@ -13,14 +13,8 @@ struct MentionSuggestionItemView: View {
var body: some View {
HStack(alignment: .center, spacing: 16) {
switch item.suggestionType {
case .user(let user):
LoadableAvatarImage(url: user.avatarURL, name: user.displayName, contentID: user.id, avatarSize: .user(on: .completionSuggestions), mediaProvider: mediaProvider)
case .allUsers(let avatar):
RoomAvatarImage(avatar: avatar, avatarSize: .room(on: .completionSuggestions), mediaProvider: mediaProvider)
case .room(let room):
RoomAvatarImage(avatar: room.avatar, avatarSize: .room(on: .completionSuggestions), mediaProvider: mediaProvider)
}
avatar
.accessibilityHidden(true)
VStack(alignment: .leading, spacing: 0) {
Text(item.displayName)
.font(.compound.bodyLG)
@@ -34,6 +28,19 @@ struct MentionSuggestionItemView: View {
}
}
}
.accessibilityElement(children: .combine)
}
@ViewBuilder
private var avatar: some View {
switch item.suggestionType {
case .user(let user):
LoadableAvatarImage(url: user.avatarURL, name: user.displayName, contentID: user.id, avatarSize: .user(on: .completionSuggestions), mediaProvider: mediaProvider)
case .allUsers(let avatar):
RoomAvatarImage(avatar: avatar, avatarSize: .room(on: .completionSuggestions), mediaProvider: mediaProvider)
case .room(let room):
RoomAvatarImage(avatar: room.avatar, avatarSize: .room(on: .completionSuggestions), mediaProvider: mediaProvider)
}
}
}