ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-10-31 16:24:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Report a phantom call to CallKit on PushKit early-return paths

Browse Source 
iOS kills the app if a VoIP push isn't followed by reportNewIncomingCall, so
report an immediately ended call on every early-return path, named after the
room. A duplicate of an ongoing call is reported as answered elsewhere and an
expired push as a missed call that can be tapped to call back.

Signed-off-by: Daniel Anderson <daniel.anderson@toptal.com>
This commit is contained in:
Daniel Anderson
2026-05-27 10:09:11 -06:00
committed by Stefan Ceriu
parent 70152f9ba1
commit 434b3aab83
2 changed files with 96 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
UnitTests/Sources/ElementCallServiceTests.swift
+47 -16
View File
@@ -5,6 +5,7 @@
// Please see LICENSE files in the repository root for full details.
//
import CallKit
import Clocks
@testable import ElementX
import PushKit
@@ -109,22 +110,6 @@ final class ElementCallServiceTests {
}
}
@Test
func expiredRingLifetimeIsIgnored() {
#expect(!callProvider.reportNewIncomingCallWithUpdateCompletionCalled)
let pushPayload = PKPushPayloadMock().updatingExpiration(currentDate, lifetime: 20)
currentDate = currentDate.addingTimeInterval(60)
service.pushRegistry(pushRegistry,
didReceiveIncomingPushWith: pushPayload,
for: .voIP) { }
sleep(20)
#expect(!callProvider.reportNewIncomingCallWithUpdateCompletionCalled)
}
@Test
func lifetimeIsCapped() async {
await confirmation { confirmation in
@@ -223,6 +208,52 @@ final class ElementCallServiceTests {
#expect(!unansweredFired, "endUnansweredCallTask should have been cancelled by setupCallSession")
}
@Test
func expiredPushReportsMissedCall() async {
// An expired push is a real call we missed, so it should show up in Recents as one.
let pushPayload = PKPushPayloadMock().updatingExpiration(currentDate, lifetime: 20)
currentDate = currentDate.addingTimeInterval(60)
await expectImmediatelyEndedCallReported(forPayload: pushPayload, expectedReason: .unanswered)
let update = callProvider.reportNewIncomingCallWithUpdateCompletionReceivedArguments?.update
#expect(update?.localizedCallerName == "welcome")
#expect(update?.remoteHandle?.value == "!room:example.com")
}
@Test
func duplicateRoomPushReportsCallAsHandled() async {
// A duplicate push for an ongoing call is reported as handled, leaving the ongoing call alone.
await service.setupCallSession(roomID: "!room:example.com", roomDisplayName: "welcome")
let pushPayload = PKPushPayloadMock().updatingExpiration(currentDate, lifetime: 30)
await expectImmediatelyEndedCallReported(forPayload: pushPayload, expectedReason: .answeredElsewhere)
// The call should be named so neither the brief system UI nor the Recents entry shows "Unknown".
let update = callProvider.reportNewIncomingCallWithUpdateCompletionReceivedArguments?.update
#expect(update?.localizedCallerName == "welcome")
#expect(service.ongoingCallRoomIDPublisher.value == "!room:example.com")
}
private func expectImmediatelyEndedCallReported(forPayload payload: PKPushPayloadMock,
expectedReason: CXCallEndedReason) async {
let baselineNewIncomingCount = callProvider.reportNewIncomingCallWithUpdateCompletionCallsCount
let baselineEndedCount = callProvider.reportCallWithEndedAtReasonCallsCount
await confirmation { confirmation in
service.pushRegistry(pushRegistry, didReceiveIncomingPushWith: payload, for: .voIP) {
confirmation()
}
}
#expect(callProvider.reportNewIncomingCallWithUpdateCompletionCallsCount == baselineNewIncomingCount + 1)
#expect(callProvider.reportCallWithEndedAtReasonCallsCount == baselineEndedCount + 1)
let reportedCall = callProvider.reportNewIncomingCallWithUpdateCompletionReceivedArguments
let endedCall = callProvider.reportCallWithEndedAtReasonReceivedArguments
#expect(reportedCall?.uuid == endedCall?.uuid)
#expect(endedCall?.reason == expectedReason)
}
}
private class PKPushPayloadMock: PKPushPayload {