ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-02 12:07:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Attempt to fix the wrong timeline start display by defaulting the backwards publisher to .idle

Browse Source 
The default values shouldn't matter as they should be updated when calling subscribeToPagination
but empirically we randomly see the timeline start virtual item when we shouldn't.
We believe there's a race condition between the default values the status publisher
so we're going to default the backwards one to .idle.
Worst case it's going to do one extra back pagination.
This commit is contained in:
Stefan Ceriu
2025-03-19 18:51:41 +02:00
committed by Stefan Ceriu
parent 7eaaf03b73
commit 188c6363fc
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Services/Timeline/TimelineProxy.swift
+6 -2
View File
@@ -14,8 +14,12 @@ final class TimelineProxy: TimelineProxyProtocol {
private var backPaginationStatusObservationToken: TaskHandle?
// The default values don't matter here, they will be updated when calling subscribeToPagination.
private let backPaginationStatusSubject = CurrentValueSubject<PaginationStatus, Never>(.timelineEndReached)
// The default values shouldn't matter here as they will be updated when calling subscribeToPagination
// but empirically we randomly see the timeline start virtual item when we shouldn't.
// We believe there's a race condition between the default values the status publisher
// so we're going to default the backwards one to .idle. Worst case it's going to do
// one extra back pagination.
private let backPaginationStatusSubject = CurrentValueSubject<PaginationStatus, Never>(.idle)
private let forwardPaginationStatusSubject = CurrentValueSubject<PaginationStatus, Never>(.timelineEndReached)
private let kind: TimelineKind