mirror of
https://github.com/Novaloop-AG/element-x-android.git
synced 2026-10-31 16:22:49 +00:00
Remove Firebase push integration from Posthog (#7810)
This causes issues with F-Droid, since now Posthog unconditionally references some Firebase classes, which are detected by their checks. Note these don't do anything if Firebase messaging isn't included, which is already the case for the F-droid variant of the app. The R8 changes should remove any code referencing Firebase in Posthog, making the offending classes unused and removing them from the final APKs. This is not the ideal fix, that would be Posthog actually extracting these classes to an optional dependency, but it's a workaround to be able to publish F-droid versions.
This commit is contained in:
committed by
GitHub
parent
6c9d501009
commit
ed80c5c537
@@ -1,2 +1,9 @@
|
||||
# Don't obfuscate anything for non-enterprise builds
|
||||
-dontobfuscate
|
||||
|
||||
# Strip PostHog's Firebase push token integration. We don't use it and it breaks F-Droid.
|
||||
# Removing the contents of this method will mark the Firebase-related classes as unused,
|
||||
# which will allow R8 to remove them from the final build.
|
||||
-assumevalues class com.posthog.android.PostHogAndroidConfig {
|
||||
boolean getCapturePushNotificationSubscriptions() return false;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user