Merge pull request #7625 from element-hq/feature/bma/moveKnockAndGalleryToLabs

Move knock and gallery to labs

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/labs/LabsPresenter.kt

@@ -89,14 +89,20 @@ class LabsPresenter(
             key(enabledFeature.feature.key) {
                 val title = when (enabledFeature.feature) {
                     FeatureFlags.Threads -> stringProvider.getString(R.string.screen_labs_enable_threads)
+                    FeatureFlags.SendGalleryMessages -> stringProvider.getString(R.string.screen_labs_enable_gallery)
+                    FeatureFlags.Knock -> stringProvider.getString(R.string.screen_labs_enable_knocking)
                     else -> enabledFeature.feature.title
                 }
                 val description = when (enabledFeature.feature) {
                     FeatureFlags.Threads -> stringProvider.getString(R.string.screen_labs_enable_threads_description)
+                    FeatureFlags.SendGalleryMessages -> stringProvider.getString(R.string.screen_labs_enable_gallery_description)
+                    FeatureFlags.Knock -> stringProvider.getString(R.string.screen_labs_enable_knocking_description)
                     else -> enabledFeature.feature.description
                 }
                 val icon = when (enabledFeature.feature) {
                     FeatureFlags.Threads -> CompoundIcons.Threads()
+                    FeatureFlags.SendGalleryMessages -> CompoundIcons.Image()
+                    FeatureFlags.Knock -> CompoundIcons.AskToJoin()
                     else -> null
                 }
                 remember(enabledFeature) {

features/preferences/impl/src/main/res/values/localazy.xml

@@ -52,6 +52,10 @@
   <string name="screen_edit_profile_error_title">"Unable to update profile"</string>
   <string name="screen_edit_profile_title">"Edit profile"</string>
   <string name="screen_edit_profile_updating_details">"Updating profile…"</string>
+  <string name="screen_labs_enable_gallery">"Gallery messages"</string>
+  <string name="screen_labs_enable_gallery_description">"Send multiple images or videos in one go. Stable on mobile, but not yet supported by web."</string>
+  <string name="screen_labs_enable_knocking">"Ask to join"</string>
+  <string name="screen_labs_enable_knocking_description">"Users can request access to a room that is not open for anyone to join. Stable on mobile, web implementation exists but is experimental."</string>
   <string name="screen_labs_enable_threads">"Enable thread replies"</string>
   <string name="screen_labs_enable_threads_description">"The app will restart to apply this change."</string>
   <string name="screen_labs_header_description">"Try out our latest ideas in development. These features are not finalised; they may be unstable, may change."</string>

libraries/featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlags.kt

@@ -45,13 +45,6 @@ enum class FeatureFlags(
         defaultValue = { false },
         isFinished = false,
     ),
-    Knock(
-        key = "feature.knock",
-        title = "Ask to join",
-        description = "Allow creating rooms which users can request access to.",
-        defaultValue = { false },
-        isFinished = false,
-    ),
     PrintLogsToLogcat(
         key = "feature.print_logs_to_logcat",
         title = "Print logs to logcat",
@@ -151,6 +144,15 @@ enum class FeatureFlags(
         description = "Allow sending multiple media items in a single message.",
         defaultValue = { false },
         isFinished = false,
+        isInLabs = true,
+    ),
+    Knock(
+        key = "feature.knock",
+        title = "Ask to join",
+        description = "Allow creating rooms which users can request access to.",
+        defaultValue = { false },
+        isFinished = false,
+        isInLabs = true,
     ),
     MessageSearch(
         key = "feature.message_search",