Add Konsist test to use isNull() instead of isEqualTo(null), and fix existing issue.

features/call/src/test/kotlin/io/element/android/features/call/MapWebkitPermissionsTest.kt

@@ -41,5 +41,4 @@ class MapWebkitPermissionsTest {
         val permission = mapWebkitPermissions(arrayOf(PermissionRequest.RESOURCE_PROTECTED_MEDIA_ID))
         assertThat(permission).isEmpty()
     }
-
 }

features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/timeline/components/reactionsummary/ReactionSummaryPresenterTests.kt

@@ -53,7 +53,7 @@ class ReactionSummaryPresenterTests {
             presenter.present()
         }.test {
             val initialState = awaitItem()
-            assertThat(initialState.target).isEqualTo(null)
+            assertThat(initialState.target).isNull()
 
             initialState.eventSink(summaryEvent)
             assertThat(awaitItem().target).isNotNull()
@@ -69,7 +69,7 @@ class ReactionSummaryPresenterTests {
             presenter.present()
         }.test {
             val initialState = awaitItem()
-            assertThat(initialState.target).isEqualTo(null)
+            assertThat(initialState.target).isNull()
 
             initialState.eventSink(summaryEvent)
             val reactions = awaitItem().target?.reactions

features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/timeline/model/InReplyToMetadataKtTest.kt

@@ -284,7 +284,7 @@ class InReplyToMetadataKtTest {
             ).metadata()
         }.test {
             awaitItem().let {
-                assertThat(it).isEqualTo(null)
+                assertThat(it).isNull()
             }
         }
     }

features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/voicemessages/timeline/DefaultVoiceMessagePlayerTest.kt

@@ -149,7 +149,7 @@ class DefaultVoiceMessagePlayerTest {
                 assertThat(it.isPlaying).isFalse()
                 assertThat(it.isEnded).isFalse()
                 assertThat(it.currentPosition).isEqualTo(0)
-                assertThat(it.duration).isEqualTo(null)
+                assertThat(it.duration).isNull()
             }
             matchReadyState(1_000L)
             player2.play()
@@ -177,7 +177,7 @@ class DefaultVoiceMessagePlayerTest {
                 assertThat(it.isPlaying).isFalse()
                 assertThat(it.isEnded).isFalse()
                 assertThat(it.currentPosition).isEqualTo(0)
-                assertThat(it.duration).isEqualTo(null)
+                assertThat(it.duration).isNull()
             }
             matchReadyState(1_000L)
             player1.play()
@@ -238,7 +238,7 @@ class DefaultVoiceMessagePlayerTest {
                 assertThat(it.isPlaying).isFalse()
                 assertThat(it.isEnded).isFalse()
                 assertThat(it.currentPosition).isEqualTo(2000)
-                assertThat(it.duration).isEqualTo(null)
+                assertThat(it.duration).isNull()
             }
             assertThat(player.prepare().isSuccess).isTrue()
             awaitItem().let {
@@ -300,7 +300,7 @@ private suspend fun TurbineTestContext<VoiceMessagePlayer.State>.matchInitialSta
         assertThat(it.isPlaying).isFalse()
         assertThat(it.isEnded).isFalse()
         assertThat(it.currentPosition).isEqualTo(0)
-        assertThat(it.duration).isEqualTo(null)
+        assertThat(it.duration).isNull()
     }
 }
 

tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistTestTest.kt

@@ -98,4 +98,16 @@ class KonsistTestTest {
                 functionDeclaration.text.contains("isEqualTo(empty")
             }
     }
+
+    @Test
+    fun `use isNull() instead of isEqualTo(null)`() {
+        Konsist
+            .scopeFromTest()
+            .functions()
+            // Exclude self
+            .withoutName("use isNull() instead of isEqualTo(null)")
+            .assertFalse { functionDeclaration ->
+                functionDeclaration.text.contains("isEqualTo(null)")
+            }
+    }
 }