Fix unit tests

features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/configureroom/ConfigureRoomPresenter.kt

@@ -16,13 +16,11 @@
 
 package io.element.android.features.createroom.impl.configureroom
 
-import android.widget.Toast
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.saveable.rememberSaveable
-import androidx.compose.ui.platform.LocalContext
 import io.element.android.features.createroom.impl.CreateRoomConfig
 import io.element.android.features.createroom.impl.CreateRoomDataStore
 import io.element.android.libraries.architecture.Presenter
@@ -40,7 +38,6 @@ class ConfigureRoomPresenter @Inject constructor(
             mutableStateOf(enabled)
         }
 
-        val context = LocalContext.current
         fun handleEvents(event: ConfigureRoomEvents) {
             when (event) {
                 is ConfigureRoomEvents.AvatarUriChanged -> dataStore.setAvatarUrl(event.uri?.toString())
@@ -48,7 +45,7 @@ class ConfigureRoomPresenter @Inject constructor(
                 is ConfigureRoomEvents.TopicChanged -> dataStore.setTopic(event.topic)
                 is ConfigureRoomEvents.RoomPrivacyChanged -> dataStore.setPrivacy(event.privacy)
                 is ConfigureRoomEvents.RemoveFromSelection -> dataStore.selectedUserListDataStore.removeUserFromSelection(event.matrixUser)
-                ConfigureRoomEvents.CreateRoom -> Toast.makeText(context, "not implemented yet", Toast.LENGTH_SHORT).show()
+                ConfigureRoomEvents.CreateRoom -> Unit // TODO
             }
         }
 

features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/configureroom/ConfigureRoomView.kt

@@ -83,7 +83,10 @@ fun ConfigureRoomView(
             ConfigureRoomToolbar(
                 isNextActionEnabled = state.isCreateButtonEnabled,
                 onBackPressed = onBackPressed,
-                onNextPressed = { state.eventSink(ConfigureRoomEvents.CreateRoom) },
+                onNextPressed = {
+                    // state.eventSink(ConfigureRoomEvents.CreateRoom)
+                    Toast.makeText(context, "not implemented yet", Toast.LENGTH_SHORT).show()
+                },
             )
         }
     ) { padding ->

features/createroom/impl/src/test/kotlin/io/element/android/features/createroom/impl/addpeople/AddPeoplePresenterTests.kt

@@ -23,6 +23,7 @@ import app.cash.molecule.moleculeFlow
 import app.cash.turbine.test
 import com.google.common.truth.Truth.assertThat
 import io.element.android.features.createroom.impl.CreateRoomDataStore
+import io.element.android.features.userlist.api.UserListDataStore
 import io.element.android.features.userlist.test.FakeUserListDataSource
 import io.element.android.features.userlist.test.FakeUserListPresenterFactory
 import kotlinx.coroutines.ExperimentalCoroutinesApi
@@ -36,7 +37,7 @@ class AddPeoplePresenterTests {
 
     @Before
     fun setup() {
-        presenter = AddPeoplePresenter(FakeUserListPresenterFactory(), FakeUserListDataSource(), CreateRoomDataStore())
+        presenter = AddPeoplePresenter(FakeUserListPresenterFactory(), FakeUserListDataSource(), CreateRoomDataStore(UserListDataStore()))
     }
 
     @Test

features/createroom/impl/src/test/kotlin/io/element/android/features/createroom/impl/configureroom/ConfigureRoomPresenterTests.kt

@@ -24,6 +24,7 @@ import app.cash.molecule.moleculeFlow
 import app.cash.turbine.test
 import com.google.common.truth.Truth.assertThat
 import io.element.android.features.createroom.impl.CreateRoomDataStore
+import io.element.android.features.userlist.api.UserListDataStore
 import io.element.android.libraries.matrix.test.AN_AVATAR_URL
 import io.element.android.libraries.matrix.test.A_MESSAGE
 import io.element.android.libraries.matrix.test.A_ROOM_NAME
@@ -41,7 +42,7 @@ class ConfigureRoomPresenterTests {
 
     @Before
     fun setup() {
-        presenter = ConfigureRoomPresenter(CreateRoomDataStore())
+        presenter = ConfigureRoomPresenter(CreateRoomDataStore(UserListDataStore()))
     }
 
     @Test

features/createroom/impl/src/test/kotlin/io/element/android/features/createroom/impl/root/CreateRoomRootPresenterTests.kt

@@ -22,6 +22,7 @@ import app.cash.molecule.RecompositionClock
 import app.cash.molecule.moleculeFlow
 import app.cash.turbine.test
 import com.google.common.truth.Truth.assertThat
+import io.element.android.features.userlist.api.UserListDataStore
 import io.element.android.features.userlist.api.aUserListState
 import io.element.android.features.userlist.test.FakeUserListDataSource
 import io.element.android.features.userlist.test.FakeUserListPresenter
@@ -51,7 +52,7 @@ class CreateRoomRootPresenterTests {
         fakeUserListPresenter = FakeUserListPresenter()
         fakeMatrixClient = FakeMatrixClient()
         userListDataSource = FakeUserListDataSource()
-        presenter = CreateRoomRootPresenter(FakeUserListPresenterFactory(fakeUserListPresenter), userListDataSource, fakeMatrixClient)
+        presenter = CreateRoomRootPresenter(FakeUserListPresenterFactory(fakeUserListPresenter), userListDataSource, UserListDataStore(), fakeMatrixClient)
     }
 
     @Test

features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/members/RoomMemberListPresenterTests.kt

@@ -23,6 +23,7 @@ import com.google.common.truth.Truth
 import io.element.android.features.roomdetails.impl.members.RoomMemberListPresenter
 import io.element.android.features.userlist.api.SelectionMode
 import io.element.android.features.userlist.api.UserListDataSource
+import io.element.android.features.userlist.api.UserListDataStore
 import io.element.android.features.userlist.api.UserListPresenter
 import io.element.android.features.userlist.api.UserListPresenterArgs
 import io.element.android.features.userlist.impl.DefaultUserListPresenter
@@ -41,10 +42,15 @@ class RoomMemberListPresenterTests {
         val userListDataSource = FakeUserListDataSource().apply {
             givenSearchResult(searchResult)
         }
+        val userListDataStore = UserListDataStore()
         val userListFactory = object : UserListPresenter.Factory {
-            override fun create(args: UserListPresenterArgs, dataSource: UserListDataSource) = DefaultUserListPresenter(args, dataSource)
+            override fun create(
+                args: UserListPresenterArgs,
+                userListDataSource: UserListDataSource,
+                userListDataStore: UserListDataStore,
+            ) = DefaultUserListPresenter(args, userListDataSource, userListDataStore)
         }
-        val presenter = RoomMemberListPresenter(userListFactory, userListDataSource)
+        val presenter = RoomMemberListPresenter(userListFactory, userListDataSource, userListDataStore)
         moleculeFlow(RecompositionClock.Immediate) {
             presenter.present()
         }.test {
@@ -58,5 +64,4 @@ class RoomMemberListPresenterTests {
             Truth.assertThat((loadedState.allUsers as? Async.Success)?.state).isEqualTo(searchResult.toImmutableList())
         }
     }
-
 }

features/userlist/test/src/main/kotlin/io/element/android/features/userlist/test/FakeUserListPresenterFactory.kt

@@ -17,6 +17,7 @@
 package io.element.android.features.userlist.test
 
 import io.element.android.features.userlist.api.UserListDataSource
+import io.element.android.features.userlist.api.UserListDataStore
 import io.element.android.features.userlist.api.UserListPresenter
 import io.element.android.features.userlist.api.UserListPresenterArgs
 
@@ -24,5 +25,9 @@ class FakeUserListPresenterFactory(
     private val fakeUserListPresenter: FakeUserListPresenter = FakeUserListPresenter()
 ) : UserListPresenter.Factory {
 
-    override fun create(args: UserListPresenterArgs, userListDataSource: UserListDataSource): UserListPresenter = fakeUserListPresenter
+    override fun create(
+        args: UserListPresenterArgs,
+        userListDataSource: UserListDataSource,
+        userListDataStore: UserListDataStore,
+    ): UserListPresenter = fakeUserListPresenter
 }