mirror of
https://github.com/Novaloop-AG/element-x-android.git
synced 2026-10-31 08:15:02 +00:00
fix(release): drop changesNotSentForReview from Play upload
Play now sends this app's changes for review automatically and the Edits API rejects the parameter, so the AAB uploaded but the edit never committed.
This commit is contained in:
@@ -159,6 +159,31 @@ fixing the changelog over relying on the fallback.
|
||||
- [ ] Internal testers get the update automatically if they're enrolled.
|
||||
- [ ] AAB + `mapping.txt` are attached to the workflow run, retained 90 days.
|
||||
|
||||
**A green "Build Release AAB" step does not mean the release shipped.** The
|
||||
upload step logs `Successfully uploaded 1 artifacts` before it commits the Play
|
||||
edit; if the commit fails, the AAB is uploaded but no release exists on the
|
||||
track. Always check the `Upload to Play Store` step, not just the job's build
|
||||
steps.
|
||||
|
||||
## Troubleshooting: `changesNotSentForReview must not be set`
|
||||
|
||||
```
|
||||
Successfully uploaded 1 artifacts
|
||||
Committing the Edit
|
||||
##[error]Changes are sent for review automatically.
|
||||
The query parameter changesNotSentForReview must not be set.
|
||||
```
|
||||
|
||||
Google flips this per app: once Play sends an app's changes for review
|
||||
automatically, the Edits API rejects `changesNotSentForReview` instead of
|
||||
ignoring it. The 26.07.0 release (2026-07-27) committed fine with the flag
|
||||
set; 26.08.0 (2026-08-03) failed with it. The parameter is no longer passed —
|
||||
if it ever needs to come back, gate it rather than setting it unconditionally.
|
||||
|
||||
Recovery: the failed edit is never committed, so the `versionCode` is not
|
||||
consumed. Re-run via `workflow_dispatch` with the same version — no tag move
|
||||
and no version bump needed.
|
||||
|
||||
## Required GitHub Actions secrets
|
||||
|
||||
The pipeline depends on these repository secrets. Missing any causes the
|
||||
|
||||
@@ -238,4 +238,8 @@ jobs:
|
||||
status: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.release_status || 'completed' }}
|
||||
whatsNewDirectory: fastlane/metadata/android
|
||||
mappingFile: app/build/outputs/mapping/gplayRelease/mapping.txt
|
||||
changesNotSentForReview: true
|
||||
# Do NOT set changesNotSentForReview. Play now sends this app's changes for review
|
||||
# automatically, and the Edits API rejects the parameter outright when it does:
|
||||
# "Changes are sent for review automatically. The query parameter
|
||||
# changesNotSentForReview must not be set." The AAB uploads fine and then the commit
|
||||
# fails, so the release silently never lands on the track. See SKILL.md.
|
||||
|
||||
Reference in New Issue
Block a user