Merge pull request #7477 from element-hq/feature/bma/normalizeUserAgent

Normalize the applicationName used in user agent

libraries/core/src/main/kotlin/io/element/android/libraries/core/extensions/BasicExtensions.kt

@@ -8,6 +8,7 @@
 
 package io.element.android.libraries.core.extensions
 
+import java.text.Normalizer
 import java.util.Locale
 
 fun Boolean.toOnOff() = if (this) "ON" else "OFF"
@@ -114,3 +115,14 @@ fun String.toSafeLength(
         this
     }
 }
+
+/**
+ * Remove accents and replace special characters by ASCII from the string.
+ * For instance, "é" will be replaced by "e", "ç" by "c", etc.
+ */
+fun String.normalized(): String {
+    // Normalize the string.
+    return Normalizer.normalize(this, Normalizer.Form.NFD)
+        // then keep only ASCII characters and replace non-ASCII characters with an empty string.
+        .replace("[^\\p{ASCII}]".toRegex(), "")
+}

libraries/core/src/test/kotlin/io/element/android/libraries/core/extensions/BasicExtensionsTest.kt

@@ -74,4 +74,10 @@ class BasicExtensionsTest {
         val result = textWithDirectionOverrides.filterDirectionOverrides()
         assertEquals("123456789", result)
     }
+
+    @Test
+    fun `normalized removes accents and replace special characters from text`() {
+        assertEquals("Stefan", "Ștefan".normalized())
+        assertEquals("ca enleve etre", "ça enlève être".normalized())
+    }
 }

libraries/network/src/main/kotlin/io/element/android/libraries/network/useragent/DefaultUserAgentProvider.kt

@@ -12,6 +12,7 @@ import android.os.Build
 import dev.zacsweers.metro.AppScope
 import dev.zacsweers.metro.ContributesBinding
 import dev.zacsweers.metro.SingleIn
+import io.element.android.libraries.core.extensions.normalized
 import io.element.android.libraries.core.meta.BuildMeta
 import io.element.android.libraries.matrix.api.SdkMetadata
 
@@ -26,11 +27,11 @@ class DefaultUserAgentProvider(
     override fun provide(): String = userAgent
 
     /**
-     * Create an user agent with the application version.
+     * Create a user agent with the application version.
      * Ex: Element X/1.5.0 (Xiaomi Mi 9T; Android 11; RKQ1.200826.002; Sdk c344b155c)
      */
     private fun buildUserAgent(): String {
-        val appName = buildMeta.applicationName
+        val appName = buildMeta.applicationName.normalized()
         val appVersion = buildMeta.versionName
         val deviceManufacturer = Build.MANUFACTURER
         val deviceModel = Build.MODEL