Move ResizerNotifier into SDKContext (#30939)

* Move ResizerNotifier into SDKContext

so we don't have to pass it into RoomView

* Fix test

* Unused import

* Add tests

* Remove a bunch of resizeNotifier props

* Remove more resizeNotifier props

* Add resizenotifier to test

* Add more sdkcontext wrappers in tests

* More sdkcontext wrappers

* Even more sdkcontext wrappers

* Add test to make sonarcloud happy

* Context isn't always there unlike props

* Test actual resizing too

* Remove commented line

test/unit-tests/components/views/voip/LegacyCallViewForRoom-test.tsx

@@ -6,7 +6,7 @@ Please see LICENSE files in the repository root for full details.
 */
 
 import React from "react";
-import { render } from "jest-matrix-react";
+import { fireEvent, render, waitFor } from "jest-matrix-react";
 import { MatrixCall } from "matrix-js-sdk/src/webrtc/call";
 import { CallEventHandlerEvent } from "matrix-js-sdk/src/webrtc/callEventHandler";
 
@@ -15,19 +15,22 @@ import LegacyCallViewForRoom from "../../../../../src/components/views/voip/Lega
 import { mkStubRoom, stubClient } from "../../../../test-utils";
 import DMRoomMap from "../../../../../src/utils/DMRoomMap";
 import { MatrixClientPeg } from "../../../../../src/MatrixClientPeg";
-import ResizeNotifier from "../../../../../src/utils/ResizeNotifier";
 import LegacyCallHandler from "../../../../../src/LegacyCallHandler";
+import { SDKContext, SdkContextClass } from "../../../../../src/contexts/SDKContext";
 
 jest.mock("../../../../../src/components/views/voip/LegacyCallView", () => jest.fn(() => "LegacyCallView"));
 
 describe("LegacyCallViewForRoom", () => {
     const LegacyCallViewMock = LegacyCallView as unknown as jest.Mock;
+    let sdkContext: SdkContextClass;
+
     beforeEach(() => {
+        stubClient();
+        sdkContext = new SdkContextClass();
         LegacyCallViewMock.mockClear();
     });
-    it("should remember sidebar state, defaulting to shown", async () => {
-        stubClient();
 
+    it("should remember sidebar state, defaulting to shown", async () => {
         const callHandler = new LegacyCallHandler();
         callHandler.start();
         jest.spyOn(LegacyCallHandler, "instance", "get").mockImplementation(() => callHandler);
@@ -45,16 +48,14 @@ describe("LegacyCallViewForRoom", () => {
         const cli = MatrixClientPeg.safeGet();
         cli.emit(CallEventHandlerEvent.Incoming, call);
 
-        const { rerender } = render(
-            <LegacyCallViewForRoom roomId={call.roomId} resizeNotifier={new ResizeNotifier()} />,
-        );
+        const { rerender } = render(<LegacyCallViewForRoom roomId={call.roomId} />);
 
         let props = LegacyCallViewMock.mock.lastCall![0];
         expect(props.sidebarShown).toBeTruthy(); // Sidebar defaults to shown
 
         props.setSidebarShown(false); // Hide the sidebar
 
-        rerender(<LegacyCallViewForRoom roomId={call.roomId} resizeNotifier={new ResizeNotifier()} />);
+        rerender(<LegacyCallViewForRoom roomId={call.roomId} />);
 
         console.log(LegacyCallViewMock.mock);
 
@@ -64,9 +65,47 @@ describe("LegacyCallViewForRoom", () => {
         rerender(<div> </div>); // Destroy the LegacyCallViewForRoom and LegacyCallView
         LegacyCallViewMock.mockClear(); // Drop stored LegacyCallView props
 
-        rerender(<LegacyCallViewForRoom roomId={call.roomId} resizeNotifier={new ResizeNotifier()} />);
+        rerender(<LegacyCallViewForRoom roomId={call.roomId} />);
 
         props = LegacyCallViewMock.mock.lastCall![0];
         expect(props.sidebarShown).toBeFalsy(); // Value was remembered
     });
+
+    it("should notify on resize start events", async () => {
+        const call = new MatrixCall({
+            client: MatrixClientPeg.safeGet(),
+            roomId: "test-room",
+        });
+
+        const callHandler = {
+            getCallForRoom: jest.fn().mockReturnValue(call),
+            isCallSidebarShown: jest.fn().mockReturnValue(true),
+            addListener: jest.fn(),
+            removeListener: jest.fn(),
+        };
+        jest.spyOn(LegacyCallHandler, "instance", "get").mockImplementation(
+            () => callHandler as unknown as LegacyCallHandler,
+        );
+
+        jest.spyOn(sdkContext.resizeNotifier, "startResizing");
+        jest.spyOn(sdkContext.resizeNotifier, "stopResizing");
+        jest.spyOn(sdkContext.resizeNotifier, "notifyTimelineHeightChanged");
+
+        const { container } = render(<LegacyCallViewForRoom roomId={call.roomId} />, {
+            wrapper: ({ children }) => <SDKContext.Provider value={sdkContext}>{children}</SDKContext.Provider>,
+        });
+
+        const resizer = container.querySelector(".mx_LegacyCallViewForRoom_ResizeHandle");
+        await waitFor(() => {
+            expect(resizer).toBeInTheDocument();
+        });
+
+        fireEvent.mouseDown(resizer!);
+        fireEvent.mouseMove(resizer!, { clientY: 100 });
+        fireEvent.mouseUp(resizer!);
+
+        expect(sdkContext.resizeNotifier.startResizing).toHaveBeenCalled();
+        expect(sdkContext.resizeNotifier.stopResizing).toHaveBeenCalled();
+        expect(sdkContext.resizeNotifier.notifyTimelineHeightChanged).toHaveBeenCalled();
+    });
 });