Refactor MessageActionBar using MVVM and move to shared-components (#32784)

* Refactor MessageActionBar into MVVM ActionBarView * Adding tooltips for menu items and correct i18n strings * Layout changes * Renaming some properties * Rename property * Create a first version of the view model and refactor media visibility logic * Refactor view to take options and rections menu as optional properties * Cleaner interface between view and view model * Refactor view properties and replace Menu and MenuItem * Bugfixes and switching to ActionBarView instead of MessageActionBar in element-web * Avoid creating view models and render toolbar until it is actually shown * Added unit and playwright tests and documented the view * Added view model unit tests and updated snapshots of dependant tests * Remove unused components and unnecessary css * Remove unused language tags * Fix for handling join-rules correctly * Prettier * Add handling of stale view model in async calls * Prettier * Split the element-web css into two different. One for legacy components and one for the ActionBarView * Missing variables used for linting * Fix for showing ActionBarView when using keyboard for navigation * Handle visibility on context menu closing * ThreadPanel uses the ActionBarView so restore css rule * Fix for visibility of the ActionBarView in Thread panel * Fix for ActionBarVuew visibility when closing right-click context menu and not still hovering * Add roving index to function as a toolbar * Adjust the RoomView test to send hover to the EventTile instead of the message text * Fix SonarCloud issues * Fix for SonarCloud issue * Merge fix * Rename mx_LegacyActionBar to mx_ThreadActionBar * Added documentation and simplified join rules * Generalize the ActionBarView and move logic to view model * Add the four new buttons to the ActionBarView * Update view model and tests to use the updated ActionBarView * Refactor element-web to use ActionBarView * Clean up styling in element-web * Clean up and updating snaps and screenshots * Added unit-tests for better coverage * Moving ActionBarView to the correct folder in shared components * Update snaps in element-web * Better documentation in stories * Merge fixes * Updates after review comments * Review comment fixes * Added documentation to view models and updated snaps * Hide button had the wrong label * Replace createRef with useRef
2026-11-04 10:32:44 +00:00 · 2026-04-01 14:27:03 +02:00
parent 0391543bbc
commit 4315038346
46 changed files with 4071 additions and 2155 deletions
@@ -0,0 +1,82 @@
+/*
+ * Copyright 2026 Element Creations Ltd.
+ *
+ * SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
+ * Please see LICENSE files in the repository root for full details.
+ */
+
+import { ActionBarAction } from "@element-hq/web-shared-components";
+
+import { EditHistoryActionBarViewModel } from "../../../src/viewmodels/message-body/EditHistoryActionBarViewModel";
+
+describe("EditHistoryActionBarViewModel", () => {
+    it("builds a label snapshot with remove and view source actions", () => {
+        const vm = new EditHistoryActionBarViewModel({
+            canRemove: true,
+            showViewSource: true,
+        });
+
+        expect(vm.getSnapshot()).toMatchObject({
+            actions: [ActionBarAction.Remove, ActionBarAction.ViewSource],
+            presentation: "label",
+            isDownloadEncrypted: false,
+            isDownloadLoading: false,
+            isPinned: false,
+            isQuoteExpanded: false,
+            isThreadReplyAllowed: true,
+        });
+    });
+
+    it("omits actions that are disabled by props", () => {
+        const vm = new EditHistoryActionBarViewModel({
+            canRemove: false,
+            showViewSource: false,
+        });
+
+        expect(vm.getSnapshot().actions).toEqual([]);
+    });
+
+    it("updates the snapshot when props change", () => {
+        const vm = new EditHistoryActionBarViewModel({
+            canRemove: false,
+            showViewSource: true,
+        });
+
+        expect(vm.getSnapshot().actions).toEqual([ActionBarAction.ViewSource]);
+
+        vm.setProps({
+            canRemove: true,
+            showViewSource: false,
+        });
+
+        expect(vm.getSnapshot().actions).toEqual([ActionBarAction.Remove]);
+    });
+
+    it("forwards remove clicks to props", () => {
+        const onRemoveClick = jest.fn();
+        const vm = new EditHistoryActionBarViewModel({
+            canRemove: true,
+            showViewSource: false,
+            onRemoveClick,
+        });
+        const anchor = document.createElement("button");
+
+        vm.onRemoveClick(anchor);
+
+        expect(onRemoveClick).toHaveBeenCalledWith(anchor);
+    });
+
+    it("forwards view source clicks to props", () => {
+        const onViewSourceClick = jest.fn();
+        const vm = new EditHistoryActionBarViewModel({
+            canRemove: false,
+            showViewSource: true,
+            onViewSourceClick,
+        });
+        const anchor = document.createElement("button");
+
+        vm.onViewSourceClick(anchor);
+
+        expect(onViewSourceClick).toHaveBeenCalledWith(anchor);
+    });
+});