mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-10-31 08:15:24 +00:00
f2eaa8e80d
* Present the multi-account announcement when nothing else is showing The user session flow owns onboarding, verification and settings, so it presents the announcement in the tab sheet slot with the lowest priority: once the verification state is known, and whenever onboarding, settings or a verification sheet is dismissed. Routes and sign-out dismiss settings without triggering it, and it is marked as seen when presented. * Show the multi-account announcement on the home screen Following review, the announcement is a best-effort sheet on the home screen instead of a UserSessionFlowCoordinator state. It's presented when the room list appears with the flag on, the announcement armed and the session verified, and counts as seen once its content appears. - Restore UserSessionFlowCoordinator to develop. - HomeScreenViewModel presents the announcement through a binding and waits for a known verification state, so it never competes with the identity confirmation onboarding. - Add account only closes the sheet until the add account flow exists. - Rename MultiAccountAnnouncementScreen to MultiAccountAnnouncementView and drop its unused coordinator and view model protocol. - Size the sheet from the measured navigation bar height and match the Figma spacing; the hard-coded 44pt pushed the content under the button. * Present the multi-account announcement from the home screen view model The announcement no longer needs its own view model: the view takes the home screen's context and presents through a boolean binding, like the home screen banners. - Drop MultiAccountAnnouncementViewModel and its models. The view sends home screen actions to close or add an account and builds its own attributed subtitle. - Check the verification state when the room list appears instead of waiting for it. Restored sessions already know it by then, unverified ones get the identity confirmation cover first and the room list appears again once it's dismissed. Nothing is left subscribed, so the sheet can no longer turn up later wherever the user is.
658 lines
27 KiB
Swift
658 lines
27 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import Combine
|
|
@testable import ElementX
|
|
import Testing
|
|
|
|
@MainActor
|
|
final class HomeScreenViewModelTests {
|
|
var viewModel: HomeScreenViewModelProtocol!
|
|
var context: HomeScreenViewModelType.Context! {
|
|
viewModel.context
|
|
}
|
|
|
|
var clientProxy: ClientProxyMock!
|
|
var roomSummaryProvider: RoomSummaryProviderMock!
|
|
var notificationManager: NotificationManagerMock!
|
|
private let userSettings: UserSettings
|
|
|
|
var cancellables = Set<AnyCancellable>()
|
|
|
|
init() {
|
|
userSettings = UserSettings.mock()
|
|
}
|
|
|
|
@Test
|
|
func selectRoom() async {
|
|
setupViewModel()
|
|
|
|
let mockRoomID = "mock_room_id"
|
|
var correctResult = false
|
|
var selectedRoomID = ""
|
|
|
|
viewModel.actions
|
|
.sink { action in
|
|
switch action {
|
|
case .presentRoom(let roomID):
|
|
correctResult = true
|
|
selectedRoomID = roomID
|
|
default:
|
|
break
|
|
}
|
|
}
|
|
.store(in: &cancellables)
|
|
|
|
context.send(viewAction: .selectRoom(roomIdentifier: mockRoomID))
|
|
await Task.yield()
|
|
#expect(correctResult)
|
|
#expect(mockRoomID == selectedRoomID)
|
|
}
|
|
|
|
@Test
|
|
func tapUserAvatar() async {
|
|
setupViewModel()
|
|
|
|
var correctResult = false
|
|
|
|
viewModel.actions
|
|
.sink { action in
|
|
switch action {
|
|
case .presentSettingsScreen:
|
|
correctResult = true
|
|
default:
|
|
break
|
|
}
|
|
}
|
|
.store(in: &cancellables)
|
|
|
|
context.send(viewAction: .showSettings)
|
|
await Task.yield()
|
|
#expect(correctResult)
|
|
}
|
|
|
|
@Test
|
|
func leaveRoomAlert() async throws {
|
|
setupViewModel()
|
|
|
|
let mockRoomID = "1"
|
|
|
|
clientProxy.roomForIdentifierClosure = { _ in .joined(JoinedRoomProxyMock(.init(id: mockRoomID, name: "Some room"))) }
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { value in
|
|
value.bindings.leaveRoomAlertItem != nil
|
|
}
|
|
|
|
context.send(viewAction: .leaveRoom(roomIdentifier: mockRoomID))
|
|
|
|
try await deferred.fulfill()
|
|
|
|
#expect(context.leaveRoomAlertItem?.roomID == mockRoomID)
|
|
}
|
|
|
|
@Test
|
|
func leaveRoomError() async throws {
|
|
setupViewModel()
|
|
|
|
let mockRoomID = "1"
|
|
let room = JoinedRoomProxyMock(.init(id: mockRoomID, name: "Some room"))
|
|
room.leaveRoomClosure = { .failure(.sdkError(ClientProxyMockError.generic)) }
|
|
|
|
clientProxy.roomForIdentifierClosure = { _ in .joined(room) }
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { value in
|
|
value.bindings.alertInfo != nil
|
|
}
|
|
|
|
context.send(viewAction: .confirmLeaveRoom(roomIdentifier: mockRoomID))
|
|
|
|
try await deferred.fulfill()
|
|
|
|
#expect(context.alertInfo != nil)
|
|
}
|
|
|
|
@Test
|
|
func leaveRoomSuccess() async throws {
|
|
setupViewModel()
|
|
|
|
let mockRoomID = "1"
|
|
|
|
let room = JoinedRoomProxyMock(.init(id: mockRoomID, name: "Some room"))
|
|
room.leaveRoomClosure = { .success(()) }
|
|
|
|
clientProxy.roomForIdentifierClosure = { _ in .joined(room) }
|
|
|
|
let deferred = deferFulfillment(viewModel.actions) { action in
|
|
if case .roomLeft(let roomIdentifier) = action {
|
|
return roomIdentifier == mockRoomID
|
|
}
|
|
return false
|
|
}
|
|
|
|
context.send(viewAction: .confirmLeaveRoom(roomIdentifier: mockRoomID))
|
|
try await deferred.fulfill()
|
|
#expect(context.alertInfo == nil)
|
|
}
|
|
|
|
@Test
|
|
func showRoomDetails() async {
|
|
setupViewModel()
|
|
|
|
let mockRoomID = "1"
|
|
var correctResult = false
|
|
viewModel.actions
|
|
.sink { action in
|
|
switch action {
|
|
case .presentRoomDetails(let roomIdentifier):
|
|
correctResult = roomIdentifier == mockRoomID
|
|
default:
|
|
break
|
|
}
|
|
}
|
|
.store(in: &cancellables)
|
|
context.send(viewAction: .showRoomDetails(roomIdentifier: mockRoomID))
|
|
await Task.yield()
|
|
#expect(context.alertInfo == nil)
|
|
#expect(correctResult)
|
|
}
|
|
|
|
@Test
|
|
func filters() async throws {
|
|
setupViewModel()
|
|
|
|
context.filtersState.activateFilter(.people)
|
|
try await Task.sleep(for: .milliseconds(100))
|
|
#expect(roomSummaryProvider.roomListPublisher.value.count == 2)
|
|
#expect(roomSummaryProvider.roomListPublisher.value.first?.name == "Foundation and Earth")
|
|
}
|
|
|
|
@Test
|
|
func search() async throws {
|
|
setupViewModel()
|
|
|
|
context.isSearchFieldFocused = true
|
|
context.searchQuery = "lude to Found"
|
|
try await Task.sleep(for: .milliseconds(100))
|
|
#expect(roomSummaryProvider.roomListPublisher.value.first?.name == "Prelude to Foundation")
|
|
#expect(roomSummaryProvider.roomListPublisher.value.count == 1)
|
|
}
|
|
|
|
@Test
|
|
func filtersEmptyState() async throws {
|
|
setupViewModel()
|
|
|
|
context.filtersState.activateFilter(.people)
|
|
context.filtersState.activateFilter(.favourites)
|
|
try await Task.sleep(for: .milliseconds(100))
|
|
#expect(context.viewState.shouldShowEmptyFilterState)
|
|
context.isSearchFieldFocused = true
|
|
#expect(!context.viewState.shouldShowEmptyFilterState)
|
|
}
|
|
|
|
@Test
|
|
func setUpRecoveryBannerState() async throws {
|
|
// Given a view model without a visible security banner.
|
|
let securityStateStateSubject = CurrentValueSubject<SessionSecurityState, Never>(.init(verificationState: .verified, recoveryState: .unknown))
|
|
setupViewModel(securityStatePublisher: securityStateStateSubject.asCurrentValuePublisher())
|
|
#expect(context.viewState.securityBannerMode == .none)
|
|
|
|
// When the recovery state comes through as disabled.
|
|
var deferred = deferFulfillment(context.$viewState) { $0.securityBannerMode == .show(.setUpRecovery) }
|
|
securityStateStateSubject.send(.init(verificationState: .verified, recoveryState: .disabled))
|
|
|
|
// Then the banner should be shown to set up recovery.
|
|
try await deferred.fulfill()
|
|
|
|
// When the recovery is enabled.
|
|
deferred = deferFulfillment(context.$viewState) { $0.securityBannerMode == .none }
|
|
securityStateStateSubject.send(.init(verificationState: .verified, recoveryState: .enabled))
|
|
|
|
// Then the banner should no longer be shown.
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func dismissSetUpRecoveryBannerState() async throws {
|
|
// Given a view model with the setup recovery banner shown.
|
|
let securityStateStateSubject = CurrentValueSubject<SessionSecurityState, Never>(.init(verificationState: .verified, recoveryState: .unknown))
|
|
setupViewModel(securityStatePublisher: securityStateStateSubject.asCurrentValuePublisher())
|
|
var deferred = deferFulfillment(context.$viewState) { $0.securityBannerMode == .show(.setUpRecovery) }
|
|
securityStateStateSubject.send(.init(verificationState: .verified, recoveryState: .disabled))
|
|
try await deferred.fulfill()
|
|
|
|
// When the banner is dismissed.
|
|
deferred = deferFulfillment(context.$viewState) { $0.securityBannerMode == .dismissed }
|
|
context.send(viewAction: .skipRecoveryKeyConfirmation)
|
|
|
|
// Then the banner should no longer be shown.
|
|
try await deferred.fulfill()
|
|
|
|
// And when the recovery state comes through a second time the banner should still not be shown.
|
|
let failure = deferFailure(context.$viewState, timeout: .seconds(1)) { $0.securityBannerMode != .dismissed }
|
|
securityStateStateSubject.send(.init(verificationState: .verified, recoveryState: .disabled))
|
|
try await failure.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func outOfSyncRecoveryBannerState() async throws {
|
|
// Given a view model without a visible security banner.
|
|
let securityStateStateSubject = CurrentValueSubject<SessionSecurityState, Never>(.init(verificationState: .verified, recoveryState: .unknown))
|
|
setupViewModel(securityStatePublisher: securityStateStateSubject.asCurrentValuePublisher())
|
|
#expect(context.viewState.securityBannerMode == .none)
|
|
|
|
// When the recovery state comes through as incomplete.
|
|
var deferred = deferFulfillment(context.$viewState) { $0.securityBannerMode == .show(.recoveryOutOfSync) }
|
|
securityStateStateSubject.send(.init(verificationState: .verified, recoveryState: .incomplete))
|
|
|
|
// Then the banner should be shown for out of sync recovery.
|
|
try await deferred.fulfill()
|
|
|
|
// When the recovery is enabled.
|
|
deferred = deferFulfillment(context.$viewState) { $0.securityBannerMode == .none }
|
|
securityStateStateSubject.send(.init(verificationState: .verified, recoveryState: .enabled))
|
|
|
|
// Then the banner should no longer be shown.
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func inviteUnreadBadge() async throws {
|
|
setupViewModel(invites: .rooms)
|
|
var invites = context.viewState.rooms.invites
|
|
#expect(invites.count == 2)
|
|
|
|
for invite in invites {
|
|
#expect(invite.badges.isDotShown)
|
|
}
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { state in
|
|
state.rooms.contains { room in
|
|
room.roomID == invites[0].roomID && room.badges.isDotShown == false
|
|
}
|
|
}
|
|
userSettings.seenInvites = Set(invites.compactMap(\.roomID))
|
|
try await deferred.fulfill()
|
|
invites = context.viewState.rooms.invites
|
|
|
|
for invite in invites {
|
|
#expect(!invite.badges.isDotShown)
|
|
}
|
|
}
|
|
|
|
@Test
|
|
func acceptInvite() async throws {
|
|
setupViewModel(invites: .rooms)
|
|
|
|
let invitedRoomIDs = context.viewState.rooms.invites.compactMap(\.roomID)
|
|
userSettings.seenInvites = Set(invitedRoomIDs)
|
|
#expect(invitedRoomIDs.count == 2)
|
|
|
|
let deferred = deferFulfillment(viewModel.actions) { $0 == .presentRoom(roomIdentifier: invitedRoomIDs[0]) }
|
|
context.send(viewAction: .acceptInvite(roomIdentifier: invitedRoomIDs[0]))
|
|
try await deferred.fulfill()
|
|
|
|
#expect(userSettings.seenInvites == [invitedRoomIDs[1]])
|
|
#expect(!notificationManager.removeDeliveredMessageNotificationsForCalled, "The notification will be dismissed when opening the room.")
|
|
}
|
|
|
|
@Test
|
|
func acceptSpaceInvite() async throws {
|
|
setupViewModel(invites: .spaces)
|
|
|
|
let invitedRoomIDs = context.viewState.rooms.invites.compactMap(\.roomID)
|
|
userSettings.seenInvites = Set(invitedRoomIDs)
|
|
#expect(invitedRoomIDs.count == 2)
|
|
|
|
let deferred = deferFulfillment(viewModel.actions) {
|
|
$0 == .presentSpace(SpaceRoomListProxyMock(.init(spaceServiceRoom: SpaceServiceRoom.mock(id: invitedRoomIDs[0], isSpace: true))))
|
|
}
|
|
context.send(viewAction: .acceptInvite(roomIdentifier: invitedRoomIDs[0]))
|
|
try await deferred.fulfill()
|
|
|
|
#expect(userSettings.seenInvites == [invitedRoomIDs[1]])
|
|
#expect(!notificationManager.removeDeliveredMessageNotificationsForCalled, "The notification will be dismissed when opening the room.")
|
|
}
|
|
|
|
@Test
|
|
func declineInvite() async throws {
|
|
setupViewModel(invites: .rooms)
|
|
let invitedRoomIDs = context.viewState.rooms.invites.compactMap(\.roomID)
|
|
userSettings.seenInvites = Set(invitedRoomIDs)
|
|
#expect(invitedRoomIDs.count == 2)
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { $0.bindings.alertInfo != nil }
|
|
context.send(viewAction: .declineInvite(roomIdentifier: invitedRoomIDs[0]))
|
|
try await deferred.fulfill()
|
|
|
|
var rejectCalled = false
|
|
clientProxy.roomForIdentifierClosure = { _ in
|
|
let roomProxy = InvitedRoomProxyMock(.init())
|
|
roomProxy.rejectInvitationClosure = {
|
|
rejectCalled = true
|
|
return .success(())
|
|
}
|
|
|
|
return .invited(roomProxy)
|
|
}
|
|
context.viewState.bindings.alertInfo?.verticalButtons?[0].action?()
|
|
|
|
// Wait for the async action to complete
|
|
try await Task.sleep(for: .milliseconds(100))
|
|
#expect(rejectCalled)
|
|
|
|
#expect(userSettings.seenInvites == [invitedRoomIDs[1]])
|
|
#expect(notificationManager.removeDeliveredMessageNotificationsForCalled)
|
|
#expect(notificationManager.removeDeliveredMessageNotificationsForReceivedInvocations == [invitedRoomIDs[0]])
|
|
}
|
|
|
|
@Test
|
|
func declineAndBlockInvite() async throws {
|
|
setupViewModel(invites: .rooms)
|
|
let invitedRoomIDs = context.viewState.rooms.invites.compactMap(\.roomID)
|
|
userSettings.seenInvites = Set(invitedRoomIDs)
|
|
#expect(invitedRoomIDs.count == 2)
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { $0.bindings.alertInfo != nil }
|
|
context.send(viewAction: .declineInvite(roomIdentifier: invitedRoomIDs[0]))
|
|
try await deferred.fulfill()
|
|
|
|
let deferredAction = deferFulfillment(viewModel.actions) { $0 == .presentDeclineAndBlock(userID: RoomMemberProxyMock.mockCharlie.userID, roomID: invitedRoomIDs[0]) }
|
|
context.viewState.bindings.alertInfo?.secondaryButton?.action?()
|
|
try await deferredAction.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func newSoundBanner() {
|
|
userSettings.hasSeenNewSoundBanner = false
|
|
|
|
setupViewModel()
|
|
#expect(context.viewState.shouldShowBanner)
|
|
#expect(context.viewState.shouldShowNewSoundBanner)
|
|
|
|
context.send(viewAction: .dismissNewSoundBanner)
|
|
#expect(!context.viewState.shouldShowBanner)
|
|
#expect(!context.viewState.shouldShowNewSoundBanner)
|
|
#expect(userSettings.hasSeenNewSoundBanner)
|
|
}
|
|
|
|
@Test
|
|
func multiAccountAnnouncement() async throws {
|
|
userSettings.multiAccountEnabled = true
|
|
setupViewModel()
|
|
|
|
// Arming it after the view model exists (Developer options) doesn't present it on its own.
|
|
userSettings.hasSeenMultiAccountAnnouncement = false
|
|
let deferredFailure = deferFailure(context.$viewState, timeout: .seconds(1)) { $0.bindings.isPresentingMultiAccountAnnouncement }
|
|
try await deferredFailure.fulfill()
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { $0.bindings.isPresentingMultiAccountAnnouncement }
|
|
context.send(viewAction: .screenAppeared)
|
|
try await deferred.fulfill()
|
|
#expect(!userSettings.hasSeenMultiAccountAnnouncement)
|
|
|
|
context.send(viewAction: .multiAccountAnnouncementAppeared)
|
|
#expect(userSettings.hasSeenMultiAccountAnnouncement)
|
|
#expect(context.viewState.bindings.isPresentingMultiAccountAnnouncement)
|
|
|
|
// A swipe down dismisses it without any of the announcement's actions.
|
|
context.isPresentingMultiAccountAnnouncement = false
|
|
let deferredReappearance = deferFailure(context.$viewState, timeout: .seconds(1)) { $0.bindings.isPresentingMultiAccountAnnouncement }
|
|
context.send(viewAction: .screenAppeared)
|
|
try await deferredReappearance.fulfill()
|
|
}
|
|
|
|
@Test(arguments: [HomeScreenViewAction.dismissMultiAccountAnnouncement, .addAccount])
|
|
func multiAccountAnnouncementActionsDismissIt(_ action: HomeScreenViewAction) async throws {
|
|
userSettings.multiAccountEnabled = true
|
|
userSettings.hasSeenMultiAccountAnnouncement = false
|
|
setupViewModel()
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { $0.bindings.isPresentingMultiAccountAnnouncement }
|
|
context.send(viewAction: .screenAppeared)
|
|
try await deferred.fulfill()
|
|
|
|
context.send(viewAction: action)
|
|
#expect(!context.viewState.bindings.isPresentingMultiAccountAnnouncement)
|
|
}
|
|
|
|
@Test(arguments: MultiAccountAnnouncementHiddenCase.allCases)
|
|
func multiAccountAnnouncementHidden(_ hiddenCase: MultiAccountAnnouncementHiddenCase) async throws {
|
|
userSettings.multiAccountEnabled = hiddenCase != .flagOff
|
|
userSettings.hasSeenMultiAccountAnnouncement = hiddenCase == .alreadySeen
|
|
let verificationState: SessionVerificationState = switch hiddenCase {
|
|
case .unverified: .unverified
|
|
case .unknownVerificationState: .unknown
|
|
case .flagOff, .alreadySeen: .verified
|
|
}
|
|
let securityStateSubject = CurrentValueSubject<SessionSecurityState, Never>(.init(verificationState: verificationState, recoveryState: .enabled))
|
|
setupViewModel(securityStatePublisher: securityStateSubject.asCurrentValuePublisher())
|
|
|
|
let deferred = deferFailure(context.$viewState, timeout: .seconds(1)) { $0.bindings.isPresentingMultiAccountAnnouncement }
|
|
context.send(viewAction: .screenAppeared)
|
|
try await deferred.fulfill()
|
|
#expect(userSettings.hasSeenMultiAccountAnnouncement == (hiddenCase == .alreadySeen))
|
|
}
|
|
|
|
@Test
|
|
func multiAccountAnnouncementPresentsOnTheNextAppearanceOnceVerified() async throws {
|
|
userSettings.multiAccountEnabled = true
|
|
userSettings.hasSeenMultiAccountAnnouncement = false
|
|
let securityStateSubject = CurrentValueSubject<SessionSecurityState, Never>(.init(verificationState: .unverified, recoveryState: .enabled))
|
|
setupViewModel(securityStatePublisher: securityStateSubject.asCurrentValuePublisher())
|
|
|
|
let deferredFailure = deferFailure(context.$viewState, timeout: .seconds(1)) { $0.bindings.isPresentingMultiAccountAnnouncement }
|
|
context.send(viewAction: .screenAppeared)
|
|
try await deferredFailure.fulfill()
|
|
|
|
// Becoming verified doesn't present it on its own…
|
|
securityStateSubject.send(.init(verificationState: .verified, recoveryState: .enabled))
|
|
let deferredVerifiedFailure = deferFailure(context.$viewState, timeout: .seconds(1)) { $0.bindings.isPresentingMultiAccountAnnouncement }
|
|
try await deferredVerifiedFailure.fulfill()
|
|
|
|
// …the room list appearing again does, e.g. once the identity confirmation cover is dismissed.
|
|
let deferred = deferFulfillment(context.$viewState) { $0.bindings.isPresentingMultiAccountAnnouncement }
|
|
context.send(viewAction: .screenAppeared)
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
// MARK: - Helpers
|
|
|
|
enum InviteType { case rooms, spaces }
|
|
|
|
enum MultiAccountAnnouncementHiddenCase: CaseIterable { case flagOff, alreadySeen, unverified, unknownVerificationState }
|
|
|
|
@Test
|
|
func roomListModeIsSetSynchronouslyOnAWarmLaunch() {
|
|
setupViewModel()
|
|
|
|
// No awaiting, the mode must not need the subscription's async delivery.
|
|
#expect(context.viewState.roomListMode == .rooms)
|
|
}
|
|
|
|
@Test
|
|
func roomListModeWaitsForTheRoomsToPublish() async throws {
|
|
let (roomListSubject, stateSubject) = setupViewModelWithManualProvider()
|
|
|
|
#expect(context.viewState.roomListMode == .skeletons)
|
|
|
|
// The provider reports loaded before the first summaries have been published.
|
|
let failure = deferFailure(context.$viewState, timeout: .seconds(1)) { $0.roomListMode != .skeletons }
|
|
stateSubject.send(.loaded(totalNumberOfRooms: 8))
|
|
try await failure.fulfill()
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { $0.roomListMode == .rooms }
|
|
roomListSubject.send(.mockRooms)
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func roomListModeDoesntHoldSkeletonsForAnEmptyFilteredResult() async throws {
|
|
let (roomListSubject, stateSubject) = setupViewModelWithManualProvider()
|
|
#expect(context.viewState.roomListMode == .skeletons)
|
|
|
|
// A filter is active before anything has published and the filtered list is loaded but empty.
|
|
context.filtersState.activateFilter(.people)
|
|
let deferred = deferFulfillment(context.$viewState) { $0.roomListMode == .rooms }
|
|
roomListSubject.send([])
|
|
stateSubject.send(.loaded(totalNumberOfRooms: 8))
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func roomListModeGoesStraightToTheCachedRooms() async throws {
|
|
let (roomListSubject, _) = setupViewModelWithManualProvider(state: .loaded(totalNumberOfRooms: 8))
|
|
#expect(context.viewState.roomListMode == .awaitingCachedRooms)
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { $0.roomListMode == .rooms }
|
|
roomListSubject.send(.mockRooms)
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func roomListModeShowsSkeletonsWhenTheCachedRoomsAreSlow() async throws {
|
|
_ = setupViewModelWithManualProvider(state: .loaded(totalNumberOfRooms: 8))
|
|
#expect(context.viewState.roomListMode == .awaitingCachedRooms)
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { $0.roomListMode == .skeletons }
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func roomListModeDoesntReturnToSkeletonsWhenTheRoomsAreFilteredOut() async throws {
|
|
let (roomListSubject, stateSubject) = setupViewModelWithManualProvider()
|
|
|
|
stateSubject.send(.loaded(totalNumberOfRooms: 8))
|
|
let deferred = deferFulfillment(context.$viewState) { $0.roomListMode == .rooms }
|
|
roomListSubject.send(.mockRooms)
|
|
try await deferred.fulfill()
|
|
|
|
// A filter or a search without matches empties the list, the mode must not regress.
|
|
let failure = deferFailure(context.$viewState, timeout: .seconds(1)) { $0.roomListMode != .rooms }
|
|
roomListSubject.send([])
|
|
stateSubject.send(.loaded(totalNumberOfRooms: 9))
|
|
try await failure.fulfill()
|
|
}
|
|
|
|
private func setupViewModelWithManualProvider(state: RoomSummaryProviderState = .notLoaded) -> (CurrentValueSubject<[RoomSummary], Never>, CurrentValueSubject<RoomSummaryProviderState, Never>) {
|
|
let roomListSubject = CurrentValueSubject<[RoomSummary], Never>([])
|
|
let stateSubject = CurrentValueSubject<RoomSummaryProviderState, Never>(state)
|
|
|
|
let provider = RoomSummaryProviderMock()
|
|
provider.roomListPublisher = roomListSubject.asCurrentValuePublisher()
|
|
provider.statePublisher = stateSubject.asCurrentValuePublisher()
|
|
|
|
setupViewModel(roomSummaryProvider: provider)
|
|
|
|
return (roomListSubject, stateSubject)
|
|
}
|
|
|
|
private func setupViewModel(securityStatePublisher: CurrentValuePublisher<SessionSecurityState, Never>? = nil, invites: InviteType? = nil, roomSummaryProvider: RoomSummaryProviderMock? = nil) {
|
|
cancellables.removeAll()
|
|
|
|
var rooms: [RoomSummary] = .mockRooms
|
|
|
|
switch invites {
|
|
case .rooms:
|
|
rooms += .mockInvites
|
|
case .spaces:
|
|
rooms += .mockSpaceInvites
|
|
case nil:
|
|
break
|
|
}
|
|
|
|
self.roomSummaryProvider = roomSummaryProvider ?? RoomSummaryProviderMock(.init(state: .loaded(rooms)))
|
|
|
|
clientProxy = ClientProxyMock(.init(userID: "@mock:client.com",
|
|
roomSummaryProvider: self.roomSummaryProvider))
|
|
|
|
clientProxy.joinRoomViaReturnValue = .success(())
|
|
clientProxy.joinRoomAliasReturnValue = .success(())
|
|
|
|
switch invites {
|
|
case .rooms:
|
|
clientProxy.roomForIdentifierClosure = { roomID in .invited(InvitedRoomProxyMock(.init(id: roomID))) }
|
|
case .spaces:
|
|
clientProxy.roomForIdentifierClosure = { spaceID in .invited(InvitedRoomProxyMock(.init(id: spaceID, isSpace: true))) }
|
|
|
|
let spaceServiceProxy = SpaceServiceProxyMock(.init())
|
|
spaceServiceProxy.spaceRoomListSpaceIDClosure = { spaceID in
|
|
.success(SpaceRoomListProxyMock(.init(spaceServiceRoom: SpaceServiceRoom.mock(id: spaceID, isSpace: true))))
|
|
}
|
|
clientProxy.spaceService = spaceServiceProxy
|
|
case nil:
|
|
break
|
|
}
|
|
|
|
let userSession = UserSessionMock(.init(clientProxy: clientProxy))
|
|
if let securityStatePublisher {
|
|
userSession.sessionSecurityStatePublisher = securityStatePublisher
|
|
}
|
|
|
|
notificationManager = NotificationManagerMock()
|
|
|
|
viewModel = HomeScreenViewModel(userSession: userSession,
|
|
selectedRoomPublisher: CurrentValueSubject<String?, Never>(nil).asCurrentValuePublisher(),
|
|
userSettings: userSettings,
|
|
analyticsService: AnalyticsServiceMock(.init()),
|
|
bugReportService: BugReportServiceMock(.init()),
|
|
notificationManager: notificationManager,
|
|
userIndicatorController: UserIndicatorControllerMock())
|
|
}
|
|
}
|
|
|
|
@MainActor
|
|
private extension [HomeScreenRoom] {
|
|
var invites: [HomeScreenRoom] {
|
|
filter { room in
|
|
if case .invite = room.type {
|
|
true
|
|
} else {
|
|
false
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
@MainActor
|
|
extension HomeScreenViewModelAction: @MainActor @retroactive Equatable {
|
|
public static func == (lhs: HomeScreenViewModelAction, rhs: HomeScreenViewModelAction) -> Bool {
|
|
switch (lhs, rhs) {
|
|
case (.presentRoom(let lhsID), .presentRoom(let rhsID)):
|
|
lhsID == rhsID
|
|
case (.presentRoomDetails(let lhsID), .presentRoomDetails(let rhsID)):
|
|
lhsID == rhsID
|
|
case (.presentReportRoom(let lhsID), .presentReportRoom(let rhsID)):
|
|
lhsID == rhsID
|
|
case (.presentDeclineAndBlock(let lhsUserID, let lhsRoomID), .presentDeclineAndBlock(let rhsUserID, let rhsRoomID)):
|
|
lhsUserID == rhsUserID && lhsRoomID == rhsRoomID
|
|
case (.presentSpace(let lhsSpaceRoomListProxy), .presentSpace(let rhsSpaceRoomListProxy)):
|
|
lhsSpaceRoomListProxy.id == rhsSpaceRoomListProxy.id
|
|
case (.roomLeft(let lhsID), .roomLeft(let rhsID)):
|
|
lhsID == rhsID
|
|
case (.transferOwnership(let lhsID), .transferOwnership(let rhsID)):
|
|
lhsID == rhsID
|
|
case (.presentSecureBackupSettings, .presentSecureBackupSettings):
|
|
true
|
|
case (.presentRecoveryKeyScreen, .presentRecoveryKeyScreen):
|
|
true
|
|
case (.presentEncryptionResetScreen, .presentEncryptionResetScreen):
|
|
true
|
|
case (.presentSettingsScreen, .presentSettingsScreen):
|
|
true
|
|
case (.presentFeedbackScreen, .presentFeedbackScreen):
|
|
true
|
|
case (.presentStartChatScreen, .presentStartChatScreen):
|
|
true
|
|
case (.logout, .logout):
|
|
true
|
|
default:
|
|
false
|
|
}
|
|
}
|
|
}
|