mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-01 09:42:39 +00:00
22d14ff8e4
* create DependenciesProtocol and replace ServiceLocator registration with it replace mocking calls for ServiceLocator to Dependencies replace ServiceLocator with instance level calls replace ServiceLocator configs with TestDependencies config in Tests replace servicelocator usage in analytics service replace remaining ServiceLocator calls in unit tests that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances fix swiftlint warning remove remaining references to ServiceLocator make dependencies properties consistent in tests delete Dependencies and DependenciesProtocol fix whitespace modifications updates from PR feedback a pass over converting AppSettings and AnalyticsService test instance properties to per test instantiation fix a missed PR feedback Sync up after rebase create DependenciesProtocol and replace ServiceLocator registration with it replace mocking calls for ServiceLocator to Dependencies replace ServiceLocator with instance level calls replace ServiceLocator configs with TestDependencies config in Tests replace servicelocator usage in analytics service replace remaining ServiceLocator calls in unit tests that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances fix swiftlint warning remove remaining references to ServiceLocator make dependencies properties consistent in tests delete Dependencies and DependenciesProtocol * AppSettings is instance level mockable now * replace mocked and preview usages of reset + AppSettings global init with AppSettings(store: UserDefaultsMock()) * AppSettings.UserDefaultsKeys is now a RawRep struct, making it extensible * update tests with new AppSettings so it builds * update remaining AppSettings test/mock inits * AppSettings.UserDefaultsKey conformed to ExpressibleByStringLiteral * addressed issues found in first pass ai review * update AppSettings instantiations after rebase * fix accessibility tests coordinator after rebase * Rename to VolatileUserDefaults * AppSettings init uses mandatory parameter * Revert UserDefaultsKey to enum * Add TrackedUserDefaults to be able to reset the defaults object * Added volatile static func to AppSettings * Use .volatile() static func instead of full init * review fixups * Resolve build issues after rebase * updated enterprise module * remove the static reset settings call from the preview tests --------- Co-authored-by: Mauro Romito <mauro.romito@element.io>
264 lines
11 KiB
Swift
264 lines
11 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import Combine
|
|
@testable import ElementX
|
|
import NotificationCenter
|
|
import Testing
|
|
|
|
@MainActor
|
|
final class NotificationManagerTests {
|
|
var notificationManager: NotificationManager!
|
|
private let clientProxy = ClientProxyMock(.init(userID: "@test:user.net"))
|
|
private lazy var mockUserSession = UserSessionMock(.init(clientProxy: clientProxy))
|
|
private var notificationCenter: UserNotificationCenterMock!
|
|
private var authorizationStatusWasGranted = false
|
|
private var shouldDisplayInAppNotificationReturnValue = false
|
|
private var handleInlineReplyDelegateCalled = false
|
|
private var notificationTappedDelegateCalled = false
|
|
private var registerForRemoteNotificationsDelegateCalled: (() -> Void)?
|
|
private let appSettings: AppSettings
|
|
|
|
init() {
|
|
appSettings = AppSettings.volatile()
|
|
notificationCenter = UserNotificationCenterMock()
|
|
notificationCenter.requestAuthorizationOptionsReturnValue = true
|
|
notificationCenter.authorizationStatusReturnValue = .authorized
|
|
notificationCenter.notificationSettingsClosure = { await UNUserNotificationCenter.current().notificationSettings() }
|
|
|
|
notificationManager = NotificationManager(notificationCenter: notificationCenter, appSettings: appSettings)
|
|
notificationManager.start()
|
|
notificationManager.setUserSession(mockUserSession)
|
|
}
|
|
|
|
deinit {
|
|
notificationCenter = nil
|
|
notificationManager = nil
|
|
}
|
|
|
|
@Test
|
|
func whenRegistered_pusherIsCalled() async {
|
|
_ = await notificationManager.register(with: Data())
|
|
|
|
#expect(clientProxy.setPusherWithCalled)
|
|
}
|
|
|
|
@Test
|
|
func whenRegisteredSuccess_completionSuccessIsCalled() async {
|
|
let success = await notificationManager.register(with: Data())
|
|
#expect(success)
|
|
}
|
|
|
|
@Test
|
|
func whenRegisteredAndPusherThrowsError_completionFalseIsCalled() async {
|
|
enum TestError: Error {
|
|
case someError
|
|
}
|
|
|
|
clientProxy.setPusherWithThrowableError = TestError.someError
|
|
let success = await notificationManager.register(with: Data())
|
|
#expect(!success)
|
|
}
|
|
|
|
@Test
|
|
func whenRegistered_pusherIsCalledWithCorrectValues() async throws {
|
|
let pushkeyData = Data("1234".utf8)
|
|
_ = await notificationManager.register(with: pushkeyData)
|
|
|
|
guard let configuration = clientProxy.setPusherWithReceivedInvocations.first else {
|
|
Issue.record("Invalid pusher configuration sent")
|
|
return
|
|
}
|
|
|
|
#expect(configuration.identifiers.pushkey == pushkeyData.base64EncodedString())
|
|
#expect(configuration.identifiers.appId == appSettings.pusherAppID)
|
|
#expect(configuration.appDisplayName == "\(InfoPlistReader.main.bundleDisplayName) (iOS)")
|
|
#expect(configuration.deviceDisplayName == UIDevice.current.name)
|
|
#expect(configuration.profileTag != nil)
|
|
#expect(configuration.lang == Bundle.app.preferredLocalizations.first)
|
|
guard case let .http(data) = configuration.kind else {
|
|
Issue.record("Http kind expected")
|
|
return
|
|
}
|
|
#expect(data.url == appSettings.pushGatewayNotifyEndpoint.absoluteString)
|
|
#expect(data.format == .eventIdOnly)
|
|
let defaultPayload = APNSPayload(aps: APSInfo(mutableContent: 1,
|
|
alert: APSAlert(locKey: "Notification",
|
|
locArgs: [])),
|
|
pusherNotificationClientIdentifier: nil)
|
|
#expect(try data.defaultPayload == (defaultPayload.toJsonString()))
|
|
}
|
|
|
|
@Test
|
|
func whenRegisteredAndPusherTagNotSetInSettings_tagGeneratedAndSavedInSettings() async {
|
|
appSettings.pusherProfileTag = nil
|
|
_ = await notificationManager.register(with: Data())
|
|
#expect(appSettings.pusherProfileTag != nil)
|
|
}
|
|
|
|
@Test
|
|
func whenRegisteredAndPusherTagIsSetInSettings_tagNotGenerated() async {
|
|
appSettings.pusherProfileTag = "12345"
|
|
_ = await notificationManager.register(with: Data())
|
|
#expect(appSettings.pusherProfileTag == "12345")
|
|
}
|
|
|
|
@Test
|
|
func whenShowLocalNotification_notificationRequestGetsAdded() async throws {
|
|
await notificationManager.showLocalNotification(with: "Title", subtitle: "Subtitle")
|
|
let request = try #require(notificationCenter.addReceivedRequest)
|
|
#expect(request.content.title == "Title")
|
|
#expect(request.content.subtitle == "Subtitle")
|
|
}
|
|
|
|
@Test
|
|
func whenStart_notificationCategoriesAreSet() {
|
|
let replyAction = UNTextInputNotificationAction(identifier: NotificationConstants.Action.inlineReply,
|
|
title: L10n.actionQuickReply,
|
|
options: [])
|
|
let messageCategory = UNNotificationCategory(identifier: NotificationConstants.Category.message,
|
|
actions: [replyAction],
|
|
intentIdentifiers: [],
|
|
options: [])
|
|
|
|
let inviteCategory = UNNotificationCategory(identifier: NotificationConstants.Category.invite,
|
|
actions: [],
|
|
intentIdentifiers: [],
|
|
options: [])
|
|
#expect(notificationCenter.setNotificationCategoriesReceivedCategories == [messageCategory, inviteCategory])
|
|
}
|
|
|
|
@Test
|
|
func whenStart_delegateIsSet() throws {
|
|
let delegate = try #require(notificationCenter.delegate)
|
|
#expect(delegate.isEqual(notificationManager))
|
|
}
|
|
|
|
@Test
|
|
func whenStart_requestAuthorizationCalledWithCorrectParams() async {
|
|
await waitForConfirmation("requestAuthorization should be called", timeout: .seconds(10)) { confirm in
|
|
notificationCenter.requestAuthorizationOptionsClosure = { _ in
|
|
confirm()
|
|
return true
|
|
}
|
|
notificationManager.requestAuthorization()
|
|
}
|
|
#expect(notificationCenter.requestAuthorizationOptionsReceivedOptions == [.alert, .sound, .badge])
|
|
}
|
|
|
|
@Test
|
|
func whenStartAndAuthorizationGranted_delegateCalled() async {
|
|
authorizationStatusWasGranted = false
|
|
notificationManager.delegate = self
|
|
await waitForConfirmation("registerForRemoteNotifications delegate function should be called", timeout: .seconds(10)) { confirm in
|
|
registerForRemoteNotificationsDelegateCalled = {
|
|
confirm()
|
|
}
|
|
notificationManager.requestAuthorization()
|
|
}
|
|
#expect(authorizationStatusWasGranted)
|
|
}
|
|
|
|
@Test
|
|
func whenStartAndAuthorizedAndNotificationDisabled_registerForRemoteNotificationsNotCalled() async throws {
|
|
appSettings.enableNotifications = false
|
|
notificationCenter.authorizationStatusReturnValue = .authorized
|
|
notificationManager.delegate = self
|
|
|
|
notificationManager.setUserSession(UserSessionMock(.init()))
|
|
try await Task.sleep(for: .seconds(1))
|
|
|
|
#expect(!authorizationStatusWasGranted)
|
|
}
|
|
|
|
@Test
|
|
func whenStartAndAuthorized_registerForRemoteNotificationsCalled() async {
|
|
appSettings.enableNotifications = true
|
|
notificationCenter.authorizationStatusReturnValue = .authorized
|
|
notificationManager.delegate = self
|
|
|
|
await waitForConfirmation("registerForRemoteNotifications delegate function should be called", timeout: .seconds(10)) { confirm in
|
|
registerForRemoteNotificationsDelegateCalled = {
|
|
confirm()
|
|
}
|
|
notificationManager.setUserSession(UserSessionMock(.init()))
|
|
}
|
|
|
|
#expect(authorizationStatusWasGranted)
|
|
}
|
|
|
|
@Test
|
|
func whenWillPresentNotificationsDelegateNotSet_CorrectPresentationOptionsReturned() async throws {
|
|
let archiver = MockCoder(requiringSecureCoding: false)
|
|
let notification = try #require(UNNotification(coder: archiver))
|
|
let options = await notificationManager.userNotificationCenter(UNUserNotificationCenter.current(), willPresent: notification)
|
|
#expect(options == [.badge, .sound, .list, .banner])
|
|
}
|
|
|
|
@Test
|
|
func whenWillPresentNotificationsDelegateSetAndNotificationsShoudNotBeDisplayed_CorrectPresentationOptionsReturned() async throws {
|
|
shouldDisplayInAppNotificationReturnValue = false
|
|
notificationManager.delegate = self
|
|
|
|
let notification = try UNNotification.with(userInfo: [AnyHashable: Any]())
|
|
let options = await notificationManager.userNotificationCenter(UNUserNotificationCenter.current(), willPresent: notification)
|
|
#expect(options == [])
|
|
}
|
|
|
|
@Test
|
|
func whenWillPresentNotificationsDelegateSetAndNotificationsShoudBeDisplayed_CorrectPresentationOptionsReturned() async throws {
|
|
shouldDisplayInAppNotificationReturnValue = true
|
|
notificationManager.delegate = self
|
|
|
|
let notification = try UNNotification.with(userInfo: [AnyHashable: Any]())
|
|
let options = await notificationManager.userNotificationCenter(UNUserNotificationCenter.current(), willPresent: notification)
|
|
#expect(options == [.badge, .sound, .list, .banner])
|
|
}
|
|
|
|
@Test
|
|
func whenNotificationCenterReceivedResponseInLineReply_delegateIsCalled() async throws {
|
|
handleInlineReplyDelegateCalled = false
|
|
notificationManager.delegate = self
|
|
let response = try UNTextInputNotificationResponse.with(userInfo: [AnyHashable: Any](), actionIdentifier: NotificationConstants.Action.inlineReply)
|
|
await notificationManager.userNotificationCenter(UNUserNotificationCenter.current(), didReceive: response)
|
|
#expect(handleInlineReplyDelegateCalled)
|
|
}
|
|
|
|
@Test
|
|
func whenNotificationCenterReceivedResponseWithActionIdentifier_delegateIsCalled() async throws {
|
|
notificationTappedDelegateCalled = false
|
|
notificationManager.delegate = self
|
|
let response = try UNTextInputNotificationResponse.with(userInfo: [AnyHashable: Any](), actionIdentifier: UNNotificationDefaultActionIdentifier)
|
|
await notificationManager.userNotificationCenter(UNUserNotificationCenter.current(), didReceive: response)
|
|
#expect(notificationTappedDelegateCalled)
|
|
}
|
|
}
|
|
|
|
extension NotificationManagerTests: @MainActor NotificationManagerDelegate {
|
|
func registerForRemoteNotifications() {
|
|
authorizationStatusWasGranted = true
|
|
registerForRemoteNotificationsDelegateCalled?()
|
|
}
|
|
|
|
func unregisterForRemoteNotifications() {
|
|
authorizationStatusWasGranted = false
|
|
}
|
|
|
|
func shouldDisplayInAppNotification(content: UNNotificationContent) -> Bool {
|
|
shouldDisplayInAppNotificationReturnValue
|
|
}
|
|
|
|
func notificationTapped(content: UNNotificationContent) async {
|
|
notificationTappedDelegateCalled = true
|
|
}
|
|
|
|
func handleInlineReply(_ service: ElementX.NotificationManagerProtocol, content: UNNotificationContent, replyText: String) async {
|
|
handleInlineReplyDelegateCalled = true
|
|
}
|
|
}
|