Michael dfebb4719c Compiler Warning Reductions (#5609) ...

* Reduce warnings in AttributedStringBuilderTests

(cherry picked from commit e1f32b2b1df147c93207e01df5c8fec4046b0f48)

* Fixed Sentry warning

(cherry picked from commit e45c3002b2331a6f2d363de61a12377316078602)

* JoinRule and AllowRule conform to Sendable

(cherry picked from commit 27c67c27b944df11adc17bdd405e442e8c50b0d6)

* AudioConverterProtocol conform to Sendable

(cherry picked from commit 352bdab15db424c632538eb3140858eae9fdfb15)

* TimelineControllerProtocol conform to Sendable

(cherry picked from commit 07a927745624db4bab3cf68842027e12177be70b)

* Resolved some AI review notes

(cherry picked from commit 8d3ac820754a6126785e639a98c8c1fcf86ef77f)

# Conflicts:
#	ElementX/Sources/Other/SendableConformance/SendableBox.swift
#	ElementX/Sources/Other/SendableConformance/WeakSendableBox.swift

2026-05-22 10:56:30 +02:00

..

AppLock

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

LayoutTests

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

MediaProvider

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

NotificationManager

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

TestUtilities

Finish migration of UnitTests target from XCTestCase to Swift Testing (#5129)

2026-02-24 12:20:01 +00:00

UserDiscoveryService

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

AnalyticsSettingsScreenViewModelTests.swift

Make AnalyticsService mockable via `AnalyticsServiceProtocol (#5599)

2026-05-20 08:23:58 +03:00

AnalyticsTests.swift

Make AnalyticsService mockable via `AnalyticsServiceProtocol (#5599)

2026-05-20 08:23:58 +03:00

AppRouteURLParserTests.swift

Rename OIDC to OAuth. (#5525)

2026-05-05 14:07:06 +01:00

ArrayTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

AttributedStringBuilderTests.swift

Compiler Warning Reductions (#5609)

2026-05-22 10:56:30 +02:00

AttributedStringTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

AudioPlayerStateTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

AudioRecorderStateTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

AudioRecorderTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

AuthenticationServiceTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

AuthenticationStartScreenViewModelTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

AVMetadataMachineReadableCodeObjectExtensionsTest.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

BlockedUsersScreenViewModelTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

BugReportScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

BugReportServiceTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

ChatsTabFlowCoordinatorTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

ClassicAppAccountManagerTests.swift

Add a view to show the user's account from Element Classic. (#5361)

2026-04-08 21:18:03 +01:00

ClassicAppMediaLoaderTests.swift

Add a view to show the user's account from Element Classic. (#5361)

2026-04-08 21:18:03 +01:00

CompletionSuggestionServiceTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

ComposerToolbarViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

CreateRoomViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

DateTests.swift

Render the live location timeline item (#5209)

2026-03-24 10:34:00 +01:00

DeactivateAccountScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

DeclineAndBlockScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

DeferredFulfillmentTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

EditRoomAddressScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

ElementCallServiceTests.swift

feat: Render declined calls in DM timeline (#5512)

2026-05-11 14:51:30 +03:00

EmojiPickerScreenViewModelTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

EmojiProviderTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

ExpiringTaskRunnerTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

GeoURITests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

GlobalSearchScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

HomeScreenRoomTests.swift

Notification Decoration Revised (#5312)

2026-04-21 14:12:07 +03:00

HomeScreenViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

IdentityConfirmationScreenViewModelTests.swift

Fix a bug where the onboarding flow was dismissed by logging out. (#5481)

2026-04-27 14:33:09 +01:00

InviteUsersViewModelTests.swift

Invite the DM recipient to a new room (#5588)

2026-05-18 10:08:07 +02:00

JoinRoomScreenViewModelTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

KeychainControllerTests.swift

Update the SDK, handling OIDC/OAuth API breaks. (#5497)

2026-04-27 14:46:53 +01:00

KnockRequestsListScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

LiveLocationManagerTests.swift

Live Location Sharing - handle server echoes (#5514)

2026-04-30 13:18:36 +00:00

LocalizationTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

LocationSharingScreenViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

LoggingTests.swift

Support for ongoing voice vs video call + joining (#5399)

2026-04-21 09:11:52 +00:00

LoginScreenViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

ManageRoomMemberSheetViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

MapTilerURLBuilderTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

MatrixEntityRegexTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

MediaPlayerProviderTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

MediaUploadingPreprocessorTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

MediaUploadPreviewScreenViewModelTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

MessageForwardingScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

NavigationRootCoordinatorTests.swift

Remove support for handling SPA calls within the app. (#5515)

2026-04-29 19:32:38 +01:00

NavigationSplitCoordinatorTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

NavigationStackCoordinatorTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

NavigationTabCoordinatorTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

NotificationContentBuilderTests.swift

Refactor the RoomMessageEventStringBuilder to take a Style instead of a Destination

2026-03-31 18:21:14 +03:00

NotificationSettingsEditScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

NotificationSettingsScreenViewModelTests.swift

Custom Notification Tones (#5527)

2026-05-20 15:40:34 +03:00

NotificationToneManagerTests.swift

Custom Notification Tones (#5527)

2026-05-20 15:40:34 +03:00

PermalinkTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

PillContextTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

PinnedEventsBannerStateTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

PollFormScreenViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

QRCodeLoginScreenViewModelTests.swift

Link new device with QR code tweaks. (#5563)

2026-05-11 14:22:34 +01:00

RemotePreferenceTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

ReportContentScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

ReportRoomScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

ResolveVerifiedUserSendFailureScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

RestorationTokenTests.swift

Update the SDK, handling OIDC/OAuth API breaks. (#5497)

2026-04-27 14:46:53 +01:00

RoomChangePermissionsScreenViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

RoomChangeRolesScreenViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

RoomDetailsEditScreenViewModelTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

RoomDetailsScreenViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

RoomEventStringBuilderTests.swift

Remove the shouldDisambiguateDisplayNames parameter from the RoomEvent and RoomStateEvent string builders.

2026-04-02 12:30:43 +03:00

RoomFlowCoordinatorTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

RoomListFiltersStateTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

RoomMemberDetailsViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

RoomMembersFlowCoordinatorTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

RoomMembersListScreenViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

RoomNotificationSettingsScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

RoomPermissionsTests.swift

Add the setting to change live location permissions to the change permissions screen.

2026-05-06 13:53:36 +02:00

RoomPollsHistoryScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

RoomRolesAndPermissionsScreenViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

RoomScreenViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

RoomStateEventStringBuilderTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

RoomSummaryProviderTests.swift

Remove the shouldDisambiguateDisplayNames parameter from the RoomEvent and RoomStateEvent string builders.

2026-04-02 12:30:43 +03:00

RoomSummaryTests.swift

Support for ongoing voice vs video call + joining (#5399)

2026-04-21 09:11:52 +00:00

RoomTests.swift

fix tests

2026-03-30 17:49:46 +02:00

SecureBackupLogoutConfirmationScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

SecurityAndPrivacyScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

ServerConfigurationScreenViewStateTests.swift

Rename OIDC to OAuth. (#5525)

2026-05-05 14:07:06 +01:00

ServerConfirmationScreenViewModelTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

ServerSelectionScreenViewModelTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

SessionDirectoriesTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

SessionVerificationStateMachineTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

SessionVerificationViewModelTests.swift

Fix session verification SAS flow not automatically starting

2026-04-20 18:19:27 +03:00

SettingsScreenViewModelTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

SoftLogoutScreenViewModelTests.swift

Rename OIDC to OAuth. (#5525)

2026-05-05 14:07:06 +01:00

SpaceAddRoomsScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

SpaceListScreenViewModelTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

SpaceScreenViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

StartChatViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

StringTests.swift

remove code related to the previous bidi usage implementation of whitespaces for the timestamp label

2026-05-12 14:46:18 +02:00

TimelineItemFactoryTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

TimelineMediaPreviewDataSourceTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

TimelineMediaPreviewViewModelTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

TimelineStateTests.swift

Timeline: add a Jump to Unread button and a new-message badge on the scroll-to-bottom button. (#5506)

2026-05-21 15:03:32 +03:00

TimelineViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

URLComponentsTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

URLTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

UserAgentBuilderTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

UserDetailsEditScreenViewModelTests.swift

Replace the ServiceLocator with direct dependency injection (#5548)

2026-05-14 09:45:49 +03:00

UserIndicatorControllerTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

UserPreferenceTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

UserProfileScreenViewModelTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

UserSessionFlowCoordinatorTests.swift

Make the AnalyticsServiceMock default a variable as well, for consistency.

2026-05-21 12:37:52 +03:00

VoiceMessageCacheTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

VoiceMessageMediaManagerTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00

VoiceMessageRecorderTests.swift

Fix new redundantSendable and redundantSwiftTestingSuite swiftformat errors

2026-03-04 17:02:11 +02:00