Files
element-x-ios/UnitTests/Sources/HealthChat/HealthChatMemberDirectoryScreenViewModelTests.swift
T
joel.poyet b475cc7e9a Let members edit their profile and invite others (#12)
* Add HealthChat API and extended profile services

Expose OpenID tokens and homeserver credentials from the client proxy, and
add fork-only services for the HealthChat member directory backend
(api.healthchat.ch) plus a service that reads MSC4133 extended profile
fields directly from the homeserver. Groundwork for the members tab and
the profile screens.

Claude-Session: https://claude.ai/code/session_013qdTbAWsZj2quQzEkagXaS

* Show extended profile details on the profile screens

Add a UserProfileScreenHook that lets the fork inject an extra Form
section below the header of the user profile and room member details
screens. The HealthChat implementation loads the MSC4133 extended
profile fields and renders them with tappable phone/email/website
links, hiding the section entirely for profiles without any fields.

Strings live in a new fork-only HealthChat.strings table (de/en/fr,
generated as HealthChatL10n via SwiftGen) since Untranslated.strings
pins the English bundle.

Claude-Session: https://claude.ai/code/session_013qdTbAWsZj2quQzEkagXaS

* Add a member directory tab

Add a HomeTabsHook that lets the fork append an extra tab to the home
tab bar, and a HealthChat members flow behind it: a directory of all
approved members from the HealthChat API with server-side search,
pending-approval and error states, chat shortcuts and pushed member
profiles. Chats and calls are handed back to the session flow via the
hook's actions publisher.

Claude-Session: https://claude.ai/code/session_013qdTbAWsZj2quQzEkagXaS

* Let members edit their profile and invite others

Add a native profile editor for the HealthChat extended profile fields
(13 fields plus avatar, saved as a partial diff through the HealthChat
API so displayname derivation and Zitadel sync stay server-side), an
invitation sheet (email plus personal note) and a profile-completeness
hint on the member directory.

A new UserDetailsEditScreenHook lets the fork substitute the profile
editor behind the settings user row — the stock display-name editor
would let users edit a value the next profile update derives away.

Claude-Session: https://claude.ai/code/session_013qdTbAWsZj2quQzEkagXaS
2026-09-22 18:27:37 +02:00

231 lines
9.6 KiB
Swift

//
// Copyright 2026 Element Creations Ltd.
//
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
// Please see LICENSE files in the repository root for full details.
//
@testable import ElementX
import Foundation
import Testing
final class HealthChatMemberDirectoryScreenViewModelTests {
private let apiService = HealthChatAPIServiceMock()
private let clientProxy = ClientProxyMock(.init())
init() throws {
apiService.profileCompletenessReturnValue = try .success(makeCompleteness(isComplete: true, message: nil))
}
@Test
func loadsMembersOnStart() async throws {
apiService.membersSearchQueryReturnValue = try .success(makeResponse(userIDs: ["@alice:healthchat.ch"]))
let viewModel = makeViewModel()
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.content)) { content in
guard case .members(let members) = content else { return false }
return members.map(\.userID) == ["@alice:healthchat.ch"]
}
try await deferred.fulfill()
}
@Test
func showsPendingApprovalMessage() async throws {
apiService.membersSearchQueryReturnValue = .success(.init(users: [],
isApproved: false,
pendingMessage: "Ihr Konto wird geprüft"))
let viewModel = makeViewModel()
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.content)) { content in
content == .pendingApproval(message: "Ihr Konto wird geprüft")
}
try await deferred.fulfill()
}
@Test
func showsFailureAndRecoversOnRetry() async throws {
apiService.membersSearchQueryReturnValue = .failure(.networkFailure)
let viewModel = makeViewModel()
let deferredFailure = deferFulfillment(viewModel.context.observe(\.viewState.content)) { $0 == .failure }
try await deferredFailure.fulfill()
apiService.membersSearchQueryReturnValue = try .success(makeResponse(userIDs: ["@alice:healthchat.ch"]))
let deferredMembers = deferFulfillment(viewModel.context.observe(\.viewState.content)) { content in
guard case .members = content else { return false }
return true
}
viewModel.context.send(viewAction: .retry)
try await deferredMembers.fulfill()
}
@Test
func searchQueryTriggersServerSearch() async throws {
let allMembers = try makeResponse(userIDs: ["@alice:healthchat.ch"])
let searchResults = try makeResponse(userIDs: ["@zoe:healthchat.ch"])
apiService.membersSearchQueryClosure = { searchQuery in
searchQuery == "Zürich" ? .success(searchResults) : .success(allMembers)
}
let viewModel = makeViewModel()
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.content)) { content in
guard case .members(let members) = content else { return false }
return members.map(\.userID) == ["@zoe:healthchat.ch"]
}
viewModel.context.searchQuery = "Zürich"
try await deferred.fulfill()
#expect(apiService.membersSearchQueryReceivedInvocations.last == "Zürich")
}
@Test
func startChatWithExistingDMPresentsRoom() async throws {
apiService.membersSearchQueryReturnValue = try .success(makeResponse(userIDs: ["@alice:healthchat.ch"]))
clientProxy.directRoomForUserIDReturnValue = .success("existingRoom")
let viewModel = makeViewModel()
let deferred = deferFulfillment(viewModel.actionsPublisher) { action in
guard case .presentRoom(let roomID) = action else { return false }
return roomID == "existingRoom"
}
try viewModel.context.send(viewAction: .startChat(makeMember(userID: "@alice:healthchat.ch")))
try await deferred.fulfill()
}
@Test
func startChatWithoutDMCreatesOne() async throws {
apiService.membersSearchQueryReturnValue = try .success(makeResponse(userIDs: ["@alice:healthchat.ch"]))
clientProxy.directRoomForUserIDReturnValue = .success(nil)
clientProxy.createDirectRoomWithExpectedRoomNameReturnValue = .success("newRoom")
let viewModel = makeViewModel()
let deferred = deferFulfillment(viewModel.actionsPublisher) { action in
guard case .presentRoom(let roomID) = action else { return false }
return roomID == "newRoom"
}
try viewModel.context.send(viewAction: .startChat(makeMember(userID: "@alice:healthchat.ch")))
try await deferred.fulfill()
#expect(clientProxy.createDirectRoomWithExpectedRoomNameReceivedArguments?.userID == "@alice:healthchat.ch")
}
@Test
func selectMemberEmitsAction() async throws {
apiService.membersSearchQueryReturnValue = try .success(makeResponse(userIDs: ["@alice:healthchat.ch"]))
let viewModel = makeViewModel()
let deferred = deferFulfillment(viewModel.actionsPublisher) { action in
guard case .selectMember(let userID) = action else { return false }
return userID == "@alice:healthchat.ch"
}
try viewModel.context.send(viewAction: .selectMember(makeMember(userID: "@alice:healthchat.ch")))
try await deferred.fulfill()
}
@Test
func showsCompletenessHintWhenProfileIsIncomplete() async throws {
apiService.membersSearchQueryReturnValue = try .success(makeResponse(userIDs: ["@alice:healthchat.ch"]))
apiService.profileCompletenessReturnValue = try .success(makeCompleteness(isComplete: false,
message: "Profil unvollständig"))
let viewModel = makeViewModel()
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.completenessMessage)) { $0 == "Profil unvollständig" }
try await deferred.fulfill()
#expect(viewModel.context.viewState.isApproved)
}
@Test
func hidesCompletenessHintWhenProfileIsComplete() async throws {
apiService.membersSearchQueryReturnValue = try .success(makeResponse(userIDs: ["@alice:healthchat.ch"]))
let viewModel = makeViewModel()
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.content)) { content in
guard case .members = content else { return false }
return true
}
try await deferred.fulfill()
#expect(viewModel.context.viewState.completenessMessage == nil)
}
@Test
func pendingApprovalDisablesInviting() async throws {
apiService.membersSearchQueryReturnValue = .success(.init(users: [],
isApproved: false,
pendingMessage: "Ihr Konto wird geprüft"))
let viewModel = makeViewModel()
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.content)) { content in
guard case .pendingApproval = content else { return false }
return true
}
try await deferred.fulfill()
#expect(!viewModel.context.viewState.isApproved)
}
@Test
func editProfileEmitsAction() async throws {
apiService.membersSearchQueryReturnValue = try .success(makeResponse(userIDs: []))
let viewModel = makeViewModel()
let deferred = deferFulfillment(viewModel.actionsPublisher) { action in
guard case .editProfile = action else { return false }
return true
}
viewModel.context.send(viewAction: .editProfile)
try await deferred.fulfill()
}
@Test
func inviteEmitsAction() async throws {
apiService.membersSearchQueryReturnValue = try .success(makeResponse(userIDs: []))
let viewModel = makeViewModel()
let deferred = deferFulfillment(viewModel.actionsPublisher) { action in
guard case .invite = action else { return false }
return true
}
viewModel.context.send(viewAction: .invite)
try await deferred.fulfill()
}
// MARK: - Helpers
private func makeCompleteness(isComplete: Bool, message: String?) throws -> HealthChatProfileCompleteness {
let messageJSON = message.map { "\"\($0)\"" } ?? "null"
return try JSONDecoder().decode(HealthChatProfileCompleteness.self, from: Data("""
{ "isComplete": \(isComplete), "message": \(messageJSON) }
""".utf8))
}
private func makeViewModel() -> HealthChatMemberDirectoryScreenViewModel {
HealthChatMemberDirectoryScreenViewModel(apiService: apiService,
clientProxy: clientProxy,
mediaProvider: MediaProviderMock(.init()),
userIndicatorController: UserIndicatorControllerMock())
}
private func makeResponse(userIDs: [String]) throws -> HealthChatMembersResponse {
try .init(users: userIDs.map(makeMember(userID:)), isApproved: true, pendingMessage: nil)
}
private func makeMember(userID: String) throws -> HealthChatMember {
try JSONDecoder().decode(HealthChatMember.self, from: Data(#"{ "userId": "\#(userID)" }"#.utf8))
}
}