mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-02 03:06:37 +00:00
22d14ff8e4
* create DependenciesProtocol and replace ServiceLocator registration with it replace mocking calls for ServiceLocator to Dependencies replace ServiceLocator with instance level calls replace ServiceLocator configs with TestDependencies config in Tests replace servicelocator usage in analytics service replace remaining ServiceLocator calls in unit tests that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances fix swiftlint warning remove remaining references to ServiceLocator make dependencies properties consistent in tests delete Dependencies and DependenciesProtocol fix whitespace modifications updates from PR feedback a pass over converting AppSettings and AnalyticsService test instance properties to per test instantiation fix a missed PR feedback Sync up after rebase create DependenciesProtocol and replace ServiceLocator registration with it replace mocking calls for ServiceLocator to Dependencies replace ServiceLocator with instance level calls replace ServiceLocator configs with TestDependencies config in Tests replace servicelocator usage in analytics service replace remaining ServiceLocator calls in unit tests that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances fix swiftlint warning remove remaining references to ServiceLocator make dependencies properties consistent in tests delete Dependencies and DependenciesProtocol * AppSettings is instance level mockable now * replace mocked and preview usages of reset + AppSettings global init with AppSettings(store: UserDefaultsMock()) * AppSettings.UserDefaultsKeys is now a RawRep struct, making it extensible * update tests with new AppSettings so it builds * update remaining AppSettings test/mock inits * AppSettings.UserDefaultsKey conformed to ExpressibleByStringLiteral * addressed issues found in first pass ai review * update AppSettings instantiations after rebase * fix accessibility tests coordinator after rebase * Rename to VolatileUserDefaults * AppSettings init uses mandatory parameter * Revert UserDefaultsKey to enum * Add TrackedUserDefaults to be able to reset the defaults object * Added volatile static func to AppSettings * Use .volatile() static func instead of full init * review fixups * Resolve build issues after rebase * updated enterprise module * remove the static reset settings call from the preview tests --------- Co-authored-by: Mauro Romito <mauro.romito@element.io>
219 lines
9.2 KiB
Swift
219 lines
9.2 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
@testable import ElementX
|
|
import Testing
|
|
|
|
@MainActor
|
|
struct RoomMemberDetailsViewModelTests {
|
|
var clientProxy: ClientProxy!
|
|
var viewModel: RoomMemberDetailsScreenViewModelProtocol!
|
|
var roomProxyMock: JoinedRoomProxyMock!
|
|
var roomMemberProxyMock: RoomMemberProxyMock!
|
|
var context: RoomMemberDetailsScreenViewModelType.Context {
|
|
viewModel.context
|
|
}
|
|
|
|
@Test
|
|
mutating func initialState() async throws {
|
|
setup(roomMemberProxyMock: .mockAlice)
|
|
|
|
let waitForMemberToLoad = deferFulfillment(context.$viewState) { $0.memberDetails != nil }
|
|
try await waitForMemberToLoad.fulfill()
|
|
|
|
#expect(context.viewState.memberDetails == RoomMemberDetails(withProxy: roomMemberProxyMock))
|
|
#expect(context.ignoreUserAlert == nil)
|
|
#expect(context.alertInfo == nil)
|
|
}
|
|
|
|
@Test
|
|
mutating func ignoreSuccess() async throws {
|
|
setup(roomMemberProxyMock: .mockAlice)
|
|
|
|
let waitForMemberToLoad = deferFulfillment(context.$viewState) { $0.memberDetails != nil }
|
|
try await waitForMemberToLoad.fulfill()
|
|
|
|
context.send(viewAction: .showIgnoreAlert)
|
|
#expect(context.ignoreUserAlert == .init(action: .ignore))
|
|
context.send(viewAction: .ignoreConfirmed)
|
|
let deferred = deferFulfillment(context.$viewState) { state in
|
|
state.memberDetails?.isIgnored == true
|
|
}
|
|
try await deferred.fulfill()
|
|
|
|
let memberDetails = try #require(context.viewState.memberDetails,
|
|
"Member details should be loaded at this point")
|
|
#expect(memberDetails.isIgnored)
|
|
#expect(!context.viewState.isProcessingIgnoreRequest)
|
|
try await Task.sleep(for: .milliseconds(100))
|
|
#expect(roomProxyMock.updateMembersCalled)
|
|
}
|
|
|
|
@Test
|
|
mutating func ignoreFailure() async throws {
|
|
let clientProxy = ClientProxyMock(.init())
|
|
clientProxy.ignoreUserReturnValue = .failure(.sdkError(ClientProxyMockError.generic))
|
|
setup(roomMemberProxyMock: .mockAlice, clientProxy: clientProxy)
|
|
|
|
let waitForMemberToLoad = deferFulfillment(context.$viewState) { $0.memberDetails != nil }
|
|
try await waitForMemberToLoad.fulfill()
|
|
|
|
context.send(viewAction: .showIgnoreAlert)
|
|
#expect(context.ignoreUserAlert == .init(action: .ignore))
|
|
context.send(viewAction: .ignoreConfirmed)
|
|
let deferred = deferFulfillment(context.$viewState) { state in
|
|
state.bindings.alertInfo != nil
|
|
}
|
|
try await deferred.fulfill()
|
|
|
|
let memberDetails = try #require(context.viewState.memberDetails,
|
|
"Member details should be loaded at this point")
|
|
#expect(!memberDetails.isIgnored)
|
|
#expect(context.alertInfo != nil)
|
|
|
|
try await Task.sleep(for: .milliseconds(100))
|
|
#expect(!roomProxyMock.updateMembersCalled)
|
|
}
|
|
|
|
@Test
|
|
mutating func unignoreSuccess() async throws {
|
|
setup(roomMemberProxyMock: .mockIgnored)
|
|
|
|
let waitForMemberToLoad = deferFulfillment(context.$viewState) { $0.memberDetails != nil }
|
|
try await waitForMemberToLoad.fulfill()
|
|
|
|
context.send(viewAction: .showUnignoreAlert)
|
|
#expect(context.ignoreUserAlert == .init(action: .unignore))
|
|
context.send(viewAction: .unignoreConfirmed)
|
|
let deferred = deferFulfillment(context.$viewState) { state in
|
|
state.memberDetails?.isIgnored == false
|
|
}
|
|
try await deferred.fulfill()
|
|
|
|
let memberDetails = try #require(context.viewState.memberDetails,
|
|
"Member details should be loaded at this point")
|
|
#expect(!memberDetails.isIgnored)
|
|
|
|
try await Task.sleep(for: .milliseconds(100))
|
|
#expect(roomProxyMock.updateMembersCalled)
|
|
}
|
|
|
|
@Test
|
|
mutating func unignoreFailure() async throws {
|
|
let clientProxy = ClientProxyMock(.init())
|
|
clientProxy.unignoreUserReturnValue = .failure(.sdkError(ClientProxyMockError.generic))
|
|
setup(roomMemberProxyMock: .mockIgnored, clientProxy: clientProxy)
|
|
|
|
let waitForMemberToLoad = deferFulfillment(context.$viewState) { $0.memberDetails != nil }
|
|
try await waitForMemberToLoad.fulfill()
|
|
|
|
context.send(viewAction: .showUnignoreAlert)
|
|
#expect(context.ignoreUserAlert == .init(action: .unignore))
|
|
context.send(viewAction: .unignoreConfirmed)
|
|
let deferred = deferFulfillment(context.$viewState) { state in
|
|
state.bindings.alertInfo != nil
|
|
}
|
|
try await deferred.fulfill()
|
|
|
|
let memberDetails = try #require(context.viewState.memberDetails,
|
|
"Member details should be loaded at this point")
|
|
#expect(memberDetails.isIgnored)
|
|
#expect(context.alertInfo != nil)
|
|
|
|
try await Task.sleep(for: .milliseconds(100))
|
|
#expect(!roomProxyMock.updateMembersCalled)
|
|
}
|
|
|
|
@Test
|
|
mutating func initialStateAccountOwner() async throws {
|
|
setup(roomMemberProxyMock: .mockMe)
|
|
|
|
let waitForMemberToLoad = deferFulfillment(context.$viewState) { $0.memberDetails != nil }
|
|
try await waitForMemberToLoad.fulfill()
|
|
|
|
#expect(context.viewState.memberDetails == RoomMemberDetails(withProxy: roomMemberProxyMock))
|
|
#expect(context.ignoreUserAlert == nil)
|
|
#expect(context.alertInfo == nil)
|
|
}
|
|
|
|
@Test
|
|
mutating func initialStateIgnoredUser() async throws {
|
|
setup(roomMemberProxyMock: .mockIgnored)
|
|
|
|
let waitForMemberToLoad = deferFulfillment(context.$viewState) { $0.memberDetails != nil }
|
|
try await waitForMemberToLoad.fulfill()
|
|
|
|
#expect(context.viewState.memberDetails == RoomMemberDetails(withProxy: roomMemberProxyMock))
|
|
#expect(context.ignoreUserAlert == nil)
|
|
#expect(context.alertInfo == nil)
|
|
}
|
|
|
|
// MARK: - History Sharing
|
|
|
|
@Test
|
|
mutating func inviteConfirmationFetchesIdentity() async throws {
|
|
let clientProxy = ClientProxyMock(.init())
|
|
setup(roomMemberProxyMock: .mockBob, clientProxy: clientProxy)
|
|
|
|
let waitForMemberToLoad = deferFulfillment(context.$viewState) { $0.memberDetails != nil }
|
|
try await waitForMemberToLoad.fulfill()
|
|
|
|
clientProxy.directRoomForUserIDReturnValue = .success(nil)
|
|
clientProxy.userIdentityForFallBackToServerReturnValue = .success(UserIdentityProxyMock(configuration: .init(verificationState: .notVerified)))
|
|
|
|
// The user identity becomes known, i.e. not unknown.
|
|
let deferred = deferFulfillment(viewModel.context.$viewState.compactMap(\.bindings.inviteConfirmationUser)) {
|
|
!$0.isUnknown
|
|
}
|
|
context.send(viewAction: .openDirectChat)
|
|
try await deferred.fulfill()
|
|
|
|
#expect(clientProxy.userIdentityForFallBackToServerCalled)
|
|
}
|
|
|
|
@Test
|
|
mutating func inviteConfirmationFallsBackToUnknownIdentityOnFailure() async throws {
|
|
let clientProxy = ClientProxyMock(.init())
|
|
setup(roomMemberProxyMock: .mockBob, clientProxy: clientProxy)
|
|
|
|
let waitForMemberToLoad = deferFulfillment(context.$viewState) { $0.memberDetails != nil }
|
|
try await waitForMemberToLoad.fulfill()
|
|
|
|
clientProxy.directRoomForUserIDReturnValue = .success(nil)
|
|
clientProxy.userIdentityForFallBackToServerReturnValue = .failure(.forbiddenAccess)
|
|
|
|
// The user identity is always unknown, i.e. never not unknown.
|
|
let deferred = deferFailure(viewModel.context.$viewState.compactMap(\.bindings.inviteConfirmationUser), timeout: .seconds(5)) {
|
|
!$0.isUnknown
|
|
}
|
|
context.send(viewAction: .openDirectChat)
|
|
try await deferred.fulfill()
|
|
|
|
#expect(clientProxy.userIdentityForFallBackToServerCalled)
|
|
}
|
|
|
|
// MARK: - Helpers
|
|
|
|
private mutating func setup(roomMemberProxyMock: RoomMemberProxyMock, clientProxy: ClientProxyMock? = nil) {
|
|
self.roomMemberProxyMock = roomMemberProxyMock
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: ""))
|
|
roomProxyMock.getMemberUserIDClosure = { _ in
|
|
.success(roomMemberProxyMock)
|
|
}
|
|
|
|
// swiftlint:disable:next force_unwrapping
|
|
let userSession = clientProxy != nil ? UserSessionMock(.init(clientProxy: clientProxy!)) : UserSessionMock(.init())
|
|
viewModel = RoomMemberDetailsScreenViewModel(userID: roomMemberProxyMock.userID,
|
|
roomProxy: roomProxyMock,
|
|
userSession: userSession,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
analytics: AnalyticsServiceMock.default,
|
|
appSettings: .volatile())
|
|
}
|
|
}
|