mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-10-31 16:24:11 +00:00
a520d94760
* Enable Swift 6.2 with default main actor isolation for the app target Turn on SWIFT_VERSION 6.2, SWIFT_APPROACHABLE_CONCURRENCY and SWIFT_DEFAULT_ACTOR_ISOLATION = MainActor for the ElementX target, matching the NSE and Share Extension (which already use 6.2 without the main actor default). # Conflicts: # ElementX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved * Update the code generation templates for Swift 6 Emit nonisolated/@unchecked Sendable mocks and nonisolated string enums, and mark async mock methods @concurrent so they keep suspending like the real implementations (otherwise intermediate states are unobservable in tests). Includes the regenerated mocks and strings. # Conflicts: # ElementX/Sources/Mocks/Generated/GeneratedMocks.swift * Make the data layer and services nonisolated and Sendable Annotate the value-type models, Rust SDK proxy wrappers, timeline item graph, settings, logging and NSE-shared types as nonisolated, and conform the service protocols to Sendable so their existentials can cross isolation boundaries. These types run off the main actor and no longer inherit the target's default main actor isolation. * Adopt the new isolation across call sites, mocks and signatures Update call sites, closure signatures and mock configuration helpers to match the nonisolated/Sendable data layer, including the main actor isolated mock inits and the @Sendable filter on recentlyVisitedRooms. ^ Conflicts: ^ ElementX/Sources/Services/SecureBackup/SecureBackupController.swift * Remove redundant @MainActor annotations With the app target defaulting to main actor isolation, the explicit @MainActor on view models, coordinators, views and their protocols is no longer required. * Fix concurrency hotspots surfaced by the migration Resolve the room summary main-thread deadlock by moving diff processing onto AsyncStreams, add the SDKListener.onMainActor FIFO bridge for SDK callbacks, hop KVO/timer/UIKit callbacks to the main actor via assumeIsolated, add isolated deinits, and apply the few justified nonisolated(unsafe) escapes for queue-confined Apple APIs. * Fix the unit tests for Swift 6 concurrency Hop the waitForConfirmation body onto the caller's actor (Swift Testing runs confirmation closures off-actor), and adjust the affected suites and async signatures. * offload diffs on concurrent threads instead of main actor * make room info protocols sendable * use a task group for fetching data so that everything runs concurrently in the TextRoomTimelineView when getting the preview. * use the generic onMainActor implementation, which already makes a stream and send the continuation on the main actor. * small pr comments issues being addressed * update enterprise * Update StaticCode to 1.1.0 and specify the required Swift isolation. * fix ElementCallServiceTests * update enterprise * re-generate mocks * update enterprise * enterprise new code conformed to swift 6 --------- Co-authored-by: Doug <douglase@element.io>
228 lines
8.9 KiB
Swift
228 lines
8.9 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
@testable import ElementX
|
|
import Testing
|
|
|
|
@MainActor
|
|
final class JoinRoomScreenViewModelTests {
|
|
private enum TestMode {
|
|
case joined
|
|
case knocked
|
|
case invited
|
|
case banned
|
|
}
|
|
|
|
var viewModel: JoinRoomScreenViewModelProtocol!
|
|
|
|
var clientProxy: ClientProxyMock!
|
|
|
|
var context: JoinRoomScreenViewModelType.Context {
|
|
viewModel.context
|
|
}
|
|
|
|
private let appSettings: AppSettings
|
|
|
|
init() {
|
|
appSettings = AppSettings.volatile()
|
|
}
|
|
|
|
deinit {
|
|
viewModel = nil
|
|
clientProxy = nil
|
|
}
|
|
|
|
@Test
|
|
func interaction() async throws {
|
|
#expect(appSettings.seenInvites.isEmpty, "There shouldn't be any seen invites before running the tests.")
|
|
|
|
setupViewModel()
|
|
try await deferFulfillment(viewModel.context.$viewState) { $0.mode == .joinable }.fulfill()
|
|
|
|
#expect(appSettings.seenInvites.isEmpty, "Only an invited room should register the room ID as a seen invite.")
|
|
|
|
let deferred = deferFulfillment(viewModel.actionsPublisher) { $0 == .joined(.roomID("1")) }
|
|
context.send(viewAction: .join)
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func acceptInviteInteraction() async throws {
|
|
#expect(appSettings.seenInvites.isEmpty, "There shouldn't be any seen invites before running the tests.")
|
|
|
|
setupViewModel(mode: .invited)
|
|
try await deferFulfillment(viewModel.context.$viewState) { $0.mode == .invited(isDM: false) }.fulfill()
|
|
|
|
#expect(appSettings.seenInvites == ["1"], "The invited room's ID should be registered as a seen invite.")
|
|
|
|
let deferred = deferFulfillment(viewModel.actionsPublisher) { $0 == .joined(.roomID("1")) }
|
|
context.send(viewAction: .acceptInvite)
|
|
try await deferred.fulfill()
|
|
|
|
#expect(appSettings.seenInvites.isEmpty, "The after accepting an invite the invite should be forgotten in case the user leaves.")
|
|
}
|
|
|
|
@Test
|
|
func declineInviteInteraction() async throws {
|
|
#expect(appSettings.seenInvites.isEmpty, "There shouldn't be any seen invites before running the tests.")
|
|
|
|
setupViewModel(mode: .invited)
|
|
|
|
try await deferFulfillment(viewModel.context.$viewState) { $0.mode == .invited(isDM: false) }.fulfill()
|
|
#expect(appSettings.seenInvites == ["1"], "The invited room's ID should be registered as a seen invite.")
|
|
|
|
context.send(viewAction: .declineInvite)
|
|
|
|
#expect(viewModel.context.alertInfo?.id == .declineInvite)
|
|
let deferred = deferFulfillment(viewModel.actionsPublisher) { $0 == .dismiss }
|
|
context.alertInfo?.secondaryButton?.action?()
|
|
try await deferred.fulfill()
|
|
|
|
#expect(appSettings.seenInvites.isEmpty, "The after declining an invite the invite should be forgotten in case another invite is received.")
|
|
}
|
|
|
|
@Test
|
|
func knockedState() async throws {
|
|
#expect(appSettings.seenInvites.isEmpty, "There shouldn't be any seen invites before running the tests.")
|
|
setupViewModel(mode: .knocked)
|
|
|
|
try await deferFulfillment(viewModel.context.$viewState) { $0.mode == .knocked }.fulfill()
|
|
|
|
#expect(appSettings.seenInvites.isEmpty, "Only an invited room should register the room ID as a seen invite.")
|
|
}
|
|
|
|
@Test
|
|
func cancelKnock() async throws {
|
|
setupViewModel(mode: .knocked)
|
|
|
|
try await deferFulfillment(viewModel.context.$viewState) { state in
|
|
state.mode == .knocked
|
|
}.fulfill()
|
|
|
|
context.send(viewAction: .cancelKnock)
|
|
#expect(viewModel.context.alertInfo?.id == .cancelKnock)
|
|
|
|
let deferred = deferFulfillment(viewModel.actionsPublisher) { action in
|
|
action == .dismiss
|
|
}
|
|
context.alertInfo?.secondaryButton?.action?()
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func declineAndBlockInviteLegacyInteraction() async throws {
|
|
setupViewModel(mode: .invited)
|
|
clientProxy.underlyingIsReportRoomSupported = false
|
|
|
|
try await deferFulfillment(viewModel.context.$viewState) { $0.roomDetails != nil }.fulfill()
|
|
|
|
context.send(viewAction: .declineInviteAndBlock(userID: "@test:matrix.org"))
|
|
|
|
try await deferFulfillment(viewModel.context.$viewState) { $0.bindings.alertInfo != nil }.fulfill()
|
|
#expect(viewModel.context.alertInfo?.id == .declineInviteAndBlock)
|
|
|
|
let deferred = deferFulfillment(viewModel.actionsPublisher) { action in
|
|
action == .dismiss
|
|
}
|
|
|
|
await waitForConfirmation("Wait for the user to be ignored") { confirm in
|
|
clientProxy.ignoreUserClosure = { userID in
|
|
defer { confirm() }
|
|
#expect(userID == "@test:matrix.org")
|
|
return .success(())
|
|
}
|
|
context.alertInfo?.secondaryButton?.action?()
|
|
}
|
|
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func declineAndBlockInviteInteraction() async throws {
|
|
setupViewModel(mode: .invited)
|
|
try await deferFulfillment(viewModel.context.$viewState) { $0.roomDetails != nil }.fulfill()
|
|
let deferredAction = deferFulfillment(viewModel.actionsPublisher) { $0 == .presentDeclineAndBlock(userID: "@test:matrix.org") }
|
|
context.send(viewAction: .declineInviteAndBlock(userID: "@test:matrix.org"))
|
|
try await deferredAction.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func forgetRoom() async throws {
|
|
setupViewModel(mode: .banned)
|
|
|
|
try await deferFulfillment(viewModel.context.$viewState) { $0.roomDetails != nil }.fulfill()
|
|
|
|
let deferred = deferFulfillment(viewModel.actionsPublisher) { action in
|
|
action == .dismiss
|
|
}
|
|
context.send(viewAction: .forget)
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
// MARK: - Helpers
|
|
|
|
private func setupViewModel(throwing: Bool = false, mode: TestMode = .joined) {
|
|
clientProxy = ClientProxyMock(.init())
|
|
|
|
clientProxy.joinRoomViaReturnValue = throwing ? .failure(.sdkError(ClientProxyMockError.generic)) : .success(())
|
|
clientProxy.joinRoomAliasReturnValue = clientProxy.joinRoomViaReturnValue
|
|
|
|
switch mode {
|
|
case .knocked:
|
|
clientProxy.roomPreviewForIdentifierViaReturnValue = .success(RoomPreviewProxyMock.knocked)
|
|
|
|
clientProxy.roomForIdentifierClosure = { _ in
|
|
let roomProxy = KnockedRoomProxyMock(.init())
|
|
// to test the cancel knock function
|
|
roomProxy.cancelKnockReturnValue = .success(())
|
|
return .knocked(roomProxy)
|
|
}
|
|
case .joined:
|
|
clientProxy.roomPreviewForIdentifierViaReturnValue = .success(RoomPreviewProxyMock.joinable)
|
|
case .invited:
|
|
clientProxy.roomPreviewForIdentifierViaReturnValue = .success(RoomPreviewProxyMock.invited())
|
|
clientProxy.roomForIdentifierClosure = { _ in
|
|
let roomProxy = InvitedRoomProxyMock(.init())
|
|
roomProxy.rejectInvitationReturnValue = .success(())
|
|
return .invited(roomProxy)
|
|
}
|
|
case .banned:
|
|
clientProxy.roomPreviewForIdentifierViaReturnValue = .success(RoomPreviewProxyMock.banned)
|
|
clientProxy.roomForIdentifierClosure = { _ in
|
|
let roomProxy = BannedRoomProxyMock(.init())
|
|
roomProxy.forgetRoomReturnValue = .success(())
|
|
return .banned(roomProxy)
|
|
}
|
|
}
|
|
|
|
viewModel = JoinRoomScreenViewModel(source: .generic(roomID: "1", via: []),
|
|
appSettings: appSettings,
|
|
userSession: UserSessionMock(.init(clientProxy: clientProxy)),
|
|
userIndicatorController: UserIndicatorControllerMock())
|
|
}
|
|
}
|
|
|
|
@MainActor
|
|
extension JoinRoomScreenViewModelAction: @MainActor @retroactive Equatable {
|
|
/// A close enough approximation for tests.
|
|
public static func == (lhs: JoinRoomScreenViewModelAction, rhs: JoinRoomScreenViewModelAction) -> Bool {
|
|
switch (lhs, rhs) {
|
|
case (.joined(.roomID(let lhsRoomID)), .joined(.roomID(let rhsRoomID))):
|
|
lhsRoomID == rhsRoomID
|
|
case (.joined(.space(let lhsSpace)), .joined(.space(let rhsSpace))):
|
|
lhsSpace.id == rhsSpace.id
|
|
case (.dismiss, .dismiss):
|
|
true
|
|
case (.presentDeclineAndBlock(let lhsUserID), .presentDeclineAndBlock(let rhsUserID)):
|
|
lhsUserID == rhsUserID
|
|
default:
|
|
false
|
|
}
|
|
}
|
|
}
|