mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-10-31 16:24:11 +00:00
a520d94760
* Enable Swift 6.2 with default main actor isolation for the app target Turn on SWIFT_VERSION 6.2, SWIFT_APPROACHABLE_CONCURRENCY and SWIFT_DEFAULT_ACTOR_ISOLATION = MainActor for the ElementX target, matching the NSE and Share Extension (which already use 6.2 without the main actor default). # Conflicts: # ElementX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved * Update the code generation templates for Swift 6 Emit nonisolated/@unchecked Sendable mocks and nonisolated string enums, and mark async mock methods @concurrent so they keep suspending like the real implementations (otherwise intermediate states are unobservable in tests). Includes the regenerated mocks and strings. # Conflicts: # ElementX/Sources/Mocks/Generated/GeneratedMocks.swift * Make the data layer and services nonisolated and Sendable Annotate the value-type models, Rust SDK proxy wrappers, timeline item graph, settings, logging and NSE-shared types as nonisolated, and conform the service protocols to Sendable so their existentials can cross isolation boundaries. These types run off the main actor and no longer inherit the target's default main actor isolation. * Adopt the new isolation across call sites, mocks and signatures Update call sites, closure signatures and mock configuration helpers to match the nonisolated/Sendable data layer, including the main actor isolated mock inits and the @Sendable filter on recentlyVisitedRooms. ^ Conflicts: ^ ElementX/Sources/Services/SecureBackup/SecureBackupController.swift * Remove redundant @MainActor annotations With the app target defaulting to main actor isolation, the explicit @MainActor on view models, coordinators, views and their protocols is no longer required. * Fix concurrency hotspots surfaced by the migration Resolve the room summary main-thread deadlock by moving diff processing onto AsyncStreams, add the SDKListener.onMainActor FIFO bridge for SDK callbacks, hop KVO/timer/UIKit callbacks to the main actor via assumeIsolated, add isolated deinits, and apply the few justified nonisolated(unsafe) escapes for queue-confined Apple APIs. * Fix the unit tests for Swift 6 concurrency Hop the waitForConfirmation body onto the caller's actor (Swift Testing runs confirmation closures off-actor), and adjust the affected suites and async signatures. * offload diffs on concurrent threads instead of main actor * make room info protocols sendable * use a task group for fetching data so that everything runs concurrently in the TextRoomTimelineView when getting the preview. * use the generic onMainActor implementation, which already makes a stream and send the continuation on the main actor. * small pr comments issues being addressed * update enterprise * Update StaticCode to 1.1.0 and specify the required Swift isolation. * fix ElementCallServiceTests * update enterprise * re-generate mocks * update enterprise * enterprise new code conformed to swift 6 --------- Co-authored-by: Doug <douglase@element.io>
146 lines
5.8 KiB
Swift
146 lines
5.8 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2024-2025 New Vector Ltd.
|
|
// Copyright 2021-2025 The Matrix.org Foundation C.I.C
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import Foundation
|
|
import MatrixRustSDK
|
|
|
|
/// Logging utility that provies multiple logging levels as well as file output and rolling.
|
|
/// Its purpose is to provide a common entry for customizing logging and should be used throughout the code.
|
|
nonisolated enum MXLog {
|
|
private nonisolated(unsafe) static var rootSpan: Span!
|
|
private nonisolated(unsafe) static var currentTarget: String!
|
|
|
|
static func configure(currentTarget: String) {
|
|
self.currentTarget = currentTarget
|
|
|
|
rootSpan = Span(file: #file, line: #line, level: .info, target: self.currentTarget, name: "root", bridgeTraceId: nil)
|
|
rootSpan.enter()
|
|
}
|
|
|
|
static func createSpan(_ name: String,
|
|
file: String = #file,
|
|
function: String = #function,
|
|
line: Int = #line,
|
|
column: Int = #column) -> Span {
|
|
createSpan(name, level: .info, file: file, function: function, line: line, column: column)
|
|
}
|
|
|
|
static func verbose(_ message: Any,
|
|
file: String = #file,
|
|
function: String = #function,
|
|
line: Int = #line,
|
|
column: Int = #column) {
|
|
log(message, level: .trace, file: file, function: function, line: line, column: column)
|
|
}
|
|
|
|
static func debug(_ message: Any,
|
|
file: String = #file,
|
|
function: String = #function,
|
|
line: Int = #line,
|
|
column: Int = #column) {
|
|
log(message, level: .debug, file: file, function: function, line: line, column: column)
|
|
}
|
|
|
|
static func info(_ message: Any,
|
|
file: String = #file,
|
|
function: String = #function,
|
|
line: Int = #line,
|
|
column: Int = #column) {
|
|
log(message, level: .info, file: file, function: function, line: line, column: column)
|
|
}
|
|
|
|
static func warning(_ message: Any,
|
|
file: String = #file,
|
|
function: String = #function,
|
|
line: Int = #line,
|
|
column: Int = #column) {
|
|
log(message, level: .warn, file: file, function: function, line: line, column: column)
|
|
}
|
|
|
|
/// Log error.
|
|
///
|
|
/// - Parameters:
|
|
/// - message: Description of the error without any variables (this is to improve error aggregations by type)
|
|
static func error(_ message: Any,
|
|
file: String = #file,
|
|
function: String = #function,
|
|
line: Int = #line,
|
|
column: Int = #column) {
|
|
log(message, level: .error, file: file, function: function, line: line, column: column)
|
|
}
|
|
|
|
/// Log failure.
|
|
///
|
|
/// A failure is any type of programming error which should never occur in production. In `DEBUG` configuration
|
|
/// any failure will raise `assertionFailure`
|
|
///
|
|
/// - Parameters:
|
|
/// - message: Description of the error without any variables (this is to improve error aggregations by type)
|
|
static func failure(_ message: Any,
|
|
file: String = #file,
|
|
function: String = #function,
|
|
line: Int = #line,
|
|
column: Int = #column) {
|
|
log(message, level: .error, file: file, function: function, line: line, column: column)
|
|
|
|
#if DEBUG
|
|
assertionFailure("\(message)")
|
|
#endif
|
|
}
|
|
|
|
#if DEBUG
|
|
private static let devPrefix = URL.documentsDirectory.pathComponents[2].uppercased()
|
|
/// A helper method for print debugging, only available on debug builds.
|
|
///
|
|
/// When running on the simulator this will log `[USERNAME] message` so that
|
|
/// you can easily filter the Xcode console to see only the logs you're interested in.
|
|
static func dev(_ message: Any,
|
|
file: String = #file,
|
|
function: String = #function,
|
|
line: Int = #line,
|
|
column: Int = #column) {
|
|
log("[\(devPrefix)] \(message)", level: .info, file: file, function: function, line: line, column: column)
|
|
}
|
|
#endif
|
|
|
|
// MARK: - Private
|
|
|
|
// periphery:ignore:parameters function,column
|
|
private static func createSpan(_ name: String,
|
|
level: LogLevel,
|
|
file: String = #file,
|
|
function: String = #function,
|
|
line: Int = #line,
|
|
column: Int = #column) -> Span {
|
|
if Span.current().isNone() {
|
|
rootSpan.enter()
|
|
}
|
|
|
|
return Span(file: file, line: UInt32(line), level: level.rustLogLevel, target: currentTarget, name: name, bridgeTraceId: nil)
|
|
}
|
|
|
|
// periphery:ignore:parameters function,column
|
|
private static func log(_ message: Any,
|
|
level: LogLevel,
|
|
file: String = #file,
|
|
function: String = #function,
|
|
line: Int = #line,
|
|
column: Int = #column) {
|
|
guard let rootSpan else {
|
|
return
|
|
}
|
|
|
|
if Span.current().isNone() {
|
|
rootSpan.enter()
|
|
}
|
|
|
|
logEvent(file: (file as NSString).lastPathComponent, line: UInt32(line), level: level.rustLogLevel, target: currentTarget, message: "\(message)")
|
|
}
|
|
}
|