mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-10-31 16:24:11 +00:00
a520d94760
* Enable Swift 6.2 with default main actor isolation for the app target Turn on SWIFT_VERSION 6.2, SWIFT_APPROACHABLE_CONCURRENCY and SWIFT_DEFAULT_ACTOR_ISOLATION = MainActor for the ElementX target, matching the NSE and Share Extension (which already use 6.2 without the main actor default). # Conflicts: # ElementX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved * Update the code generation templates for Swift 6 Emit nonisolated/@unchecked Sendable mocks and nonisolated string enums, and mark async mock methods @concurrent so they keep suspending like the real implementations (otherwise intermediate states are unobservable in tests). Includes the regenerated mocks and strings. # Conflicts: # ElementX/Sources/Mocks/Generated/GeneratedMocks.swift * Make the data layer and services nonisolated and Sendable Annotate the value-type models, Rust SDK proxy wrappers, timeline item graph, settings, logging and NSE-shared types as nonisolated, and conform the service protocols to Sendable so their existentials can cross isolation boundaries. These types run off the main actor and no longer inherit the target's default main actor isolation. * Adopt the new isolation across call sites, mocks and signatures Update call sites, closure signatures and mock configuration helpers to match the nonisolated/Sendable data layer, including the main actor isolated mock inits and the @Sendable filter on recentlyVisitedRooms. ^ Conflicts: ^ ElementX/Sources/Services/SecureBackup/SecureBackupController.swift * Remove redundant @MainActor annotations With the app target defaulting to main actor isolation, the explicit @MainActor on view models, coordinators, views and their protocols is no longer required. * Fix concurrency hotspots surfaced by the migration Resolve the room summary main-thread deadlock by moving diff processing onto AsyncStreams, add the SDKListener.onMainActor FIFO bridge for SDK callbacks, hop KVO/timer/UIKit callbacks to the main actor via assumeIsolated, add isolated deinits, and apply the few justified nonisolated(unsafe) escapes for queue-confined Apple APIs. * Fix the unit tests for Swift 6 concurrency Hop the waitForConfirmation body onto the caller's actor (Swift Testing runs confirmation closures off-actor), and adjust the affected suites and async signatures. * offload diffs on concurrent threads instead of main actor * make room info protocols sendable * use a task group for fetching data so that everything runs concurrently in the TextRoomTimelineView when getting the preview. * use the generic onMainActor implementation, which already makes a stream and send the continuation on the main actor. * small pr comments issues being addressed * update enterprise * Update StaticCode to 1.1.0 and specify the required Swift isolation. * fix ElementCallServiceTests * update enterprise * re-generate mocks * update enterprise * enterprise new code conformed to swift 6 --------- Co-authored-by: Doug <douglase@element.io>
270 lines
10 KiB
Swift
270 lines
10 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import Combine
|
|
import MatrixRustSDK
|
|
import SwiftUI
|
|
|
|
typealias InviteUsersScreenViewModelType = StateStoreViewModel<InviteUsersScreenViewState, InviteUsersScreenViewAction>
|
|
|
|
class InviteUsersScreenViewModel: InviteUsersScreenViewModelType, InviteUsersScreenViewModelProtocol {
|
|
private let clientProxy: ClientProxyProtocol
|
|
private let roomType: InviteUsersScreenRoomType
|
|
private let userDiscoveryService: UserDiscoveryServiceProtocol
|
|
private let userIndicatorController: UserIndicatorControllerProtocol
|
|
private let appSettings: AppSettings
|
|
|
|
private var suggestedUsers = [UserProfileProxy]()
|
|
|
|
private let actionsSubject: PassthroughSubject<InviteUsersScreenViewModelAction, Never> = .init()
|
|
var actions: AnyPublisher<InviteUsersScreenViewModelAction, Never> {
|
|
actionsSubject.eraseToAnyPublisher()
|
|
}
|
|
|
|
init(userSession: UserSessionProtocol,
|
|
roomType: InviteUsersScreenRoomType,
|
|
isSkippable: Bool,
|
|
userDiscoveryService: UserDiscoveryServiceProtocol,
|
|
userIndicatorController: UserIndicatorControllerProtocol,
|
|
appSettings: AppSettings) {
|
|
clientProxy = userSession.clientProxy
|
|
self.roomType = roomType
|
|
self.userDiscoveryService = userDiscoveryService
|
|
self.userIndicatorController = userIndicatorController
|
|
self.appSettings = appSettings
|
|
|
|
let mandatoryInvitees: [UserProfileProxy] = if case .draft(let invitees) = roomType { invitees } else { [] }
|
|
|
|
super.init(initialViewState: InviteUsersScreenViewState(selectedUsers: mandatoryInvitees,
|
|
mandatoryInvitees: mandatoryInvitees,
|
|
isSkippable: isSkippable),
|
|
mediaProvider: userSession.mediaProvider)
|
|
|
|
setupSubscriptions()
|
|
fetchMembersIfNeeded()
|
|
|
|
Task {
|
|
suggestedUsers = await userSession.clientProxy.recentConversationCounterparts()
|
|
|
|
if state.usersSection.type == .suggestions {
|
|
state.usersSection = .init(type: .suggestions, users: suggestedUsers)
|
|
}
|
|
}
|
|
}
|
|
|
|
// MARK: - Public
|
|
|
|
override func process(viewAction: InviteUsersScreenViewAction) {
|
|
switch viewAction {
|
|
case .cancel:
|
|
actionsSubject.send(.dismiss)
|
|
case .proceed:
|
|
switch roomType {
|
|
case .draft:
|
|
createDraftRoom(mandatoryUserIDs: state.selectedUsers.map(\.userID))
|
|
case .existingRoom(let roomProxy):
|
|
guard roomProxy.details.historySharingState != RoomHistorySharingState.hidden,
|
|
!state.usersToConfirm.isEmpty,
|
|
!state.isSkippable else {
|
|
inviteUsers(state.selectedUsers.map(\.userID), roomProxy: roomProxy)
|
|
return
|
|
}
|
|
state.bindings.presentConfirmationDialog = true
|
|
}
|
|
case .removeUnknownUsers:
|
|
state.bindings.presentConfirmationDialog = false
|
|
state.selectedUsers.removeAll { user in
|
|
state.usersToConfirm.contains { $0.userID == user.userID }
|
|
}
|
|
state.usersToConfirm = []
|
|
case .confirmUnknownUsers:
|
|
state.bindings.presentConfirmationDialog = false
|
|
state.usersToConfirm = []
|
|
if case .existingRoom(let roomProxy) = roomType {
|
|
inviteUsers(state.selectedUsers.map(\.userID), roomProxy: roomProxy)
|
|
}
|
|
case .toggleUser(let user):
|
|
toggleUser(user)
|
|
}
|
|
}
|
|
|
|
// MARK: - Private
|
|
|
|
private func toggleUser(_ user: UserProfileProxy) {
|
|
guard !state.isInviteeMandatory(user) else { return }
|
|
|
|
if state.selectedUsers.contains(user) {
|
|
state.selectedUsers.removeAll { $0.userID == user.userID }
|
|
} else {
|
|
state.selectedUsers.append(user)
|
|
withElementAnimation(.easeInOut) { state.bindings.selectedUsersPosition = user.userID }
|
|
Task {
|
|
let identityUnknown = if case .success(let identity) = await self.clientProxy.userIdentity(for: user.userID, fallBackToServer: false) {
|
|
identity == nil
|
|
} else {
|
|
true
|
|
}
|
|
if identityUnknown {
|
|
// If we do not have the identity cached, we will prompt the user to confirm they meant to invite them.
|
|
self.state.usersToConfirm.append(user)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
private func createDraftRoom(mandatoryUserIDs: [String]) {
|
|
showLoadingIndicator(title: L10n.commonCreatingRoom)
|
|
|
|
Task {
|
|
defer { hideLoadingIndicator() }
|
|
|
|
switch await clientProxy.createRoom(name: nil,
|
|
topic: nil,
|
|
accessType: .private,
|
|
isSpace: false,
|
|
userIDs: mandatoryUserIDs,
|
|
avatarURL: nil,
|
|
aliasLocalPart: nil) {
|
|
case .success(let roomID):
|
|
actionsSubject.send(.openRoom(roomID: roomID))
|
|
case .failure:
|
|
state.bindings.alertInfo = .init(id: .unknown,
|
|
title: L10n.commonError,
|
|
message: L10n.screenStartChatErrorStartingChat)
|
|
}
|
|
}
|
|
}
|
|
|
|
private func inviteUsers(_ users: [String], roomProxy: JoinedRoomProxyProtocol) {
|
|
showLoadingIndicator(title: L10n.screenRoomDetailsInvitePeoplePreparing, message: L10n.screenRoomDetailsInvitePeopleDontClose)
|
|
|
|
Task {
|
|
defer {
|
|
hideLoadingIndicator()
|
|
actionsSubject.send(.dismiss)
|
|
}
|
|
|
|
let result: Result<Void, RoomProxyError> = await withTaskGroup(of: Result<Void, RoomProxyError>.self) { group in
|
|
for user in users {
|
|
group.addTask {
|
|
await roomProxy.invite(userID: user)
|
|
}
|
|
}
|
|
|
|
for await inviteResult in group where inviteResult.isFailure {
|
|
return inviteResult
|
|
}
|
|
|
|
return .success(())
|
|
}
|
|
|
|
guard case .failure = result else {
|
|
return
|
|
}
|
|
|
|
state.bindings.alertInfo = .init(id: .unknown,
|
|
title: L10n.commonUnableToInviteTitle,
|
|
message: L10n.commonUnableToInviteMessage)
|
|
}
|
|
}
|
|
|
|
private func buildMembershipStateIfNeeded(members: [RoomMemberProxyProtocol]) {
|
|
showLoadingIndicator()
|
|
|
|
Task.detached { [members] in
|
|
// accessing RoomMember's properties is very slow. We need to do it in a background thread.
|
|
let membershipState = members
|
|
.reduce(into: [String: MembershipState]()) { partialResult, member in
|
|
partialResult[member.userID] = member.membership
|
|
}
|
|
|
|
Task { @MainActor in
|
|
self.state.membershipState = membershipState
|
|
self.hideLoadingIndicator()
|
|
}
|
|
}
|
|
}
|
|
|
|
// periphery:ignore - automatically cancelled when set to nil
|
|
@CancellableTask
|
|
private var fetchUsersTask: Task<Void, Never>?
|
|
|
|
private func setupSubscriptions() {
|
|
context.$viewState
|
|
.map(\.bindings.searchQuery)
|
|
.debounceTextQueriesAndRemoveDuplicates()
|
|
.sink { [weak self] _ in
|
|
self?.fetchUsers()
|
|
}
|
|
.store(in: &cancellables)
|
|
}
|
|
|
|
private func fetchMembersIfNeeded() {
|
|
guard case .existingRoom(let roomProxy) = roomType else { return }
|
|
|
|
Task {
|
|
showLoadingIndicator()
|
|
await roomProxy.updateMembers()
|
|
hideLoadingIndicator()
|
|
}
|
|
|
|
roomProxy.membersPublisher
|
|
.filter { !$0.isEmpty }
|
|
.first()
|
|
.receive(on: DispatchQueue.main)
|
|
.sink { [weak self] members in
|
|
self?.buildMembershipStateIfNeeded(members: members)
|
|
}
|
|
.store(in: &cancellables)
|
|
}
|
|
|
|
private func fetchUsers() {
|
|
guard searchQuery.count >= 3 else {
|
|
state.usersSection = .init(type: .suggestions, users: suggestedUsers)
|
|
return
|
|
}
|
|
|
|
state.isSearching = true
|
|
|
|
fetchUsersTask = Task {
|
|
let result = await userDiscoveryService.searchProfiles(with: searchQuery)
|
|
|
|
guard !Task.isCancelled else { return }
|
|
|
|
state.isSearching = false
|
|
|
|
switch result {
|
|
case .success(let users):
|
|
state.usersSection = .init(type: .searchResult, users: users)
|
|
case .failure:
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
private var searchQuery: String {
|
|
context.searchQuery
|
|
}
|
|
|
|
private let userIndicatorID = UUID().uuidString
|
|
|
|
private func showLoadingIndicator(title: String = L10n.commonLoading,
|
|
message: String? = nil) {
|
|
userIndicatorController.submitIndicator(UserIndicator(id: userIndicatorID,
|
|
type: .modal,
|
|
title: title,
|
|
message: message,
|
|
persistent: true),
|
|
delay: .milliseconds(200))
|
|
}
|
|
|
|
private func hideLoadingIndicator() {
|
|
userIndicatorController.retractIndicatorWithId(userIndicatorID)
|
|
}
|
|
}
|