mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-10-31 08:15:24 +00:00
joel.poyet
34523cf51a
ClassicAppManager migrates an existing user's session and encryption keys by reading the legacy app's app-group container and keychain. Those identifiers defaulted to Element's own, which this team cannot provision, so loadAccounts() threw invalidAppGroupIdentifier — caught and logged, never surfaced. Since both apps share a bundle id, the result would be every existing user silently logged out and losing local history when they update. The legacy identifiers belong to HealthChat and are provisionable under the same team, so repoint them rather than dropping them. Also stop sending accounts without key backup to a dead end. Upstream shows those users a sheet asking them to open Element Classic and set up backup first, but this update replaces that app and nothing registers its URL scheme, so the sheet's only button does nothing. Sign in directly instead: the user re-verifies the device and loses only history that by definition has no backup.
22 lines
1.3 KiB
YAML
22 lines
1.3 KiB
YAML
# HealthChat product identity.
|
|
# Included permanently from project.yml (this fork always builds as HealthChat).
|
|
# Only build-setting scalars belong here — XcodeGen concatenates arrays on include-merge,
|
|
# so entitlement arrays (associated-domains, app-groups, keychain-groups) are edited directly
|
|
# in ElementX/SupportingFiles/target.yml instead.
|
|
# NB: APP_NAME (internal PRODUCT_NAME / module name) is intentionally left as ElementX so that
|
|
# `@testable import ElementX` and $(PRODUCT_MODULE_NAME) keep working.
|
|
settings:
|
|
APP_DISPLAY_NAME: HealthChat
|
|
PRODUCTION_APP_NAME: HealthChat
|
|
APP_GROUP_IDENTIFIER: group.ch.healthchat
|
|
BASE_BUNDLE_IDENTIFIER: ch.healthchat.element
|
|
DEVELOPMENT_TEAM: 6G37K72W82
|
|
|
|
# The legacy element-ios HealthChat's identifiers. ClassicAppManager reads the account and
|
|
# crypto-store keys from these to migrate existing users on an in-place update. Upstream's
|
|
# defaults in app.yml point at Element's own (group.im.vector / im.vector.app.*), which this
|
|
# team cannot provision — repoint, never remove. Failure here is silent.
|
|
CLASSIC_APP_GROUP_IDENTIFIER: group.ch.healthchat
|
|
CLASSIC_APP_KEYCHAIN_SERVICE_IDENTIFIER: ch.healthchat.element.encryption-manager-service
|
|
CLASSIC_APP_KEYCHAIN_ACCESS_GROUP_IDENTIFIER: "$(DEVELOPMENT_TEAM).ch.healthchat.element.keychain.shared"
|