mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-10-31 16:24:11 +00:00
Mauro
b1ed870474
* Run the tests on iOS 27.0 Bump the required simulator OS in the preview, UI and Compound tests, and the CI tool's default OS, from 26.5 to 27.0. Test devices stay the same. iOS 27 writes transcoded videos 146 bytes larger, so update the expected sizes in MediaUploadingPreprocessorTests. * Build and test on CI with Xcode 27 Select Xcode 27 in ci_common.sh and move every macOS workflow to the xcode-27 runner image, as macos-26 doesn't include Xcode 27. The Compound workflow now also creates its simulator on the iOS 27.0 runtime. The xcode-27 runners are slower, so give the unit, Enterprise, Compound and snapshot recording jobs longer timeouts. * Fix the preview snapshot layout on iOS 27 On iOS 27 the hosting controller applies the window's safe area when rendering, but the snapshot size comes from sizeThatFits, which ignores it. Component previews were shifted down and clipped at the bottom. Disable the hosting controller's safe area regions for these snapshots so the measured and rendered layouts match. swift-snapshot-testing also renders into a window without a scene, and on iOS 27 a navigation stack in such a window reserves space for a large title it never shows, leaving a gap below the navigation bar. Attach the render window to the app's scene until swift-snapshot-testing handles it. The invite users and add rooms screens sized their selected items row from a measured width stored in state, which is zero on the first layout pass, so snapshots could draw the row empty. Use containerRelativeFrame instead. The add rooms search previews now also wait for their results, and the search previews that show a clear button get a small precision tolerance, as it renders inconsistently in snapshots. * Re-record the preview snapshots on iOS 27.0 Recorded on an iPhone SE (3rd generation) simulator running iOS 27.0 with Xcode 27.0 (27A266a). The changes come from iOS 27 rendering: text anti-aliasing, hyphenation and line breaking, navigation bars and toggles that now render in snapshots, lazy stacks that were blank on iOS 26, and pseudo-language locale formatting. * Fix the UI tests on iOS 27 iOS 27 no longer exposes accessibility identifiers on SwiftUI menu items, so the space exploration test now finds them by label within the menu. On iPad, the start chat search field keeps focus after submitting and can swallow the next tap, so retry the tap if the create room screen doesn't appear. * Re-record the UI test snapshots on iOS 27.0 Recorded on iPhone 17 and iPad (A16) simulators running iOS 27.0 with Xcode 27.0. The changes come from iOS 27 styling, like the keyboard height and glass borders. This also removes the iPad app lock setup snapshots, which have been orphaned since those tests stopped running on iPad. * Fix the accessibility tests crashing on iOS 27 The accessibility tests' previews wrapper kept its ImageRenderer alive across the awaits that follow the render. On iOS 27, releasing it at that point tears down its view graph outside of a SwiftUI update, which hits an assertion and crashes the app. Release the renderer as soon as the image has been rendered. * Keep the accessibility tests' image renderers alive on iOS 27 Releasing the ImageRenderer straight away wasn't enough: on iOS 27, releasing one that rendered a preview crashes SwiftUI whichever context it happens in. Keep the renderers alive instead. Each test launches a fresh app, so they only live for the one test. * Share the UI tests' app settings with their mock user session Since the user session flow reads its settings from UserSettings, the UI tests' mock user session was wrapping a fresh volatile AppSettings instead of the one the tests configure. The flags that skip onboarding weren't picked up, so every user session UI test got stuck on the notifications permission screen. * Re-record the Compound snapshots on iOS 27.0 Apply the same safe area fix as the app's preview tests, so size-that-fits snapshots aren't clipped on iOS 27, and re-record the snapshots on an iPhone SE (3rd generation) simulator running iOS 27.0 in English (US). * Fix a race reading the keyboard in the accessibility tests On iOS 27 the QR code login screen's keyboard can be dismissing between checking that it exists and reading its frame, which fails the test. Snapshot it in a single query instead.
85 lines
4.3 KiB
Swift
85 lines
4.3 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import XCTest
|
|
|
|
@MainActor
|
|
class StartChatTests: XCTestCase {
|
|
enum Step {
|
|
static let startChat = 1
|
|
static let startChatWithResults = 2
|
|
static let createRoom = 3
|
|
static let createRoomFilled = 5
|
|
static let inviteUsers = 6
|
|
static let inviteUsersWithResults = 7
|
|
static let inviteUsersSelectedResults = 8
|
|
static let dismissed = 99
|
|
}
|
|
|
|
func testFlow() async throws {
|
|
let app = Application.launch(.startChatFlow)
|
|
try await app.assertScreenshot(step: Step.startChat)
|
|
|
|
let startChatSearchField = app.searchFields.firstMatch
|
|
startChatSearchField.clearAndTypeText("Bob\n", app: app)
|
|
XCTAssertFalse(app.staticTexts[A11yIdentifiers.startChatScreen.searchNoResults].waitForExistence(timeout: 1.0))
|
|
XCTAssertEqual(app.collectionViews.firstMatch.cells.count, 2)
|
|
try await app.assertScreenshot(step: Step.startChatWithResults)
|
|
|
|
startChatSearchField.clearAndTypeText("\n", app: app)
|
|
app.buttons[A11yIdentifiers.startChatScreen.createRoom].firstMatch.tap()
|
|
// On iPad the search field keeps focus on iOS 27, so the first tap can be swallowed while it resigns.
|
|
if !app.textFields[A11yIdentifiers.createRoomScreen.roomName].waitForExistence(timeout: 2.0) {
|
|
app.buttons[A11yIdentifiers.startChatScreen.createRoom].firstMatch.tap()
|
|
}
|
|
XCTAssertTrue(app.textFields[A11yIdentifiers.createRoomScreen.roomName].waitForExistence(timeout: 1.0))
|
|
try await app.assertScreenshot(step: Step.createRoom)
|
|
|
|
app.buttons[A11yIdentifiers.createRoomScreen.roomAvatar].tap()
|
|
app.popovers.buttons.element(boundBy: 3).tap() // There are 3 buttons with the accessibility identifier, so use the index to get the right one.
|
|
let cancelButton = app.buttons["Cancel"]
|
|
// The system UI snapshot is unreliable, instead lets just assert something.
|
|
// XCTAssertTrue(cancelButton.waitForExistence(timeout: 1.0))
|
|
// try await app.assertScreenshot(step: Step.createRoomAvatarPicker)
|
|
XCTAssertTrue(app.navigationBars["Photos"].waitForExistence(timeout: 20.0)) // The first load of the photo picker can sometimes be *really* slow.
|
|
cancelButton.tap()
|
|
|
|
// typeText sometimes misses letters but it's faster than typing one letter at a time
|
|
// repeat the same letter enough times to avoid that but also to work on iPads
|
|
app.textFields[A11yIdentifiers.createRoomScreen.roomName].tap()
|
|
app.textFields[A11yIdentifiers.createRoomScreen.roomName].typeText(.init(repeating: "x", count: 200))
|
|
app.textFields[A11yIdentifiers.createRoomScreen.roomName].typeText("\n")
|
|
try await app.assertScreenshot(step: Step.createRoomFilled)
|
|
|
|
app.buttons[A11yIdentifiers.createRoomScreen.create].tap()
|
|
XCTAssertTrue(app.buttons[A11yIdentifiers.inviteUsersScreen.proceed].waitForExistence(timeout: 1.0))
|
|
try await app.assertScreenshot(step: Step.inviteUsers)
|
|
|
|
let inviteUsersSearchField = app.searchFields.firstMatch
|
|
inviteUsersSearchField.clearAndTypeText("Bob\n", app: app)
|
|
|
|
let cells = app.collectionViews.firstMatch.cells
|
|
// The update of the cells is not immediate, and may take a bunch of milliseconds
|
|
// so let's await it.
|
|
let predicate = NSPredicate(format: "count == 2")
|
|
let expectation = XCTNSPredicateExpectation(predicate: predicate, object: cells)
|
|
await fulfillment(of: [expectation], timeout: 5.0)
|
|
|
|
try await app.assertScreenshot(step: Step.inviteUsersWithResults)
|
|
|
|
cells.element(boundBy: 0).tap()
|
|
// Selecting the first member has inserted the horizontal collection view above the list.
|
|
// So to select the second member we now need to increment the index by 2 instead of 1.
|
|
cells.element(boundBy: 2).tap()
|
|
try await app.assertScreenshot(step: Step.inviteUsersSelectedResults)
|
|
|
|
app.buttons[A11yIdentifiers.inviteUsersScreen.proceed].tap()
|
|
try await app.assertScreenshot(step: Step.dismissed)
|
|
}
|
|
}
|