mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-10-31 16:24:11 +00:00
Michael
22d14ff8e4
* create DependenciesProtocol and replace ServiceLocator registration with it replace mocking calls for ServiceLocator to Dependencies replace ServiceLocator with instance level calls replace ServiceLocator configs with TestDependencies config in Tests replace servicelocator usage in analytics service replace remaining ServiceLocator calls in unit tests that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances fix swiftlint warning remove remaining references to ServiceLocator make dependencies properties consistent in tests delete Dependencies and DependenciesProtocol fix whitespace modifications updates from PR feedback a pass over converting AppSettings and AnalyticsService test instance properties to per test instantiation fix a missed PR feedback Sync up after rebase create DependenciesProtocol and replace ServiceLocator registration with it replace mocking calls for ServiceLocator to Dependencies replace ServiceLocator with instance level calls replace ServiceLocator configs with TestDependencies config in Tests replace servicelocator usage in analytics service replace remaining ServiceLocator calls in unit tests that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances fix swiftlint warning remove remaining references to ServiceLocator make dependencies properties consistent in tests delete Dependencies and DependenciesProtocol * AppSettings is instance level mockable now * replace mocked and preview usages of reset + AppSettings global init with AppSettings(store: UserDefaultsMock()) * AppSettings.UserDefaultsKeys is now a RawRep struct, making it extensible * update tests with new AppSettings so it builds * update remaining AppSettings test/mock inits * AppSettings.UserDefaultsKey conformed to ExpressibleByStringLiteral * addressed issues found in first pass ai review * update AppSettings instantiations after rebase * fix accessibility tests coordinator after rebase * Rename to VolatileUserDefaults * AppSettings init uses mandatory parameter * Revert UserDefaultsKey to enum * Add TrackedUserDefaults to be able to reset the defaults object * Added volatile static func to AppSettings * Use .volatile() static func instead of full init * review fixups * Resolve build issues after rebase * updated enterprise module * remove the static reset settings call from the preview tests --------- Co-authored-by: Mauro Romito <mauro.romito@element.io>
810 lines
44 KiB
Swift
810 lines
44 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import AsyncAlgorithms
|
|
import Combine
|
|
@testable import ElementX
|
|
import MatrixRustSDK
|
|
import SwiftUI
|
|
import Testing
|
|
|
|
@MainActor
|
|
struct RoomDetailsScreenViewModelTests {
|
|
var viewModel: RoomDetailsScreenViewModel!
|
|
var roomProxyMock: JoinedRoomProxyMock!
|
|
var notificationSettingsProxyMock: NotificationSettingsProxyMock!
|
|
var context: RoomDetailsScreenViewModelType.Context {
|
|
viewModel.context
|
|
}
|
|
|
|
var cancellables = Set<AnyCancellable>()
|
|
|
|
init() {
|
|
cancellables.removeAll()
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test"))
|
|
notificationSettingsProxyMock = NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration())
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: notificationSettingsProxyMock,
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
}
|
|
|
|
@Test
|
|
mutating func leaveRoomTappedWhenPublic() async throws {
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockBob, .mockAlice]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", members: mockedMembers, joinRule: .public))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
let deferred = deferFulfillment(context.observe(\.viewState.bindings.leaveRoomAlertItem)) { $0 != nil }
|
|
|
|
context.send(viewAction: .processTapLeave)
|
|
try await deferred.fulfill()
|
|
|
|
#expect(context.viewState.bindings.leaveRoomAlertItem?.state == .public)
|
|
#expect(context.viewState.bindings.leaveRoomAlertItem?.subtitle == L10n.leaveRoomAlertSubtitle)
|
|
}
|
|
|
|
@Test
|
|
mutating func leaveRoomTappedWhenRoomNotPublic() async throws {
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockBob, .mockAlice]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", members: mockedMembers))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
let deferred = deferFulfillment(context.observe(\.viewState.bindings.leaveRoomAlertItem)) { $0 != nil }
|
|
|
|
context.send(viewAction: .processTapLeave)
|
|
|
|
try await deferred.fulfill()
|
|
|
|
#expect(context.viewState.bindings.leaveRoomAlertItem?.state == .private)
|
|
#expect(context.viewState.bindings.leaveRoomAlertItem?.subtitle == L10n.leaveRoomAlertPrivateSubtitle)
|
|
}
|
|
|
|
@Test
|
|
mutating func leaveRoomTappedWithLessThanTwoMembers() {
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockAlice]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", members: mockedMembers))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
context.send(viewAction: .processTapLeave)
|
|
#expect(context.leaveRoomAlertItem?.state == .empty)
|
|
#expect(context.leaveRoomAlertItem?.subtitle == L10n.leaveRoomAlertEmptySubtitle)
|
|
}
|
|
|
|
@Test
|
|
func leaveRoomSuccess() async throws {
|
|
roomProxyMock.leaveRoomClosure = {
|
|
.success(())
|
|
}
|
|
|
|
let deferred = deferFulfillment(viewModel.actions) { action in
|
|
switch action {
|
|
case .leftRoom:
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
context.send(viewAction: .confirmLeave)
|
|
|
|
try await deferred.fulfill()
|
|
|
|
#expect(roomProxyMock.leaveRoomCallsCount == 1)
|
|
}
|
|
|
|
@Test
|
|
func leaveRoomError() async throws {
|
|
try await confirmation("leaveRoomError") { confirm in
|
|
roomProxyMock.leaveRoomClosure = {
|
|
defer {
|
|
confirm()
|
|
}
|
|
return .failure(.sdkError(ClientProxyMockError.generic))
|
|
}
|
|
|
|
let deferred = deferFulfillment(context.observe(\.alertInfo)) { $0 != nil }
|
|
context.send(viewAction: .confirmLeave)
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
#expect(roomProxyMock.leaveRoomCallsCount == 1)
|
|
}
|
|
|
|
@Test
|
|
mutating func initialDMDetailsState() async throws {
|
|
let recipient = RoomMemberProxyMock.mockDan
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMe, recipient]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", isDirect: true, isEncrypted: true, members: mockedMembers))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
let deferred = deferFulfillment(viewModel.context.observe(\.viewState.dmRecipientInfo)) { $0 != nil }
|
|
|
|
try await deferred.fulfill()
|
|
|
|
#expect(context.viewState.dmRecipientInfo?.member == RoomMemberDetails(withProxy: recipient))
|
|
}
|
|
|
|
@Test
|
|
mutating func ignoreSuccess() async throws {
|
|
let recipient = RoomMemberProxyMock.mockDan
|
|
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMe, recipient]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", isDirect: true, isEncrypted: true, members: mockedMembers))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
let deferredRecipient = deferFulfillment(viewModel.context.observe(\.viewState.dmRecipientInfo)) { $0 != nil }
|
|
|
|
try await deferredRecipient.fulfill()
|
|
|
|
#expect(context.viewState.dmRecipientInfo?.member == RoomMemberDetails(withProxy: recipient))
|
|
|
|
let deferredProcessing = deferFulfillment(viewModel.context.observe(\.viewState.isProcessingIgnoreRequest),
|
|
transitionValues: [false, true, false])
|
|
|
|
context.send(viewAction: .ignoreConfirmed)
|
|
|
|
try await deferredProcessing.fulfill()
|
|
|
|
#expect(context.viewState.dmRecipientInfo?.member.isIgnored == true)
|
|
}
|
|
|
|
@Test
|
|
mutating func ignoreFailure() async throws {
|
|
let recipient = RoomMemberProxyMock.mockDan
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMe, recipient]
|
|
let clientProxy = ClientProxyMock(.init())
|
|
clientProxy.ignoreUserReturnValue = .failure(.sdkError(ClientProxyMockError.generic))
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", isDirect: true, isEncrypted: true, members: mockedMembers))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init(clientProxy: clientProxy)),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
let deferredRecipient = deferFulfillment(viewModel.context.observe(\.viewState.dmRecipientInfo)) { $0 != nil }
|
|
|
|
try await deferredRecipient.fulfill()
|
|
|
|
#expect(context.viewState.dmRecipientInfo?.member == RoomMemberDetails(withProxy: recipient))
|
|
|
|
let deferredProcessing = deferFulfillment(viewModel.context.observe(\.viewState.isProcessingIgnoreRequest),
|
|
transitionValues: [false, true, false])
|
|
|
|
context.send(viewAction: .ignoreConfirmed)
|
|
|
|
try await deferredProcessing.fulfill()
|
|
|
|
#expect(context.viewState.dmRecipientInfo?.member.isIgnored == false)
|
|
#expect(context.alertInfo != nil)
|
|
}
|
|
|
|
@Test
|
|
mutating func unignoreSuccess() async throws {
|
|
let recipient = RoomMemberProxyMock.mockIgnored
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMe, recipient]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", isDirect: true, isEncrypted: true, members: mockedMembers))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
let deferredRecipient = deferFulfillment(viewModel.context.observe(\.viewState.dmRecipientInfo)) { $0 != nil }
|
|
|
|
try await deferredRecipient.fulfill()
|
|
|
|
#expect(context.viewState.dmRecipientInfo?.member == RoomMemberDetails(withProxy: recipient))
|
|
|
|
let deferredProcessing = deferFulfillment(viewModel.context.observe(\.viewState.isProcessingIgnoreRequest),
|
|
transitionValues: [false, true, false])
|
|
|
|
context.send(viewAction: .unignoreConfirmed)
|
|
|
|
try await deferredProcessing.fulfill()
|
|
|
|
#expect(context.viewState.dmRecipientInfo?.member.isIgnored == false)
|
|
}
|
|
|
|
@Test
|
|
mutating func unignoreFailure() async throws {
|
|
let recipient = RoomMemberProxyMock.mockIgnored
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMe, recipient]
|
|
let clientProxy = ClientProxyMock(.init())
|
|
clientProxy.unignoreUserReturnValue = .failure(.sdkError(ClientProxyMockError.generic))
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", isDirect: true, isEncrypted: true, members: mockedMembers))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init(clientProxy: clientProxy)),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
let deferredRecipient = deferFulfillment(viewModel.context.observe(\.viewState.dmRecipientInfo)) { $0 != nil }
|
|
|
|
try await deferredRecipient.fulfill()
|
|
|
|
#expect(context.viewState.dmRecipientInfo?.member == RoomMemberDetails(withProxy: recipient))
|
|
|
|
let deferredProcessing = deferFulfillment(viewModel.context.observe(\.viewState.isProcessingIgnoreRequest),
|
|
transitionValues: [false, true, false])
|
|
|
|
context.send(viewAction: .unignoreConfirmed)
|
|
|
|
try await deferredProcessing.fulfill()
|
|
|
|
#expect(context.viewState.dmRecipientInfo?.member.isIgnored == true)
|
|
#expect(context.alertInfo != nil)
|
|
}
|
|
|
|
@Test
|
|
mutating func cannotInvitePeople() async {
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMe, .mockAlice]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test",
|
|
members: mockedMembers,
|
|
joinRule: .public,
|
|
powerLevelsConfiguration: .init(canUserInvite: false)))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
_ = await context.observe(\.viewState).debounce(for: .milliseconds(100)).first()
|
|
|
|
#expect(!context.viewState.canInviteUsers)
|
|
}
|
|
|
|
@Test
|
|
mutating func invitePeople() async {
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMe, .mockBob, .mockAlice]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", members: mockedMembers, joinRule: .public))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
_ = await context.observe(\.viewState).debounce(for: .milliseconds(100)).first()
|
|
|
|
#expect(context.viewState.canInviteUsers)
|
|
|
|
var callbackCorrectlyCalled = false
|
|
viewModel.actions
|
|
.sink { action in
|
|
switch action {
|
|
case .requestInvitePeoplePresentation:
|
|
callbackCorrectlyCalled = true
|
|
default:
|
|
callbackCorrectlyCalled = false
|
|
}
|
|
}
|
|
.store(in: &cancellables)
|
|
|
|
context.send(viewAction: .processTapInvite)
|
|
await Task.yield()
|
|
#expect(callbackCorrectlyCalled)
|
|
}
|
|
|
|
@Test
|
|
mutating func canEditAvatar() async {
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMe, .mockBob, .mockAlice]
|
|
|
|
let configuration = JoinedRoomProxyMockConfiguration(name: "Test",
|
|
isDirect: false,
|
|
members: mockedMembers)
|
|
|
|
roomProxyMock = JoinedRoomProxyMock(configuration)
|
|
|
|
let powerLevelsProxyMock = RoomPowerLevelsProxyMock(configuration: .init())
|
|
powerLevelsProxyMock.canUserUserIDSendStateEventClosure = { _, event in
|
|
.success(event == .roomAvatar)
|
|
}
|
|
powerLevelsProxyMock.canOwnUserSendStateEventClosure = { event in
|
|
event == .roomAvatar
|
|
}
|
|
roomProxyMock.powerLevelsReturnValue = .success(powerLevelsProxyMock)
|
|
|
|
let roomInfoProxyMock = RoomInfoProxyMock(configuration)
|
|
roomInfoProxyMock.powerLevels = powerLevelsProxyMock
|
|
roomProxyMock.infoPublisher = CurrentValueSubject(roomInfoProxyMock).asCurrentValuePublisher()
|
|
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
_ = await context.observe(\.viewState).debounce(for: .milliseconds(100)).first()
|
|
|
|
#expect(context.viewState.canEditRoomAvatar)
|
|
#expect(!context.viewState.canEditRoomName)
|
|
#expect(!context.viewState.canEditRoomTopic)
|
|
#expect(context.viewState.canEditBaseInfo)
|
|
}
|
|
|
|
@Test
|
|
mutating func canEditName() async {
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMe, .mockBob, .mockAlice]
|
|
|
|
let configuration = JoinedRoomProxyMockConfiguration(name: "Test",
|
|
isDirect: false,
|
|
members: mockedMembers)
|
|
|
|
roomProxyMock = JoinedRoomProxyMock(configuration)
|
|
|
|
let powerLevelsProxyMock = RoomPowerLevelsProxyMock(configuration: .init())
|
|
powerLevelsProxyMock.canUserUserIDSendStateEventClosure = { _, event in
|
|
.success(event == .roomName)
|
|
}
|
|
powerLevelsProxyMock.canOwnUserSendStateEventClosure = { event in
|
|
event == .roomName
|
|
}
|
|
roomProxyMock.powerLevelsReturnValue = .success(powerLevelsProxyMock)
|
|
|
|
let roomInfoProxyMock = RoomInfoProxyMock(configuration)
|
|
roomInfoProxyMock.powerLevels = powerLevelsProxyMock
|
|
roomProxyMock.infoPublisher = CurrentValueSubject(roomInfoProxyMock).asCurrentValuePublisher()
|
|
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
_ = await context.observe(\.viewState).debounce(for: .milliseconds(100)).first()
|
|
|
|
#expect(!context.viewState.canEditRoomAvatar)
|
|
#expect(context.viewState.canEditRoomName)
|
|
#expect(!context.viewState.canEditRoomTopic)
|
|
#expect(context.viewState.canEditBaseInfo)
|
|
}
|
|
|
|
@Test
|
|
mutating func canEditTopic() async {
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMe, .mockBob, .mockAlice]
|
|
|
|
let configuration = JoinedRoomProxyMockConfiguration(name: "Test",
|
|
isDirect: false,
|
|
members: mockedMembers)
|
|
|
|
roomProxyMock = JoinedRoomProxyMock(configuration)
|
|
|
|
let powerLevelsProxyMock = RoomPowerLevelsProxyMock(configuration: .init())
|
|
powerLevelsProxyMock.canUserUserIDSendStateEventClosure = { _, event in
|
|
.success(event == .roomTopic)
|
|
}
|
|
powerLevelsProxyMock.canOwnUserSendStateEventClosure = { event in
|
|
event == .roomTopic
|
|
}
|
|
roomProxyMock.powerLevelsReturnValue = .success(powerLevelsProxyMock)
|
|
|
|
let roomInfoProxyMock = RoomInfoProxyMock(configuration)
|
|
roomInfoProxyMock.powerLevels = powerLevelsProxyMock
|
|
roomProxyMock.infoPublisher = CurrentValueSubject(roomInfoProxyMock).asCurrentValuePublisher()
|
|
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
_ = await context.observe(\.viewState).debounce(for: .milliseconds(100)).first()
|
|
|
|
#expect(!context.viewState.canEditRoomAvatar)
|
|
#expect(!context.viewState.canEditRoomName)
|
|
#expect(context.viewState.canEditRoomTopic)
|
|
#expect(context.viewState.canEditBaseInfo)
|
|
}
|
|
|
|
@Test
|
|
mutating func cannotEditRoom() async {
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMe, .mockBob, .mockAlice]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", isDirect: false, members: mockedMembers))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
_ = await context.observe(\.viewState).debounce(for: .milliseconds(100)).first()
|
|
|
|
#expect(!context.viewState.canEditRoomAvatar)
|
|
#expect(!context.viewState.canEditRoomName)
|
|
#expect(!context.viewState.canEditRoomTopic)
|
|
#expect(!context.viewState.canEditBaseInfo)
|
|
}
|
|
|
|
@Test
|
|
mutating func cannotEditDirectRoom() async {
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMeAdmin, .mockBob, .mockAlice]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", isDirect: true, members: mockedMembers))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: NotificationSettingsProxyMock(with: NotificationSettingsProxyMockConfiguration()),
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
_ = await context.observe(\.viewState).debounce(for: .milliseconds(100)).first()
|
|
|
|
#expect(!context.viewState.canEditBaseInfo)
|
|
}
|
|
|
|
// MARK: - Notifications
|
|
|
|
@Test
|
|
mutating func notificationLoadingSettingsFailure() async throws {
|
|
notificationSettingsProxyMock.getNotificationSettingsRoomIdIsEncryptedIsOneToOneThrowableError = NotificationSettingsError.Generic(msg: "error")
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: notificationSettingsProxyMock,
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
var deferred = deferFulfillment(context.observe(\.viewState.notificationSettingsState)) { $0.isError }
|
|
|
|
try await deferred.fulfill()
|
|
|
|
notificationSettingsProxyMock.callbacks.send(.settingsDidChange)
|
|
|
|
deferred = deferFulfillment(context.observe(\.viewState.notificationSettingsState)) { $0.isError }
|
|
|
|
try await deferred.fulfill()
|
|
|
|
let expectedAlertInfo = AlertInfo(id: RoomDetailsScreenErrorType.alert,
|
|
title: L10n.commonError,
|
|
message: L10n.screenRoomDetailsErrorLoadingNotificationSettings)
|
|
#expect(context.viewState.bindings.alertInfo?.id == expectedAlertInfo.id)
|
|
#expect(context.viewState.bindings.alertInfo?.title == expectedAlertInfo.title)
|
|
#expect(context.viewState.bindings.alertInfo?.message == expectedAlertInfo.message)
|
|
}
|
|
|
|
@Test
|
|
func notificationDefaultMode() async throws {
|
|
notificationSettingsProxyMock.getNotificationSettingsRoomIdIsEncryptedIsOneToOneReturnValue = RoomNotificationSettingsProxyMock(with: .init(mode: .allMessages, isDefault: true))
|
|
|
|
let deferred = deferFulfillment(context.observe(\.viewState.notificationSettingsState)) { $0.isLoaded }
|
|
|
|
notificationSettingsProxyMock.callbacks.send(.settingsDidChange)
|
|
try await deferred.fulfill()
|
|
|
|
#expect(context.viewState.notificationSettingsState.label == "Default")
|
|
}
|
|
|
|
@Test
|
|
func notificationCustomMode() async throws {
|
|
notificationSettingsProxyMock.getNotificationSettingsRoomIdIsEncryptedIsOneToOneReturnValue = RoomNotificationSettingsProxyMock(with: .init(mode: .allMessages, isDefault: false))
|
|
|
|
let deferred = deferFulfillment(context.observe(\.viewState.notificationSettingsState)) { $0.isCustom }
|
|
|
|
notificationSettingsProxyMock.callbacks.send(.settingsDidChange)
|
|
try await deferred.fulfill()
|
|
|
|
#expect(context.viewState.notificationSettingsState.label == "Custom")
|
|
}
|
|
|
|
@Test
|
|
func notificationRoomMuted() async throws {
|
|
notificationSettingsProxyMock.getNotificationSettingsRoomIdIsEncryptedIsOneToOneReturnValue = RoomNotificationSettingsProxyMock(with: .init(mode: .mute, isDefault: false))
|
|
|
|
let deferred = deferFulfillment(context.observe(\.viewState.notificationSettingsState)) { $0.isLoaded }
|
|
|
|
notificationSettingsProxyMock.callbacks.send(.settingsDidChange)
|
|
try await deferred.fulfill()
|
|
|
|
_ = await context.observe(\.viewState).debounce(for: .milliseconds(100)).first()
|
|
|
|
#expect(context.viewState.notificationShortcutButtonTitle == L10n.commonUnmute)
|
|
#expect(context.viewState.notificationShortcutButtonIcon == \.notificationsOff)
|
|
}
|
|
|
|
@Test
|
|
func notificationRoomNotMuted() async throws {
|
|
notificationSettingsProxyMock.getNotificationSettingsRoomIdIsEncryptedIsOneToOneReturnValue = RoomNotificationSettingsProxyMock(with: .init(mode: .mentionsAndKeywordsOnly, isDefault: false))
|
|
|
|
let deferred = deferFulfillment(context.observe(\.viewState.notificationSettingsState)) { $0.isLoaded }
|
|
|
|
notificationSettingsProxyMock.callbacks.send(.settingsDidChange)
|
|
try await deferred.fulfill()
|
|
|
|
#expect(context.viewState.notificationShortcutButtonTitle == L10n.commonMute)
|
|
#expect(context.viewState.notificationShortcutButtonIcon == \.notifications)
|
|
}
|
|
|
|
@Test
|
|
func unmuteTappedFailure() async throws {
|
|
try await notificationRoomMuted()
|
|
|
|
try await confirmation("unmuteTappedFailure") { confirm in
|
|
notificationSettingsProxyMock.unmuteRoomRoomIdIsEncryptedIsOneToOneClosure = { _, _, _ in
|
|
defer {
|
|
confirm()
|
|
}
|
|
throw NotificationSettingsError.Generic(msg: "unmute error")
|
|
}
|
|
context.send(viewAction: .processToggleMuteNotifications)
|
|
try await deferFulfillment(context.observe(\.alertInfo)) { $0 != nil }.fulfill()
|
|
}
|
|
|
|
#expect(!context.viewState.isProcessingMuteToggleAction)
|
|
#expect(context.viewState.notificationShortcutButtonTitle == L10n.commonUnmute)
|
|
|
|
let expectedAlertInfo = AlertInfo(id: RoomDetailsScreenErrorType.alert,
|
|
title: L10n.commonError,
|
|
message: L10n.screenRoomDetailsErrorUnmuting)
|
|
|
|
#expect(context.viewState.bindings.alertInfo?.id == expectedAlertInfo.id)
|
|
#expect(context.viewState.bindings.alertInfo?.title == expectedAlertInfo.title)
|
|
#expect(context.viewState.bindings.alertInfo?.message == expectedAlertInfo.message)
|
|
}
|
|
|
|
@Test
|
|
func muteTappedFailure() async throws {
|
|
try await notificationRoomNotMuted()
|
|
|
|
try await confirmation("muteTappedFailure") { confirm in
|
|
notificationSettingsProxyMock.setNotificationModeRoomIdModeClosure = { _, _ in
|
|
defer {
|
|
confirm()
|
|
}
|
|
throw NotificationSettingsError.Generic(msg: "mute error")
|
|
}
|
|
|
|
let deferred = deferFulfillment(context.observe(\.alertInfo)) { $0 != nil }
|
|
context.send(viewAction: .processToggleMuteNotifications)
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
#expect(!context.viewState.isProcessingMuteToggleAction)
|
|
#expect(context.viewState.notificationShortcutButtonTitle == L10n.commonMute)
|
|
|
|
let expectedAlertInfo = AlertInfo(id: RoomDetailsScreenErrorType.alert,
|
|
title: L10n.commonError,
|
|
message: L10n.screenRoomDetailsErrorMuting)
|
|
|
|
#expect(context.viewState.bindings.alertInfo?.id == expectedAlertInfo.id)
|
|
#expect(context.viewState.bindings.alertInfo?.title == expectedAlertInfo.title)
|
|
#expect(context.viewState.bindings.alertInfo?.message == expectedAlertInfo.message)
|
|
}
|
|
|
|
@Test
|
|
func muteTapped() async throws {
|
|
try await notificationRoomNotMuted()
|
|
|
|
try await confirmation("muteTapped") { confirm in
|
|
notificationSettingsProxyMock.setNotificationModeRoomIdModeClosure = { [weak notificationSettingsProxyMock] _, mode in
|
|
notificationSettingsProxyMock?.getNotificationSettingsRoomIdIsEncryptedIsOneToOneReturnValue = RoomNotificationSettingsProxyMock(with: .init(mode: mode, isDefault: false))
|
|
confirm()
|
|
}
|
|
|
|
let deferred = deferFulfillment(context.observe(\.viewState.isProcessingMuteToggleAction),
|
|
transitionValues: [false, true, false])
|
|
context.send(viewAction: .processToggleMuteNotifications)
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
let deferred = deferFulfillment(context.observe(\.viewState.notificationSettingsState)) { state in
|
|
switch state {
|
|
case .loaded(settings: let settings): settings.mode == .mute
|
|
default: false
|
|
}
|
|
}
|
|
|
|
notificationSettingsProxyMock.callbacks.send(.settingsDidChange)
|
|
try await deferred.fulfill()
|
|
|
|
if case .loaded(let newNotificationSettingsState) = viewModel.state.notificationSettingsState {
|
|
#expect(!newNotificationSettingsState.isDefault)
|
|
#expect(newNotificationSettingsState.mode == .mute)
|
|
} else {
|
|
Issue.record("invalid state")
|
|
}
|
|
}
|
|
|
|
@Test
|
|
func unmuteTapped() async throws {
|
|
try await notificationRoomMuted()
|
|
|
|
try await confirmation("unmuteTapped") { confirm in
|
|
notificationSettingsProxyMock.unmuteRoomRoomIdIsEncryptedIsOneToOneClosure = { [weak notificationSettingsProxyMock] _, _, _ in
|
|
notificationSettingsProxyMock?.getNotificationSettingsRoomIdIsEncryptedIsOneToOneReturnValue = RoomNotificationSettingsProxyMock(with: .init(mode: .allMessages, isDefault: false))
|
|
confirm()
|
|
}
|
|
|
|
let deferred = deferFulfillment(context.observe(\.viewState.isProcessingMuteToggleAction),
|
|
transitionValues: [false, true, false])
|
|
context.send(viewAction: .processToggleMuteNotifications)
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
let deferred = deferFulfillment(context.observe(\.viewState.notificationSettingsState)) { state in
|
|
switch state {
|
|
case .loaded(settings: let settings): settings.mode == .allMessages
|
|
default: false
|
|
}
|
|
}
|
|
|
|
notificationSettingsProxyMock.callbacks.send(.settingsDidChange)
|
|
try await deferred.fulfill()
|
|
|
|
if case .loaded(let newNotificationSettingsState) = viewModel.state.notificationSettingsState {
|
|
#expect(!newNotificationSettingsState.isDefault)
|
|
#expect(newNotificationSettingsState.mode == .allMessages)
|
|
} else {
|
|
Issue.record("invalid state")
|
|
}
|
|
}
|
|
|
|
// MARK: - Knock Requests
|
|
|
|
@Test
|
|
mutating func knockRequestsCounter() async throws {
|
|
let mockedRequests: [KnockRequestProxyMock] = [.init(), .init()]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", isDirect: false, knockRequestsState: .loaded(mockedRequests), joinRule: .knock))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: notificationSettingsProxyMock,
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
let deferred = deferFulfillment(context.observe(\.viewState)) { state in
|
|
state.knockRequestsCount == 2 && state.canSeeKnockingRequests
|
|
}
|
|
try await deferred.fulfill()
|
|
|
|
let deferredAction = deferFulfillment(viewModel.actions) { $0 == .displayKnockingRequests }
|
|
context.send(viewAction: .processTapRequestsToJoin)
|
|
try await deferredAction.fulfill()
|
|
}
|
|
|
|
@Test
|
|
mutating func knockRequestsCounterIsLoading() async throws {
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", isDirect: false, knockRequestsState: .loading, joinRule: .knock))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: notificationSettingsProxyMock,
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
let deferred = deferFulfillment(context.observe(\.viewState)) { state in
|
|
state.knockRequestsCount == 0 && state.canSeeKnockingRequests
|
|
}
|
|
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
mutating func knockRequestsCounterIsNotShownIfNoPermissions() async throws {
|
|
let mockedRequests: [KnockRequestProxyMock] = [.init(), .init()]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test",
|
|
isDirect: false,
|
|
knockRequestsState: .loaded(mockedRequests),
|
|
joinRule: .knock,
|
|
powerLevelsConfiguration: .init(canUserInvite: false)))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: notificationSettingsProxyMock,
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
let deferred = deferFulfillment(context.observe(\.viewState)) { state in
|
|
state.knockRequestsCount == 2 &&
|
|
state.dmRecipientInfo == nil &&
|
|
!state.canSeeKnockingRequests &&
|
|
!state.canInviteUsers
|
|
}
|
|
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
mutating func knockRequestsCounterIsNotShownIfDM() async throws {
|
|
let mockedRequests: [KnockRequestProxyMock] = [.init(), .init()]
|
|
let mockedMembers: [RoomMemberProxyMock] = [.mockMe, .mockAlice]
|
|
roomProxyMock = JoinedRoomProxyMock(.init(name: "Test", isDirect: true, members: mockedMembers, knockRequestsState: .loaded(mockedRequests), joinRule: .knock))
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: notificationSettingsProxyMock,
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
let deferred = deferFulfillment(context.observe(\.viewState)) { state in
|
|
state.knockRequestsCount == 2 &&
|
|
!state.canSeeKnockingRequests &&
|
|
state.dmRecipientInfo != nil &&
|
|
state.canInviteUsers
|
|
}
|
|
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
// MARK: - History Sharing
|
|
|
|
@Test
|
|
mutating func historySharingPillDisplayed() async throws {
|
|
let configuration = JoinedRoomProxyMockConfiguration(historyVisibility: .shared)
|
|
let infoSubject = CurrentValueSubject<RoomInfoProxyProtocol, Never>(RoomInfoProxyMock(configuration))
|
|
let roomProxyMock = JoinedRoomProxyMock(configuration)
|
|
roomProxyMock.underlyingInfoPublisher = infoSubject.asCurrentValuePublisher()
|
|
|
|
viewModel = RoomDetailsScreenViewModel(roomProxy: roomProxyMock,
|
|
userSession: UserSessionMock(.init()),
|
|
analyticsService: AnalyticsServiceMock.default,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
notificationSettingsProxy: notificationSettingsProxyMock,
|
|
attributedStringBuilder: AttributedStringBuilder(mentionBuilder: MentionBuilder()),
|
|
appSettings: .volatile())
|
|
|
|
let deferredShared = deferFulfillment(context.observe(\.viewState),
|
|
message: "The pill should be shown for rooms with shared history visibility") { state in
|
|
state.details.historySharingState == .shared
|
|
}
|
|
try await deferredShared.fulfill()
|
|
}
|
|
}
|