mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-06 04:18:31 +00:00
22d14ff8e4
* create DependenciesProtocol and replace ServiceLocator registration with it replace mocking calls for ServiceLocator to Dependencies replace ServiceLocator with instance level calls replace ServiceLocator configs with TestDependencies config in Tests replace servicelocator usage in analytics service replace remaining ServiceLocator calls in unit tests that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances fix swiftlint warning remove remaining references to ServiceLocator make dependencies properties consistent in tests delete Dependencies and DependenciesProtocol fix whitespace modifications updates from PR feedback a pass over converting AppSettings and AnalyticsService test instance properties to per test instantiation fix a missed PR feedback Sync up after rebase create DependenciesProtocol and replace ServiceLocator registration with it replace mocking calls for ServiceLocator to Dependencies replace ServiceLocator with instance level calls replace ServiceLocator configs with TestDependencies config in Tests replace servicelocator usage in analytics service replace remaining ServiceLocator calls in unit tests that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances fix swiftlint warning remove remaining references to ServiceLocator make dependencies properties consistent in tests delete Dependencies and DependenciesProtocol * AppSettings is instance level mockable now * replace mocked and preview usages of reset + AppSettings global init with AppSettings(store: UserDefaultsMock()) * AppSettings.UserDefaultsKeys is now a RawRep struct, making it extensible * update tests with new AppSettings so it builds * update remaining AppSettings test/mock inits * AppSettings.UserDefaultsKey conformed to ExpressibleByStringLiteral * addressed issues found in first pass ai review * update AppSettings instantiations after rebase * fix accessibility tests coordinator after rebase * Rename to VolatileUserDefaults * AppSettings init uses mandatory parameter * Revert UserDefaultsKey to enum * Add TrackedUserDefaults to be able to reset the defaults object * Added volatile static func to AppSettings * Use .volatile() static func instead of full init * review fixups * Resolve build issues after rebase * updated enterprise module * remove the static reset settings call from the preview tests --------- Co-authored-by: Mauro Romito <mauro.romito@element.io>
333 lines
14 KiB
Swift
333 lines
14 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
import Compound
|
|
import SwiftUI
|
|
import UniformTypeIdentifiers
|
|
|
|
struct NotificationSettingsScreen: View {
|
|
@Bindable var context: NotificationSettingsScreenViewModel.Context
|
|
|
|
var body: some View {
|
|
Form {
|
|
if context.viewState.settings?.inconsistentSettings.isEmpty == false {
|
|
configurationMismatchSection
|
|
} else {
|
|
if context.viewState.showSystemNotificationsAlert {
|
|
userPermissionSection
|
|
}
|
|
|
|
enableNotificationSection
|
|
|
|
if context.enableNotifications {
|
|
roomsNotificationSection
|
|
|
|
if context.viewState.settings?.roomMentionsEnabled != nil {
|
|
mentionsSection
|
|
}
|
|
|
|
if context.viewState.showCallsSettings, context.viewState.settings?.callsEnabled != nil {
|
|
callsSection
|
|
}
|
|
|
|
if context.viewState.settings?.invitationsEnabled != nil {
|
|
additionalSettingsSection
|
|
}
|
|
|
|
soundSelectionSection
|
|
}
|
|
}
|
|
}
|
|
.compoundList()
|
|
.navigationTitle(L10n.screenNotificationSettingsTitle)
|
|
.navigationBarTitleDisplayMode(.inline)
|
|
.toolbar { toolbar }
|
|
.alert(item: $context.alertInfo)
|
|
.track(screen: .SettingsNotifications)
|
|
}
|
|
|
|
// MARK: - Private
|
|
|
|
@ToolbarContentBuilder
|
|
private var toolbar: some ToolbarContent {
|
|
if context.viewState.isModallyPresented {
|
|
ToolbarItem(placement: .confirmationAction) {
|
|
Button(L10n.actionClose) {
|
|
context.send(viewAction: .close)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
private var userPermissionSection: some View {
|
|
Section {
|
|
ListRow(kind: .custom {
|
|
HStack(alignment: .firstTextBaseline, spacing: 13) {
|
|
Image(systemSymbol: .exclamationmarkCircleFill)
|
|
.foregroundColor(.compound.iconTertiaryAlpha)
|
|
.accessibilityHidden(true)
|
|
VStack(alignment: .leading, spacing: 2) {
|
|
Text(L10n.screenNotificationSettingsSystemNotificationsTurnedOff)
|
|
.font(.compound.bodyLG)
|
|
.foregroundColor(.compound.textPrimary)
|
|
Text(context.viewState.strings.changeYourSystemSettings)
|
|
.font(.compound.bodySM)
|
|
.foregroundColor(.compound.textSecondary)
|
|
.tint(.compound.textPrimary)
|
|
}
|
|
}
|
|
.padding(.horizontal, ListRowPadding.horizontal)
|
|
.padding(.vertical, 8)
|
|
})
|
|
}
|
|
}
|
|
|
|
private var enableNotificationSection: some View {
|
|
Section {
|
|
ListRow(label: .plain(title: L10n.screenNotificationSettingsEnableNotifications),
|
|
kind: .toggle($context.enableNotifications))
|
|
.onChange(of: context.enableNotifications) {
|
|
context.send(viewAction: .changedEnableNotifications)
|
|
}
|
|
}
|
|
}
|
|
|
|
private var roomsNotificationSection: some View {
|
|
Section {
|
|
// Group chats
|
|
ListRow(label: .plain(title: L10n.screenNotificationSettingsGroupChats),
|
|
details: context.viewState.settings.map {
|
|
.title(context.viewState.strings.string(for: $0.groupChatsMode))
|
|
} ?? .isWaiting(true),
|
|
kind: .navigationLink {
|
|
context.send(viewAction: .groupChatsTapped)
|
|
})
|
|
.disabled(context.viewState.settings == nil)
|
|
.accessibilityIdentifier(A11yIdentifiers.roomDetailsScreen.notifications)
|
|
|
|
// Direct chats
|
|
ListRow(label: .plain(title: L10n.screenNotificationSettingsDirectChats),
|
|
details: context.viewState.settings.map {
|
|
.title(context.viewState.strings.string(for: $0.directChatsMode))
|
|
} ?? .isWaiting(true),
|
|
kind: .navigationLink {
|
|
context.send(viewAction: .directChatsTapped)
|
|
})
|
|
.disabled(context.viewState.settings == nil)
|
|
.accessibilityIdentifier(A11yIdentifiers.roomDetailsScreen.notifications)
|
|
|
|
} header: {
|
|
Text(L10n.screenNotificationSettingsNotificationSectionTitle)
|
|
.compoundListSectionHeader()
|
|
}
|
|
}
|
|
|
|
private var mentionsSection: some View {
|
|
Section {
|
|
ListRow(label: .plain(title: L10n.screenNotificationSettingsRoomMentionLabel),
|
|
kind: .toggle($context.roomMentionsEnabled))
|
|
.disabled(context.viewState.settings?.roomMentionsEnabled == nil)
|
|
.allowsHitTesting(!context.viewState.applyingChange)
|
|
.onChange(of: context.roomMentionsEnabled) {
|
|
context.send(viewAction: .roomMentionChanged)
|
|
}
|
|
} header: {
|
|
Text(L10n.screenNotificationSettingsMentionsSectionTitle)
|
|
.compoundListSectionHeader()
|
|
}
|
|
}
|
|
|
|
private var callsSection: some View {
|
|
Section {
|
|
ListRow(label: .plain(title: L10n.screenNotificationSettingsCallsLabel),
|
|
kind: .toggle($context.callsEnabled))
|
|
.disabled(context.viewState.settings?.callsEnabled == nil)
|
|
.allowsHitTesting(!context.viewState.applyingChange)
|
|
.onChange(of: context.callsEnabled) {
|
|
context.send(viewAction: .callsChanged)
|
|
}
|
|
} header: {
|
|
Text(L10n.screenNotificationSettingsAdditionalSettingsSectionTitle)
|
|
.compoundListSectionHeader()
|
|
}
|
|
}
|
|
|
|
private var additionalSettingsSection: some View {
|
|
Section {
|
|
ListRow(label: .plain(title: L10n.screenNotificationSettingsInviteForMeLabel),
|
|
kind: .toggle($context.invitationsEnabled))
|
|
.disabled(context.viewState.settings?.invitationsEnabled == nil)
|
|
.allowsHitTesting(!context.viewState.applyingChange)
|
|
.onChange(of: context.invitationsEnabled) {
|
|
context.send(viewAction: .invitationsChanged)
|
|
}
|
|
} header: {
|
|
Text(L10n.screenNotificationSettingsAdditionalSettingsSectionTitle)
|
|
.compoundListSectionHeader()
|
|
}
|
|
}
|
|
|
|
@ViewBuilder
|
|
private var soundSelectionSection: some View {
|
|
Section {
|
|
DisclosureGroup(context.viewState.selectedAlertTone.label, isExpanded: $context.shouldShowAlertSounds) {
|
|
customSoundSelectionSection
|
|
}
|
|
.foregroundStyle(.compound.textPrimary)
|
|
.listRowBackground(Color.compound.bgCanvasDefaultLevel1)
|
|
.listRowSeparatorTint(ListRowColor.separatorTint)
|
|
} header: {
|
|
Text(L10n.screenNotificationSettingsSoundSectionTitle)
|
|
.compoundListSectionHeader()
|
|
}
|
|
|
|
Section(isExpanded: $context.shouldShowAlertSounds) {
|
|
presetSoundSelectionSection
|
|
} header: { }
|
|
}
|
|
|
|
private var presetSoundSelectionSection: some View {
|
|
ForEach(NotificationToneManager.allDefaultAlerts, id: \.filename) { alertTone in
|
|
ListRow(label: .plain(title: alertTone.label),
|
|
kind: .selection(isSelected: context.viewState.selectedAlertTone == alertTone) {
|
|
context.send(viewAction: .selectAlertTone(alertTone))
|
|
})
|
|
}
|
|
}
|
|
|
|
@ViewBuilder
|
|
private var customSoundSelectionSection: some View {
|
|
ForEach(context.viewState.availableCustomTones, id: \.filename) { alertTone in
|
|
ListRow(label: .plain(title: alertTone.label),
|
|
kind: .selection(isSelected: context.viewState.selectedAlertTone == alertTone) {
|
|
context.send(viewAction: .selectAlertTone(alertTone))
|
|
})
|
|
}
|
|
.onDelete { indices in
|
|
let tones = indices.map {
|
|
context.viewState.availableCustomTones[$0]
|
|
}
|
|
|
|
context.send(viewAction: .deleteCustomAlertTones(tones))
|
|
}
|
|
|
|
ListRow(label: .plain(title: L10n.screenNotificationSettingsSoundCustomSoundButtonTitle),
|
|
kind: .button {
|
|
context.shouldShowCustomAlertTonePicker = true
|
|
})
|
|
.fileImporter(isPresented: $context.shouldShowCustomAlertTonePicker,
|
|
allowedContentTypes: [
|
|
.mp3,
|
|
.aiff,
|
|
.wav,
|
|
UTType("com.apple.m4a-audio"),
|
|
UTType("com.apple.coreaudio-format")
|
|
].compactMap(\.self)) {
|
|
context.send(viewAction: .addedCustomAlertTone($0))
|
|
}
|
|
}
|
|
|
|
private var configurationMismatchSection: some View {
|
|
Section {
|
|
ListRow(kind: .custom {
|
|
VStack(alignment: .leading, spacing: 16) {
|
|
VStack(alignment: .leading, spacing: 8) {
|
|
Text(L10n.screenNotificationSettingsConfigurationMismatch)
|
|
.font(.compound.bodyLGSemibold)
|
|
Text(L10n.screenNotificationSettingsConfigurationMismatchDescription)
|
|
.font(.compound.bodyMD)
|
|
.foregroundColor(.compound.textSecondary)
|
|
}
|
|
Button {
|
|
context.send(viewAction: .fixConfigurationMismatchTapped)
|
|
} label: {
|
|
Text(L10n.actionContinue)
|
|
.frame(maxWidth: .infinity)
|
|
}
|
|
.buttonStyle(.compound(.primary, size: .medium))
|
|
.disabled(context.viewState.fixingConfigurationMismatch)
|
|
.accessibilityIdentifier(A11yIdentifiers.notificationSettingsScreen.fixMismatchConfiguration)
|
|
}
|
|
.padding(.horizontal, ListRowPadding.horizontal)
|
|
.padding(.vertical, 24)
|
|
})
|
|
}
|
|
}
|
|
}
|
|
|
|
// MARK: - Previews
|
|
|
|
struct NotificationSettingsScreen_Previews: PreviewProvider, TestablePreview {
|
|
static let viewModel: NotificationSettingsScreenViewModel = {
|
|
let appSettings = AppSettings.volatile()
|
|
let notificationCenter = UserNotificationCenterMock()
|
|
notificationCenter.authorizationStatusReturnValue = .notDetermined
|
|
let notificationSettingsProxy = NotificationSettingsProxyMock(with: .init())
|
|
notificationSettingsProxy.getDefaultRoomNotificationModeIsEncryptedIsOneToOneClosure = { isEncrypted, isOneToOne in
|
|
switch (isEncrypted, isOneToOne) {
|
|
case (_, true):
|
|
return .allMessages
|
|
default:
|
|
return .mentionsAndKeywordsOnly
|
|
}
|
|
}
|
|
notificationSettingsProxy.isRoomMentionEnabledReturnValue = true
|
|
notificationSettingsProxy.isCallEnabledReturnValue = false
|
|
|
|
let userSession = UserSessionMock(.init(clientProxy: ClientProxyMock(.init(userID: "John Doe"))))
|
|
|
|
var viewModel = NotificationSettingsScreenViewModel(appSettings: appSettings,
|
|
userNotificationCenter: notificationCenter,
|
|
notificationToneManager: NotificationToneManagerMock.default,
|
|
notificationSettingsProxy: notificationSettingsProxy,
|
|
userIndicatorController: UserIndicatorControllerMock.default,
|
|
isModallyPresented: true)
|
|
viewModel.fetchInitialContent()
|
|
return viewModel
|
|
}()
|
|
|
|
static let viewModelConfigurationMismatch: NotificationSettingsScreenViewModel = {
|
|
let appSettings = AppSettings.volatile()
|
|
let notificationCenter = UserNotificationCenterMock()
|
|
notificationCenter.authorizationStatusReturnValue = .notDetermined
|
|
let notificationSettingsProxy = NotificationSettingsProxyMock(with: .init())
|
|
notificationSettingsProxy.getDefaultRoomNotificationModeIsEncryptedIsOneToOneClosure = { isEncrypted, isOneToOne in
|
|
switch (isEncrypted, isOneToOne) {
|
|
case (true, true):
|
|
return .allMessages
|
|
case (false, true):
|
|
return .mute
|
|
default:
|
|
return .mentionsAndKeywordsOnly
|
|
}
|
|
}
|
|
notificationSettingsProxy.isRoomMentionEnabledReturnValue = true
|
|
notificationSettingsProxy.isCallEnabledReturnValue = false
|
|
|
|
let userSession = UserSessionMock(.init(clientProxy: ClientProxyMock(.init(userID: "John Doe"))))
|
|
|
|
var viewModel = NotificationSettingsScreenViewModel(appSettings: appSettings,
|
|
userNotificationCenter: notificationCenter,
|
|
notificationToneManager: NotificationToneManagerMock.default,
|
|
notificationSettingsProxy: notificationSettingsProxy,
|
|
userIndicatorController: UserIndicatorControllerMock(),
|
|
isModallyPresented: true)
|
|
viewModel.fetchInitialContent()
|
|
return viewModel
|
|
}()
|
|
|
|
static var previews: some View {
|
|
NotificationSettingsScreen(context: viewModel.context)
|
|
.snapshotPreferences(expect: viewModel.context.observe(\.viewState.settings).map { $0 != nil })
|
|
|
|
NotificationSettingsScreen(context: viewModelConfigurationMismatch.context)
|
|
.snapshotPreferences(expect: viewModelConfigurationMismatch.context.observe(\.viewState.settings).map { $0 != nil })
|
|
.previewDisplayName("Configuration mismatch")
|
|
}
|
|
}
|