mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-10-31 16:24:11 +00:00
Michael
22d14ff8e4
* create DependenciesProtocol and replace ServiceLocator registration with it replace mocking calls for ServiceLocator to Dependencies replace ServiceLocator with instance level calls replace ServiceLocator configs with TestDependencies config in Tests replace servicelocator usage in analytics service replace remaining ServiceLocator calls in unit tests that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances fix swiftlint warning remove remaining references to ServiceLocator make dependencies properties consistent in tests delete Dependencies and DependenciesProtocol fix whitespace modifications updates from PR feedback a pass over converting AppSettings and AnalyticsService test instance properties to per test instantiation fix a missed PR feedback Sync up after rebase create DependenciesProtocol and replace ServiceLocator registration with it replace mocking calls for ServiceLocator to Dependencies replace ServiceLocator with instance level calls replace ServiceLocator configs with TestDependencies config in Tests replace servicelocator usage in analytics service replace remaining ServiceLocator calls in unit tests that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances fix swiftlint warning remove remaining references to ServiceLocator make dependencies properties consistent in tests delete Dependencies and DependenciesProtocol * AppSettings is instance level mockable now * replace mocked and preview usages of reset + AppSettings global init with AppSettings(store: UserDefaultsMock()) * AppSettings.UserDefaultsKeys is now a RawRep struct, making it extensible * update tests with new AppSettings so it builds * update remaining AppSettings test/mock inits * AppSettings.UserDefaultsKey conformed to ExpressibleByStringLiteral * addressed issues found in first pass ai review * update AppSettings instantiations after rebase * fix accessibility tests coordinator after rebase * Rename to VolatileUserDefaults * AppSettings init uses mandatory parameter * Revert UserDefaultsKey to enum * Add TrackedUserDefaults to be able to reset the defaults object * Added volatile static func to AppSettings * Use .volatile() static func instead of full init * review fixups * Resolve build issues after rebase * updated enterprise module * remove the static reset settings call from the preview tests --------- Co-authored-by: Mauro Romito <mauro.romito@element.io>
220 lines
11 KiB
Swift
220 lines
11 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2022-2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
@testable import ElementX
|
|
import Testing
|
|
|
|
@MainActor
|
|
struct KnockRequestsListScreenViewModelTests {
|
|
@Test
|
|
func loadingState() async throws {
|
|
let roomProxyMock = JoinedRoomProxyMock(.init(knockRequestsState: .loading, joinRule: .knock))
|
|
let viewModel = KnockRequestsListScreenViewModel(roomProxy: roomProxyMock,
|
|
mediaProvider: MediaProviderMock(),
|
|
userIndicatorController: UserIndicatorControllerMock())
|
|
let context = viewModel.context
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { state in
|
|
!state.shouldDisplayRequests &&
|
|
state.isKnockableRoom &&
|
|
state.canAccept &&
|
|
!state.canBan &&
|
|
!state.canDecline &&
|
|
state.isLoading &&
|
|
!state.shouldDisplayEmptyView
|
|
}
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func emptyState() async throws {
|
|
let roomProxyMock = JoinedRoomProxyMock(.init(knockRequestsState: .loaded([]), joinRule: .knock))
|
|
let viewModel = KnockRequestsListScreenViewModel(roomProxy: roomProxyMock,
|
|
mediaProvider: MediaProviderMock(),
|
|
userIndicatorController: UserIndicatorControllerMock())
|
|
let context = viewModel.context
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { state in
|
|
!state.shouldDisplayRequests &&
|
|
state.isKnockableRoom &&
|
|
state.canAccept &&
|
|
!state.canBan &&
|
|
!state.canDecline &&
|
|
!state.isLoading &&
|
|
state.shouldDisplayEmptyView
|
|
}
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func loadedState() async throws {
|
|
let roomProxyMock = JoinedRoomProxyMock(.init(members: [.mockAdmin],
|
|
knockRequestsState: .loaded([KnockRequestProxyMock(.init(eventID: "1", userID: "@alice:matrix.org")),
|
|
KnockRequestProxyMock(.init(eventID: "2", userID: "@bob:matrix.org")),
|
|
KnockRequestProxyMock(.init(eventID: "3", userID: "@charlie:matrix.org")),
|
|
KnockRequestProxyMock(.init(eventID: "4", userID: "@dan:matrix.org"))]),
|
|
ownUserID: RoomMemberProxyMock.mockAdmin.userID,
|
|
joinRule: .knock))
|
|
let viewModel = KnockRequestsListScreenViewModel(roomProxy: roomProxyMock,
|
|
mediaProvider: MediaProviderMock(),
|
|
userIndicatorController: UserIndicatorControllerMock())
|
|
let context = viewModel.context
|
|
|
|
var deferred = deferFulfillment(context.$viewState) { state in
|
|
state.shouldDisplayRequests &&
|
|
state.isKnockableRoom &&
|
|
state.canAccept &&
|
|
state.canBan &&
|
|
state.canDecline &&
|
|
!state.isLoading &&
|
|
!state.shouldDisplayEmptyView &&
|
|
state.displayedRequests.count == 4 &&
|
|
state.handledEventIDs.isEmpty &&
|
|
state.shouldDisplayAcceptAllButton
|
|
}
|
|
try await deferred.fulfill()
|
|
|
|
deferred = deferFulfillment(context.$viewState) { state in
|
|
state.shouldDisplayRequests &&
|
|
state.handledEventIDs == ["1"] &&
|
|
!state.shouldDisplayEmptyView &&
|
|
state.displayedRequests.count == 3 &&
|
|
state.shouldDisplayAcceptAllButton
|
|
}
|
|
context.send(viewAction: .acceptRequest(eventID: "1"))
|
|
try await deferred.fulfill()
|
|
|
|
deferred = deferFulfillment(context.$viewState) { state in
|
|
state.bindings.alertInfo?.id == .declineRequest
|
|
}
|
|
context.send(viewAction: .declineRequest(eventID: "2"))
|
|
try await deferred.fulfill()
|
|
|
|
let declineAlertInfo = try #require(context.alertInfo)
|
|
deferred = deferFulfillment(context.$viewState) { state in
|
|
state.shouldDisplayRequests &&
|
|
state.handledEventIDs == ["1", "2"] &&
|
|
!state.shouldDisplayEmptyView &&
|
|
state.displayedRequests.count == 2 &&
|
|
state.shouldDisplayAcceptAllButton
|
|
}
|
|
declineAlertInfo.primaryButton.action?()
|
|
try await deferred.fulfill()
|
|
|
|
deferred = deferFulfillment(context.$viewState) { state in
|
|
state.bindings.alertInfo?.id == .declineAndBan
|
|
}
|
|
context.send(viewAction: .ban(eventID: "3"))
|
|
try await deferred.fulfill()
|
|
|
|
let banAlertInfo = try #require(context.alertInfo)
|
|
deferred = deferFulfillment(context.$viewState) { state in
|
|
state.shouldDisplayRequests &&
|
|
state.handledEventIDs == ["1", "2", "3"] &&
|
|
!state.shouldDisplayEmptyView &&
|
|
state.displayedRequests.count == 1 &&
|
|
!state.shouldDisplayAcceptAllButton
|
|
}
|
|
banAlertInfo.primaryButton.action?()
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func acceptAll() async throws {
|
|
let roomProxyMock = JoinedRoomProxyMock(.init(knockRequestsState: .loaded([KnockRequestProxyMock(.init(eventID: "1", userID: "@alice:matrix.org")),
|
|
KnockRequestProxyMock(.init(eventID: "2", userID: "@bob:matrix.org")),
|
|
KnockRequestProxyMock(.init(eventID: "3", userID: "@charlie:matrix.org")),
|
|
KnockRequestProxyMock(.init(eventID: "4", userID: "@dan:matrix.org"))]),
|
|
joinRule: .knock))
|
|
let viewModel = KnockRequestsListScreenViewModel(roomProxy: roomProxyMock,
|
|
mediaProvider: MediaProviderMock(),
|
|
userIndicatorController: UserIndicatorControllerMock())
|
|
let context = viewModel.context
|
|
|
|
var deferred = deferFulfillment(context.$viewState) { state in
|
|
state.shouldDisplayRequests &&
|
|
state.isKnockableRoom &&
|
|
state.canAccept &&
|
|
!state.canBan &&
|
|
!state.canDecline &&
|
|
!state.isLoading &&
|
|
!state.shouldDisplayEmptyView &&
|
|
state.displayedRequests.count == 4 &&
|
|
state.handledEventIDs.isEmpty &&
|
|
state.shouldDisplayAcceptAllButton
|
|
}
|
|
try await deferred.fulfill()
|
|
|
|
deferred = deferFulfillment(context.$viewState) { state in
|
|
state.bindings.alertInfo?.id == .acceptAllRequests
|
|
}
|
|
context.send(viewAction: .acceptAllRequests)
|
|
try await deferred.fulfill()
|
|
|
|
let alertInfo = try #require(context.alertInfo)
|
|
|
|
deferred = deferFulfillment(context.$viewState) { state in
|
|
!state.shouldDisplayRequests &&
|
|
state.handledEventIDs == ["1", "2", "3", "4"] &&
|
|
!state.isLoading &&
|
|
state.shouldDisplayEmptyView
|
|
}
|
|
alertInfo.primaryButton.action?()
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func loadedStateBecomesEmptyIfTheJoinRuleIsNotKnocking() async throws {
|
|
// If there is a sudden change in the rule, but the requests are still published, we want to hide all of them and show the empty view
|
|
let roomProxyMock = JoinedRoomProxyMock(.init(members: [.mockAdmin],
|
|
knockRequestsState: .loaded([KnockRequestProxyMock(.init(eventID: "1", userID: "@alice:matrix.org")),
|
|
KnockRequestProxyMock(.init(eventID: "2", userID: "@bob:matrix.org")),
|
|
KnockRequestProxyMock(.init(eventID: "3", userID: "@charlie:matrix.org")),
|
|
KnockRequestProxyMock(.init(eventID: "4", userID: "@dan:matrix.org"))]),
|
|
ownUserID: RoomMemberProxyMock.mockAdmin.userID,
|
|
joinRule: .invite))
|
|
let viewModel = KnockRequestsListScreenViewModel(roomProxy: roomProxyMock,
|
|
mediaProvider: MediaProviderMock(),
|
|
userIndicatorController: UserIndicatorControllerMock())
|
|
let context = viewModel.context
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { state in
|
|
!state.shouldDisplayRequests &&
|
|
state.shouldDisplayEmptyView &&
|
|
!state.isLoading &&
|
|
!state.isKnockableRoom
|
|
}
|
|
try await deferred.fulfill()
|
|
}
|
|
|
|
@Test
|
|
func loadedStateBecomesEmptyIfPermissionsAreRemoved() async throws {
|
|
// If there is a sudden change in permissions, and the user can't do any other action, we hide all the requests and shoe the empty view
|
|
let roomProxyMock = JoinedRoomProxyMock(.init(knockRequestsState: .loaded([KnockRequestProxyMock(.init(eventID: "1", userID: "@alice:matrix.org")),
|
|
KnockRequestProxyMock(.init(eventID: "2", userID: "@bob:matrix.org")),
|
|
KnockRequestProxyMock(.init(eventID: "3", userID: "@charlie:matrix.org")),
|
|
KnockRequestProxyMock(.init(eventID: "4", userID: "@dan:matrix.org"))]),
|
|
joinRule: .knock,
|
|
powerLevelsConfiguration: .init(canUserInvite: false)))
|
|
let viewModel = KnockRequestsListScreenViewModel(roomProxy: roomProxyMock,
|
|
mediaProvider: MediaProviderMock(),
|
|
userIndicatorController: UserIndicatorControllerMock())
|
|
let context = viewModel.context
|
|
|
|
let deferred = deferFulfillment(context.$viewState) { state in
|
|
!state.shouldDisplayRequests &&
|
|
state.shouldDisplayEmptyView &&
|
|
!state.canAccept &&
|
|
!state.canBan &&
|
|
!state.canDecline &&
|
|
!state.isLoading
|
|
}
|
|
try await deferred.fulfill()
|
|
}
|
|
}
|