mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-01 09:42:39 +00:00
22d14ff8e4
* create DependenciesProtocol and replace ServiceLocator registration with it replace mocking calls for ServiceLocator to Dependencies replace ServiceLocator with instance level calls replace ServiceLocator configs with TestDependencies config in Tests replace servicelocator usage in analytics service replace remaining ServiceLocator calls in unit tests that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances fix swiftlint warning remove remaining references to ServiceLocator make dependencies properties consistent in tests delete Dependencies and DependenciesProtocol fix whitespace modifications updates from PR feedback a pass over converting AppSettings and AnalyticsService test instance properties to per test instantiation fix a missed PR feedback Sync up after rebase create DependenciesProtocol and replace ServiceLocator registration with it replace mocking calls for ServiceLocator to Dependencies replace ServiceLocator with instance level calls replace ServiceLocator configs with TestDependencies config in Tests replace servicelocator usage in analytics service replace remaining ServiceLocator calls in unit tests that depended on the UnitTestAppCoordinator configuration with per suite dependencies instances fix swiftlint warning remove remaining references to ServiceLocator make dependencies properties consistent in tests delete Dependencies and DependenciesProtocol * AppSettings is instance level mockable now * replace mocked and preview usages of reset + AppSettings global init with AppSettings(store: UserDefaultsMock()) * AppSettings.UserDefaultsKeys is now a RawRep struct, making it extensible * update tests with new AppSettings so it builds * update remaining AppSettings test/mock inits * AppSettings.UserDefaultsKey conformed to ExpressibleByStringLiteral * addressed issues found in first pass ai review * update AppSettings instantiations after rebase * fix accessibility tests coordinator after rebase * Rename to VolatileUserDefaults * AppSettings init uses mandatory parameter * Revert UserDefaultsKey to enum * Add TrackedUserDefaults to be able to reset the defaults object * Added volatile static func to AppSettings * Use .volatile() static func instead of full init * review fixups * Resolve build issues after rebase * updated enterprise module * remove the static reset settings call from the preview tests --------- Co-authored-by: Mauro Romito <mauro.romito@element.io>
119 lines
5.9 KiB
Swift
119 lines
5.9 KiB
Swift
//
|
|
// Copyright 2025 Element Creations Ltd.
|
|
// Copyright 2025 New Vector Ltd.
|
|
//
|
|
// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
|
|
// Please see LICENSE files in the repository root for full details.
|
|
//
|
|
|
|
@testable import ElementX
|
|
import MatrixRustSDK
|
|
import MatrixRustSDKMocks
|
|
import Testing
|
|
|
|
@MainActor
|
|
final class RoomSummaryProviderTests {
|
|
private let baseFilters: [RoomListEntriesDynamicFilterKind] = [.any(filters: [.all(filters: [.nonSpace, .nonLeft]),
|
|
.all(filters: [.space, .invite])]),
|
|
.deduplicateVersions]
|
|
|
|
var appSettings: AppSettings!
|
|
var roomList: RoomListSDKMock!
|
|
var dynamicEntriesController: RoomListDynamicEntriesControllerSDKMock!
|
|
var roomSummaryProvider: RoomSummaryProvider!
|
|
|
|
@Test
|
|
func defaultRustFilters() async {
|
|
// Given a new room provider.
|
|
setup()
|
|
await Task.yield()
|
|
|
|
// Then it should have the default Rust filters enabled.
|
|
#expect(dynamicEntriesController.setFilterKindCallsCount == 1)
|
|
#expect(dynamicEntriesController.setFilterKindReceivedInvocations.last == .all(filters: baseFilters))
|
|
|
|
// When setting one our user filters.
|
|
roomSummaryProvider.setFilter(.all(filters: [.favourites]))
|
|
await Task.yield()
|
|
|
|
// Then that filter should be added to the default Rust filters.
|
|
#expect(dynamicEntriesController.setFilterKindCallsCount == 2)
|
|
#expect(dynamicEntriesController.setFilterKindReceivedInvocations.last == .all(filters: [.all(filters: [.favourite, .joined])] + baseFilters))
|
|
}
|
|
|
|
@Test
|
|
func lowPriorityRustFilters() async {
|
|
// Given a new room provider with the low priority filter enabled.
|
|
setup(isLowPriorityFilterEnabled: true)
|
|
await Task.yield()
|
|
|
|
// Then the default Rust filters should include the non-low priority filter,
|
|
// so that low priority rooms are hidden from the top of the room list.
|
|
#expect(dynamicEntriesController.setFilterKindCallsCount == 1)
|
|
#expect(dynamicEntriesController.setFilterKindReceivedInvocations.last == .all(filters: baseFilters + [.nonLowPriority]))
|
|
|
|
// When setting the low priority filter.
|
|
roomSummaryProvider.setFilter(.all(filters: [.lowPriority]))
|
|
await Task.yield()
|
|
|
|
// Then the non-low priority filter should be replaced with the low priority filter.
|
|
#expect(dynamicEntriesController.setFilterKindCallsCount == 2)
|
|
#expect(dynamicEntriesController.setFilterKindReceivedInvocations.last == .all(filters: [.all(filters: [.lowPriority, .joined])] + baseFilters))
|
|
|
|
// When setting another one of our filters.
|
|
roomSummaryProvider.setFilter(.all(filters: [.rooms]))
|
|
await Task.yield()
|
|
|
|
// Then the filter should be combined with the non-low priority filter.
|
|
#expect(dynamicEntriesController.setFilterKindCallsCount == 3)
|
|
#expect(dynamicEntriesController.setFilterKindReceivedInvocations.last == .all(filters: [.all(filters: [.category(expect: .group), .joined])] + baseFilters + [.nonLowPriority]))
|
|
}
|
|
|
|
@Test
|
|
func roomIdentifierFilters() async {
|
|
setup()
|
|
await Task.yield()
|
|
|
|
// Then it should have the default Rust filters enabled.
|
|
#expect(dynamicEntriesController.setFilterKindCallsCount == 1)
|
|
#expect(dynamicEntriesController.setFilterKindReceivedInvocations.last == .all(filters: baseFilters))
|
|
|
|
// When setting one our user filters.
|
|
roomSummaryProvider.setFilter(.rooms(roomsIDs: ["SomeRoom"], filters: [.favourites]))
|
|
await Task.yield()
|
|
|
|
// Then that filter should be added to the default Rust filters.
|
|
#expect(dynamicEntriesController.setFilterKindCallsCount == 2)
|
|
#expect(dynamicEntriesController.setFilterKindReceivedInvocations.last == .all(filters: [.all(filters: [.favourite, .joined])] + baseFilters + [.identifiers(identifiers: ["SomeRoom"])]))
|
|
}
|
|
|
|
// MARK: - Helpers
|
|
|
|
private func setup(isLowPriorityFilterEnabled: Bool = false) {
|
|
appSettings = AppSettings.volatile()
|
|
appSettings.lowPriorityFilterEnabled = isLowPriorityFilterEnabled
|
|
|
|
let stateEventStringBuilder = RoomStateEventStringBuilder(userID: "@me:matrix.org")
|
|
let attributedStringBuilder = AttributedStringBuilder(mentionBuilder: MentionBuilder())
|
|
let eventStringBuilder = RoomEventStringBuilder(stateEventStringBuilder: stateEventStringBuilder,
|
|
messageEventStringBuilder: RoomMessageEventStringBuilder(attributedStringBuilder: attributedStringBuilder,
|
|
style: .senderPrefixed),
|
|
shouldPrefixSenderName: true)
|
|
|
|
roomSummaryProvider = RoomSummaryProvider(roomListService: RoomListServiceSDKMock(),
|
|
eventStringBuilder: eventStringBuilder,
|
|
name: "Test",
|
|
notificationSettings: NotificationSettingsProxyMock(with: .init()),
|
|
appSettings: appSettings)
|
|
|
|
dynamicEntriesController = RoomListDynamicEntriesControllerSDKMock()
|
|
dynamicEntriesController.setFilterKindReturnValue = true
|
|
let dynamicAdaptersResult = RoomListEntriesWithDynamicAdaptersResultSDKMock()
|
|
dynamicAdaptersResult.controllerReturnValue = dynamicEntriesController
|
|
roomList = RoomListSDKMock()
|
|
roomList.entriesWithDynamicAdaptersPageSizeListenerReturnValue = dynamicAdaptersResult
|
|
roomList.loadingStateListenerReturnValue = .some(.init(state: .notLoaded, stateStream: .init(noHandle: .init())))
|
|
roomSummaryProvider.setRoomList(roomList)
|
|
}
|
|
}
|