mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-10-31 16:24:11 +00:00
joel.poyet
4e8774a9a8
* Make CI work on this internal fork
Every check was red on every pull request. Upstream declares permissions: {} in its
workflows, which costs nothing on a public repo and is fatal here: the token is
limited to Metadata:read, so actions/checkout cannot read an internal repo and dies
with a misleading "Repository not found". Repo settings cannot fix it — an explicit
permissions block always overrides the default.
Each job now gets the minimum it needs. Danger also reads the pull request through
the issues API, so it needs issues:read alongside pull-requests:write, and zizmor's
SARIF upload needs actions:read on a private repo.
The unit tests move to the org's Mac Studio: GitHub-hosted macos-26 could not finish
inside the hour and bills at 10x. Preview tests are skipped there, using the flag
upstream already uses for its own enterprise tests — they render a snapshot per
preview and never once finished on either runner. The trade is that preview snapshot
regressions are no longer caught in CI.
Workflows that only make sense upstream are gated off rather than deleted, so they
keep rebasing cleanly. The enterprise tests need Element's bot token and their
private submodule. Three nightlies fail at checkout every weeknight — this repo is a
detached copy rather than a network fork, so GitHub never disabled their schedules —
and one of them posts to Element's Codecov on every run.
* Erase the test simulators before running the tests
The unit tests assume a clean simulator, which costs nothing on a hosted VM
because it hands out a fresh device every run. This runner reuses the same two
devices, so app containers, caches and logs survive between runs and six suites
fail on the previous run's leftovers rather than on anything in the code.
LoggingTests is the clearest: it expects no log files and finds nine, in the same
device container each time.
Only the two devices the tooling pins are erased, resolved by UDID. A blanket
erase would take out simulator state belonging to other work on a machine the
release pipeline shares.
* Remove the simulator reset again
It was added on the theory that the runner's reused simulators were leaking state
between runs. That theory was wrong: erasing both devices changed nothing — the
same seven suites failed identically before and after.
The leftover files LoggingTests trips on are its own, from a previous attempt of
the same test within one run (the suite runs with -test-iterations 4), so nothing
crosses runs for an erase to clean. Keeping a step that mutates shared state on the
release machine for no measured benefit is worse than not having it.
88 lines
3.3 KiB
YAML
88 lines
3.3 KiB
YAML
name: UI Tests
|
|
|
|
on:
|
|
workflow_dispatch:
|
|
inputs:
|
|
test_name:
|
|
description: 'If a test name is provided, only that test will be run. Otherwise, all tests will be run. Use the format "ClassName/testName" to run a single test.'
|
|
required: false
|
|
|
|
schedule:
|
|
- cron: "0 2 * * 1-5"
|
|
|
|
permissions: {}
|
|
|
|
jobs:
|
|
tests:
|
|
name: Tests
|
|
# HealthChat: skip in this fork. It runs nightly Mon-Fri and fails at checkout, because
|
|
# permissions: {} leaves a metadata-only token that cannot read an INTERNAL repo. Fixing the
|
|
# permission would not help: the rebrand changed the start screen without re-recording any
|
|
# UITests snapshot, so it would fail on content instead. Gated rather than deleted so the file
|
|
# keeps rebasing cleanly. Run locally with `swift run tools ci ui-tests`.
|
|
if: github.repository == 'element-hq/element-x-ios'
|
|
runs-on: macos-26
|
|
timeout-minutes: 90
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
device: [iPhone, iPad]
|
|
|
|
concurrency:
|
|
# Only allow a single run of this workflow on each branch, automatically cancelling older runs.
|
|
group: ${{ format('ui-tests-{0}-{1}', github.ref, matrix.device) }}
|
|
cancel-in-progress: true
|
|
|
|
steps:
|
|
- uses: nschloe/action-cached-lfs-checkout@385a8ecc719e50b8c71af6ab01a624b486b7c3bc # v1.2.5
|
|
with:
|
|
persist-credentials: false
|
|
|
|
- name: Setup environment
|
|
run: source ci_scripts/ci_common.sh && setup_github_actions_environment
|
|
|
|
- name: Run tests
|
|
run: |
|
|
args=(--device-type "${{ matrix.device }}")
|
|
if [[ -n "${GITHUB_EVENT_INPUTS_TEST_NAME}" ]]; then
|
|
args+=( --test-name "${GITHUB_EVENT_INPUTS_TEST_NAME}")
|
|
fi
|
|
swift run -q tools ci ui-tests "${args[@]}"
|
|
env:
|
|
GITHUB_EVENT_INPUTS_TEST_NAME: ${{ github.event.inputs.test_name }}
|
|
|
|
- name: Archive artifacts
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
# We only care about artefacts if the tests fail
|
|
if: failure()
|
|
with:
|
|
name: ${{ matrix.device }}
|
|
path: test_output/UITests.xcresult.zip
|
|
retention-days: 7
|
|
if-no-files-found: ignore
|
|
|
|
- name: Upload coverage to Codecov
|
|
# Skip if not successful and in forks
|
|
if: ${{ success() && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) }}
|
|
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
|
|
with:
|
|
report_type: coverage
|
|
files: test_output/ui-cobertura.xml
|
|
disable_search: true
|
|
fail_ci_if_error: true
|
|
token: ${{ secrets.CODECOV_TOKEN }}
|
|
flags: uitests
|
|
|
|
- name: Upload test results to Codecov
|
|
# Skip if cancelled and in forks
|
|
if: ${{ !cancelled() && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) }}
|
|
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
|
|
continue-on-error: true
|
|
with:
|
|
report_type: test_results
|
|
files: test_output/ui-junit.xml
|
|
disable_search: true
|
|
fail_ci_if_error: false
|
|
token: ${{ secrets.CODECOV_TOKEN }}
|
|
flags: uitests
|