Commit Graph

778 Commits

Author SHA1 Message Date
Doug 8f2904701b Fix more unit tests. (#1406)
- Randomise test order.
- Use deferred fulfilment in more places.
- Make sure to change something before awaiting the fulfilment.
- Build a fresh AppSettings after reset().
- Retry tests on failure.
2023-07-27 12:38:48 +01:00
Alfonso Grillo 1529b5b8ca Update SDK to 1.0.102-alpha (#1408)
* Update SDK to 1.0.102-alpha

* Log error

* Notification Improvements API part 1 (#1410)

* changes

* WIP

* progress

* updated test

* removed unused

* code improvement

* Process diffs as batches provided by the SDK.

---------

Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
Co-authored-by: Doug <douglase@element.io>
2023-07-27 09:48:56 +00:00
Alfonso Grillo 90ff2df00e Refactor TimelineItemBubbledStylerView for polls (#1404)
* Refactor bubble bg colors and insets

* Improve MapLibreStaticMapView layout

* Add BubbleTimestampLayout

* Refactor BubbleTimestampLayoutType

* Refine .horizontal, .vertical layouts

* Rename layout type

* Add docs

* Restore LocationRoomTimelineItem body

* Refactor whitespaces

* Fix background color for LocationRoomTimelineView.

* Fix UTs

* Fix analytics ui tests

* Fix bug report tests

* Fix settings ui tests

* Rename private property

* Record room screen tests
2023-07-26 15:17:41 +00:00
Mauro 99b5bf5150 Reverting to TableView but with SwiftUI compatibility (#1407)
* revert but also allows us to keep the existing SwiftUI implementation if we need it

* code improvement

* pr review

* FF is volatile

* message that communicates that is volatile
2023-07-26 13:53:43 +00:00
Mauro ba6ad3236f Update RoomScreen and UserSessionScreen UI tests (#1400)
* room tests

* User session screen tests

* regenerated keyboard ones

* fixing some minor issues

* code improvement

* fixed the remaining tests

* fixed last two
2023-07-26 12:23:15 +02:00
Doug f2ffded87e Use generated UIColors everywhere. (#1405)
- Fix destructive buttons in the menu.
2023-07-26 11:21:34 +01:00
Nicolas Mauri ed68ed1c91 Edit the room Notification setting (#1394) 2023-07-26 09:27:14 +00:00
Mauro Romito ed28bc5d02 two sync loop always enabled by default 2023-07-26 10:39:19 +02:00
Doug 7a9edc5efa Make the app version and the device ID copyable in the Settings screen. (#1389) 2023-07-25 17:31:42 +00:00
Stefan Ceriu 9f4479b57a Fix problem with disclosure groups randomly not disclosing by replacing with custom component
- 99% of the code is the same as we were already massively customising it
2023-07-25 18:46:14 +03:00
Alfonso Grillo ec7670165c Fix LocationRoomTimelineView clipping (#1396) 2023-07-25 16:04:48 +02:00
Mauro 7cf32ba37c SwiftUI timeline refactor + TimelineViewState decoupling (#1392)
* swiftUI conversion + scroll to bottom

* remove unused

* back pagination implemented, however when a lot of elements are in the scroll the perfomance diminishes not sure what may be causing it

* scroll adapter solution

* way better

* works but height animation in cells are broken

* code improvement

* everything implemented

* rebase fix

* fix

* doc

* fix test compilation

* code improvement and animation improvement

* code improvement

* code improvements

* tests updated.

* pr comments

* better identifiers

* fix

* some PR comments

* pr comments
2023-07-25 12:20:13 +00:00
Doug 43dafda3ef Tweaks for macOS (#1383)
* Fix constant Create Room button animation on macOS.

* Allow right-clicking on timeline items to work again on macOS.

* Use inline media upload previews on macOS

This comes with the caveat that the previews are no longer interactive.
2023-07-24 12:08:50 +00:00
Stefan Ceriu de199382de Default media upload file mime types to application/octet-stream so that uploading doesn't fail rust side 2023-07-24 12:24:13 +03:00
Alfonso Grillo 6fc8c31449 Reduce boilerplate in Developer Options Screen (#1378)
* Reduce developer options boilerplate

* Add protocol DeveloperOptions

* Delete timelineDiffableAnimationsEnabled

* Refactor DeveloperOptions -> DeveloperOptionsProtocol
2023-07-24 08:42:14 +00:00
Mauro Romito 83ed717dcd better code 2023-07-21 17:57:23 +02:00
Mauro Romito c0b868e3c7 avoid problems 2023-07-21 17:57:23 +02:00
Doug fbe05a8679 Compound Room Details (#1369) 2023-07-21 14:22:09 +01:00
Doug 3b0961f3c5 Fix tint colour in dark mode. (#1376) 2023-07-21 11:05:40 +01:00
Mauro b1df9efd46 fix (#1375) 2023-07-20 15:55:34 +00:00
Alfonso Grillo 48b15678df Disable map tilt and rotate interactions (#1373) 2023-07-20 15:29:38 +00:00
Alfonso Grillo e92b2c94ed Refactor map styles for forking (#1364)
* Add MapLibreStyle

* Refactor url builders

* Add doc

* Add UTs

* Rename style

* Improve doc

* Update project

* Amend doc

* Improve documentation
2023-07-20 15:09:50 +00:00
Doug 0561bac46b Fix tint colour on alerts and dialogs. (#1370) 2023-07-20 14:37:10 +00:00
Mauro 5a24d0817c Fix for offset 1 not making new messages auto scroll (#1371)
* bett docs + fix

* better doc

* small code improvement

* code improvement

* code improvement
2023-07-20 13:52:02 +00:00
Alfonso Grillo ed27aa9a47 Location event body representation (#1368)
* Change GeoURI body format

* Update location event representation
2023-07-20 13:04:13 +00:00
Mauro f0ca15290f Flipping the tableView (#1366)
* I can't believe this works so well.

* code improvements

* we probably just need to change the TODO

* better naming

* done, there is only one small bug to fix

* fix

* this needs to be decided

* fixed the backpagination issue and improved the scroll to top gesture triggered by tapping on the clock (but won't work when I am at the bottom)

* fix
2023-07-20 11:29:45 +00:00
Stefan Ceriu 5f8efefe19 Fixes #1262 - Compute correct sizes for portrait videos (#1367)
* Fixes #1262 - Compute correct sizes for portrait videos

* Add unit test

* Tweaks following code review
2023-07-20 10:30:43 +00:00
Doug 66eea98b33 Fix visibility of navigation bar when searching the forwarding screen. (#1357)
* Fix visibility of navigation bar when searching the forwarding screen.

- Update Introspect and replace deprecated calls with new ones.
- Remove obsoleted colours from DesignKit.
2023-07-19 15:55:21 +00:00
Mauro caeb86e178 Better identification system for virtual items (#1361)
* better identification system

* better handling for unknown
2023-07-19 14:29:56 +00:00
Alfonso Grillo df58d8378e Delete Location Sharing feature flags (#1358)
* Delete location sharing feature flags

* Add changelog.d file

* Update localizations

* Amend changelog file
2023-07-19 12:15:26 +02:00
Alfonso Grillo cf39710891 Remove ”copy” action for location events (#1355)
* Hide ”copy” action for location events

* Cleanup
2023-07-18 15:54:42 +00:00
Mauro Romito ad1422ad6c sdk bump 2023-07-18 17:32:11 +02:00
Mauro f46abbaf9e Diffable fade animations (#1343)
* animate only 2 seconds after the appearence

* scrolling is stable

* code improvement

* comment and removing code that is not necessary anymore

* feature flag

* comment

* better code

* the day divider ID is the timestamp itself as ISO

* Apply suggestions from code review

Co-authored-by: Alfonso Grillo <alfogrillo@gmail.com>

* format fix

---------

Co-authored-by: Alfonso Grillo <alfogrillo@gmail.com>
2023-07-18 14:18:11 +00:00
Doug 48dbbfb4d0 Log the crash event's ID to see if duplicate logs are for the same event. (#1350) 2023-07-18 15:00:33 +01:00
Mauro 19ecf906e3 Redacting is now displayed for moderators in groups (#1324)
* basic implementation

* sdk update

* format

* changelog
2023-07-18 13:51:27 +00:00
Alfonso Grillo 55892eb05b Fix map tint color (#1354) 2023-07-18 15:16:23 +02:00
Stefan Ceriu 9e95130331 Fixes #1247 - Pasting from Notes into EX tries to upload an RTF attachment 2023-07-18 13:53:42 +03:00
Stefan Ceriu d0965c7f88 Fixes #1332 - Pasting an image from MobileSafari gives both url and file upload 2023-07-18 13:53:42 +03:00
Stefan Ceriu 3a538c6e29 Cleanup sync service state management using new currentState sdk support 2023-07-18 13:52:51 +03:00
Doug c83a2bd729 Tidy up Developer screen, add button to crash the app. (#1348)
* ID all the things
2023-07-18 11:25:07 +01:00
Mauro Romito 63935ceab3 sdk bump 2023-07-18 10:03:25 +02:00
Alfonso Grillo 79fcfcd61b Update errorMissingLocationAuth (#1341) 2023-07-17 13:19:28 +00:00
Stefan Ceriu 870cefe316 Fix syncing not restaring because of relying on the roomList service state instead of the sync service one 2023-07-17 14:36:46 +03:00
Mauro 2baeb13ebc Updating members after an ignore/unignore action has been performed. (#1327)
* fix

* format

* update members
2023-07-17 10:57:47 +00:00
Alfonso Grillo 04b83aaf38 Fix UserIndicatorController delayed appearance (#1330) 2023-07-17 10:16:41 +00:00
Velin92 4441a65845 Translations update 2023-07-17 10:12:45 +02:00
David Langley b31af77686 Reactions: Add more button (#1314)
* Add expand/collapse UI for reactions

- Adds a CollapsibleFlowLayout for controlling the layout
- Adds tests for  this layout and some mocks for testing layouts generally
- Improves the rendering of the reaction buttons which were not pixel perfect
- Adds the UI for the expand collapse buttons including the count of hidden items in the collapsed state.

* Add comment for reactionsCollapsed binding.

* Add the add more button and change the layout to be reactions specific and account for the add more button specifics.

* Update CollapsibleReactionLayout.swift

* Rename lines to rows, to hopefully ease the incoming merge.

* Add LayoutValueKey to organise subviews by item type.

- create ReactionLayoutItemType to tag subviews with ReactionLayoutItem
- Add LayoutValueKey support to the layout mocks
- Fix some mistakes in the merge
- Make the test code a bit more DRY
- Make the animation of the addMore and collapse buttons consistent

* Fix naming of the add more button label

* Address comments and fix padding

- Fix typos
- Use pdf/svg for icon
- Fix incorrect padding from a bad merge

* Fix "Add more" button padding to match designs

* Update snapshot test reference images.

* Fix naming, add Preserves Vector Data
2023-07-14 16:32:32 +00:00
David Langley a44a60cb0a Sort reactions on the timeline by count and then timestamp and show the date on the summary view (#1320)
* Sort timetamps on timeline and show the date on the summary view

- Sort reaction aggregations on the timeline by count and then by most recent timestamp ascending(tagging new reactions on the end)
- Show the timestamp on the summary view and sort descending(newest at the top)

* Address comments.

- Fix ID case.
- Improve readability of components in body.
- Improve the comments that describe the sorting.
2023-07-14 17:18:32 +01:00
Mauro eaf8079339 Fix for delayed loader not working properly. (#1329)
* fix

* Update ElementX/Sources/Other/UserIndicator/UserIndicatorController.swift

Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>

* Update ElementX/Sources/Other/Extensions/Duration.swift

Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>

* fix for the issue of the missing xcoconfig file

---------

Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
2023-07-14 14:51:29 +00:00
David Langley bf91e97c88 Remove Task.sleep from NotificationTests. (#1326)
- Add `weak` to mock variables called `delegate`
- Delete `UserNotificationCenterSpy` and use `UserNotificationCenterMock`
- Remove Task.sleep in favour of mock closures along with expectations/fulfillment.
2023-07-14 13:45:42 +01:00