The suite intermittently hung on CI, most recently for the full 2 minute time
limit on lifetimeIsCapped(). A spindump from a failed run shows the process
suspended rather than spinning (0.247s of CPU over 190s) with a background
priority worker thread sitting runnable for roughly 145 seconds without ever
being scheduled.
That band is exactly what swift-clocks' TestClock depends on to make progress:
both advance() and checkSuspension() await Task.megaYield(), which serially
awaits 20 detached tasks at background priority. On an oversubscribed runner
those never run, so the test waits forever instead of failing. The same
mechanism, less starved, is why two of the passing tests took 1.0s and 0.77s
for what is otherwise pure logic. checkSuspension() made it worse, since
asking whether a timer was armed cost a megaYield per poll.
ManualClock replaces it. It holds a single pending sleep, since that is all a
test needs to step through: the sleep registers a continuation, advance(by:)
resumes it synchronously once its deadline passes, and waitForScheduledSleep()
suspends until the timer is armed instead of polling for it. Nothing in the
path touches background priority and no loop's iteration count depends on the
scheduler. The suite now runs in 0.019s, and under a locally saturated CPU the
old version took 1.005s against the new one's 0.037s.
Also drops the now unused Clocks package, removes the 2 minute time limit that
was papering over the starvation, re-enables callIsTimingOut() which the same
flakiness had disabled, and has lifetimeIsCapped() assert the 90 second cap
directly rather than inferring it from when the timer fires.
Continue grouping the standalone modules under Components. Updates the
preview asset paths and the media resource references in the app and unit
test targets.
The shim is embedded but not linked, so nothing at build time proves it is
still there. If it stops being copied into the bundle, or the class is renamed,
dlopen simply fails at runtime and the user gets a blank map behind an error
alert. Nothing in CI would notice.
The test asserts the framework loads and the shim resolves, which is exactly
the pair that breaks if either side of the arrangement is disturbed.
* use observation in unit and preview tests instead of the async stream
* use a parsing approach that is independent of the sourcery annotation
* Fix observation deferred fulfillments not receiving the initial value
Observation's observe only emits transitions, not the value present at subscription time. Drop the leading initial value from the affected transitionValues sequences and assert it directly with #expect instead.
* improved docs
* improved defer fullfillment
* applied also for async streams
* fix xcodeproject
* better documentation
* restict deferFulfillment only for Publisher which can never fail
* Listen to call decline to stop ringing when declined from other device
* MSC4075 Use expirationTS to define the call ringing window
* Implement ElementCallService tests.
* Update acknowledgements.
* Use StateStoreViewModelV2 in AnalyticsPromptScreen.
* Use StateStoreViewModelV2 in UserProfileScreen.
* Use StateStoreViewModelV2 in MediaUploadPreviewScreen.
* Use StateStoreViewModelV2 in the Roles & Permissions screens.
* Add the asyncStream variant of deferFailure.
* Use StateStoreViewModelV2 in BlockedUsersScreen.
* Use StateStoreViewModelV2 in ManageRoomMemberSheet.
* Use StateStoreViewModelV2 in ResolveVerifiedUserSendFailureScreen.
* Use StateStoreViewModelV2 in ReportContentScreen.
* Use StateStoreViewModelV2 in ReportRoomScreen.
* Use StateStoreViewModelV2 in StaticLocationScreen.
* Use StateStoreViewModelV2 in EmojiPickerScreen.
* Use StateStoreViewModelV2 in PollFormScreen.
* Use StateStoreViewModelV2 in DeclineAndBlockScreen.
* Use StateStoreViewModelV2 in RoomDetailsScreen.
* Fix a random compilation error that just popped up 🤷♂️
* Fix expectation message.
* Retrofit `deferFulfillment` onto snapshot tests.
* Convert a bunch of preview tests to the new fulfillment publisher
* Convert more tests
* Remove unneeded delays from the remaining tests
* Remove snapshotting delay option.
* xcode ready solution
* now the previews won't fail but get generated
* delay in some screens that require a waiting state (the bloom does not work in previews)
* better code
* longer delay
removed and redone lfs
readded as lfs
* prefire basic implementation
force the unit tests to run on iPhone 14
skipping plugin validation
archive artifacts
better workflow
removed the OS restriction
lfs
custom stencil
new test file
deleting
* git lfs
* lfs
* test
* customised the stencil to support our internal protocol
* for now we can remove the OS check from the stencil
* added a delay
* tests have been moved
* improvement
* recommit
* perceptual precision lowered
* updated snapshot testing and selected also iOS version
* added ios version control
* Extract notification content building outside of the NotificationItemProxy. First step in a bigger refactoring of the NSE
* Import the attributed string buider into the NSE, sort `sources` imports
* Extract message event string building into the RoomMessageEventStringBuilder and reuse it building content for push notifications
* Cleanup
* Add changelog
* moved NSRegularExpression outside of the AttributedString builder into the MatrixEntityRegex
* fixed eventId v3 regex
* added permalink builders for users, room identifiers and aliases, and events
* added timeline item permalink contextual menu actions and error alerts
* added an app wide ServiceLocator and moved the top level userIndicatorPresenter to it.
* added URL constructor that takes a StaticString and returns an non-optional
* Include Unit and UI tests in the swiftlint search paths
* Update homebrew dependencies like on the other workflows. Fixes problems caused by buggy swiftformat prebundled on the github actions macos runner
* Removed UI tests from PR tests and running them on a schedule instead. Hopefuly fixed code coverage.
* Added back simulator versions as they need to match UI test snapshots
* Allow UI tests to run on this PR
* Added back skipped UI tests
* Fix danger sometimes not working on forks and disable integration tests on them
* #37 Remove sign out button from home screen
* #37 Move crash button visibility flag to BuildSettings, import BuildSettings from test targets
* #37 Add log out button into the settings screen
* #37 Add version into the settings screen
* #37 enhance bug report parameters
* #37 Remove sign out button from home screen
* #37 Move crash button visibility flag to BuildSettings, import BuildSettings from test targets
* #37 Add log out button into the settings screen
* #37 Add version into the settings screen
* #37 enhance bug report parameters
* #37 Add changelog
* #37 Fix code smells and PR remarks
Mauro
Stefan Ceriu
Doug
Mauro Romito
Valere Fedronic
Doug
Stefan Ceriu
Alfonso Grillo
Aleksandrs Proskurins
ismailgulek