Commit Graph

34 Commits

Author SHA1 Message Date
Mauro b1ed870474 Support for Xcode 27 on CI (#6217)
* Run the tests on iOS 27.0

Bump the required simulator OS in the preview, UI and Compound tests, and the CI tool's default OS, from 26.5 to 27.0. Test devices stay the same.

iOS 27 writes transcoded videos 146 bytes larger, so update the expected sizes in MediaUploadingPreprocessorTests.

* Build and test on CI with Xcode 27

Select Xcode 27 in ci_common.sh and move every macOS workflow to the xcode-27 runner image, as macos-26 doesn't include Xcode 27. The Compound workflow now also creates its simulator on the iOS 27.0 runtime.

The xcode-27 runners are slower, so give the unit, Enterprise, Compound and snapshot recording jobs longer timeouts.

* Fix the preview snapshot layout on iOS 27

On iOS 27 the hosting controller applies the window's safe area when rendering, but the snapshot size comes from sizeThatFits, which ignores it. Component previews were shifted down and clipped at the bottom. Disable the hosting controller's safe area regions for these snapshots so the measured and rendered layouts match.

swift-snapshot-testing also renders into a window without a scene, and on iOS 27 a navigation stack in such a window reserves space for a large title it never shows, leaving a gap below the navigation bar. Attach the render window to the app's scene until swift-snapshot-testing handles it.

The invite users and add rooms screens sized their selected items row from a measured width stored in state, which is zero on the first layout pass, so snapshots could draw the row empty. Use containerRelativeFrame instead. The add rooms search previews now also wait for their results, and the search previews that show a clear button get a small precision tolerance, as it renders inconsistently in snapshots.

* Re-record the preview snapshots on iOS 27.0

Recorded on an iPhone SE (3rd generation) simulator running iOS 27.0 with Xcode 27.0 (27A266a). The changes come from iOS 27 rendering: text anti-aliasing, hyphenation and line breaking, navigation bars and toggles that now render in snapshots, lazy stacks that were blank on iOS 26, and pseudo-language locale formatting.

* Fix the UI tests on iOS 27

iOS 27 no longer exposes accessibility identifiers on SwiftUI menu items, so the space exploration test now finds them by label within the menu. On iPad, the start chat search field keeps focus after submitting and can swallow the next tap, so retry the tap if the create room screen doesn't appear.

* Re-record the UI test snapshots on iOS 27.0

Recorded on iPhone 17 and iPad (A16) simulators running iOS 27.0 with Xcode 27.0. The changes come from iOS 27 styling, like the keyboard height and glass borders. This also removes the iPad app lock setup snapshots, which have been orphaned since those tests stopped running on iPad.

* Fix the accessibility tests crashing on iOS 27

The accessibility tests' previews wrapper kept its ImageRenderer alive across the awaits that follow the render. On iOS 27, releasing it at that point tears down its view graph outside of a SwiftUI update, which hits an assertion and crashes the app. Release the renderer as soon as the image has been rendered.

* Keep the accessibility tests' image renderers alive on iOS 27

Releasing the ImageRenderer straight away wasn't enough: on iOS 27, releasing one that rendered a preview crashes SwiftUI whichever context it happens in. Keep the renderers alive instead. Each test launches a fresh app, so they only live for the one test.

* Share the UI tests' app settings with their mock user session

Since the user session flow reads its settings from UserSettings, the UI tests' mock user session was wrapping a fresh volatile AppSettings instead of the one the tests configure. The flags that skip onboarding weren't picked up, so every user session UI test got stuck on the notifications permission screen.

* Re-record the Compound snapshots on iOS 27.0

Apply the same safe area fix as the app's preview tests, so size-that-fits snapshots aren't clipped on iOS 27, and re-record the snapshots on an iPhone SE (3rd generation) simulator running iOS 27.0 in English (US).

* Fix a race reading the keyboard in the accessibility tests

On iOS 27 the QR code login screen's keyboard can be dismissing between checking that it exists and reading its frame, which fails the test. Snapshot it in a single query instead.
2026-09-29 17:02:48 +02:00
Stefan Ceriu 32f86da98d Replace danger-swift with a actions/github-script version (#6080)
* Replace danger-swift with a actions/github-script version
* Report PR check results in a comment

Annotations are only visible in the Checks tab, so the results were easy to
miss on the pull request itself. The workflow now keeps a single comment up to
date on the Conversation tab, listing failures and warnings together, and
deletes it again once there is nothing left to report.

Commenting on pull requests from forks needs a token with write access, which
the pull_request trigger does not provide, hence the switch to
pull_request_target. The job never checks out or executes any code from the
pull request, it only reads the event payload and the list of changed files.
2026-08-27 17:50:02 +03:00
Mauro Romito a0521d1fdf improve the contribution docs with preview tests setup 2026-08-06 12:26:54 +02:00
mredig 8684b2c050 review fixups 2026-08-06 12:26:54 +02:00
mredig d7283aa552 Update Contributing.md with snapshot testing instructions 2026-08-06 12:26:54 +02:00
Stefan Ceriu 6d77a0a557 Fix typo in contributing.md 2026-07-31 10:26:57 +03:00
Doug e9442a3c60 Clarify Xcode version usage in CONTRIBUTING.md 2026-06-16 10:28:11 +01:00
Stefan Ceriu 9a8c875025 Add an etiquette section to the contribution guide (#5625) 2026-05-27 11:08:45 +03:00
mxandreas 1406e43a36 Add guidelines for new features and a bit refactoring. (#5436)
* Add guidelines for new features and a bit refactoring.

* Add link to Android.

* Update CONTRIBUTING.md

Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>

* Some final touches.

---------

Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
2026-04-20 13:51:41 +01:00
Doug 001a389f51 Update CONTRIBUTING.md with Localazy download instructions 2026-04-13 13:16:58 +01:00
Stefan Ceriu bce9119bc3 Replace the last of the fastlane lanes with swift tooling
- move more sharable code to CI static methods
- merge `release_to_github` and `prepare_next_release` into one single command as they had dependencies on each other
- remove all traces of ruby and fastlane
2026-03-11 10:06:44 +02:00
Stefan Ceriu fc03e05697 Replace ruby/fastlane tools with swift variants. (#5105)
* Replace ruby/fastlane unit and preview test flows with swift variants.

* Switch to swift-log and Logger for logging

* Address (my own!) PR comments.

---------

Co-authored-by: Doug <douglase@element.io>
2026-02-19 09:13:42 +00:00
Doug 784bc04237 Fix typo in CONTRIBUTING.md changelog section 2026-01-05 12:52:06 +00:00
Doug ca0797e968 Clarify product input requirements and how to add translations for contributions. (#4849) 2025-12-12 11:35:48 +00:00
manuroe cffcb5c7b9 Fix Matrix room in CONTRIBUTING.md (#4043) 2025-04-18 16:07:53 +02:00
Stefan Ceriu 1af5a4ae09 Update CONTRIBUTING.md 2025-01-16 09:03:00 +02:00
Stefan Ceriu ebef0d1fbe Update CONTRIBUTING.md 2024-08-27 09:23:26 +03:00
Guillaume cdaa88efcc Update sonarcloud project key (#3112) 2024-08-05 09:38:51 +01:00
Doug 82823c94ce Replace Towncrier with GitHub releases + labels. (#2966)
* Set up GitHub generated release notes.

* Remove Towncrier from the release script.

* Add changelog failures for Labels with Danger and stop requesting a changelog file.

* Update changelog documentation.
2024-06-25 11:07:01 +00:00
Doug 8a52ed0cb6 Update Compound. (#2906)
* Update Compound.

* Remove LFS hack from the docs.

* Fix preview tests

---------

Co-authored-by: Stefan Ceriu <stefanc@matrix.org>
2024-06-07 12:25:24 +03:00
Doug 30bf8115c2 Update codecov links. (#2237) 2023-12-13 16:15:13 +00:00
Doug 09b276d94b Update most references of vector-im to element-hq (#2231)
Sonarcloud and codecov will follow in a later PR when confirmed working. Changelog ignored as it isn't particularly important with the redirect.
2023-12-12 14:34:44 +00:00
Doug 7c3ee01a6f Update CONTRIBUTING.md (#2135) 2023-11-22 08:54:17 +00:00
David Langley 13decc668a Reaction highlights (#1145)
* Highlight own reactions

- Highlight own reactions on timeline and improve style.
- Highlight reactions on message bottom sheet only when it our own.

* Improve overlay background colours

* pin to new sdk version

* Remove the red used for debug.

* Fix padding, overlap and only display count if > 1.

- Fix reaction padding and overlap of reaction and bubble.
- Only display count if greater than 1.
- Return EmptyView for TimelineDeliveryStatus.cancelled.

* Fix colors as per design recommendations.

* Add Snapshot tests for reactions and documentation.

- Add UITests for the timeline including reactions.
- Add the reference snapshots.
- Add documentation on how to run snapshot tests and update the reference snapshots.

* Fix Package.resolved
2023-06-25 13:24:48 +01:00
Doug d7622ea731 Update UI tests (#730)
* Update snapshots.

* Fix timeline grouping and UI tests.

* Remove German UI tests with double-length pseudolanguage.

Avoids tests breaking when translations are updated.
2023-03-28 13:06:53 +00:00
sem pruijs 1fe2e7e882 Update support link (#668)
* Update matrix room to be the element x room

* Add change log file

* Update README rupport link
2023-03-06 09:38:31 +02:00
Mauro c8fb93e00d Swiftformat on githooks + New swift run tools setup command (#563) 2023-02-10 15:04:00 +02:00
Doug 30cb97ee4f Add a tool to build MatrixRustSDK. (#369) 2022-12-15 09:35:00 +00:00
Aleksandrs Proskurins 1c4dc89627 Update documentation files (#313)
* Updated md files

* Changelog

* Update CONTRIBUTING.md

Co-authored-by: Stefan Ceriu <stefanc@matrix.org>

* PR fixes

* Update README.md

Co-authored-by: Stefan Ceriu <stefanc@matrix.org>

Co-authored-by: Stefan Ceriu <stefanc@matrix.org>
2022-11-15 11:49:13 +02:00
Stefan Ceriu fabb0bc95f New timeline (#276) (#280)
* Fixes #276 - Rebuilt room timeline:
    - Removed the need for the ListCollectionViewAdapter
    - Rewrote the TimelineItemList without using introspection
    - Added ReversedScrollView for laying out items at the bottom/trailing
    - Rewrote TimelineProvider diffing through CollectionDifference (similar to the RoomSummaryProvider)
    - Added back `scrollDismissesKeyboard`  behavior
    - Various other tweaks and fixes
- Fixed various warnings:
    - removed async AttributedStringBuilder as AttributedString is non-sendable, made the RoomTimelineItemFactory synchronous
    - removed unused virtual timeline items
    - removed unused isOutgoing property from the FormattedBodyText
* Make TimelineItemContextMenuActions indentifiable and specify contextMenu identifiers
* Bump the matrix-rust-components-swift to v1.0.16-alpha
* Add changes file and changelog contribution guide
* Fix attributed string builder unit tests
2022-11-02 13:03:34 +02:00
Johannes Marbach 27f681440b Add notes for how to debug the network traffic (#223)
* Add notes for how to debug the network traffic

* Add changelog

Co-authored-by: Stefan Ceriu <stefanc@matrix.org>
2022-10-14 13:13:57 +00:00
Doug 98cd04c81d Add docs around Git LFS and include in Brewfile. 2022-09-06 13:37:19 +01:00
vollkorntomate f70c8b1164 Fix broken link in CONTRIBUTING.md
Signed-off-by: Thomas Völkl thomas@vollkorntomate.de
2022-08-02 12:21:55 +01:00
Stefan Ceriu 217bbad618 Closes #55, #56 - Update project documentation 2022-05-19 10:24:34 +03:00