Commit Graph

27 Commits

Author SHA1 Message Date
joel.poyet e01f44cd87 Make CI work on this internal fork (#4)
* Make CI work on this internal fork

Every check was red on every pull request. Upstream declares permissions: {} in its
workflows, which costs nothing on a public repo and is fatal here: the token is
limited to Metadata:read, so actions/checkout cannot read an internal repo and dies
with a misleading "Repository not found". Repo settings cannot fix it — an explicit
permissions block always overrides the default.

Each job now gets the minimum it needs. Danger also reads the pull request through
the issues API, so it needs issues:read alongside pull-requests:write, and zizmor's
SARIF upload needs actions:read on a private repo.

The unit tests move to the org's Mac Studio: GitHub-hosted macos-26 could not finish
inside the hour and bills at 10x. Preview tests are skipped there, using the flag
upstream already uses for its own enterprise tests — they render a snapshot per
preview and never once finished on either runner. The trade is that preview snapshot
regressions are no longer caught in CI.

Workflows that only make sense upstream are gated off rather than deleted, so they
keep rebasing cleanly. The enterprise tests need Element's bot token and their
private submodule. Three nightlies fail at checkout every weeknight — this repo is a
detached copy rather than a network fork, so GitHub never disabled their schedules —
and one of them posts to Element's Codecov on every run.

* Erase the test simulators before running the tests

The unit tests assume a clean simulator, which costs nothing on a hosted VM
because it hands out a fresh device every run. This runner reuses the same two
devices, so app containers, caches and logs survive between runs and six suites
fail on the previous run's leftovers rather than on anything in the code.
LoggingTests is the clearest: it expects no log files and finds nine, in the same
device container each time.

Only the two devices the tooling pins are erased, resolved by UDID. A blanket
erase would take out simulator state belonging to other work on a machine the
release pipeline shares.

* Remove the simulator reset again

It was added on the theory that the runner's reused simulators were leaking state
between runs. That theory was wrong: erasing both devices changed nothing — the
same seven suites failed identically before and after.

The leftover files LoggingTests trips on are its own, from a previous attempt of
the same test within one run (the suite runs with -test-iterations 4), so nothing
crosses runs for an erase to clean. Keeping a step that mutates shared state on the
release machine for no measured benefit is worse than not having it.
2026-07-16 14:34:48 +02:00
renovate[bot] 3f3aa79a48 Update actions/checkout action to v7 (#5791)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-06-26 14:49:05 +01:00
renovate[bot] 8262533b6d Update GitHub Actions to v6.0.3 2026-06-10 16:58:31 +02:00
Stefan Ceriu 47de08125a Fix formatting .. according to Zed rules anyway 2026-04-21 17:19:50 +03:00
Doug 51194c09e2 Add zizmor checks on CI. (#5161)
* Add zizmor checks on CI.

* Fix zizmor credentials warnings

* Add persist-credentials: false to action-cached-lfs-checkout too.

* Add empty permissions by default.

* Ignore pull_request_target failure and add a warning.
2026-03-05 13:54:51 +00:00
renovate[bot] fe9722a6bb Update GitHub Actions 2025-12-07 11:22:49 +02:00
renovate[bot] bfa287b3f8 Update actions/checkout action to v6 2025-11-21 14:56:18 +02:00
renovate[bot] df3a74671f Update actions/checkout action to v5 2025-11-07 14:53:30 +02:00
Stefan Ceriu ab4812e06f Switch to using a SHA instead of the action version 2025-11-07 14:51:33 +02:00
Stefan Ceriu e2be27d873 Try moving danger swift to an ubuntu runner 2025-11-07 14:51:33 +02:00
Doug 9cd181ef74 Add timeouts to our GitHub actions. (#4669)
6 hours is way too long and eats up the runners.
2025-10-28 18:37:15 +00:00
Michael Telatynski c55c5a677b Configure concurrency for Danger CI workflow (#4646)
Added concurrency settings to Danger workflow.
2025-10-22 09:58:16 +01:00
Stefan Ceriu 9874d6fd84 Switch all workflow runners back to macos-15 in hope that it will require less ram and won't time out. 2025-09-29 12:37:28 +03:00
Stefan Ceriu b705eacf48 Switch workflows to the macos-26 runner 2025-09-26 17:20:41 +03:00
renovate[bot] 57686d5f9b Update actions/checkout action to v5 (#4401)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-08-11 18:00:27 +01:00
Doug cfaa1b455a Use the new preview screen when tapping media on the room and pinned events screens. (#3736)
* Use the new TimelineMediaPreview modifier on the room and pinned timeline screens.

* Use the same presentation logic for all timeline media previews.

* Fix a bug with the detection of the timeline end.

* Send pagination requests from the media preview screen.

* Add SwiftLint to the Danger workflow (it is no longer installed on the runner).

* Put SwiftLint back on all of the GitHub runners too.

* Set the function_parameter_count lint rule to 10.

* Make sure to clean-up any previews when the coordinator is done.

* Handle the viewInRoomTimeline action more appropriately.
2025-02-05 13:27:23 +00:00
Doug 4e880f1924 Fix incorrect analytics mapping for UTDs. (#3497)
* Fix incorrect analytics mapping for UTDs.

* Upgrade GitHub workflows to use macOS 15.
2024-11-08 08:36:15 +00:00
Doug 152ecc6f9c Trigger a Danger run when labelling a PR too. (#2972) 2024-06-27 11:33:47 +01:00
renovate[bot] f197368dba Update actions/checkout action to v4 2024-05-20 11:14:18 +01:00
Stefan Ceriu 48b06519f9 Replace deprecated danger-swift-with-swiftlint docker image 2024-04-15 10:43:17 +03:00
Doug 99e7f76ca0 Update danger image, fix snapshots (#436) 2023-01-11 11:01:33 +00:00
Stefan Ceriu 2fd0491a18 SwiftUI NavigationController and UserNotificationControllers (#309)
* Fixes #286 - Adopted the new SwiftUI NavigationStack based NavigationController throughout the application
* Fixes #315 - Implemented new user notification components on top of SwiftUI and the new navigation flows
* Add home screen fade animation between skeletons and real rooms
* Bump the danger-swift version used on the CI and swiftlint with it
* Renamed Splash to Onboarding, Empty to Splash
2022-11-16 13:37:34 +00:00
Stefan Ceriu 142180b1f3 Various CI fixes (#161)
* Update homebrew dependencies like on the other workflows. Fixes problems caused by buggy swiftformat prebundled on the github actions macos runner

* Removed UI tests from PR tests and running them on a schedule instead. Hopefuly fixed code coverage.

* Added back simulator versions as they need to match UI test snapshots

* Allow UI tests to run on this PR

* Added back skipped UI tests

* Fix danger sometimes not working on forks and disable integration tests on them
2022-08-19 17:42:03 +03:00
Doug b6e1d6d1e5 Use a more robust detection for forks. (#160) 2022-08-12 14:45:56 +01:00
Doug 087b25b6ab Don't run Danger for forks as secrets are missing.
Simplify the check for the alpha release to reduce number of jobs.
2022-08-04 08:50:43 +01:00
Stefan Ceriu db1114d381 vector-im/element-x-ios/issues/13 - Towncrier setup for PR builds 2022-05-11 10:39:45 +03:00
Stefan Ceriu 1b1b541a63 vector-im/element-x-ios/issues/14 - Initial Danger setup 2022-04-28 12:19:18 +03:00