ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-04 01:20:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix flakey app lock setup pin screen pin entry typing

Browse Source
This commit is contained in:
Stefan Ceriu
2024-01-26 17:52:55 +02:00
committed by Stefan Ceriu
parent e80b43f148
commit ffbfdfa96e
3 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Other/AccessibilityIdentifiers.swift
+1
View File
@@ -62,6 +62,7 @@ enum A11yIdentifiers {
} }
struct AppLockSetupPINScreen { struct AppLockSetupPINScreen {
let textField = "app_lock_setup_pin-text_field"
let cancel = "app_lock_setup_pin-cancel" let cancel = "app_lock_setup_pin-cancel"
} }
ElementX/Sources/Screens/AppLock/AppLockSetupPINScreen/View/PINTextField.swift
+3 -1
View File
@@ -26,6 +26,7 @@ struct PINTextField: View {
textField textField
.textFieldStyle(PINTextFieldStyle(pinCode: pinCode, isSecure: isSecure)) .textFieldStyle(PINTextFieldStyle(pinCode: pinCode, isSecure: isSecure))
.keyboardType(.numberPad) .keyboardType(.numberPad)
.accessibilityIdentifier(A11yIdentifiers.appLockSetupPINScreen.textField)
.onChange(of: pinCode) { newValue in .onChange(of: pinCode) { newValue in
let sanitized = sanitize(newValue) let sanitized = sanitize(newValue)
if sanitized != newValue { if sanitized != newValue {
@@ -67,7 +68,8 @@ private struct PINTextFieldStyle: TextFieldStyle {
.overlay { .overlay {
configuration configuration
.focused($isFocussed) .focused($isFocussed)
.opacity(0.0) // Textfield isn't accessible for UI tests otherwise
.opacity(0.01)
} }
.onTapGesture { isFocussed = true } .onTapGesture { isFocussed = true }
} }
UITests/Sources/AppLockSetupUITests.swift
+8 -8
View File
@@ -137,16 +137,16 @@ class AppLockSetupUITests: XCTestCase {
// MARK: - Helpers // MARK: - Helpers
private func enterPIN() { private func enterPIN() {
app.keys["2"].tap() let textField = app.secureTextFields[A11yIdentifiers.appLockSetupPINScreen.textField]
app.keys["0"].tap() XCTAssert(textField.waitForExistence(timeout: 10))
app.keys["2"].tap()
app.keys["3"].tap() textField.clearAndTypeText("2023")
} }
private func enterDifferentPIN() { private func enterDifferentPIN() {
app.keys["2"].tap() let textField = app.secureTextFields[A11yIdentifiers.appLockSetupPINScreen.textField]
app.keys["2"].tap() XCTAssert(textField.waitForExistence(timeout: 10))
app.keys["3"].tap()
app.keys["3"].tap() textField.clearAndTypeText("2233")
} }
} }