ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-05 11:58:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix an issue rendering pills in some forks. (#3913)

Browse Source
This commit is contained in:
Doug
2025-03-18 16:36:45 +00:00
committed by GitHub
parent 6050267123
commit fcdc09e271
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Other/InfoPlistReader.swift
+7 -2
View File
@@ -104,9 +104,14 @@ struct InfoPlistReader {
let exportedTypes: [[String: Any]] = infoPlistValue(forKey: Keys.utExportedTypeDeclarationsKey) let exportedTypes: [[String: Any]] = infoPlistValue(forKey: Keys.utExportedTypeDeclarationsKey)
guard let mentionPills = exportedTypes.first(where: { $0[Keys.utDescriptionKey] as? String == Values.mentionPills }), guard let mentionPills = exportedTypes.first(where: { $0[Keys.utDescriptionKey] as? String == Values.mentionPills }),
let utType = mentionPills[Keys.utTypeIdentifierKey] as? String else { let utType = mentionPills[Keys.utTypeIdentifierKey] as? String else {
fatalError("Add properly \(Values.mentionPills) exported type into your target's Info.plst") fatalError("Add properly \(Values.mentionPills) exported type into your target's Info.plist")
} }
return utType
// The pills type is formed from the baseBundleIdentifier, however weirdly, if a fork sets that with a value
// that includes one or more uppercase characters, pill rendering breaks. If we lowercase the type identifier
// the bug is fixed, even though the value used in the fork's Info.plist no longer matches the value returned.
// Maybe in the future the fork should set their own PILLS_UT_TYPE_IDENTIFIER, but for now this works 🤷‍♂️🤷‍♂️🤷‍♂️
return utType.lowercased()
} }
// MARK: - Private // MARK: - Private