ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 06:55:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Diffable fade animations (#1343)

Browse Source 
* animate only 2 seconds after the appearence

* scrolling is stable

* code improvement

* comment and removing code that is not necessary anymore

* feature flag

* comment

* better code

* the day divider ID is the timestamp itself as ISO

* Apply suggestions from code review

Co-authored-by: Alfonso Grillo <alfogrillo@gmail.com>

* format fix

---------

Co-authored-by: Alfonso Grillo <alfogrillo@gmail.com>
This commit is contained in:
Mauro
2023-07-18 16:18:11 +02:00
committed by GitHub
parent 48dbbfb4d0
commit f46abbaf9e
6 changed files with 34 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Screens/RoomScreen/View/TimelineTableViewController.swift
+16 -9
View File
@@ -97,6 +97,8 @@ class TimelineTableViewController: UIViewController {
private var previousLayout: LayoutDescriptor?
/// Whether or not the view has been shown on screen yet.
private var hasAppearedOnce = false
/// Whether the scroll and the animations should happen
private var shouldAnimate = false
init(coordinator: TimelineView.Coordinator,
timelineStyle: TimelineStyle,
@@ -168,6 +170,11 @@ class TimelineTableViewController: UIViewController {
guard !hasAppearedOnce else { return }
scrollToBottom(animated: false)
hasAppearedOnce = true
// This is to prevent the SS proxy issue that forces a full refresh of all the timeline items
// the first time the timeline is opened
DispatchQueue.main.asyncAfter(deadline: .now() + 2) {
self.shouldAnimate = ServiceLocator.shared.settings.timelineDiffableAnimationsEnabled
}
}
override func didMove(toParent parent: UIViewController?) {
@@ -231,8 +238,7 @@ class TimelineTableViewController: UIViewController {
return cell
}
// dataSource?.defaultRowAnimation = .automatic
dataSource?.defaultRowAnimation = .fade
tableView.delegate = self
}
@@ -249,13 +255,14 @@ class TimelineTableViewController: UIViewController {
snapshot.appendSections([.main])
snapshot.appendItems(timelineItemsIDs)
MXLog.verbose("DIFF: \(snapshot.itemIdentifiers.difference(from: dataSource.snapshot().itemIdentifiers))")
dataSource.apply(snapshot, animatingDifferences: false)
// Probably redundant now we observe content size changes…
// Leaving in place for the release and will reassess after.
updateTopPadding()
let currentSnapshot = dataSource.snapshot()
MXLog.verbose("DIFF: \(snapshot.itemIdentifiers.difference(from: currentSnapshot.itemIdentifiers))")
// We only animate if the last item has changed
// We don't care to animate backpagination since we want to keep the scrolling position when that happens
let animated = shouldAnimate && snapshot.itemIdentifiers.last != currentSnapshot.itemIdentifiers.last
dataSource.apply(snapshot, animatingDifferences: animated)
if previousLayout.isBottomVisible {
scrollToBottom(animated: false)
} else if let pinnedItem = previousLayout.pinnedItem {