ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 06:55:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

read receipt cell should be grouped and the avatar accessibility hidden

Browse Source
This commit is contained in:
Mauro Romito
2025-07-21 13:35:56 +02:00
committed by Mauro
parent e035947355
commit f45a5f814e
4 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
AccessibilityTests/Sources/AccessibilityTests.swift
+2 -1
View File
@@ -91,7 +91,8 @@ final class AccessibilityTests: XCTestCase {
private static let notHumanReadableMessage = "Label not human-readable" private static let notHumanReadableMessage = "Label not human-readable"
/// Use this array to filter add specific filters to ignore specific issues for certain elements /// Use this array to filter add specific filters to ignore specific issues for certain elements
private static let ignoredA11yIdentifiers: [String: [FilterType]] = [A11yIdentifiers.authenticationStartScreen.appVersion: [.auditType(.hitRegion)]] private static let ignoredA11yIdentifiers: [String: [FilterType]] = [A11yIdentifiers.authenticationStartScreen.appVersion: [.auditType(.hitRegion)],
A11yIdentifiers.pollView.summary: [.auditType(.hitRegion)]]
} }
private enum FilterType { private enum FilterType {
ElementX/Sources/Other/AccessibilityIdentifiers.swift
+5
View File
@@ -42,6 +42,7 @@ enum A11yIdentifiers {
static let pollFormScreen = PollFormScreen() static let pollFormScreen = PollFormScreen()
static let roomPollsHistoryScreen = RoomPollsHistoryScreen() static let roomPollsHistoryScreen = RoomPollsHistoryScreen()
static let manageRoomMemberSheet = ManageRoomMemberSheet() static let manageRoomMemberSheet = ManageRoomMemberSheet()
static let pollView = PollView()
struct AlertInfo { struct AlertInfo {
let primaryButton = "alert_info-primary_button" let primaryButton = "alert_info-primary_button"
@@ -297,4 +298,8 @@ enum A11yIdentifiers {
struct ManageRoomMemberSheet { struct ManageRoomMemberSheet {
let viewProfile = "manage_room_member_sheet-view_profile" let viewProfile = "manage_room_member_sheet-view_profile"
} }
struct PollView {
let summary = "poll_view-summary"
}
} }
ElementX/Sources/Screens/Timeline/View/Polls/PollView.swift
+1
View File
@@ -128,6 +128,7 @@ struct PollView: View {
.scaledPadding(.leading, showVotes ? 0 : 32) .scaledPadding(.leading, showVotes ? 0 : 32)
.foregroundColor(.compound.textSecondary) .foregroundColor(.compound.textSecondary)
.frame(maxWidth: .infinity, alignment: showVotes ? .trailing : .leading) .frame(maxWidth: .infinity, alignment: showVotes ? .trailing : .leading)
.accessibilityIdentifier(A11yIdentifiers.pollView.summary)
} }
} }
ElementX/Sources/Screens/Timeline/View/ReadReceipts/ReadReceiptCell.swift
+2
View File
@@ -30,6 +30,7 @@ struct ReadReceiptCell: View {
contentID: readReceipt.userID, contentID: readReceipt.userID,
avatarSize: .user(on: .readReceiptSheet), avatarSize: .user(on: .readReceiptSheet),
mediaProvider: mediaProvider) mediaProvider: mediaProvider)
.accessibilityHidden(true)
VStack(alignment: .leading, spacing: 0) { VStack(alignment: .leading, spacing: 0) {
HStack(spacing: 12) { HStack(spacing: 12) {
Text(title) Text(title)
@@ -50,6 +51,7 @@ struct ReadReceiptCell: View {
.lineLimit(1) .lineLimit(1)
} }
} }
.accessibilityElement(children: .combine)
.padding(.vertical, 8) .padding(.vertical, 8)
.padding(.horizontal, 16) .padding(.horizontal, 16)
} }