Open Live Locations map on tapping on the banner (#5477)

* Implemented opening the LLS on our own user when tapping on the banner

* added a test for moving the map as soon as the first update arrives.

* updated preview tests

ElementX/Sources/Screens/RoomScreen/RoomScreenCoordinator.swift

@@ -40,7 +40,7 @@ enum RoomScreenCoordinatorAction {
     case presentLocationPicker
     case presentPollForm(mode: PollFormMode)
     case presentLocationViewer(StaticLocationData)
-    case presentLiveLocationViewer(sender: TimelineItemSender, initialLiveLocationShare: LiveLocationShare)
+    case presentLiveLocationViewer(sender: TimelineItemSender?, initialLiveLocationShare: LiveLocationShare?)
     case presentEmojiPicker(itemID: TimelineItemIdentifier, selectedEmojis: Set<String>)
     case presentRoomMemberDetails(userID: String)
     case presentMessageForwarding(forwardingItem: MessageForwardingItem)
@@ -197,6 +197,8 @@ final class RoomScreenCoordinator: CoordinatorProtocol {
                     actionsSubject.send(.presentThread(threadRootEventID: threadRootEventID, focussedEventID: focussedEventID))
                 case .stopLiveLocationSharing:
                     Task { [weak self] in await self?.timelineViewModel.stopLiveLocationSharing() }
+                case .displayLiveLocation:
+                    actionsSubject.send(.presentLiveLocationViewer(sender: nil, initialLiveLocationShare: nil))
                 }
             }
             .store(in: &cancellables)

ElementX/Sources/Screens/RoomScreen/RoomScreenModels.swift

@@ -21,6 +21,7 @@ enum RoomScreenViewModelAction: Equatable {
     case displayRoom(roomID: String, via: [String])
     case displayMessageForwarding(MessageForwardingItem)
     case stopLiveLocationSharing
+    case displayLiveLocation
 }
 
 enum RoomScreenViewAction {
@@ -34,6 +35,7 @@ enum RoomScreenViewAction {
     case viewKnockRequests
     case displaySuccessorRoom
     case displayThreadList
+    case tappedOpenLiveLocation
     case tappedStopLiveLocation
 }
 

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift

@@ -124,6 +124,8 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
             actionsSubject.send(.displayThreadList)
         case .tappedStopLiveLocation:
             actionsSubject.send(.stopLiveLocationSharing)
+        case .tappedOpenLiveLocation:
+            actionsSubject.send(.displayLiveLocation)
         }
     }
     

ElementX/Sources/Screens/RoomScreen/View/LiveLocationSharingBannerView.swift

@@ -9,19 +9,22 @@ import Compound
 import SwiftUI
 
 struct LiveLocationSharingBannerView: View {
+    var onTap: () -> Void
     var onStop: () -> Void
     
     var body: some View {
-        HStack(spacing: 9) {
-            CompoundIcon(\.locationPinSolid, size: .medium, relativeTo: .compound.bodyMDSemibold)
-                .foregroundColor(Color.compound.iconSuccessPrimary)
-                .accessibilityHidden(true)
-            Text(L10n.screenRoomLiveLocationBanner)
-                .font(.compound.bodyMDSemibold)
-                .foregroundColor(.compound.textPrimary)
-            Spacer()
-            Button(L10n.actionStop, role: .destructive, action: onStop)
-                .buttonStyle(.compound(.primary, size: .small))
+        Button { onTap() } label: {
+            HStack(spacing: 9) {
+                CompoundIcon(\.locationPinSolid, size: .medium, relativeTo: .compound.bodyMDSemibold)
+                    .foregroundColor(Color.compound.iconSuccessPrimary)
+                    .accessibilityHidden(true)
+                Text(L10n.screenRoomLiveLocationBanner)
+                    .font(.compound.bodyMDSemibold)
+                    .foregroundColor(.compound.textPrimary)
+                Spacer()
+                Button(L10n.actionStop, role: .destructive, action: onStop)
+                    .buttonStyle(.compound(.primary, size: .small))
+            }
         }
         .padding(.vertical, 16)
         .padding(.horizontal, 15)
@@ -33,7 +36,7 @@ struct LiveLocationSharingBannerView: View {
 
 struct LiveLocationSharingBannerView_Previews: PreviewProvider, TestablePreview {
     static var previews: some View {
-        LiveLocationSharingBannerView { }
+        LiveLocationSharingBannerView { } onStop: { }
             .previewLayout(.sizeThatFits)
     }
 }

ElementX/Sources/Screens/RoomScreen/View/RoomScreen.swift

@@ -88,6 +88,8 @@ struct RoomScreen: View {
     
     private var liveLocationBanner: some View {
         LiveLocationSharingBannerView {
+            context.send(viewAction: .tappedOpenLiveLocation)
+        } onStop: {
             context.send(viewAction: .tappedStopLiveLocation)
         }
     }