#396 - Work around duplicated room list items and add error logs (#571)

ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift

@@ -87,6 +87,8 @@ class RoomSummaryProvider: RoomSummaryProviderProtocol {
                 return updatedItems
             }
         
+        detectDuplicatesInRoomList(rooms)
+        
         MXLog.info("Finished applying \(diffs.count) diffs")
     }
         
@@ -185,6 +187,25 @@ class RoomSummaryProvider: RoomSummaryProviderProtocol {
         
         return CollectionDifference(changes)
     }
+    
+    private func detectDuplicatesInRoomList(_ rooms: [RoomSummary]) {
+        let filteredRooms = rooms.filter {
+            switch $0 {
+            case .empty:
+                return false
+            default:
+                return true
+            }
+        }
+        
+        let groupedRooms = Dictionary(grouping: filteredRooms, by: \.id)
+        
+        let duplicates = groupedRooms.filter { $1.count > 1 }
+        
+        if duplicates.count > 0 {
+            MXLog.error("Found duplicated room room list items: \(duplicates)")
+        }
+    }
 }
 
 extension SlidingSyncViewRoomsListDiff {

ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProviderProtocol.swift

@@ -25,7 +25,7 @@ enum RoomSummaryProviderState {
     case live
 }
 
-enum RoomSummary {
+enum RoomSummary: CustomStringConvertible {
     case empty
     case filled(details: RoomSummaryDetails)
     case invalidated(details: RoomSummaryDetails)
@@ -38,6 +38,17 @@ enum RoomSummary {
             return details.id
         }
     }
+    
+    var description: String {
+        switch self {
+        case .empty:
+            return "\(String(describing: Self.self)): Empty"
+        case .invalidated(let details):
+            return "\(String(describing: Self.self)): Invalidated(\(details.id))"
+        case .filled(let details):
+            return "\(String(describing: Self.self)): Filled(\(details.id))"
+        }
+    }
 }
 
 protocol RoomSummaryProviderProtocol {