ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 06:55:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve user search using the GET profile (#754)

Browse Source 
* Add getProfile in ClientProxyProtocol

* Add fetchProfileIfNeeded

* Refactor search

* Update StartChatSuggestedUserCell UI

* Add showProfilePopover action

* Remove popover code

* Add UTs in StartChatViewModelTests

* Add UI tests

* Cleanup code

* Refine design

* Fix design

* Localise StartChatSuggestedUserCell

* Update localisations

* Update StartChatSuggestedUserCell design

* Fix UT

* Fix PR comments

* Apply suggestions

* Fix typo
This commit is contained in:
Alfonso Grillo
2023-04-04 10:47:41 +02:00
committed by GitHub
parent b089cd6b62
commit ea979d6515
17 changed files with 232 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
UnitTests/Sources/StartChatViewModelTests.swift
+70 -12
View File
@@ -33,26 +33,84 @@ class StartChatScreenViewModelTests: XCTestCase {
viewModel = StartChatViewModel(userSession: userSession, userIndicatorController: nil)
}
func test_queryShowingNoResults() async throws {
viewModel.context.searchQuery = "A"
func testQueryShowingNoResults() async throws {
await search(query: "A")
XCTAssertEqual(context.viewState.usersSection.type, .suggestions)
viewModel.context.searchQuery = "AA"
await search(query: "AA")
XCTAssertEqual(context.viewState.usersSection.type, .suggestions)
viewModel.context.searchQuery = "AAA"
_ = await context.$viewState.nextValue
XCTAssertEqual(context.viewState.usersSection.type, .searchResult)
XCTAssert(context.viewState.hasEmptySearchResults)
await search(query: "AAA")
assertSearchResults(toBe: 0)
}
func test_queryShowingResults() async throws {
func testQueryShowingResults() async throws {
clientProxy.searchUsersResult = .success(.init(results: [UserProfile.mockAlice], limited: true))
viewModel.context.searchQuery = "AAA"
_ = await context.$viewState.nextValue
await search(query: "AAA")
assertSearchResults(toBe: 1)
}
func testGetProfileIsNotCalled() async {
clientProxy.searchUsersResult = .success(.init(results: searchResults, limited: true))
clientProxy.getProfileResult = .success(.init(userID: "@alice:matrix.org"))
await search(query: "AAA")
assertSearchResults(toBe: 3)
XCTAssertFalse(clientProxy.getProfileCalled)
}
func testLocalResultShows() async {
clientProxy.searchUsersResult = .success(.init(results: searchResults, limited: true))
clientProxy.getProfileResult = .success(.init(userID: "@some:matrix.org"))
await search(query: "@a:b.com")
assertSearchResults(toBe: 4)
XCTAssertTrue(clientProxy.getProfileCalled)
}
func testLocalResultWithDuplicates() async {
clientProxy.searchUsersResult = .success(.init(results: searchResults, limited: true))
clientProxy.getProfileResult = .success(.init(userID: "@bob:matrix.org"))
await search(query: "@a:b.com")
assertSearchResults(toBe: 3)
let firstUserID = viewModel.context.viewState.usersSection.users.first?.userID
XCTAssertEqual(firstUserID, "@bob:matrix.org")
XCTAssertTrue(clientProxy.getProfileCalled)
}
func testSearchResultsShowWhenGetProfileFails() async {
clientProxy.searchUsersResult = .success(.init(results: searchResults, limited: true))
clientProxy.getProfileResult = .failure(.failedGettingUserProfile)
await search(query: "@a:b.com")
assertSearchResults(toBe: 4)
}
// MARK: - Private
private func assertSearchResults(toBe count: Int) {
XCTAssertTrue(count >= 0)
XCTAssertEqual(context.viewState.usersSection.type, .searchResult)
XCTAssertEqual(context.viewState.usersSection.users.count, 1)
XCTAssertFalse(context.viewState.hasEmptySearchResults)
XCTAssertEqual(context.viewState.usersSection.users.count, count)
XCTAssertEqual(context.viewState.hasEmptySearchResults, count == 0)
}
@discardableResult
private func search(query: String) async -> StartChatViewState? {
viewModel.context.searchQuery = query
return await context.$viewState.nextValue
}
private var searchResults: [UserProfile] {
[
.mockAlice,
.mockBob,
.mockCharlie
]
}
}