mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-04 10:33:45 +00:00
Attach Screenshot in Bug Report Screen (#578)
* 127 Attach Screenshot in Bug Report Screen * #127 code improvement * #127 Code improvements, and changed the loading... label to sending... * using a statically defined identifier for the new defined ui element * added the RowLabelStyle and improved the design of the view * code improvement * code improvement * making alignment private * synthesised init
This commit is contained in:
@@ -82,7 +82,9 @@
|
|||||||
"bug_report_screen_description" = "Please describe the bug. What did you do? What did you expect to happen? What actually happened. Please go into as much detail as you can.";
|
"bug_report_screen_description" = "Please describe the bug. What did you do? What did you expect to happen? What actually happened. Please go into as much detail as you can.";
|
||||||
"bug_report_screen_include_logs" = "Send logs to help";
|
"bug_report_screen_include_logs" = "Send logs to help";
|
||||||
"bug_report_screen_logs_description" = "To check things work as intended, logs will be sent with your message. These will be private. To just send your message, turn off this setting.";
|
"bug_report_screen_logs_description" = "To check things work as intended, logs will be sent with your message. These will be private. To just send your message, turn off this setting.";
|
||||||
|
"bug_report_screen_attach_screenshot" = "Attach Screenshot";
|
||||||
|
"bug_report_screen_edit_screenshot" = "Edit Screenshot";
|
||||||
|
"bug_report_screen_sending" = "Sending...";
|
||||||
|
|
||||||
// Session verification
|
// Session verification
|
||||||
/*
|
/*
|
||||||
|
|||||||
@@ -16,12 +16,18 @@ extension ElementL10n {
|
|||||||
public static let actionConfirm = ElementL10n.tr("Untranslated", "action_confirm")
|
public static let actionConfirm = ElementL10n.tr("Untranslated", "action_confirm")
|
||||||
/// Match
|
/// Match
|
||||||
public static let actionMatch = ElementL10n.tr("Untranslated", "action_match")
|
public static let actionMatch = ElementL10n.tr("Untranslated", "action_match")
|
||||||
|
/// Attach Screenshot
|
||||||
|
public static let bugReportScreenAttachScreenshot = ElementL10n.tr("Untranslated", "bug_report_screen_attach_screenshot")
|
||||||
/// Please describe the bug. What did you do? What did you expect to happen? What actually happened. Please go into as much detail as you can.
|
/// Please describe the bug. What did you do? What did you expect to happen? What actually happened. Please go into as much detail as you can.
|
||||||
public static let bugReportScreenDescription = ElementL10n.tr("Untranslated", "bug_report_screen_description")
|
public static let bugReportScreenDescription = ElementL10n.tr("Untranslated", "bug_report_screen_description")
|
||||||
|
/// Edit Screenshot
|
||||||
|
public static let bugReportScreenEditScreenshot = ElementL10n.tr("Untranslated", "bug_report_screen_edit_screenshot")
|
||||||
/// Send logs to help
|
/// Send logs to help
|
||||||
public static let bugReportScreenIncludeLogs = ElementL10n.tr("Untranslated", "bug_report_screen_include_logs")
|
public static let bugReportScreenIncludeLogs = ElementL10n.tr("Untranslated", "bug_report_screen_include_logs")
|
||||||
/// To check things work as intended, logs will be sent with your message. These will be private. To just send your message, turn off this setting.
|
/// To check things work as intended, logs will be sent with your message. These will be private. To just send your message, turn off this setting.
|
||||||
public static let bugReportScreenLogsDescription = ElementL10n.tr("Untranslated", "bug_report_screen_logs_description")
|
public static let bugReportScreenLogsDescription = ElementL10n.tr("Untranslated", "bug_report_screen_logs_description")
|
||||||
|
/// Sending...
|
||||||
|
public static let bugReportScreenSending = ElementL10n.tr("Untranslated", "bug_report_screen_sending")
|
||||||
/// Report a bug
|
/// Report a bug
|
||||||
public static let bugReportScreenTitle = ElementL10n.tr("Untranslated", "bug_report_screen_title")
|
public static let bugReportScreenTitle = ElementL10n.tr("Untranslated", "bug_report_screen_title")
|
||||||
/// %@ iOS
|
/// %@ iOS
|
||||||
|
|||||||
@@ -32,6 +32,7 @@ struct A11yIdentifiers {
|
|||||||
let screenshot = "bug_report-screenshot"
|
let screenshot = "bug_report-screenshot"
|
||||||
let removeScreenshot = "bug_report-remove_screenshot"
|
let removeScreenshot = "bug_report-remove_screenshot"
|
||||||
let send = "bug_report-send"
|
let send = "bug_report-send"
|
||||||
|
let attachScreenshot = "bug-report-attach_screenshot"
|
||||||
}
|
}
|
||||||
|
|
||||||
struct ChangeServer {
|
struct ChangeServer {
|
||||||
|
|||||||
@@ -26,7 +26,6 @@ struct SettingsDefaultRow: View {
|
|||||||
|
|
||||||
// MARK: Private
|
// MARK: Private
|
||||||
|
|
||||||
@ScaledMetric private var menuIconSize = 30.0
|
|
||||||
private let listRowInsets = EdgeInsets(top: 8, leading: 16, bottom: 8, trailing: 16)
|
private let listRowInsets = EdgeInsets(top: 8, leading: 16, bottom: 8, trailing: 16)
|
||||||
|
|
||||||
// MARK: Views
|
// MARK: Views
|
||||||
@@ -34,16 +33,12 @@ struct SettingsDefaultRow: View {
|
|||||||
var body: some View {
|
var body: some View {
|
||||||
Button(action: action) {
|
Button(action: action) {
|
||||||
HStack(spacing: 16) {
|
HStack(spacing: 16) {
|
||||||
image
|
Label(title: {
|
||||||
.foregroundColor(.element.systemGray)
|
Text(title)
|
||||||
.padding(4)
|
}, icon: {
|
||||||
.background(Color.element.systemGray6)
|
image
|
||||||
.clipShape(RoundedRectangle(cornerRadius: 8))
|
})
|
||||||
.frame(width: menuIconSize, height: menuIconSize)
|
.labelStyle(SettingsRowLabelStyle())
|
||||||
|
|
||||||
Text(title)
|
|
||||||
.font(.element.body)
|
|
||||||
.foregroundColor(.element.primaryContent)
|
|
||||||
|
|
||||||
Spacer()
|
Spacer()
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,37 @@
|
|||||||
|
//
|
||||||
|
// Copyright 2023 New Vector Ltd
|
||||||
|
//
|
||||||
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
// you may not use this file except in compliance with the License.
|
||||||
|
// You may obtain a copy of the License at
|
||||||
|
//
|
||||||
|
// http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
//
|
||||||
|
// Unless required by applicable law or agreed to in writing, software
|
||||||
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
// See the License for the specific language governing permissions and
|
||||||
|
// limitations under the License.
|
||||||
|
//
|
||||||
|
|
||||||
|
import SwiftUI
|
||||||
|
|
||||||
|
struct SettingsRowLabelStyle: LabelStyle {
|
||||||
|
@ScaledMetric private var menuIconSize = 30.0
|
||||||
|
|
||||||
|
var alignment: VerticalAlignment = .firstTextBaseline
|
||||||
|
|
||||||
|
func makeBody(configuration: Configuration) -> some View {
|
||||||
|
HStack(alignment: alignment, spacing: 16) {
|
||||||
|
configuration.icon
|
||||||
|
.foregroundColor(.element.secondaryContent)
|
||||||
|
.padding(4)
|
||||||
|
.background(Color.element.formBackground)
|
||||||
|
.clipShape(RoundedRectangle(cornerRadius: 8))
|
||||||
|
.frame(width: menuIconSize, height: menuIconSize)
|
||||||
|
configuration.title
|
||||||
|
.font(.element.body)
|
||||||
|
.foregroundColor(.element.primaryContent)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -52,7 +52,7 @@ final class BugReportCoordinator: CoordinatorProtocol {
|
|||||||
case .cancel:
|
case .cancel:
|
||||||
self.completion?(.cancel)
|
self.completion?(.cancel)
|
||||||
case let .submitStarted(progressTracker):
|
case let .submitStarted(progressTracker):
|
||||||
self.startLoading(progressPublisher: progressTracker)
|
self.startLoading(label: ElementL10n.bugReportScreenSending, progressPublisher: progressTracker)
|
||||||
case .submitFinished:
|
case .submitFinished:
|
||||||
self.stopLoading()
|
self.stopLoading()
|
||||||
self.completion?(.finish)
|
self.completion?(.finish)
|
||||||
|
|||||||
@@ -39,4 +39,5 @@ enum BugReportViewAction {
|
|||||||
case cancel
|
case cancel
|
||||||
case submit
|
case submit
|
||||||
case removeScreenshot
|
case removeScreenshot
|
||||||
|
case attachScreenshot(UIImage)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -43,6 +43,8 @@ class BugReportViewModel: BugReportViewModelType, BugReportViewModelProtocol {
|
|||||||
await submitBugReport()
|
await submitBugReport()
|
||||||
case .removeScreenshot:
|
case .removeScreenshot:
|
||||||
state.screenshot = nil
|
state.screenshot = nil
|
||||||
|
case let .attachScreenshot(image):
|
||||||
|
state.screenshot = image
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -52,11 +54,18 @@ class BugReportViewModel: BugReportViewModelType, BugReportViewModelProtocol {
|
|||||||
let progressTracker = ProgressTracker()
|
let progressTracker = ProgressTracker()
|
||||||
callback?(.submitStarted(progressTracker: progressTracker))
|
callback?(.submitStarted(progressTracker: progressTracker))
|
||||||
do {
|
do {
|
||||||
|
var files: [URL] = []
|
||||||
|
if let screenshot = context.viewState.screenshot {
|
||||||
|
let imageURL = URL.temporaryDirectory.appendingPathComponent("Screenshot.png")
|
||||||
|
let pngData = screenshot.pngData()
|
||||||
|
try pngData?.write(to: imageURL)
|
||||||
|
files.append(imageURL)
|
||||||
|
}
|
||||||
let bugReport = BugReport(text: context.reportText,
|
let bugReport = BugReport(text: context.reportText,
|
||||||
includeLogs: context.sendingLogsEnabled,
|
includeLogs: context.sendingLogsEnabled,
|
||||||
includeCrashLog: true,
|
includeCrashLog: true,
|
||||||
githubLabels: [],
|
githubLabels: [],
|
||||||
files: [])
|
files: files)
|
||||||
let result = try await bugReportService.submitBugReport(bugReport,
|
let result = try await bugReportService.submitBugReport(bugReport,
|
||||||
progressListener: progressTracker)
|
progressListener: progressTracker)
|
||||||
MXLog.info("SubmitBugReport succeeded, result: \(result.reportUrl)")
|
MXLog.info("SubmitBugReport succeeded, result: \(result.reportUrl)")
|
||||||
|
|||||||
@@ -14,6 +14,7 @@
|
|||||||
// limitations under the License.
|
// limitations under the License.
|
||||||
//
|
//
|
||||||
|
|
||||||
|
import PhotosUI
|
||||||
import SwiftUI
|
import SwiftUI
|
||||||
|
|
||||||
struct BugReportScreen: View {
|
struct BugReportScreen: View {
|
||||||
@@ -23,6 +24,8 @@ struct BugReportScreen: View {
|
|||||||
horizontalSizeClass == .regular ? 50 : 16
|
horizontalSizeClass == .regular ? 50 : 16
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@State private var selectedScreenshot: PhotosPickerItem?
|
||||||
|
|
||||||
@ObservedObject var context: BugReportViewModel.Context
|
@ObservedObject var context: BugReportViewModel.Context
|
||||||
|
|
||||||
var body: some View {
|
var body: some View {
|
||||||
@@ -37,14 +40,24 @@ struct BugReportScreen: View {
|
|||||||
.navigationBarTitleDisplayMode(.inline)
|
.navigationBarTitleDisplayMode(.inline)
|
||||||
.toolbar { toolbar }
|
.toolbar { toolbar }
|
||||||
.interactiveDismissDisabled()
|
.interactiveDismissDisabled()
|
||||||
|
.onChange(of: selectedScreenshot) { newItem in
|
||||||
|
Task {
|
||||||
|
guard let data = try? await newItem?.loadTransferable(type: Data.self),
|
||||||
|
let image = UIImage(data: data)
|
||||||
|
else {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
context.send(viewAction: .attachScreenshot(image))
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// The main content of the view to be shown in a scroll view.
|
/// The main content of the view to be shown in a scroll view.
|
||||||
var mainContent: some View {
|
var mainContent: some View {
|
||||||
VStack(alignment: .leading, spacing: 24) {
|
VStack(alignment: .leading, spacing: 24) {
|
||||||
descriptionTextEditor
|
descriptionTextEditor
|
||||||
|
attachScreenshot
|
||||||
sendLogsToggle
|
sendLogsToggle
|
||||||
screenshot
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -75,7 +88,7 @@ struct BugReportScreen: View {
|
|||||||
.stroke(Color.element.quaternaryContent)
|
.stroke(Color.element.quaternaryContent)
|
||||||
}
|
}
|
||||||
.frame(maxWidth: .infinity)
|
.frame(maxWidth: .infinity)
|
||||||
.frame(height: 300)
|
.frame(height: 220)
|
||||||
.font(.body)
|
.font(.body)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -97,22 +110,38 @@ struct BugReportScreen: View {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@ViewBuilder
|
@ViewBuilder
|
||||||
private var screenshot: some View {
|
private var attachScreenshot: some View {
|
||||||
if let screenshot = context.viewState.screenshot {
|
VStack(alignment: .leading, spacing: 16) {
|
||||||
ZStack(alignment: .topTrailing) {
|
PhotosPicker(selection: $selectedScreenshot,
|
||||||
Image(uiImage: screenshot)
|
matching: .screenshots,
|
||||||
.resizable()
|
photoLibrary: .shared()) {
|
||||||
.scaledToFit()
|
HStack(spacing: 16) {
|
||||||
.frame(width: 100)
|
Label(context.viewState.screenshot == nil ? ElementL10n.bugReportScreenAttachScreenshot : ElementL10n.bugReportScreenEditScreenshot, systemImage: "camera")
|
||||||
.accessibilityIdentifier(A11yIdentifiers.bugReportScreen.screenshot)
|
.labelStyle(SettingsRowLabelStyle())
|
||||||
Button { context.send(viewAction: .removeScreenshot) } label: {
|
Spacer()
|
||||||
Image(uiImage: Asset.Images.closeCircle.image)
|
|
||||||
}
|
}
|
||||||
.offset(x: 10, y: -10)
|
|
||||||
.accessibilityIdentifier(A11yIdentifiers.bugReportScreen.removeScreenshot)
|
|
||||||
}
|
}
|
||||||
.padding(.vertical, 16)
|
|
||||||
.padding(.horizontal, 16)
|
.padding(.horizontal, 16)
|
||||||
|
.padding(.vertical, 11)
|
||||||
|
.background(RoundedRectangle(cornerRadius: 14).fill(Color.element.formRowBackground))
|
||||||
|
.accessibilityIdentifier(A11yIdentifiers.bugReportScreen.attachScreenshot)
|
||||||
|
if let screenshot = context.viewState.screenshot {
|
||||||
|
ZStack(alignment: .topTrailing) {
|
||||||
|
Image(uiImage: screenshot)
|
||||||
|
.resizable()
|
||||||
|
.scaledToFit()
|
||||||
|
.frame(width: 100)
|
||||||
|
.cornerRadius(4)
|
||||||
|
.accessibilityIdentifier(A11yIdentifiers.bugReportScreen.screenshot)
|
||||||
|
Button { context.send(viewAction: .removeScreenshot) } label: {
|
||||||
|
Image(Asset.Images.closeCircle.name)
|
||||||
|
}
|
||||||
|
.offset(x: 10, y: -10)
|
||||||
|
.accessibilityIdentifier(A11yIdentifiers.bugReportScreen.removeScreenshot)
|
||||||
|
}
|
||||||
|
.padding(.vertical, 16)
|
||||||
|
.padding(.horizontal, 16)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -140,10 +169,19 @@ struct BugReportScreen: View {
|
|||||||
|
|
||||||
struct BugReport_Previews: PreviewProvider {
|
struct BugReport_Previews: PreviewProvider {
|
||||||
static let viewModel = BugReportViewModel(bugReportService: MockBugReportService(),
|
static let viewModel = BugReportViewModel(bugReportService: MockBugReportService(),
|
||||||
screenshot: Asset.Images.appLogo.image,
|
screenshot: nil,
|
||||||
isModallyPresented: false)
|
isModallyPresented: false)
|
||||||
|
|
||||||
static var previews: some View {
|
static var previews: some View {
|
||||||
BugReportScreen(context: viewModel.context)
|
Group {
|
||||||
|
BugReportScreen(context: BugReportViewModel(bugReportService: MockBugReportService(),
|
||||||
|
screenshot: nil,
|
||||||
|
isModallyPresented: false).context)
|
||||||
|
.previewDisplayName("Without Screenshot")
|
||||||
|
BugReportScreen(context: BugReportViewModel(bugReportService: MockBugReportService(),
|
||||||
|
screenshot: Asset.Images.appLogo.image,
|
||||||
|
isModallyPresented: false).context)
|
||||||
|
.previewDisplayName("With Screenshot")
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -17,7 +17,6 @@
|
|||||||
import SwiftUI
|
import SwiftUI
|
||||||
|
|
||||||
struct RoomDetailsScreen: View {
|
struct RoomDetailsScreen: View {
|
||||||
@ScaledMetric private var menuIconSize = 30.0
|
|
||||||
private let listRowInsets = EdgeInsets(top: 8, leading: 16, bottom: 8, trailing: 16)
|
private let listRowInsets = EdgeInsets(top: 8, leading: 16, bottom: 8, trailing: 16)
|
||||||
|
|
||||||
@ObservedObject var context: RoomDetailsViewModel.Context
|
@ObservedObject var context: RoomDetailsViewModel.Context
|
||||||
@@ -102,16 +101,8 @@ struct RoomDetailsScreen: View {
|
|||||||
context.send(viewAction: .processTapPeople)
|
context.send(viewAction: .processTapPeople)
|
||||||
} label: {
|
} label: {
|
||||||
HStack {
|
HStack {
|
||||||
Image(systemName: "person")
|
Label(ElementL10n.bottomActionPeople, systemImage: "person")
|
||||||
.foregroundColor(.element.secondaryContent)
|
.labelStyle(SettingsRowLabelStyle())
|
||||||
.padding(4)
|
|
||||||
.background(Color.element.formBackground)
|
|
||||||
.cornerRadius(8)
|
|
||||||
.frame(width: menuIconSize, height: menuIconSize)
|
|
||||||
|
|
||||||
Text(ElementL10n.bottomActionPeople)
|
|
||||||
.foregroundColor(.element.primaryContent)
|
|
||||||
.font(.body)
|
|
||||||
|
|
||||||
Spacer()
|
Spacer()
|
||||||
|
|
||||||
@@ -138,22 +129,17 @@ struct RoomDetailsScreen: View {
|
|||||||
private var securitySection: some View {
|
private var securitySection: some View {
|
||||||
Section {
|
Section {
|
||||||
HStack(alignment: .top) {
|
HStack(alignment: .top) {
|
||||||
Image(systemName: "lock.shield")
|
Label(title: {
|
||||||
.foregroundColor(.element.secondaryContent)
|
VStack(alignment: .leading, spacing: 2) {
|
||||||
.padding(4)
|
Text(ElementL10n.encryptionEnabled)
|
||||||
.background(Color.element.formBackground)
|
Text(ElementL10n.encryptionEnabledTileDescription)
|
||||||
.cornerRadius(8)
|
.foregroundColor(.element.secondaryContent)
|
||||||
.frame(width: menuIconSize, height: menuIconSize)
|
.font(.element.footnote)
|
||||||
|
}
|
||||||
VStack(alignment: .leading, spacing: 2) {
|
}, icon: {
|
||||||
Text(ElementL10n.encryptionEnabled)
|
Image(systemName: "lock.shield")
|
||||||
.foregroundColor(.element.primaryContent)
|
})
|
||||||
.font(.element.body)
|
.labelStyle(SettingsRowLabelStyle(alignment: .top))
|
||||||
|
|
||||||
Text(ElementL10n.encryptionEnabledTileDescription)
|
|
||||||
.foregroundColor(.element.secondaryContent)
|
|
||||||
.font(.element.footnote)
|
|
||||||
}
|
|
||||||
|
|
||||||
Spacer()
|
Spacer()
|
||||||
|
|
||||||
|
|||||||
@@ -20,7 +20,6 @@ struct SettingsScreen: View {
|
|||||||
@State private var showingLogoutConfirmation = false
|
@State private var showingLogoutConfirmation = false
|
||||||
|
|
||||||
@ScaledMetric private var avatarSize = AvatarSize.user(on: .settings).value
|
@ScaledMetric private var avatarSize = AvatarSize.user(on: .settings).value
|
||||||
@ScaledMetric private var menuIconSize = 30.0
|
|
||||||
|
|
||||||
private let listRowInsets = EdgeInsets(top: 8, leading: 16, bottom: 8, trailing: 16)
|
private let listRowInsets = EdgeInsets(top: 8, leading: 16, bottom: 8, trailing: 16)
|
||||||
|
|
||||||
|
|||||||
@@ -189,7 +189,7 @@ class BugReportService: NSObject, BugReportServiceProtocol {
|
|||||||
var zippedFiles: [URL] = []
|
var zippedFiles: [URL] = []
|
||||||
|
|
||||||
for url in filesToCompress {
|
for url in filesToCompress {
|
||||||
let zippedFileURL = URL(fileURLWithPath: NSTemporaryDirectory())
|
let zippedFileURL = URL.temporaryDirectory
|
||||||
.appendingPathComponent(url.lastPathComponent)
|
.appendingPathComponent(url.lastPathComponent)
|
||||||
|
|
||||||
// remove old zipped file if exists
|
// remove old zipped file if exists
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:fd7fe8c3cbd9a73717651dc206734d7c68fa60f0c854a8a6cd53e11b2446c1e9
|
oid sha256:840363fb8bda7290d75aad9dd2bfee3583299aca1682a18d9348c17cdff495de
|
||||||
size 108261
|
size 115274
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:da6f2865d45eff4ba6cc6b28954152184fa2b1e0b360b680789e5fc52156800d
|
oid sha256:f542e446145a1ce909d977120e5d32cf172d6adb7bfd54ebb7f7b0428bb94f1d
|
||||||
size 109266
|
size 115114
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:0a8b60268e5024ab15548a0de7585f1492d18cbbc5ff02344d82cd7cb468609c
|
oid sha256:7a370935dd82dde19d887038b076f155273e0dfaa3af6c9fa33bcfb97b825eb6
|
||||||
size 163777
|
size 169111
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:2267708bec43c594b550ee43a9871ed6efa36c185fa12b73232c6ad508274328
|
oid sha256:dc4a8c344dd80070277035e811b84b31ae9050d4f11bb22e507e0cf402cc5e56
|
||||||
size 165403
|
size 171658
|
||||||
|
|||||||
+2
-2
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:25f7467d86397206aa24ed89c570cd3449356a915f773f8753cc99a65080ceac
|
oid sha256:e80577c2f9a41da888e211e5948169c7b8449f6da79403f2787f98e4f9532819
|
||||||
size 115806
|
size 122129
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:e0efbca15ea0e8f2d69e421aa71623837919895b0e206e02b45944de504200b2
|
oid sha256:52c8c00c02ba4da3ea07981704182f02e9e3981befd6f7c7ade1b51f7ce3187b
|
||||||
size 140892
|
size 151905
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:8c8ccf539c26dd51858cd0ae66a7e42a8e3ac2dbe41832a0df6825a2a804d04f
|
oid sha256:a28aa63ec2b888633e8898bb7c8d91ae784da1569d3faa45f29a209d6dea5354
|
||||||
size 141237
|
size 151771
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:1c31dfc2666606276181af62a131e0e1199f5b75b72725817766d6cc0fc25375
|
oid sha256:add279f6f7f8f9d15941d2b9b3c1046165bb7f5df30d964a50763a1fbbc59c05
|
||||||
size 161533
|
size 165889
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:59221f632aef10a110775bd24aba1717feb900dde5168f79f72c42080b539943
|
oid sha256:31791083395412c78e885160659df1ba7ba1a0cc2bc927fdc7e61b09f1cb6f6c
|
||||||
size 166287
|
size 169888
|
||||||
|
|||||||
+2
-2
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:53a27c874a017b7391fdf2df70fe3c2744ce9700683dcac2851fd8de46738c0b
|
oid sha256:219bdb41bad2e50060ffb9b9052626ac77763a4e80e3f0a7e90e0f8a881f6f71
|
||||||
size 148351
|
size 158742
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:e7e6ee6f769c67df4b6e2505f6aab85241bfa38ec5a8d3704d8de83be54d169f
|
oid sha256:e61714b5faf17d54f5e1053fb6d4062dae065caa59987fb6a35a66652dabc317
|
||||||
size 107687
|
size 114745
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:7cdf78ee1d8da820ad8ab7d9055f8ab3e0811aacacc56d93eca7cbe75d038066
|
oid sha256:e66ec0e654b0c209b675142bd4acec0220b65d088822c35c14521ab57cec0b46
|
||||||
size 108651
|
size 114579
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:b8dd0c7905a101a5cd98bb2bc95a538453b8fb9532cf4eba75e48239b8d67c1d
|
oid sha256:e2771a646e6581abab1c86c79ae463c817cc61f8eef45e23dbccf856fa69286c
|
||||||
size 163129
|
size 168402
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:7ad3e77c76fea231adf9340f4ca0208eadbae56f4b4b7aa6bb1c2ab697e9525c
|
oid sha256:11073c8e77147d476713c92ae2209dde2593bd1e52f8444790eaca040d978f07
|
||||||
size 164851
|
size 171000
|
||||||
|
|||||||
+2
-2
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:f99a41d423d6cdf87c690e5278390903bb554aa08d8d3e823279273ac50dda25
|
oid sha256:bb1983b49b4ebd61e4717dcd8a500307839d3e4a96d24afb4e37f236c083da10
|
||||||
size 115672
|
size 121992
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:4451410930f771a8943773939648db0c13a98fceeabfbe4e85803f5d4fa3e90f
|
oid sha256:9e910c1fb0e2e449b999f08c0e38f0fc1228506e903d22d53057687a3e1c6125
|
||||||
size 139842
|
size 148744
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:b74030d8442522efd6bc6ebd019b5c4260b24124e5b3c9b333a6d3bd2614a46e
|
oid sha256:dc190d5cda1f47929fb14fec12ff81a330d66e8ce4bca7846d896bc598410918
|
||||||
size 139825
|
size 150772
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:ece22c9e46b3dd2f1b2f62cfd2617face59c06d46da81caec2b0a07fbe3b286c
|
oid sha256:b0668c40ede3181a2ff1091e4572908ed61549ca0fca4aee29b2f7ce4b5323bb
|
||||||
size 160607
|
size 164888
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:1fabb5f82e3f12e01435c6f48d618d83c049ee6437a7c59580fc9c6319d3317d
|
oid sha256:5a5ee287e5f6d416e57105c6418f8c5346153af63027a7fb9f1443b8fe944a39
|
||||||
size 165314
|
size 168860
|
||||||
|
|||||||
+2
-2
@@ -1,3 +1,3 @@
|
|||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:6a45deead94f995386a1bf034bee68f5741f9fe2d06ab8e7abbfe97254a7ca65
|
oid sha256:8e01515371cf24c0c527c2728d1a15090ff7162faa22b7d2dacfad15818b6aee
|
||||||
size 148195
|
size 158582
|
||||||
|
|||||||
@@ -37,4 +37,13 @@ class BugReportViewModelTests: XCTestCase {
|
|||||||
try await Task.sleep(nanoseconds: 100_000_000)
|
try await Task.sleep(nanoseconds: 100_000_000)
|
||||||
XCTAssertNil(context.viewState.screenshot)
|
XCTAssertNil(context.viewState.screenshot)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func testAttachScreenshot() async throws {
|
||||||
|
let viewModel = BugReportViewModel(bugReportService: MockBugReportService(), screenshot: nil, isModallyPresented: false)
|
||||||
|
let context = viewModel.context
|
||||||
|
XCTAssertNil(context.viewState.screenshot)
|
||||||
|
context.send(viewAction: .attachScreenshot(UIImage.actions))
|
||||||
|
try await Task.sleep(nanoseconds: 100_000_000)
|
||||||
|
XCTAssert(context.viewState.screenshot == UIImage.actions)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1 @@
|
|||||||
|
Added the functionality to attach a screenshot in the Bug Report View.
|
||||||
Reference in New Issue
Block a user