Attach Screenshot in Bug Report Screen (#578)

* 127 Attach Screenshot in Bug Report Screen

* #127 code improvement

* #127 Code improvements, and changed the loading... label to sending...

* using a statically defined identifier for the new defined ui element

* added the RowLabelStyle and improved the design of the view

* code improvement

* code improvement

* making alignment private

* synthesised init

ElementX/Sources/Other/AccessibilityIdentifiers.swift

@@ -32,6 +32,7 @@ struct A11yIdentifiers {
         let screenshot = "bug_report-screenshot"
         let removeScreenshot = "bug_report-remove_screenshot"
         let send = "bug_report-send"
+        let attachScreenshot = "bug-report-attach_screenshot"
     }
     
     struct ChangeServer {

ElementX/Sources/Other/SwiftUI/Views/SettingsDefaultRow.swift

@@ -26,7 +26,6 @@ struct SettingsDefaultRow: View {
     
     // MARK: Private
     
-    @ScaledMetric private var menuIconSize = 30.0
     private let listRowInsets = EdgeInsets(top: 8, leading: 16, bottom: 8, trailing: 16)
 
     // MARK: Views
@@ -34,16 +33,12 @@ struct SettingsDefaultRow: View {
     var body: some View {
         Button(action: action) {
             HStack(spacing: 16) {
-                image
-                    .foregroundColor(.element.systemGray)
-                    .padding(4)
-                    .background(Color.element.systemGray6)
-                    .clipShape(RoundedRectangle(cornerRadius: 8))
-                    .frame(width: menuIconSize, height: menuIconSize)
-                
-                Text(title)
-                    .font(.element.body)
-                    .foregroundColor(.element.primaryContent)
+                Label(title: {
+                    Text(title)
+                }, icon: {
+                    image
+                })
+                .labelStyle(SettingsRowLabelStyle())
                 
                 Spacer()
                 

ElementX/Sources/Other/SwiftUI/Views/SettingsRowLabelStyle.swift

@@ -0,0 +1,37 @@
+//
+// Copyright 2023 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import SwiftUI
+
+struct SettingsRowLabelStyle: LabelStyle {
+    @ScaledMetric private var menuIconSize = 30.0
+    
+    var alignment: VerticalAlignment = .firstTextBaseline
+
+    func makeBody(configuration: Configuration) -> some View {
+        HStack(alignment: alignment, spacing: 16) {
+            configuration.icon
+                .foregroundColor(.element.secondaryContent)
+                .padding(4)
+                .background(Color.element.formBackground)
+                .clipShape(RoundedRectangle(cornerRadius: 8))
+                .frame(width: menuIconSize, height: menuIconSize)
+            configuration.title
+                .font(.element.body)
+                .foregroundColor(.element.primaryContent)
+        }
+    }
+}