From e8da21e340e0c185b4dedf6a2a6b02b464905459 Mon Sep 17 00:00:00 2001 From: Mauro <34335419+Velin92@users.noreply.github.com> Date: Wed, 20 Dec 2023 14:22:57 +0100 Subject: [PATCH] Poll options can be multiline during creation (#2274) --- .../Screens/CreatePollScreen/View/PollFormScreen.swift | 7 +++---- .../PreviewTests/test_pollFormScreen.Edit.png | 4 ++-- .../__Snapshots__/PreviewTests/test_pollFormScreen.New.png | 4 ++-- changelog.d/2273.bugfix | 1 + 4 files changed, 8 insertions(+), 8 deletions(-) create mode 100644 changelog.d/2273.bugfix diff --git a/ElementX/Sources/Screens/CreatePollScreen/View/PollFormScreen.swift b/ElementX/Sources/Screens/CreatePollScreen/View/PollFormScreen.swift index 54a4a6db3..8ae6f1e72 100644 --- a/ElementX/Sources/Screens/CreatePollScreen/View/PollFormScreen.swift +++ b/ElementX/Sources/Screens/CreatePollScreen/View/PollFormScreen.swift @@ -94,6 +94,8 @@ struct PollFormScreen: View { .accessibilityIdentifier(A11yIdentifiers.pollFormScreen.addOption) } } + // Disables animations when the text view resizes for multiline + .animation(.noAnimation, value: UUID()) } private var showResultsSection: some View { @@ -166,13 +168,10 @@ private struct PollFormOptionRow: View { .accessibilityLabel(L10n.actionRemove) } - TextField(text: $text) { + TextField(text: $text, axis: .vertical) { Text(placeholder) .compoundTextFieldPlaceholder() } - .introspect(.textField, on: .supportedVersions) { textField in - textField.clearButtonMode = .whileEditing - } .tint(.compound.iconAccentTertiary) .alignmentGuide(.listRowSeparatorLeading) { _ in 0 } } diff --git a/UnitTests/__Snapshots__/PreviewTests/test_pollFormScreen.Edit.png b/UnitTests/__Snapshots__/PreviewTests/test_pollFormScreen.Edit.png index acdc87daf..309cd0add 100644 --- a/UnitTests/__Snapshots__/PreviewTests/test_pollFormScreen.Edit.png +++ b/UnitTests/__Snapshots__/PreviewTests/test_pollFormScreen.Edit.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:b4be2cd725b1827517224eeee1def3f15c4a51b931bc38119faebc953a8ca5ab -size 128139 +oid sha256:f22c1b227cb4545c3d8609cf08adeca1680733a5ce65f53ff6d8f20f30d3886a +size 128184 diff --git a/UnitTests/__Snapshots__/PreviewTests/test_pollFormScreen.New.png b/UnitTests/__Snapshots__/PreviewTests/test_pollFormScreen.New.png index 769c6fb16..bc103cb02 100644 --- a/UnitTests/__Snapshots__/PreviewTests/test_pollFormScreen.New.png +++ b/UnitTests/__Snapshots__/PreviewTests/test_pollFormScreen.New.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:e18f6203bb7bf2df1ac5910f1caa05161fe6866ae6183ca3cfb27e6efe507305 -size 126330 +oid sha256:fcfca7febd7b0e6d7b66695b2149049eefbaf9a8d47f3a3f56c48c0e4b837695 +size 128716 diff --git a/changelog.d/2273.bugfix b/changelog.d/2273.bugfix new file mode 100644 index 000000000..8917d2741 --- /dev/null +++ b/changelog.d/2273.bugfix @@ -0,0 +1 @@ +Options in poll form creation can be multiline. \ No newline at end of file