Update compound and remove all of the temporary icons (#2419)

* Update compound and fix breaking changes.

* Replace a lot of temporary icon assets with Compound versions.

* Replace temporary composer icon assets with Compound versions.

* Remove old icon asset from EI.

* Use Compound icons where possible for hero images.

* Snapshots

ElementX/Sources/Screens/Settings/SettingsScreen/View/SettingsScreen.swift

@@ -87,7 +87,7 @@ struct SettingsScreen: View {
                             kind: .button { context.send(viewAction: .sessionVerification) })
                 } else {
                     ListRow(label: .default(title: L10n.commonChatBackup,
-                                            icon: Image(asset: Asset.Images.secureBackupIcon)),
+                                            icon: \.key),
                             details: context.viewState.showSecureBackupBadge ? .icon(secureBackupBadge) : nil,
                             kind: .navigationLink { context.send(viewAction: .secureBackup) })
                         .accessibilityIdentifier(A11yIdentifiers.settingsScreen.secureBackup)
@@ -115,14 +115,14 @@ struct SettingsScreen: View {
                     .accessibilityIdentifier(A11yIdentifiers.settingsScreen.notifications)
             
             ListRow(label: .default(title: L10n.commonAnalytics,
-                                    icon: \.polls),
+                                    icon: \.chart),
                     kind: .navigationLink {
                         context.send(viewAction: .analytics)
                     })
                     .accessibilityIdentifier(A11yIdentifiers.settingsScreen.analytics)
             
             ListRow(label: .default(title: L10n.commonScreenLock,
-                                    icon: CompoundIcon(asset: Asset.Images.lock)),
+                                    icon: \.lock),
                     kind: .navigationLink {
                         context.send(viewAction: .appLock)
                     })
@@ -147,7 +147,7 @@ struct SettingsScreen: View {
     private var manageSessionsSection: some View {
         Section {
             ListRow(label: .default(title: L10n.actionManageDevices,
-                                    icon: CompoundIcon(asset: Asset.Images.devices)),
+                                    icon: \.devices),
                     kind: .button {
                         context.send(viewAction: .accountSessionsList)
                     })
@@ -165,7 +165,7 @@ struct SettingsScreen: View {
             
             if context.viewState.showDeveloperOptions {
                 ListRow(label: .default(title: L10n.commonDeveloperOptions,
-                                        icon: CompoundIcon(asset: Asset.Images.codeBlock)),
+                                        icon: \.code),
                         kind: .navigationLink {
                             context.send(viewAction: .developerOptions)
                         })
@@ -177,7 +177,7 @@ struct SettingsScreen: View {
     private var signOutSection: some View {
         Section {
             ListRow(label: .action(title: L10n.screenSignoutPreferenceItem,
-                                   icon: CompoundIcon(asset: Asset.Images.signOut),
+                                   icon: \.signOut,
                                    role: .destructive),
                     kind: .button {
                         context.send(viewAction: .logout)

ElementX/Sources/Screens/Settings/UserDetailsEditScreen/View/UserDetailsEditScreen.swift

@@ -89,7 +89,7 @@ struct UserDetailsEditScreen: View {
     }
     
     private var avatarOverlayIcon: some View {
-        CompoundIcon(asset: Asset.Images.editing, size: .xSmall, relativeTo: .compound.bodyLG)
+        CompoundIcon(\.editSolid, size: .xSmall, relativeTo: .compound.bodyLG)
             .foregroundColor(.white)
             .padding(4)
             .background {