mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-02 12:07:55 +00:00
Finish migration of UnitTests target from XCTestCase to Swift Testing (#5129)
* Initial plan * Migrate 3 test files from XCTest to Swift Testing - MediaUploadPreviewScreenViewModelTests: @MainActor @Suite struct with init(), BundleFinder class for Bundle(for:), mutating test/setup functions, [self] capture replacing [weak self] in closures - NotificationManagerTests: @MainActor @Suite final class with init()/deinit, expectation/fulfillment(of:) replaced with confirmation(...), test_ prefix stripped - NotificationSettingsScreenViewModelTests: @MainActor @Suite struct with init() throws, non-optional stored properties, test prefix stripped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 3 XCTest files to Swift Testing - NotificationSettingsEditScreenViewModelTests: @MainActor @Suite struct with init() throws, mutating test methods - TimelineViewModelTests: @MainActor @Suite final class with init() async throws + deinit - AttributedStringBuilderTests: @Suite struct with init() async throws All XCT assertions replaced with #expect/#require/Issue.record Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 4 test files from XCTest to Swift Testing - TimelineMediaPreviewViewModelTests: @Suite struct, mutating @Test funcs, testLoadingItem renamed to loadingItem (called internally by other tests) - ServerConfirmationScreenViewModelTests: @Suite final class with init()/deinit - CompletionSuggestionServiceTests: @Suite struct with init() - RoomFlowCoordinatorTests: @Suite final class with deinit Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 4 test files from XCTest to Swift Testing - VoiceMessageRecorderTests: @Suite struct with init() async throws, added BundleFinder class for Bundle lookup, migrated all assertions - SpaceScreenViewModelTests: @Suite struct, private mutating setupViewModel, all test funcs mutating, XCTestExpectation → confirmation - RoomNotificationSettingsScreenViewModelTests: @Suite struct with init() throws, cancellable tests marked mutating - JoinRoomScreenViewModelTests: @Suite final class with init()/deinit, XCTestExpectation → confirmation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate 6 test files from XCTestCase to Swift Testing Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> * Fix trailing blank line in RoomPollsHistoryScreenViewModelTests Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> * Migrate 3 test files from XCTest to Swift Testing - MediaUploadingPreprocessorTests: @Suite final class with init()/deinit, removed executionTimeAllowance, XCTAssertEqual(accuracy:) → abs(Double) - SecurityAndPrivacyScreenViewModelTests: @MainActor @Suite final class, 5 expectation+fulfillment → await confirmation(...) - CreateRoomViewModelTests: @MainActor @Suite final class, 4 expectation+fulfillment → await confirmation(...) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate RoomScreenViewModelTests and RoomDetailsScreenViewModelTests to Swift Testing - Replace XCTest with Testing framework - RoomScreenViewModelTests: final class with init() async throws + deinit - RoomDetailsScreenViewModelTests: struct with init() and mutating funcs - Convert XCT assertions to #expect / Issue.record - Convert XCTestExpectation patterns to confirmation { confirm in } - Strip 'test' prefix from all test function names Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Migrate ComposerToolbarViewModelTests from XCTest to Swift Testing - Replace import XCTest with import Testing - Convert XCTestCase class to @MainActor @Suite final class - Replace setUp()/tearDown() with init()/deinit - Strip 'test' prefix from all 41 test method names and add @Test - Replace XCTAssert* with #expect()/#require() - Replace try XCTUnwrap() with try #require() - Convert expectation+wait patterns to deferFulfillment with PassthroughSubject - Convert isInverted expectation to boolean flag checked after await - Use deferFulfillment on $viewState for state-transition tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address comments with Copilot. * Fix the failing tests. * Fixed flaky tests (#5137) resolved flaky tests * Tweaks and fixes. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com> Co-authored-by: Doug <douglase@element.io> Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
This commit is contained in:
Copilot
GitHub
@@ -9,10 +9,11 @@
|
||||
import Combine
|
||||
@testable import ElementX
|
||||
import MatrixRustSDK
|
||||
import XCTest
|
||||
import Testing
|
||||
|
||||
@Suite
|
||||
@MainActor
|
||||
class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
final class SecurityAndPrivacyScreenViewModelTests {
|
||||
var viewModel: SecurityAndPrivacyScreenViewModelProtocol!
|
||||
var spaceServiceProxy: SpaceServiceProxyMock!
|
||||
var roomProxy: JoinedRoomProxyMock!
|
||||
@@ -21,13 +22,18 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
viewModel.context
|
||||
}
|
||||
|
||||
override func tearDown() {
|
||||
init() {
|
||||
AppSettings.resetAllSettings()
|
||||
}
|
||||
|
||||
deinit {
|
||||
viewModel = nil
|
||||
roomProxy = nil
|
||||
AppSettings.resetAllSettings()
|
||||
}
|
||||
|
||||
func testSetSingleJoinedSpaceMembersAccess() async throws {
|
||||
@Test
|
||||
func setSingleJoinedSpaceMembersAccess() async throws {
|
||||
let singleRoom = [SpaceServiceRoom].mockSingleRoom
|
||||
let space = singleRoom[0]
|
||||
setupViewModel(joinedParentSpaces: singleRoom, joinRule: .public)
|
||||
@@ -35,30 +41,31 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
let deferred = deferFulfillment(context.$viewState) { $0.selectableJoinedSpaces.count == 1 }
|
||||
try await deferred.fulfill()
|
||||
|
||||
XCTAssertEqual(context.viewState.currentSettings.accessType, .anyone)
|
||||
XCTAssertTrue(context.viewState.isSaveDisabled)
|
||||
XCTAssertTrue(context.viewState.isSpaceMembersOptionSelectable)
|
||||
#expect(context.viewState.currentSettings.accessType == .anyone)
|
||||
#expect(context.viewState.isSaveDisabled)
|
||||
#expect(context.viewState.isSpaceMembersOptionSelectable)
|
||||
guard case .singleJoined = context.viewState.spaceSelection else {
|
||||
XCTFail("Expected spaceSelection to be .singleJoined")
|
||||
Issue.record("Expected spaceSelection to be .singleJoined")
|
||||
return
|
||||
}
|
||||
|
||||
context.send(viewAction: .selectedSpaceMembersAccess)
|
||||
XCTAssertEqual(context.desiredSettings.accessType, .spaceMembers(spaceIDs: [space.id]))
|
||||
XCTAssertFalse(context.viewState.shouldShowAccessSectionFooter)
|
||||
XCTAssertFalse(context.viewState.isSaveDisabled)
|
||||
#expect(context.desiredSettings.accessType == .spaceMembers(spaceIDs: [space.id]))
|
||||
#expect(!context.viewState.shouldShowAccessSectionFooter)
|
||||
#expect(!context.viewState.isSaveDisabled)
|
||||
|
||||
let expectation = expectation(description: "Join rule has updated")
|
||||
roomProxy.updateJoinRuleClosure = { value in
|
||||
XCTAssertEqual(value, .restricted(rules: [.roomMembership(roomID: space.id)]))
|
||||
expectation.fulfill()
|
||||
return .success(())
|
||||
await waitForConfirmation("Join rule has updated") { confirm in
|
||||
roomProxy.updateJoinRuleClosure = { value in
|
||||
#expect(value == .restricted(rules: [.roomMembership(roomID: space.id)]))
|
||||
confirm()
|
||||
return .success(())
|
||||
}
|
||||
context.send(viewAction: .save)
|
||||
}
|
||||
context.send(viewAction: .save)
|
||||
await fulfillment(of: [expectation])
|
||||
}
|
||||
|
||||
func testSetSingleJoinedAskToJoinWithSpaceMembersAccess() async throws {
|
||||
@Test
|
||||
func setSingleJoinedAskToJoinWithSpaceMembersAccess() async throws {
|
||||
let singleRoom = [SpaceServiceRoom].mockSingleRoom
|
||||
let space = singleRoom[0]
|
||||
setupViewModel(joinedParentSpaces: singleRoom, joinRule: .public)
|
||||
@@ -66,30 +73,31 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
let deferred = deferFulfillment(context.$viewState) { $0.selectableJoinedSpaces.count == 1 }
|
||||
try await deferred.fulfill()
|
||||
|
||||
XCTAssertEqual(context.viewState.currentSettings.accessType, .anyone)
|
||||
XCTAssertTrue(context.viewState.isSaveDisabled)
|
||||
XCTAssertTrue(context.viewState.isAskToJoinWithSpaceMembersOptionSelectable)
|
||||
#expect(context.viewState.currentSettings.accessType == .anyone)
|
||||
#expect(context.viewState.isSaveDisabled)
|
||||
#expect(context.viewState.isAskToJoinWithSpaceMembersOptionSelectable)
|
||||
guard case .singleJoined = context.viewState.spaceSelection else {
|
||||
XCTFail("Expected spaceSelection to be .singleJoined")
|
||||
Issue.record("Expected spaceSelection to be .singleJoined")
|
||||
return
|
||||
}
|
||||
|
||||
context.send(viewAction: .selectedAskToJoinWithSpaceMembersAccess)
|
||||
XCTAssertEqual(context.desiredSettings.accessType, .askToJoinWithSpaceMembers(spaceIDs: [space.id]))
|
||||
XCTAssertFalse(context.viewState.shouldShowAccessSectionFooter)
|
||||
XCTAssertFalse(context.viewState.isSaveDisabled)
|
||||
#expect(context.desiredSettings.accessType == .askToJoinWithSpaceMembers(spaceIDs: [space.id]))
|
||||
#expect(!context.viewState.shouldShowAccessSectionFooter)
|
||||
#expect(!context.viewState.isSaveDisabled)
|
||||
|
||||
let expectation = expectation(description: "Join rule has updated")
|
||||
roomProxy.updateJoinRuleClosure = { value in
|
||||
XCTAssertEqual(value, .knockRestricted(rules: [.roomMembership(roomID: space.id)]))
|
||||
expectation.fulfill()
|
||||
return .success(())
|
||||
await waitForConfirmation("Join rule has updated") { confirm in
|
||||
roomProxy.updateJoinRuleClosure = { value in
|
||||
#expect(value == .knockRestricted(rules: [.roomMembership(roomID: space.id)]))
|
||||
confirm()
|
||||
return .success(())
|
||||
}
|
||||
context.send(viewAction: .save)
|
||||
}
|
||||
context.send(viewAction: .save)
|
||||
await fulfillment(of: [expectation])
|
||||
}
|
||||
|
||||
func testSingleUnknownSpaceMembersAccessCanBeReselected() async throws {
|
||||
@Test
|
||||
func singleUnknownSpaceMembersAccessCanBeReselected() async throws {
|
||||
let singleRoom = [SpaceServiceRoom].mockSingleRoom
|
||||
let space = singleRoom[0]
|
||||
setupViewModel(joinedParentSpaces: [], joinRule: .restricted(rules: [.roomMembership(roomID: space.id)]))
|
||||
@@ -97,41 +105,43 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
let deferred = deferFulfillment(context.$viewState) { $0.selectableJoinedSpaces.count == 0 }
|
||||
try await deferred.fulfill()
|
||||
|
||||
XCTAssertEqual(context.viewState.currentSettings.accessType, .spaceMembers(spaceIDs: [space.id]))
|
||||
XCTAssertEqual(context.desiredSettings, context.viewState.currentSettings)
|
||||
XCTAssertTrue(context.viewState.isSpaceMembersOptionSelectable)
|
||||
XCTAssertFalse(context.viewState.shouldShowAccessSectionFooter)
|
||||
XCTAssertTrue(context.viewState.isSaveDisabled)
|
||||
#expect(context.viewState.currentSettings.accessType == .spaceMembers(spaceIDs: [space.id]))
|
||||
#expect(context.desiredSettings == context.viewState.currentSettings)
|
||||
#expect(context.viewState.isSpaceMembersOptionSelectable)
|
||||
#expect(!context.viewState.shouldShowAccessSectionFooter)
|
||||
#expect(context.viewState.isSaveDisabled)
|
||||
guard case .singleUnknown = context.viewState.spaceSelection else {
|
||||
XCTFail("Expected spaceSelection to be .singleUnknown")
|
||||
Issue.record("Expected spaceSelection to be .singleUnknown")
|
||||
return
|
||||
}
|
||||
|
||||
let saveDeferred = deferFulfillment(context.$viewState) { !$0.isSaveDisabled }
|
||||
context.desiredSettings.accessType = .anyone
|
||||
XCTAssertTrue(context.viewState.isSpaceMembersOptionSelectable)
|
||||
XCTAssertFalse(context.viewState.isSaveDisabled)
|
||||
try await saveDeferred.fulfill()
|
||||
#expect(context.viewState.isSpaceMembersOptionSelectable)
|
||||
|
||||
context.send(viewAction: .selectedSpaceMembersAccess)
|
||||
XCTAssertTrue(context.viewState.isSaveDisabled)
|
||||
XCTAssertEqual(context.desiredSettings.accessType, .spaceMembers(spaceIDs: [space.id]))
|
||||
#expect(context.viewState.isSaveDisabled)
|
||||
#expect(context.desiredSettings.accessType == .spaceMembers(spaceIDs: [space.id]))
|
||||
guard case .singleUnknown = context.viewState.spaceSelection else {
|
||||
XCTFail("Expected spaceSelection to be .singleUnknown")
|
||||
Issue.record("Expected spaceSelection to be .singleUnknown")
|
||||
return
|
||||
}
|
||||
}
|
||||
|
||||
func testMultipleKnownSpacesMembersSelection() async throws {
|
||||
@Test
|
||||
func multipleKnownSpacesMembersSelection() async throws {
|
||||
let spaces = [SpaceServiceRoom].mockJoinedSpaces2
|
||||
setupViewModel(joinedParentSpaces: spaces, joinRule: .public)
|
||||
|
||||
let deferred = deferFulfillment(context.$viewState) { $0.selectableJoinedSpaces.count == 3 }
|
||||
try await deferred.fulfill()
|
||||
|
||||
XCTAssertEqual(context.viewState.currentSettings.accessType, .anyone)
|
||||
XCTAssertTrue(context.viewState.isSaveDisabled)
|
||||
XCTAssertTrue(context.viewState.isSpaceMembersOptionSelectable)
|
||||
#expect(context.viewState.currentSettings.accessType == .anyone)
|
||||
#expect(context.viewState.isSaveDisabled)
|
||||
#expect(context.viewState.isSpaceMembersOptionSelectable)
|
||||
guard case .multiple = context.viewState.spaceSelection else {
|
||||
XCTFail("Expected spaceSelection to be .multiple")
|
||||
Issue.record("Expected spaceSelection to be .multiple")
|
||||
return
|
||||
}
|
||||
|
||||
@@ -150,32 +160,33 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
context.send(viewAction: .selectedSpaceMembersAccess)
|
||||
try await deferredAction.fulfill()
|
||||
selectedIDs.send([spaces[0].id])
|
||||
XCTAssertEqual(context.desiredSettings.accessType, .spaceMembers(spaceIDs: [spaces[0].id]))
|
||||
XCTAssertTrue(context.viewState.shouldShowAccessSectionFooter)
|
||||
XCTAssertFalse(context.viewState.isSaveDisabled)
|
||||
#expect(context.desiredSettings.accessType == .spaceMembers(spaceIDs: [spaces[0].id]))
|
||||
#expect(context.viewState.shouldShowAccessSectionFooter)
|
||||
#expect(!context.viewState.isSaveDisabled)
|
||||
|
||||
let expectation = expectation(description: "Join rule has updated")
|
||||
roomProxy.updateJoinRuleClosure = { value in
|
||||
XCTAssertEqual(value, .restricted(rules: [.roomMembership(roomID: spaces[0].id)]))
|
||||
expectation.fulfill()
|
||||
return .success(())
|
||||
await waitForConfirmation("Join rule has updated") { confirm in
|
||||
roomProxy.updateJoinRuleClosure = { value in
|
||||
#expect(value == .restricted(rules: [.roomMembership(roomID: spaces[0].id)]))
|
||||
confirm()
|
||||
return .success(())
|
||||
}
|
||||
context.send(viewAction: .save)
|
||||
}
|
||||
context.send(viewAction: .save)
|
||||
await fulfillment(of: [expectation])
|
||||
}
|
||||
|
||||
func testMultipleKnownAskToJoinSpacesMembersSelection() async throws {
|
||||
@Test
|
||||
func multipleKnownAskToJoinSpacesMembersSelection() async throws {
|
||||
let spaces = [SpaceServiceRoom].mockJoinedSpaces2
|
||||
setupViewModel(joinedParentSpaces: spaces, joinRule: .public)
|
||||
|
||||
let deferred = deferFulfillment(context.$viewState) { $0.selectableJoinedSpaces.count == 3 }
|
||||
try await deferred.fulfill()
|
||||
|
||||
XCTAssertEqual(context.viewState.currentSettings.accessType, .anyone)
|
||||
XCTAssertTrue(context.viewState.isSaveDisabled)
|
||||
XCTAssertTrue(context.viewState.isAskToJoinWithSpaceMembersOptionSelectable)
|
||||
#expect(context.viewState.currentSettings.accessType == .anyone)
|
||||
#expect(context.viewState.isSaveDisabled)
|
||||
#expect(context.viewState.isAskToJoinWithSpaceMembersOptionSelectable)
|
||||
guard case .multiple = context.viewState.spaceSelection else {
|
||||
XCTFail("Expected spaceSelection to be .multiple")
|
||||
Issue.record("Expected spaceSelection to be .multiple")
|
||||
return
|
||||
}
|
||||
|
||||
@@ -194,21 +205,22 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
context.send(viewAction: .selectedAskToJoinWithSpaceMembersAccess)
|
||||
try await deferredAction.fulfill()
|
||||
selectedIDs.send([spaces[0].id])
|
||||
XCTAssertEqual(context.desiredSettings.accessType, .askToJoinWithSpaceMembers(spaceIDs: [spaces[0].id]))
|
||||
XCTAssertTrue(context.viewState.shouldShowAccessSectionFooter)
|
||||
XCTAssertFalse(context.viewState.isSaveDisabled)
|
||||
#expect(context.desiredSettings.accessType == .askToJoinWithSpaceMembers(spaceIDs: [spaces[0].id]))
|
||||
#expect(context.viewState.shouldShowAccessSectionFooter)
|
||||
#expect(!context.viewState.isSaveDisabled)
|
||||
|
||||
let expectation = expectation(description: "Join rule has updated")
|
||||
roomProxy.updateJoinRuleClosure = { value in
|
||||
XCTAssertEqual(value, .knockRestricted(rules: [.roomMembership(roomID: spaces[0].id)]))
|
||||
expectation.fulfill()
|
||||
return .success(())
|
||||
await waitForConfirmation("Join rule has updated") { confirm in
|
||||
roomProxy.updateJoinRuleClosure = { value in
|
||||
#expect(value == .knockRestricted(rules: [.roomMembership(roomID: spaces[0].id)]))
|
||||
confirm()
|
||||
return .success(())
|
||||
}
|
||||
context.send(viewAction: .save)
|
||||
}
|
||||
context.send(viewAction: .save)
|
||||
await fulfillment(of: [expectation])
|
||||
}
|
||||
|
||||
func testMultipleSpacesMembersSelection() async throws {
|
||||
@Test
|
||||
func multipleSpacesMembersSelection() async throws {
|
||||
let spaces = [SpaceServiceRoom].mockJoinedSpaces2
|
||||
setupViewModel(joinedParentSpaces: spaces,
|
||||
joinRule: .restricted(rules: [.roomMembership(roomID: "unknownSpaceID")]))
|
||||
@@ -216,11 +228,11 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
let deferred = deferFulfillment(context.$viewState) { $0.selectableSpacesCount == 4 }
|
||||
try await deferred.fulfill()
|
||||
|
||||
XCTAssertTrue(context.viewState.currentSettings.accessType.isSpaceMembers)
|
||||
XCTAssertTrue(context.viewState.isSaveDisabled)
|
||||
XCTAssertTrue(context.viewState.isSpaceMembersOptionSelectable)
|
||||
#expect(context.viewState.currentSettings.accessType.isSpaceMembers)
|
||||
#expect(context.viewState.isSaveDisabled)
|
||||
#expect(context.viewState.isSpaceMembersOptionSelectable)
|
||||
guard case .multiple = context.viewState.spaceSelection else {
|
||||
XCTFail("Expected spaceSelection to be .multiple")
|
||||
Issue.record("Expected spaceSelection to be .multiple")
|
||||
return
|
||||
}
|
||||
|
||||
@@ -240,21 +252,22 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
context.send(viewAction: .manageSpaces)
|
||||
try await deferredAction.fulfill()
|
||||
selectedIDs.send([spaces[0].id, "unknownSpaceID"])
|
||||
XCTAssertEqual(context.desiredSettings.accessType, .spaceMembers(spaceIDs: [spaces[0].id, "unknownSpaceID"]))
|
||||
XCTAssertTrue(context.viewState.shouldShowAccessSectionFooter)
|
||||
XCTAssertFalse(context.viewState.isSaveDisabled)
|
||||
#expect(context.desiredSettings.accessType == .spaceMembers(spaceIDs: [spaces[0].id, "unknownSpaceID"]))
|
||||
#expect(context.viewState.shouldShowAccessSectionFooter)
|
||||
#expect(!context.viewState.isSaveDisabled)
|
||||
|
||||
let expectation = expectation(description: "Join rule has updated")
|
||||
roomProxy.updateJoinRuleClosure = { value in
|
||||
XCTAssertEqual(value, .restricted(rules: [.roomMembership(roomID: spaces[0].id), .roomMembership(roomID: "unknownSpaceID")]))
|
||||
expectation.fulfill()
|
||||
return .success(())
|
||||
await waitForConfirmation("Join rule has updated") { confirm in
|
||||
roomProxy.updateJoinRuleClosure = { value in
|
||||
#expect(value == .restricted(rules: [.roomMembership(roomID: spaces[0].id), .roomMembership(roomID: "unknownSpaceID")]))
|
||||
confirm()
|
||||
return .success(())
|
||||
}
|
||||
context.send(viewAction: .save)
|
||||
}
|
||||
context.send(viewAction: .save)
|
||||
await fulfillment(of: [expectation])
|
||||
}
|
||||
|
||||
func testMultipleSpacesMembersSelectionWithAnExistingNonParentButJoinedSpace() async throws {
|
||||
@Test
|
||||
func multipleSpacesMembersSelectionWithAnExistingNonParentButJoinedSpace() async throws {
|
||||
let joinedParentSpaces = [SpaceServiceRoom].mockJoinedSpaces2
|
||||
let singleRoom = [SpaceServiceRoom].mockSingleRoom
|
||||
let space = singleRoom[0]
|
||||
@@ -267,11 +280,11 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
let deferred = deferFulfillment(context.$viewState) { $0.selectableSpacesCount == 5 }
|
||||
try await deferred.fulfill()
|
||||
|
||||
XCTAssertTrue(context.viewState.currentSettings.accessType.isSpaceMembers)
|
||||
XCTAssertTrue(context.viewState.isSaveDisabled)
|
||||
XCTAssertTrue(context.viewState.isSpaceMembersOptionSelectable)
|
||||
#expect(context.viewState.currentSettings.accessType.isSpaceMembers)
|
||||
#expect(context.viewState.isSaveDisabled)
|
||||
#expect(context.viewState.isSpaceMembersOptionSelectable)
|
||||
guard case .multiple = context.viewState.spaceSelection else {
|
||||
XCTFail("Expected spaceSelection to be .multiple")
|
||||
Issue.record("Expected spaceSelection to be .multiple")
|
||||
return
|
||||
}
|
||||
|
||||
@@ -291,12 +304,13 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
context.send(viewAction: .manageSpaces)
|
||||
try await deferredAction.fulfill()
|
||||
selectedIDs.send([allSpaces[0].id, "unknownSpaceID"])
|
||||
XCTAssertEqual(context.desiredSettings.accessType, .spaceMembers(spaceIDs: [allSpaces[0].id, "unknownSpaceID"]))
|
||||
XCTAssertTrue(context.viewState.shouldShowAccessSectionFooter)
|
||||
XCTAssertFalse(context.viewState.isSaveDisabled)
|
||||
#expect(context.desiredSettings.accessType == .spaceMembers(spaceIDs: [allSpaces[0].id, "unknownSpaceID"]))
|
||||
#expect(context.viewState.shouldShowAccessSectionFooter)
|
||||
#expect(!context.viewState.isSaveDisabled)
|
||||
}
|
||||
|
||||
func testEmptySpaceMembersSelectionEdgeCase() async throws {
|
||||
@Test
|
||||
func emptySpaceMembersSelectionEdgeCase() async throws {
|
||||
// Edge case where there is no available joined parents and the room has a restricted join rule.
|
||||
// With no space ids in it
|
||||
setupViewModel(joinedParentSpaces: [],
|
||||
@@ -305,17 +319,18 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
let deferred = deferFulfillment(context.$viewState) { $0.selectableSpacesCount == 0 }
|
||||
try await deferred.fulfill()
|
||||
|
||||
XCTAssertTrue(context.viewState.currentSettings.accessType.isSpaceMembers)
|
||||
XCTAssertTrue(context.viewState.isSaveDisabled)
|
||||
XCTAssertFalse(context.viewState.isSpaceMembersOptionSelectable)
|
||||
XCTAssertFalse(context.viewState.shouldShowAccessSectionFooter)
|
||||
#expect(context.viewState.currentSettings.accessType.isSpaceMembers)
|
||||
#expect(context.viewState.isSaveDisabled)
|
||||
#expect(!context.viewState.isSpaceMembersOptionSelectable)
|
||||
#expect(!context.viewState.shouldShowAccessSectionFooter)
|
||||
guard case .empty = context.viewState.spaceSelection else {
|
||||
XCTFail("Expected spaceSelection to be .empty")
|
||||
Issue.record("Expected spaceSelection to be .empty")
|
||||
return
|
||||
}
|
||||
}
|
||||
|
||||
func testEmptySpaceMembersSelectionWithJoinedParentEdgeCase() async throws {
|
||||
@Test
|
||||
func emptySpaceMembersSelectionWithJoinedParentEdgeCase() async throws {
|
||||
// Edge case where there is one available joined parent but the room has a restricted join rule.
|
||||
// With no space ids in it
|
||||
let singleRoom = [SpaceServiceRoom].mockSingleRoom
|
||||
@@ -325,12 +340,12 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
let deferred = deferFulfillment(context.$viewState) { $0.selectableSpacesCount == 1 }
|
||||
try await deferred.fulfill()
|
||||
|
||||
XCTAssertTrue(context.viewState.currentSettings.accessType.isSpaceMembers)
|
||||
XCTAssertTrue(context.viewState.isSaveDisabled)
|
||||
XCTAssertTrue(context.viewState.isSpaceMembersOptionSelectable)
|
||||
XCTAssertTrue(context.viewState.shouldShowAccessSectionFooter)
|
||||
#expect(context.viewState.currentSettings.accessType.isSpaceMembers)
|
||||
#expect(context.viewState.isSaveDisabled)
|
||||
#expect(context.viewState.isSpaceMembersOptionSelectable)
|
||||
#expect(context.viewState.shouldShowAccessSectionFooter)
|
||||
guard case .multiple = context.viewState.spaceSelection else {
|
||||
XCTFail("Expected spaceSelection to be .multiple")
|
||||
Issue.record("Expected spaceSelection to be .multiple")
|
||||
return
|
||||
}
|
||||
|
||||
@@ -348,11 +363,12 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
try await deferredAction.fulfill()
|
||||
}
|
||||
|
||||
func testSave() async throws {
|
||||
@Test
|
||||
func save() async throws {
|
||||
setupViewModel(joinedParentSpaces: [], joinRule: .public)
|
||||
|
||||
// Saving shouldn't dismiss this screen (or trigger any other action).
|
||||
let deferred = deferFailure(viewModel.actionsPublisher, timeout: 1) { _ in true }
|
||||
let deferred = deferFailure(viewModel.actionsPublisher, timeout: .seconds(1)) { _ in true }
|
||||
|
||||
context.desiredSettings.accessType = .inviteOnly
|
||||
context.send(viewAction: .save)
|
||||
@@ -360,15 +376,16 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
try await deferred.fulfill()
|
||||
}
|
||||
|
||||
func testCancelWithChangesAndDiscard() async throws {
|
||||
@Test
|
||||
func cancelWithChangesAndDiscard() async throws {
|
||||
setupViewModel(joinedParentSpaces: [], joinRule: .public)
|
||||
context.desiredSettings.accessType = .inviteOnly
|
||||
XCTAssertFalse(context.viewState.isSaveDisabled)
|
||||
XCTAssertNil(context.alertInfo)
|
||||
#expect(!context.viewState.isSaveDisabled)
|
||||
#expect(context.alertInfo == nil)
|
||||
|
||||
context.send(viewAction: .cancel)
|
||||
|
||||
XCTAssertNotNil(context.alertInfo)
|
||||
#expect(context.alertInfo != nil)
|
||||
|
||||
let deferred = deferFulfillment(viewModel.actionsPublisher) {
|
||||
switch $0 {
|
||||
@@ -382,15 +399,16 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
try await deferred.fulfill()
|
||||
}
|
||||
|
||||
func testCancelWithChangesAndSave() async throws {
|
||||
@Test
|
||||
func cancelWithChangesAndSave() async throws {
|
||||
setupViewModel(joinedParentSpaces: [], joinRule: .public)
|
||||
context.desiredSettings.accessType = .inviteOnly
|
||||
XCTAssertFalse(context.viewState.isSaveDisabled)
|
||||
XCTAssertNil(context.alertInfo)
|
||||
#expect(!context.viewState.isSaveDisabled)
|
||||
#expect(context.alertInfo == nil)
|
||||
|
||||
context.send(viewAction: .cancel)
|
||||
|
||||
XCTAssertNotNil(context.alertInfo)
|
||||
#expect(context.alertInfo != nil)
|
||||
|
||||
let deferred = deferFulfillment(viewModel.actionsPublisher) {
|
||||
switch $0 {
|
||||
@@ -404,19 +422,20 @@ class SecurityAndPrivacyScreenViewModelTests: XCTestCase {
|
||||
try await deferred.fulfill()
|
||||
}
|
||||
|
||||
func testCancelWithChangesAndSaveWithFailure() async throws {
|
||||
@Test
|
||||
func cancelWithChangesAndSaveWithFailure() async throws {
|
||||
setupViewModel(joinedParentSpaces: [], joinRule: .public)
|
||||
roomProxy.updateJoinRuleReturnValue = .failure(.sdkError(RoomProxyMockError.generic))
|
||||
context.desiredSettings.accessType = .inviteOnly
|
||||
XCTAssertFalse(context.viewState.isSaveDisabled)
|
||||
XCTAssertNil(context.alertInfo)
|
||||
#expect(!context.viewState.isSaveDisabled)
|
||||
#expect(context.alertInfo == nil)
|
||||
|
||||
context.send(viewAction: .cancel)
|
||||
|
||||
XCTAssertNotNil(context.alertInfo)
|
||||
#expect(context.alertInfo != nil)
|
||||
|
||||
// The screen should not be dismissed if a failure occurred.
|
||||
let deferred = deferFailure(viewModel.actionsPublisher, timeout: 1) { _ in true }
|
||||
let deferred = deferFailure(viewModel.actionsPublisher, timeout: .seconds(1)) { _ in true }
|
||||
context.alertInfo?.primaryButton.action?() // Save
|
||||
try await deferred.fulfill()
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user